René's URL Explorer Experiment


Title: GH-118095: Unify the behavior of tier 2 `FOR_ITER` branch micro-ops by markshannon · Pull Request #118420 · python/cpython · GitHub

Open Graph Title: GH-118095: Unify the behavior of tier 2 `FOR_ITER` branch micro-ops by markshannon · Pull Request #118420 · python/cpython

X Title: GH-118095: Unify the behavior of tier 2 `FOR_ITER` branch micro-ops by markshannon · Pull Request #118420 · python/cpython

Description: Simplifies and unifies the behavior of _GUARD_NOT_EXHAUSTED_RANGE _GUARD_NOT_EXHAUSTED_LIST _GUARD_NOT_EXHAUSTED_TUPLE _FOR_ITER_TIER_TWO Such that all leave just the iterator on the stack and they exit to the POP_TOP immediately after the associated END_FOR. This fixes a bug in the tier 2 handling of _FOR_ITER_TIER_TWO where errors were treated as occurring at the jump target, not an the original instructions. Issue: gh-118095

Open Graph Description: Simplifies and unifies the behavior of _GUARD_NOT_EXHAUSTED_RANGE _GUARD_NOT_EXHAUSTED_LIST _GUARD_NOT_EXHAUSTED_TUPLE _FOR_ITER_TIER_TWO Such that all leave just the iterator on the stack and they...

X Description: Simplifies and unifies the behavior of _GUARD_NOT_EXHAUSTED_RANGE _GUARD_NOT_EXHAUSTED_LIST _GUARD_NOT_EXHAUSTED_TUPLE _FOR_ITER_TIER_TWO Such that all leave just the iterator on the stack and they...

Opengraph URL: https://github.com/python/cpython/pull/118420

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:feb40ed2-9400-17da-bcde-aab80e9a3feb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8010:14EB6E:217AC6B:2BDA0FB:6B023B8B
html-safe-noncedc82c41e021f8e8e62f9ddca1a2a0405aca5075d8e98a547dc6863811f2c4756
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MDEwOjE0RUI2RToyMTdBQzZCOjJCREEwRkI6NkIwMjNCOEIiLCJ2aXNpdG9yX2lkIjoiNDc4MDE1ODM1MDA4NjI1NzU0NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac82d1eedec7c62dfe6bbb79efc4938bb3ad3c2446356cde71d07d5907e1d8c71b
hovercard-subject-tagpull_request:1847448768
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/118420/files
twitter:imagehttps://avatars.githubusercontent.com/u/9448417?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/9448417?s=400&v=4
og:image:altSimplifies and unifies the behavior of _GUARD_NOT_EXHAUSTED_RANGE _GUARD_NOT_EXHAUSTED_LIST _GUARD_NOT_EXHAUSTED_TUPLE _FOR_ITER_TIER_TWO Such that all leave just the iterator on the stack and they...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/118420/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F118420%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F118420%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/118420/files
Reloadhttps://github.com/python/cpython/pull/118420/files
Reloadhttps://github.com/python/cpython/pull/118420/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
markshannonhttps://github.com/markshannon
python:mainhttps://github.com/python/cpython/tree/main
faster-cpython:unify-tier-2-for-iterhttps://github.com/faster-cpython/cpython/tree/unify-tier-2-for-iter
Conversation 7 https://github.com/python/cpython/pull/118420
Commits 9 https://github.com/python/cpython/pull/118420/commits
Checks 0 https://github.com/python/cpython/pull/118420/checks
Files changed https://github.com/python/cpython/pull/118420/files
Please reload this pagehttps://github.com/python/cpython/pull/118420/files
GH-118095: Unify the behavior of tier 2 FOR_ITER branch micro-ops https://github.com/python/cpython/pull/118420/files#top
Show all changes 9 commits https://github.com/python/cpython/pull/118420/files
f8bd566 Target _FOR_ITER_TIER_TWO at POP_TOP following END_FOR markshannon Apr 30, 2024 https://github.com/python/cpython/pull/118420/commits/f8bd566d5ec4f3e07100de3048e26f2f6c05d303
3bac858 Move handling of _FOR_ITER_TIER_TWO exits from trace creation to the … markshannon Apr 30, 2024 https://github.com/python/cpython/pull/118420/commits/3bac85827afb2f129f1e13c4125b207dd375ef04
b83d053 Extend treatment of _FOR_ITER_TIER_TWO to all FOR_ITER tier 2 tests (… markshannon Apr 30, 2024 https://github.com/python/cpython/pull/118420/commits/b83d053441aeb09aa7ab84c97143ac6aaf5cf252
bb7efd4 Fix a minor bug in optimizer symbols markshannon Apr 30, 2024 https://github.com/python/cpython/pull/118420/commits/bb7efd4fa185dc18b9a3195a258c47112b29d6de
983b7c8 Fix stats for non-tier-2 build markshannon May 1, 2024 https://github.com/python/cpython/pull/118420/commits/983b7c8f8ca15dfd445d002e716c3d718cc429d1
df2792f Fix tier 2 build markshannon May 1, 2024 https://github.com/python/cpython/pull/118420/commits/df2792f46f39e6a22096f5817e6824456f7d6b6f
d2af12f Merge branch 'main' into unify-tier-2-for-iter markshannon May 2, 2024 https://github.com/python/cpython/pull/118420/commits/d2af12fc39e662f90dd6be4c0615dee724fd2fcf
98b517d Address review comments markshannon May 2, 2024 https://github.com/python/cpython/pull/118420/commits/98b517d16d75055d707f188964594477cbeed1c9
aa35032 Merge branch 'main' into unify-tier-2-for-iter markshannon May 2, 2024 https://github.com/python/cpython/pull/118420/commits/aa350326e1d35594f58633bb9a0205e37e290fd9
Clear filters https://github.com/python/cpython/pull/118420/files
Please reload this pagehttps://github.com/python/cpython/pull/118420/files
Please reload this pagehttps://github.com/python/cpython/pull/118420/files
bytecodes.c https://github.com/python/cpython/pull/118420/files#diff-729a985b0cb8b431cb291f1edb561bbbfea22e3f8c262451cd83328a0936a342
executor_cases.c.h https://github.com/python/cpython/pull/118420/files#diff-a1c3430c42a66c16e6d2e154491a6da993b187b27c628545a12a02c7b2a06b81
optimizer.c https://github.com/python/cpython/pull/118420/files#diff-de09f74c4306be5ef0284d665091976873569094d645a35b48467ea2a11d67f7
optimizer_symbols.c https://github.com/python/cpython/pull/118420/files#diff-b28c00f0aab70992e604ed7c3e9cb4ca39779f33d5ff2c7777de5a044422f095
specialize.c https://github.com/python/cpython/pull/118420/files#diff-22e653d878778ca28317261f7826545288d02fd9980cf485d0329f28a34993f2
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L222
Python/bytecodes.chttps://github.com/python/cpython/pull/118420/files#diff-729a985b0cb8b431cb291f1edb561bbbfea22e3f8c262451cd83328a0936a342
View file https://github.com/faster-cpython/cpython/blob/aa350326e1d35594f58633bb9a0205e37e290fd9/Python/bytecodes.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/118420/{{ revealButtonHref }}
https://github.com/python/cpython/pull/118420/files#diff-729a985b0cb8b431cb291f1edb561bbbfea22e3f8c262451cd83328a0936a342
https://github.com/python/cpython/pull/118420/files#diff-729a985b0cb8b431cb291f1edb561bbbfea22e3f8c262451cd83328a0936a342
Python/executor_cases.c.hhttps://github.com/python/cpython/pull/118420/files#diff-a1c3430c42a66c16e6d2e154491a6da993b187b27c628545a12a02c7b2a06b81
View file https://github.com/faster-cpython/cpython/blob/aa350326e1d35594f58633bb9a0205e37e290fd9/Python/executor_cases.c.h
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/118420/files
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L302
Python/optimizer.chttps://github.com/python/cpython/pull/118420/files#diff-de09f74c4306be5ef0284d665091976873569094d645a35b48467ea2a11d67f7
View file https://github.com/faster-cpython/cpython/blob/aa350326e1d35594f58633bb9a0205e37e290fd9/Python/optimizer.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/118420/{{ revealButtonHref }}
https://github.com/python/cpython/pull/118420/files#diff-de09f74c4306be5ef0284d665091976873569094d645a35b48467ea2a11d67f7
https://github.com/python/cpython/pull/118420/files#diff-de09f74c4306be5ef0284d665091976873569094d645a35b48467ea2a11d67f7
https://github.com/python/cpython/pull/118420/files#diff-de09f74c4306be5ef0284d665091976873569094d645a35b48467ea2a11d67f7
https://github.com/python/cpython/pull/118420/files#diff-de09f74c4306be5ef0284d665091976873569094d645a35b48467ea2a11d67f7
https://github.com/python/cpython/pull/118420/files#diff-de09f74c4306be5ef0284d665091976873569094d645a35b48467ea2a11d67f7
https://github.com/python/cpython/pull/118420/files#diff-de09f74c4306be5ef0284d665091976873569094d645a35b48467ea2a11d67f7
https://github.com/python/cpython/pull/118420/files#diff-de09f74c4306be5ef0284d665091976873569094d645a35b48467ea2a11d67f7
https://github.com/python/cpython/pull/118420/files#diff-de09f74c4306be5ef0284d665091976873569094d645a35b48467ea2a11d67f7
https://github.com/python/cpython/pull/118420/files#diff-de09f74c4306be5ef0284d665091976873569094d645a35b48467ea2a11d67f7
https://github.com/python/cpython/pull/118420/files#diff-de09f74c4306be5ef0284d665091976873569094d645a35b48467ea2a11d67f7
https://github.com/python/cpython/pull/118420/files#diff-de09f74c4306be5ef0284d665091976873569094d645a35b48467ea2a11d67f7
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L305
Python/optimizer_symbols.chttps://github.com/python/cpython/pull/118420/files#diff-b28c00f0aab70992e604ed7c3e9cb4ca39779f33d5ff2c7777de5a044422f095
View file https://github.com/faster-cpython/cpython/blob/aa350326e1d35594f58633bb9a0205e37e290fd9/Python/optimizer_symbols.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/118420/{{ revealButtonHref }}
https://github.com/python/cpython/pull/118420/files#diff-b28c00f0aab70992e604ed7c3e9cb4ca39779f33d5ff2c7777de5a044422f095
gvanrossumhttps://github.com/gvanrossum
May 1, 2024https://github.com/python/cpython/pull/118420/files#r1586865914
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/118420/files
markshannonhttps://github.com/markshannon
May 2, 2024https://github.com/python/cpython/pull/118420/files#r1587443497
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/118420/files
https://github.com/python/cpython/pull/118420/files#diff-b28c00f0aab70992e604ed7c3e9cb4ca39779f33d5ff2c7777de5a044422f095
Python/specialize.chttps://github.com/python/cpython/pull/118420/files#diff-22e653d878778ca28317261f7826545288d02fd9980cf485d0329f28a34993f2
View file https://github.com/faster-cpython/cpython/blob/aa350326e1d35594f58633bb9a0205e37e290fd9/Python/specialize.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/118420/{{ revealButtonHref }}
https://github.com/python/cpython/pull/118420/files#diff-22e653d878778ca28317261f7826545288d02fd9980cf485d0329f28a34993f2
https://github.com/python/cpython/pull/118420/files#diff-22e653d878778ca28317261f7826545288d02fd9980cf485d0329f28a34993f2
https://github.com/python/cpython/pull/118420/files#diff-22e653d878778ca28317261f7826545288d02fd9980cf485d0329f28a34993f2
https://github.com/python/cpython/pull/118420/files#diff-22e653d878778ca28317261f7826545288d02fd9980cf485d0329f28a34993f2
https://github.com/python/cpython/pull/118420/files#diff-22e653d878778ca28317261f7826545288d02fd9980cf485d0329f28a34993f2
https://github.com/python/cpython/pull/118420/files#diff-22e653d878778ca28317261f7826545288d02fd9980cf485d0329f28a34993f2
https://github.com/python/cpython/pull/118420/files#diff-22e653d878778ca28317261f7826545288d02fd9980cf485d0329f28a34993f2
https://github.com/python/cpython/pull/118420/files#diff-22e653d878778ca28317261f7826545288d02fd9980cf485d0329f28a34993f2
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.