René's URL Explorer Experiment


Title: gh-118331: Don't raise an error if tuple allocation fails when clearing weakrefs by mpage · Pull Request #118338 · python/cpython · GitHub

Open Graph Title: gh-118331: Don't raise an error if tuple allocation fails when clearing weakrefs by mpage · Pull Request #118338 · python/cpython

X Title: gh-118331: Don't raise an error if tuple allocation fails when clearing weakrefs by mpage · Pull Request #118338 · python/cpython

Description: It's not safe to raise an exception in PyObject_ClearWeakRefs() if one is not already set. PyObject_ClearWeakRefs() may be called (transitively) by _Py_Dealloc(), which contains cpyt...

Open Graph Description: It's not safe to raise an exception in PyObject_ClearWeakRefs() if one is not already set. PyObject_ClearWeakRefs() may be called (transitively) by _Py_Dealloc(), which contains ...

X Description: It's not safe to raise an exception in PyObject_ClearWeakRefs() if one is not already set. PyObject_ClearWeakRefs() may be called (transitively) by _Py_Dealloc(), which contains ...

Opengraph URL: https://github.com/python/cpython/pull/118338

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e58b94ec-24eb-f343-2c82-3153335fe351
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB55C:9124A:317E454:40C21CC:696B825B
html-safe-nonce7b0f4df134db852bce14c889099ca9aecb923aeb1acedac0bae4834becb77dce
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNTVDOjkxMjRBOjMxN0U0NTQ6NDBDMjFDQzo2OTZCODI1QiIsInZpc2l0b3JfaWQiOiIxNjUzNTQzNTUxNTI3MjU2NjY3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac5c3b38d151d77646302fe5fb63fde870645710499344b93b6a681056807e1914
hovercard-subject-tagpull_request:1843615158
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/118338/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e2db7b1896cd0653247c07aad5d7379383f17952d73bf511d4046cee0ca3d462/python/cpython/pull/118338
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e2db7b1896cd0653247c07aad5d7379383f17952d73bf511d4046cee0ca3d462/python/cpython/pull/118338
og:image:altIt's not safe to raise an exception in PyObject_ClearWeakRefs() if one is not already set. PyObject_ClearWeakRefs() may be called (transitively) by _Py_Dealloc(), which contains ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamempage
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/118338#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F118338
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F118338
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/118338
Reloadhttps://github.com/python/cpython/pull/118338
Reloadhttps://github.com/python/cpython/pull/118338
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/118338
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/118338
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/118338#issue-comment-box
colesburyhttps://github.com/colesbury
python:mainhttps://github.com/python/cpython/tree/main
mpage:gh-118331-wr-no-memhttps://github.com/mpage/cpython/tree/gh-118331-wr-no-mem
gh-118331: Don't raise an error if tuple allocation fails when clearing weakrefs https://github.com/python/cpython/pull/118338#top
colesburyhttps://github.com/colesbury
python:mainhttps://github.com/python/cpython/tree/main
mpage:gh-118331-wr-no-memhttps://github.com/mpage/cpython/tree/gh-118331-wr-no-mem
Conversation 7 https://github.com/python/cpython/pull/118338
Commits 6 https://github.com/python/cpython/pull/118338/commits
Checks 0 https://github.com/python/cpython/pull/118338/checks
Files changed 2 https://github.com/python/cpython/pull/118338/files
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/mpage
mpagehttps://github.com/mpage
Apr 26, 2024https://github.com/python/cpython/pull/118338#issue-2266624478
Please reload this pagehttps://github.com/python/cpython/pull/118338
cpython/Objects/object.chttps://github.com/python/cpython/blob/5a90de0d4cbc151a6deea36a27eb81b192410e56/Objects/object.c#L2843-L2860
5a90de0https://github.com/python/cpython/commit/5a90de0d4cbc151a6deea36a27eb81b192410e56
gh-111926https://github.com/python/cpython/issues/111926
exists in 3.12https://github.com/python/cpython/blob/186fbe82f7b3124835bcd3cfc4a03139ea8ba034/Objects/weakrefobject.c#L977-L981
test_repl's test_no_memory: AssertionError: -6 not found in (1, 120) #118331https://github.com/python/cpython/issues/118331
Please reload this pagehttps://github.com/python/cpython/pull/118338
https://github.com/mpage
Don't raise an error if tuple allocation fails when clearing weakrefshttps://github.com/python/cpython/pull/118338/commits/195a7e59cff10be13bc0473bb43517f340d6de35
195a7e5https://github.com/python/cpython/pull/118338/commits/195a7e59cff10be13bc0473bb43517f340d6de35
https://github.com/python/cpython/blob/5a90de0d4cbc151a6deea36a27eb81b192410e56/Objects/object.c#L2843-L2860https://github.com/python/cpython/blob/5a90de0d4cbc151a6deea36a27eb81b192410e56/Objects/object.c#L2843-L2860
pythongh-111926https://github.com/python/cpython/issues/111926
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Apr 26, 2024 https://github.com/python/cpython/pull/118338#ref-issue-2266382889
test_repl's test_no_memory: AssertionError: -6 not found in (1, 120) #118331 https://github.com/python/cpython/issues/118331
https://github.com/mpage
mpagehttps://github.com/mpage
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Apr 26, 2024https://github.com/python/cpython/pull/118338#event-12629225137
mpagehttps://github.com/mpage
April 26, 2024 16:37https://github.com/python/cpython/pull/118338#commits-pushed-99e3f85
https://github.com/mpage
Fix testhttps://github.com/python/cpython/pull/118338/commits/99e3f854df936e98665a99f83eb36816f3be4a9c
99e3f85https://github.com/python/cpython/pull/118338/commits/99e3f854df936e98665a99f83eb36816f3be4a9c
https://github.com/mpage
Make test more robust to future changeshttps://github.com/python/cpython/pull/118338/commits/632087c085e0f571a435501e03ed294675f36eb6
632087chttps://github.com/python/cpython/pull/118338/commits/632087c085e0f571a435501e03ed294675f36eb6
https://github.com/mpage
Don't pass object to PyErr_WriteUnraisablehttps://github.com/python/cpython/pull/118338/commits/7ba419dca085c04a7de2d8e794b71557959ee4d2
7ba419dhttps://github.com/python/cpython/pull/118338/commits/7ba419dca085c04a7de2d8e794b71557959ee4d2
https://github.com/mpage
mpagehttps://github.com/mpage
April 27, 2024 01:55https://github.com/python/cpython/pull/118338#event-12629761534
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Apr 27, 2024https://github.com/python/cpython/pull/118338#event-12629761652
https://github.com/mpage
mpagehttps://github.com/mpage
colesburyhttps://github.com/colesbury
April 27, 2024 01:55https://github.com/python/cpython/pull/118338#event-12629761778
https://github.com/Fidget-Spinner
Fidget-Spinnerhttps://github.com/Fidget-Spinner
Apr 27, 2024 https://github.com/python/cpython/pull/118338#pullrequestreview-2026219904
View reviewed changes https://github.com/python/cpython/pull/118338/files/7ba419dca085c04a7de2d8e794b71557959ee4d2
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Apr 27, 2024https://github.com/python/cpython/pull/118338#event-12630025794
https://github.com/hugovk
hugovkhttps://github.com/hugovk
Apr 27, 2024https://github.com/python/cpython/pull/118338#issuecomment-2080420438
gh-118331https://github.com/python/cpython/issues/118331
Please reload this pagehttps://github.com/python/cpython/pull/118338
https://github.com/colesbury
colesburyhttps://github.com/colesbury
Apr 29, 2024 https://github.com/python/cpython/pull/118338#pullrequestreview-2028744339
View reviewed changes https://github.com/python/cpython/pull/118338/files/7ba419dca085c04a7de2d8e794b71557959ee4d2
colesburyhttps://github.com/colesbury
https://github.com/python/cpython/pull/118338#pullrequestreview-2028744339
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/118338
https://github.com/colesbury
colesburyhttps://github.com/colesbury
Apr 29, 2024 https://github.com/python/cpython/pull/118338#pullrequestreview-2028771017
View reviewed changes https://github.com/python/cpython/pull/118338/files/7ba419dca085c04a7de2d8e794b71557959ee4d2
Objects/weakrefobject.chttps://github.com/python/cpython/pull/118338/files/7ba419dca085c04a7de2d8e794b71557959ee4d2#diff-203baf73fbb7f03732f24a6070851675c64af2e125892f45639e715e83030d61
Please reload this pagehttps://github.com/python/cpython/pull/118338
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting changes https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Apr 29, 2024https://github.com/python/cpython/pull/118338#event-12644677733
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Apr 29, 2024https://github.com/python/cpython/pull/118338#issuecomment-2082983376
Please reload this pagehttps://github.com/python/cpython/pull/118338
mpagehttps://github.com/mpage
April 29, 2024 09:24https://github.com/python/cpython/pull/118338#commits-pushed-15c85d4
https://github.com/mpage
Don't chain exceptionshttps://github.com/python/cpython/pull/118338/commits/15c85d453f12cefa64f3142685e01edb992d5b20
15c85d4https://github.com/python/cpython/pull/118338/commits/15c85d453f12cefa64f3142685e01edb992d5b20
https://github.com/mpage
Merge branch 'main' intohttps://github.com/python/cpython/pull/118338/commits/728a2979f66059cddbd7f42da83c36575865ed93
pythongh-118331https://github.com/python/cpython/issues/118331
-wr-no-memhttps://github.com/python/cpython/pull/118338/commits/728a2979f66059cddbd7f42da83c36575865ed93
728a297https://github.com/python/cpython/pull/118338/commits/728a2979f66059cddbd7f42da83c36575865ed93
https://github.com/mpage
mpagehttps://github.com/mpage
Apr 29, 2024https://github.com/python/cpython/pull/118338#issuecomment-2083182448
Please reload this pagehttps://github.com/python/cpython/pull/118338
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting change review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20change%20review%22
awaiting changes https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22
Apr 29, 2024https://github.com/python/cpython/pull/118338#event-12645984322
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Apr 29, 2024https://github.com/python/cpython/pull/118338#issuecomment-2083182660
@Fidget-Spinnerhttps://github.com/Fidget-Spinner
@colesburyhttps://github.com/colesbury
Please reload this pagehttps://github.com/python/cpython/pull/118338
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Fidget-Spinnerhttps://github.com/Fidget-Spinner
colesburyhttps://github.com/colesbury
April 29, 2024 16:34https://github.com/python/cpython/pull/118338#event-12645985099
https://github.com/colesbury
colesburyhttps://github.com/colesbury
Apr 29, 2024 https://github.com/python/cpython/pull/118338#pullrequestreview-2029018877
View reviewed changes https://github.com/python/cpython/pull/118338/files/728a2979f66059cddbd7f42da83c36575865ed93
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting change review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20change%20review%22
Apr 29, 2024https://github.com/python/cpython/pull/118338#event-12646023295
https://github.com/colesbury
colesburyhttps://github.com/colesbury
April 29, 2024 16:39https://github.com/python/cpython/pull/118338#event-12646038006
https://github.com/colesbury
colesburyhttps://github.com/colesbury
43fa766https://github.com/python/cpython/commit/43fa76638fc75958b592096b6830c15f0afa1a73
Apr 29, 2024https://github.com/python/cpython/pull/118338#event-12646229479
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Apr 29, 2024https://github.com/python/cpython/pull/118338#event-12646230078
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F118338
https://github.com/colesbury
colesbury https://github.com/colesbury
https://github.com/python/cpython/pull/118338/files/728a2979f66059cddbd7f42da83c36575865ed93
https://github.com/Fidget-Spinner
Fidget-Spinner https://github.com/Fidget-Spinner
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/118338
https://github.com/mpage
https://github.com/hugovk
https://github.com/colesbury
https://github.com/Fidget-Spinner
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.