René's URL Explorer Experiment


Title: gh-117953: Cleanups For fix_up_extension() in import.c by ericsnowcurrently · Pull Request #118192 · python/cpython · GitHub

Open Graph Title: gh-117953: Cleanups For fix_up_extension() in import.c by ericsnowcurrently · Pull Request #118192 · python/cpython

X Title: gh-117953: Cleanups For fix_up_extension() in import.c by ericsnowcurrently · Pull Request #118192 · python/cpython

Description: These are cleanups I've pulled out of gh-118116. Mostly, this change moves code around to align with some future changes and to improve clarity a little. There is one very small change in behavio...

Open Graph Description: These are cleanups I've pulled out of gh-118116. Mostly, this change moves code around to align with some future changes and to improve clarity a little. There is one very small change in beh...

X Description: These are cleanups I've pulled out of gh-118116. Mostly, this change moves code around to align with some future changes and to improve clarity a little. There is one very small change in...

Opengraph URL: https://github.com/python/cpython/pull/118192

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:687f50ae-5435-d388-701e-7de2097a1a82
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD304:1A2A10:6998BC:8A2182:696B498B
html-safe-nonce19806fa71ad5aa55c4e673e589fa096315a38cc63800d50866ba2bcfb1335fa2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMzA0OjFBMkExMDo2OTk4QkM6OEEyMTgyOjY5NkI0OThCIiwidmlzaXRvcl9pZCI6IjE3NzIzNTk2NzU4NjU1MjIwMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7105c5d4f0ddb48837ee5e7b436688f422827b377f79014b5055eb6cf56cc2b3
hovercard-subject-tagpull_request:1837167343
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/118192/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6e466342a8a27a55b47e6fdbaf1795c56202d15332200204e905b5ddaf502ede/python/cpython/pull/118192
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6e466342a8a27a55b47e6fdbaf1795c56202d15332200204e905b5ddaf502ede/python/cpython/pull/118192
og:image:altThese are cleanups I've pulled out of gh-118116. Mostly, this change moves code around to align with some future changes and to improve clarity a little. There is one very small change in beh...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameericsnowcurrently
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/118192#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F118192
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F118192
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/118192
Reloadhttps://github.com/python/cpython/pull/118192
Reloadhttps://github.com/python/cpython/pull/118192
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/118192
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/118192
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/118192#issue-comment-box
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
python:mainhttps://github.com/python/cpython/tree/main
ericsnowcurrently:clean-up-fixup-extensionhttps://github.com/ericsnowcurrently/cpython/tree/clean-up-fixup-extension
gh-117953: Cleanups For fix_up_extension() in import.c https://github.com/python/cpython/pull/118192#top
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
python:mainhttps://github.com/python/cpython/tree/main
ericsnowcurrently:clean-up-fixup-extensionhttps://github.com/ericsnowcurrently/cpython/tree/clean-up-fixup-extension
Conversation 0 https://github.com/python/cpython/pull/118192
Commits 11 https://github.com/python/cpython/pull/118192/commits
Checks 0 https://github.com/python/cpython/pull/118192/checks
Files changed https://github.com/python/cpython/pull/118192/files
Please reload this pagehttps://github.com/python/cpython/pull/118192
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Apr 23, 2024https://github.com/python/cpython/pull/118192#issue-2259404222
Please reload this pagehttps://github.com/python/cpython/pull/118192
gh-118116https://github.com/python/cpython/pull/118116
Single-Phase Init Extension Module Init Functions Still Run in Isolated Interpreters #117953https://github.com/python/cpython/issues/117953
Please reload this pagehttps://github.com/python/cpython/pull/118192
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
April 23, 2024 08:27https://github.com/python/cpython/pull/118192#commits-pushed-d87d212
https://github.com/ericsnowcurrently
Factor out fix_up_extension_for_interpreter().https://github.com/python/cpython/pull/118192/commits/d87d2128422ab3a37563d6d6501a395724fb53f5
d87d212https://github.com/python/cpython/pull/118192/commits/d87d2128422ab3a37563d6d6501a395724fb53f5
https://github.com/ericsnowcurrently
Pass tstate through to fix_up_extension().https://github.com/python/cpython/pull/118192/commits/b85c5afb269197d4724be688050b99605ce9e985
b85c5afhttps://github.com/python/cpython/pull/118192/commits/b85c5afb269197d4724be688050b99605ce9e985
https://github.com/ericsnowcurrently
We already know the def is okay.https://github.com/python/cpython/pull/118192/commits/319c4613182d9b42c447b2255dd699a63900dd0c
319c461https://github.com/python/cpython/pull/118192/commits/319c4613182d9b42c447b2255dd699a63900dd0c
https://github.com/ericsnowcurrently
Let the modules arg to fix_up_extension_for_interpreter() be NULL.https://github.com/python/cpython/pull/118192/commits/e6ea054525ee34af451c07eb8b7dcf2738d7ce85
e6ea054https://github.com/python/cpython/pull/118192/commits/e6ea054525ee34af451c07eb8b7dcf2738d7ce85
https://github.com/ericsnowcurrently
Always expect a valid modules dict passed to fix_up_extension().https://github.com/python/cpython/pull/118192/commits/439661f496715e944c217f4611c13e4aee395a47
439661fhttps://github.com/python/cpython/pull/118192/commits/439661f496715e944c217f4611c13e4aee395a47
https://github.com/ericsnowcurrently
Do interpreter fixups after the extension cache, not before.https://github.com/python/cpython/pull/118192/commits/0d28e0faa47c80797fd3323d6c11f2590ec785eb
0d28e0fhttps://github.com/python/cpython/pull/118192/commits/0d28e0faa47c80797fd3323d6c11f2590ec785eb
https://github.com/ericsnowcurrently
Call fix_up_extension_for_interpreter() separately.https://github.com/python/cpython/pull/118192/commits/abd69f44136d345328fe79190dd0e8557ef6d51a
abd69f4https://github.com/python/cpython/pull/118192/commits/abd69f44136d345328fe79190dd0e8557ef6d51a
https://github.com/ericsnowcurrently
fix_up_extension_for_interpreter() -> finish_singlephase_extension()https://github.com/python/cpython/pull/118192/commits/f347f8d0fb0c6857f73d87fda573e110ebf5c589
f347f8dhttps://github.com/python/cpython/pull/118192/commits/f347f8d0fb0c6857f73d87fda573e110ebf5c589
https://github.com/ericsnowcurrently
fix_up_extension() -> update_global_state_for_extension()https://github.com/python/cpython/pull/118192/commits/49760890beec60dff8b07485d36ca33bfb982387
4976089https://github.com/python/cpython/pull/118192/commits/49760890beec60dff8b07485d36ca33bfb982387
https://github.com/ericsnowcurrently
Update the comment about extensions.https://github.com/python/cpython/pull/118192/commits/5627ad973164a25e2308b55c4139a41060db3a6d
5627ad9https://github.com/python/cpython/pull/118192/commits/5627ad973164a25e2308b55c4139a41060db3a6d
https://github.com/ericsnowcurrently
Make sure __file__ is set before m_copy gets populated.https://github.com/python/cpython/pull/118192/commits/8b4e216dfa45d84eae952ddde4010908adb9220f
8b4e216https://github.com/python/cpython/pull/118192/commits/8b4e216dfa45d84eae952ddde4010908adb9220f
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Apr 23, 2024https://github.com/python/cpython/pull/118192#event-12579207463
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
brettcannonhttps://github.com/brettcannon
kumaraditya303https://github.com/kumaraditya303
ncoghlanhttps://github.com/ncoghlan
warsawhttps://github.com/warsaw
code ownershttps://github.com/python/cpython/blob/2e7771a03d8975ee8a9918ce754c665508c3f682/.github/CODEOWNERS#L106
April 23, 2024 17:32https://github.com/python/cpython/pull/118192#event-12579207681
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Apr 23, 2024 https://github.com/python/cpython/pull/118192#ref-issue-2247045160
Single-Phase Init Extension Module Init Functions Still Run in Isolated Interpreters #117953 https://github.com/python/cpython/issues/117953
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Apr 23, 2024https://github.com/python/cpython/pull/118192#event-12579208917
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
brettcannonhttps://github.com/brettcannon
kumaraditya303https://github.com/kumaraditya303
ncoghlanhttps://github.com/ncoghlan
warsawhttps://github.com/warsaw
April 23, 2024 17:32https://github.com/python/cpython/pull/118192#event-12579208984
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
af3c1d8https://github.com/python/cpython/commit/af3c1d817d3f8369f8003965d967332a3a721a25
Apr 24, 2024https://github.com/python/cpython/pull/118192#event-12594400545
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Apr 24, 2024https://github.com/python/cpython/pull/118192#event-12594401554
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
April 24, 2024 15:55https://github.com/python/cpython/pull/118192#event-12594403817
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F118192
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/118192
https://github.com/ericsnowcurrently
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.