René's URL Explorer Experiment


Title: gh-109118: Make comprehensions work within annotation scopes, but without inlining by JelleZijlstra · Pull Request #118160 · python/cpython · GitHub

Open Graph Title: gh-109118: Make comprehensions work within annotation scopes, but without inlining by JelleZijlstra · Pull Request #118160 · python/cpython

X Title: gh-109118: Make comprehensions work within annotation scopes, but without inlining by JelleZijlstra · Pull Request #118160 · python/cpython

Description: This is what I have so far to allow comprehensions within annotation scopes. The first commit changes the tests to what I think is the right behavior, and removes the SyntaxError on comprehensions ...

Open Graph Description: This is what I have so far to allow comprehensions within annotation scopes. The first commit changes the tests to what I think is the right behavior, and removes the SyntaxError on comprehensions ...

X Description: This is what I have so far to allow comprehensions within annotation scopes. The first commit changes the tests to what I think is the right behavior, and removes the SyntaxError on comprehensions ...

Opengraph URL: https://github.com/python/cpython/pull/118160

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:cd8ace38-b836-ca3a-b04f-a402c6fadc85
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE42E:371600:BAC868:102EF46:696A7F02
html-safe-nonceda2f63e53f7a4405488a53dabe888395f6778ca6b0c626da10c6ca0bb6a2fc08
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNDJFOjM3MTYwMDpCQUM4Njg6MTAyRUY0Njo2OTZBN0YwMiIsInZpc2l0b3JfaWQiOiI4MDc0NTA2MjE1Nzk5NTUzNzk0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacf5b32d9b118a8faa97a6b1a06db63977adade2313651935245bc7288cc13c38f
hovercard-subject-tagpull_request:1835378703
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/118160/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/37b2cf7ca6028c6fa0cd917040a1417f336e660931f3ca34af2d6add1cb00d0e/python/cpython/pull/118160
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/37b2cf7ca6028c6fa0cd917040a1417f336e660931f3ca34af2d6add1cb00d0e/python/cpython/pull/118160
og:image:altThis is what I have so far to allow comprehensions within annotation scopes. The first commit changes the tests to what I think is the right behavior, and removes the SyntaxError on comprehensions ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameJelleZijlstra
hostnamegithub.com
expected-hostnamegithub.com
None913560fa317c3c5a71e34f9b19253c9f09d02b4b958a86c2a56f4c8541116377
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5998c30593994bf2589055aef7b22d368a499367
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/118160#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F118160
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F118160
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/118160
Reloadhttps://github.com/python/cpython/pull/118160
Reloadhttps://github.com/python/cpython/pull/118160
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/118160
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/118160
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/118160#issue-comment-box
JelleZijlstrahttps://github.com/JelleZijlstra
python:mainhttps://github.com/python/cpython/tree/main
JelleZijlstra:lambdaannohttps://github.com/JelleZijlstra/cpython/tree/lambdaanno
gh-109118: Make comprehensions work within annotation scopes, but without inlining https://github.com/python/cpython/pull/118160#top
JelleZijlstrahttps://github.com/JelleZijlstra
python:mainhttps://github.com/python/cpython/tree/main
JelleZijlstra:lambdaannohttps://github.com/JelleZijlstra/cpython/tree/lambdaanno
Conversation 5 https://github.com/python/cpython/pull/118160
Commits 7 https://github.com/python/cpython/pull/118160/commits
Checks 0 https://github.com/python/cpython/pull/118160/checks
Files changed https://github.com/python/cpython/pull/118160/files
Please reload this pagehttps://github.com/python/cpython/pull/118160
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
Apr 22, 2024https://github.com/python/cpython/pull/118160#issue-2257398864
Please reload this pagehttps://github.com/python/cpython/pull/118160
#104528https://github.com/python/cpython/pull/104528
@carljmhttps://github.com/carljm
Annotation scopes containing nested scopes #109118https://github.com/python/cpython/issues/109118
Please reload this pagehttps://github.com/python/cpython/pull/118160
JelleZijlstrahttps://github.com/JelleZijlstra
April 22, 2024 13:19https://github.com/python/cpython/pull/118160#commits-pushed-ad56c5f
https://github.com/JelleZijlstra
Desired behaviorhttps://github.com/python/cpython/pull/118160/commits/ad56c5fbc2c598ead76bc9a1bbbd31b9287a193e
ad56c5fhttps://github.com/python/cpython/pull/118160/commits/ad56c5fbc2c598ead76bc9a1bbbd31b9287a193e
https://github.com/JelleZijlstra
not correcthttps://github.com/python/cpython/pull/118160/commits/5ade8d4836a23567eddff7251ae385c502f7d981
5ade8d4https://github.com/python/cpython/pull/118160/commits/5ade8d4836a23567eddff7251ae385c502f7d981
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Apr 22, 2024 https://github.com/python/cpython/pull/118160#ref-issue-1886639998
Annotation scopes containing nested scopes #109118 https://github.com/python/cpython/issues/109118
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
Apr 22, 2024 https://github.com/python/cpython/pull/118160#ref-pullrequest-2249520540
gh-109118: Allow lambdas in annotation scopes in classes #118019 https://github.com/python/cpython/pull/118019
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
Apr 22, 2024 https://github.com/python/cpython/pull/118160#pullrequestreview-2015743961
View reviewed changes https://github.com/python/cpython/pull/118160/files/5ade8d4836a23567eddff7251ae385c502f7d981
Lib/test/test_type_params.pyhttps://github.com/python/cpython/pull/118160/files/5ade8d4836a23567eddff7251ae385c502f7d981#diff-a3155be59171fb8ab2dbda75f1be6110623d1f120e7a01ff23f2344ee7635bfa
Please reload this pagehttps://github.com/python/cpython/pull/118160
https://github.com/carljm
carljmhttps://github.com/carljm
Apr 24, 2024https://github.com/python/cpython/pull/118160#issuecomment-2075014598
Please reload this pagehttps://github.com/python/cpython/pull/118160
JelleZijlstrahttps://github.com/JelleZijlstra
April 25, 2024 21:03https://github.com/python/cpython/pull/118160#commits-pushed-ba90c97
https://github.com/JelleZijlstra
Revert "not correct"https://github.com/python/cpython/pull/118160/commits/ba90c9764ba62b288ef0b262ff3b57ecb9e16161
ba90c97https://github.com/python/cpython/pull/118160/commits/ba90c9764ba62b288ef0b262ff3b57ecb9e16161
5ade8d4https://github.com/JelleZijlstra/cpython/commit/5ade8d4836a23567eddff7251ae385c502f7d981
https://github.com/JelleZijlstra
Merge remote-tracking branch 'upstream/main' into lambdaannohttps://github.com/python/cpython/pull/118160/commits/28e78a6bc4de47f3f4095342708eccc8db882409
28e78a6https://github.com/python/cpython/pull/118160/commits/28e78a6bc4de47f3f4095342708eccc8db882409
https://github.com/JelleZijlstra
Do not inline themhttps://github.com/python/cpython/pull/118160/commits/1a9b8eda9f4782534ec3930039a2e2633c677a8f
1a9b8edhttps://github.com/python/cpython/pull/118160/commits/1a9b8eda9f4782534ec3930039a2e2633c677a8f
https://github.com/JelleZijlstra
Rename "error_cases"https://github.com/python/cpython/pull/118160/commits/79e9332f87e5f4a051d03eb52e1dae795d9ae18d
79e9332https://github.com/python/cpython/pull/118160/commits/79e9332f87e5f4a051d03eb52e1dae795d9ae18d
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
Apr 26, 2024https://github.com/python/cpython/pull/118160#issuecomment-2078601940
Please reload this pagehttps://github.com/python/cpython/pull/118160
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
Apr 26, 2024https://github.com/python/cpython/pull/118160#event-12618414399
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
April 26, 2024 04:20https://github.com/python/cpython/pull/118160#event-12618416051
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Apr 26, 2024https://github.com/python/cpython/pull/118160#event-12618416279
https://github.com/carljm
carljmhttps://github.com/carljm
Apr 26, 2024 https://github.com/python/cpython/pull/118160#pullrequestreview-2025989633
View reviewed changes https://github.com/python/cpython/pull/118160/files/79e9332f87e5f4a051d03eb52e1dae795d9ae18d
carljmhttps://github.com/carljm
https://github.com/python/cpython/pull/118160#pullrequestreview-2025989633
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/118160
Doc/whatsnew/3.13.rsthttps://github.com/python/cpython/pull/118160/files/79e9332f87e5f4a051d03eb52e1dae795d9ae18d#diff-0eef04c1aae0cf8389945464f271ff6789259ef8985f5fdbb21c9a99c4b5021f
Please reload this pagehttps://github.com/python/cpython/pull/118160
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Apr 26, 2024https://github.com/python/cpython/pull/118160#event-12629234613
https://github.com/JelleZijlstra
https://github.com/carljm
Update Doc/whatsnew/3.13.rsthttps://github.com/python/cpython/pull/118160/commits/9e6ade7446bffa32eb39ac4f7903a2fd3a9d4add
9e6ade7https://github.com/python/cpython/pull/118160/commits/9e6ade7446bffa32eb39ac4f7903a2fd3a9d4add
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
2326d6chttps://github.com/python/cpython/commit/2326d6c868e300a814179d77fc308fec8365cb8c
Apr 28, 2024https://github.com/python/cpython/pull/118160#event-12634791213
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Apr 28, 2024https://github.com/python/cpython/pull/118160#event-12634791307
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
April 28, 2024 13:21https://github.com/python/cpython/pull/118160#event-12634791323
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F118160
https://github.com/carljm
carljm https://github.com/carljm
https://github.com/python/cpython/pull/118160/files/79e9332f87e5f4a051d03eb52e1dae795d9ae18d
Please reload this pagehttps://github.com/python/cpython/pull/118160
https://github.com/JelleZijlstra
https://github.com/carljm
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.