René's URL Explorer Experiment


Title: gh-117889: Fix PGO test in test_peg_generator by vstinner · Pull Request #117893 · python/cpython · GitHub

Open Graph Title: gh-117889: Fix PGO test in test_peg_generator by vstinner · Pull Request #117893 · python/cpython

X Title: gh-117889: Fix PGO test in test_peg_generator by vstinner · Pull Request #117893 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Reuse support.check_cflags_pgo() in test_peg_generator to check if PGO build is used or not. Issue: test_peg_generator fails on a PGO+LTO build with clang #117889

X Description: Reuse support.check_cflags_pgo() in test_peg_generator to check if PGO build is used or not. Issue: test_peg_generator fails on a PGO+LTO build with clang #117889

Opengraph URL: https://github.com/python/cpython/pull/117893

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5e86416d-77ad-b777-8bf5-a25c24a95087
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id99B8:2826BD:F7A96C:14615FE:6AFE980E
html-safe-nonced5f64f783c82a8cd4e38bd48cc76216c6cd4ac41f2b4721b2b178b19857f6f94
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OUI4OjI4MjZCRDpGN0E5NkM6MTQ2MTVGRTo2QUZFOTgwRSIsInZpc2l0b3JfaWQiOiI1Nzk2MjU5OTA0NzkyNDY3NDcwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac455e6a71048e8c34781c63c6d4a897f0bdc568ffdddc5d5da31e087af4694cc5
hovercard-subject-tagpull_request:1823295875
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/117893/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/32d3cc3fe959edbd48c5d7ae2915ca90237c9c6ecd8eeb2588a12e6deb38aeff/python/cpython/pull/117893
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/32d3cc3fe959edbd48c5d7ae2915ca90237c9c6ecd8eeb2588a12e6deb38aeff/python/cpython/pull/117893
og:image:altReuse support.check_cflags_pgo() in test_peg_generator to check if PGO build is used or not. Issue: test_peg_generator fails on a PGO+LTO build with clang #117889
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamevstinner
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/117893#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F117893
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F117893
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/117893
Reloadhttps://github.com/python/cpython/pull/117893
Reloadhttps://github.com/python/cpython/pull/117893
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
vstinner:test_peg_genhttps://github.com/vstinner/cpython/tree/test_peg_gen
Conversationhttps://github.com/python/cpython/pull/117893
Commits2 (2)https://github.com/python/cpython/pull/117893/commits
Checkshttps://github.com/python/cpython/pull/117893/checks
Files changedhttps://github.com/python/cpython/pull/117893/files
gh-117889: Fix PGO test in test_peg_generatorhttps://github.com/python/cpython/pull/117893#top
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
vstinner:test_peg_genhttps://github.com/vstinner/cpython/tree/test_peg_gen
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Apr 15, 2024https://github.com/python/cpython/pull/117893#issue-2243682533
Please reload this pagehttps://github.com/python/cpython/pull/117893
test_peg_generator fails on a PGO+LTO build with clang #117889https://github.com/python/cpython/issues/117889
Please reload this pagehttps://github.com/python/cpython/pull/117893
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
needs backport to 3.11 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.11%22
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
Apr 15, 2024https://github.com/python/cpython/pull/117893#event-12470184503
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
lysnikolaouhttps://github.com/lysnikolaou
pablogsalhttps://github.com/pablogsal
code ownershttps://github.com/python/cpython/blob/7d0be7aea569b3bc9a3936501d7d32af87c70e73/.github/CODEOWNERS#L147
April 15, 2024 13:25https://github.com/python/cpython/pull/117893#event-12470184796
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
tests https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Apr 15, 2024https://github.com/python/cpython/pull/117893#event-12470185769
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Apr 15, 2024 https://github.com/python/cpython/pull/117893#ref-issue-2243556086
test_peg_generator fails on a PGO+LTO build with clang #117889 https://github.com/python/cpython/issues/117889
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
needs backport to 3.11 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.11%22
Apr 15, 2024https://github.com/python/cpython/pull/117893#event-12470192245
vstinnerhttps://github.com/vstinner
April 15, 2024 15:29https://github.com/python/cpython/pull/117893#commits-pushed-b0afdac
https://github.com/vstinner
pythongh-117889https://github.com/python/cpython/issues/117889
: Fix PGO test in test_peg_generatorhttps://github.com/python/cpython/pull/117893/commits/b0afdacaa4dee837b1c3627f0de4f23c767c62df
b0afdachttps://github.com/python/cpython/pull/117893/commits/b0afdacaa4dee837b1c3627f0de4f23c767c62df
https://github.com/vstinner
test.pythoninfo logs PGO_PROF_USE_FLAGhttps://github.com/python/cpython/pull/117893/commits/b95aa4788e38554989b98f29a02401cd8c244187
b95aa47https://github.com/python/cpython/pull/117893/commits/b95aa4788e38554989b98f29a02401cd8c244187
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
force-pushedhttps://github.com/python/cpython/compare/03007bad5d45687f68bc6bc33cebdc9106f5af9a..b95aa4788e38554989b98f29a02401cd8c244187
03007bahttps://github.com/python/cpython/commit/03007bad5d45687f68bc6bc33cebdc9106f5af9a
b95aa47https://github.com/python/cpython/commit/b95aa4788e38554989b98f29a02401cd8c244187
Compare https://github.com/python/cpython/compare/03007bad5d45687f68bc6bc33cebdc9106f5af9a..b95aa4788e38554989b98f29a02401cd8c244187
April 15, 2024 13:30https://github.com/python/cpython/pull/117893#event-12470277483
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Apr 15, 2024 https://github.com/python/cpython/pull/117893#pullrequestreview-2001145566
View reviewed changes https://github.com/python/cpython/pull/117893/files/b95aa4788e38554989b98f29a02401cd8c244187
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Apr 15, 2024https://github.com/python/cpython/pull/117893#event-12470438397
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Apr 15, 2024https://github.com/python/cpython/pull/117893#issuecomment-2056883001
Please reload this pagehttps://github.com/python/cpython/pull/117893
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
April 15, 2024 13:45https://github.com/python/cpython/pull/117893#event-12470575524
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Apr 15, 2024 https://github.com/python/cpython/pull/117893#ref-pullrequest-2239464988
gh-117752: Autoconf: fix PGO builds for 'make -C build' incantations #117803 https://github.com/python/cpython/pull/117803
https://github.com/erlend-aasland
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F117893
https://github.com/bedevere-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F117893
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
64cd6fchttps://github.com/python/cpython/commit/64cd6fc9a6a3c3c19091a1c81cbbe8994583017d
Apr 15, 2024https://github.com/python/cpython/pull/117893#event-12470828793
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
April 15, 2024 13:59https://github.com/python/cpython/pull/117893#event-12470829042
https://github.com/apps/miss-islington-app
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F117893
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Apr 15, 2024https://github.com/python/cpython/pull/117893#event-12470829767
miss-islingtonhttps://github.com/miss-islington
Apr 15, 2024 https://github.com/python/cpython/pull/117893#ref-commit-a6a1573
https://github.com/vstinner
https://github.com/miss-islington
pythongh-117889https://github.com/python/cpython/issues/117889
: Fix PGO test in test_peg_generator (https://github.com/miss-islington/cpython/commit/a6a15738cc1c9e72946ffba001f734614a5949d0
pythonGH-117893https://github.com/python/cpython/pull/117893
)https://github.com/miss-islington/cpython/commit/a6a15738cc1c9e72946ffba001f734614a5949d0
a6a1573https://github.com/miss-islington/cpython/commit/a6a15738cc1c9e72946ffba001f734614a5949d0
64cd6fchttps://github.com/miss-islington/cpython/commit/64cd6fc9a6a3c3c19091a1c81cbbe8994583017d
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Apr 15, 2024https://github.com/python/cpython/pull/117893#issuecomment-2056933614
GH-117895https://github.com/python/cpython/pull/117895
3.12 branchhttps://github.com/python/cpython/tree/3.12
Please reload this pagehttps://github.com/python/cpython/pull/117893
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
Apr 15, 2024https://github.com/python/cpython/pull/117893#event-12470833038
erlend-aaslandhttps://github.com/erlend-aasland
Apr 15, 2024 https://github.com/python/cpython/pull/117893#ref-commit-6a4c06b
https://github.com/miss-islington
https://github.com/vstinner
[3.12]https://github.com/python/cpython/commit/6a4c06bcb341628d720ea5b2d0cb5500db8b7694
gh-117889https://github.com/python/cpython/issues/117889
: Fix PGO test in test_peg_generator (https://github.com/python/cpython/commit/6a4c06bcb341628d720ea5b2d0cb5500db8b7694
GH-117893https://github.com/python/cpython/pull/117893
) (https://github.com/python/cpython/commit/6a4c06bcb341628d720ea5b2d0cb5500db8b7694
#11…https://github.com/python/cpython/pull/117895
6a4c06bhttps://github.com/python/cpython/commit/6a4c06bcb341628d720ea5b2d0cb5500db8b7694
…7895https://github.com/python/cpython/pull/117895
64cd6fchttps://github.com/python/cpython/commit/64cd6fc9a6a3c3c19091a1c81cbbe8994583017d
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Apr 15, 2024https://github.com/python/cpython/pull/117893#issuecomment-2057688205
@erlend-aaslandhttps://github.com/erlend-aasland
Please reload this pagehttps://github.com/python/cpython/pull/117893
diegorussohttps://github.com/diegorusso
Apr 17, 2024 https://github.com/python/cpython/pull/117893#ref-commit-e015fc7
https://github.com/vstinner
https://github.com/diegorusso
pythongh-117889https://github.com/python/cpython/issues/117889
: Fix PGO test in test_peg_generator (https://github.com/diegorusso/cpython/commit/e015fc7aa8d2b5011d4bfe22443f176e30532c1f
python#117893https://github.com/python/cpython/pull/117893
)https://github.com/diegorusso/cpython/commit/e015fc7aa8d2b5011d4bfe22443f176e30532c1f
e015fc7https://github.com/diegorusso/cpython/commit/e015fc7aa8d2b5011d4bfe22443f176e30532c1f
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F117893
https://github.com/erlend-aasland
erlend-aasland https://github.com/erlend-aasland
https://github.com/python/cpython/pull/117893/files/b95aa4788e38554989b98f29a02401cd8c244187
https://github.com/pablogsal
pablogsal https://github.com/pablogsal
https://github.com/lysnikolaou
lysnikolaou https://github.com/lysnikolaou
Please reload this pagehttps://github.com/python/cpython/pull/117893
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
tests https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests
Please reload this pagehttps://github.com/python/cpython/pull/117893
https://github.com/vstinner
https://github.com/erlend-aasland
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.