| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:5e86416d-77ad-b777-8bf5-a25c24a95087 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 99B8:2826BD:F7A96C:14615FE:6AFE980E |
| html-safe-nonce | d5f64f783c82a8cd4e38bd48cc76216c6cd4ac41f2b4721b2b178b19857f6f94 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OUI4OjI4MjZCRDpGN0E5NkM6MTQ2MTVGRTo2QUZFOTgwRSIsInZpc2l0b3JfaWQiOiI1Nzk2MjU5OTA0NzkyNDY3NDcwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 455e6a71048e8c34781c63c6d4a897f0bdc568ffdddc5d5da31e087af4694cc5 |
| hovercard-subject-tag | pull_request:1823295875 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/117893/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/32d3cc3fe959edbd48c5d7ae2915ca90237c9c6ecd8eeb2588a12e6deb38aeff/python/cpython/pull/117893 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/32d3cc3fe959edbd48c5d7ae2915ca90237c9c6ecd8eeb2588a12e6deb38aeff/python/cpython/pull/117893 |
| og:image:alt | Reuse support.check_cflags_pgo() in test_peg_generator to check if PGO build is used or not.
Issue: test_peg_generator fails on a PGO+LTO build with clang #117889 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | vstinner |
| hostname | github.com |
| expected-hostname | github.com |
| None | b3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4a10310af51a1bfffbedc4fd81cb582acf0cb0ff |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/cpython/pull/117893#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F117893 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F117893 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/117893 |
| Reload | https://github.com/python/cpython/pull/117893 |
| Reload | https://github.com/python/cpython/pull/117893 |
| python | https://github.com/python |
| cpython | https://github.com/python/cpython |
| Code | https://github.com/python/cpython |
| Issues5k+ (5k+) | https://github.com/python/cpython/issues |
| Pull requests2.4k (2.4k) | https://github.com/python/cpython/pulls |
| Actions | https://github.com/python/cpython/actions |
| Projects | https://github.com/python/cpython/projects |
| Security and quality | https://github.com/python/cpython/security |
| Insights | https://github.com/python/cpython/insights |
| https://github.com/python/cpython |
| vstinner | https://github.com/vstinner |
| python:main | https://github.com/python/cpython/tree/main |
| vstinner:test_peg_gen | https://github.com/vstinner/cpython/tree/test_peg_gen |
| Conversation | https://github.com/python/cpython/pull/117893 |
| Commits2 (2) | https://github.com/python/cpython/pull/117893/commits |
| Checks | https://github.com/python/cpython/pull/117893/checks |
| Files changed | https://github.com/python/cpython/pull/117893/files |
| gh-117889: Fix PGO test in test_peg_generator | https://github.com/python/cpython/pull/117893#top |
| vstinner | https://github.com/vstinner |
| python:main | https://github.com/python/cpython/tree/main |
| vstinner:test_peg_gen | https://github.com/vstinner/cpython/tree/test_peg_gen |
|
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
| Apr 15, 2024 | https://github.com/python/cpython/pull/117893#issue-2243682533 |
| Please reload this page | https://github.com/python/cpython/pull/117893 |
| test_peg_generator fails on a PGO+LTO build with clang #117889 | https://github.com/python/cpython/issues/117889 |
| Please reload this page | https://github.com/python/cpython/pull/117893 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
|
needs backport to 3.11
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.11%22 |
|
needs backport to 3.12
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22 |
| Apr 15, 2024 | https://github.com/python/cpython/pull/117893#event-12470184503 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
| lysnikolaou | https://github.com/lysnikolaou |
| pablogsal | https://github.com/pablogsal |
| code owners | https://github.com/python/cpython/blob/7d0be7aea569b3bc9a3936501d7d32af87c70e73/.github/CODEOWNERS#L147 |
| April 15, 2024 13:25 | https://github.com/python/cpython/pull/117893#event-12470184796 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
tests
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Apr 15, 2024 | https://github.com/python/cpython/pull/117893#event-12470185769 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
Apr 15, 2024
| https://github.com/python/cpython/pull/117893#ref-issue-2243556086 |
|
test_peg_generator fails on a PGO+LTO build with clang
#117889
| https://github.com/python/cpython/issues/117889 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
|
needs backport to 3.11
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.11%22 |
| Apr 15, 2024 | https://github.com/python/cpython/pull/117893#event-12470192245 |
| vstinner | https://github.com/vstinner |
| April 15, 2024 15:29 | https://github.com/python/cpython/pull/117893#commits-pushed-b0afdac |
|
| https://github.com/vstinner |
| pythongh-117889 | https://github.com/python/cpython/issues/117889 |
| : Fix PGO test in test_peg_generator | https://github.com/python/cpython/pull/117893/commits/b0afdacaa4dee837b1c3627f0de4f23c767c62df |
| b0afdac | https://github.com/python/cpython/pull/117893/commits/b0afdacaa4dee837b1c3627f0de4f23c767c62df |
|
| https://github.com/vstinner |
| test.pythoninfo logs PGO_PROF_USE_FLAG | https://github.com/python/cpython/pull/117893/commits/b95aa4788e38554989b98f29a02401cd8c244187 |
| b95aa47 | https://github.com/python/cpython/pull/117893/commits/b95aa4788e38554989b98f29a02401cd8c244187 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
| force-pushed | https://github.com/python/cpython/compare/03007bad5d45687f68bc6bc33cebdc9106f5af9a..b95aa4788e38554989b98f29a02401cd8c244187 |
| 03007ba | https://github.com/python/cpython/commit/03007bad5d45687f68bc6bc33cebdc9106f5af9a |
| b95aa47 | https://github.com/python/cpython/commit/b95aa4788e38554989b98f29a02401cd8c244187 |
|
Compare
| https://github.com/python/cpython/compare/03007bad5d45687f68bc6bc33cebdc9106f5af9a..b95aa4788e38554989b98f29a02401cd8c244187 |
| April 15, 2024 13:30 | https://github.com/python/cpython/pull/117893#event-12470277483 |
| https://github.com/erlend-aasland |
| erlend-aasland | https://github.com/erlend-aasland |
|
Apr 15, 2024
| https://github.com/python/cpython/pull/117893#pullrequestreview-2001145566 |
|
View reviewed changes
| https://github.com/python/cpython/pull/117893/files/b95aa4788e38554989b98f29a02401cd8c244187 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Apr 15, 2024 | https://github.com/python/cpython/pull/117893#event-12470438397 |
| https://github.com/erlend-aasland |
| erlend-aasland | https://github.com/erlend-aasland |
| Apr 15, 2024 | https://github.com/python/cpython/pull/117893#issuecomment-2056883001 |
| Please reload this page | https://github.com/python/cpython/pull/117893 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
| April 15, 2024 13:45 | https://github.com/python/cpython/pull/117893#event-12470575524 |
| https://github.com/erlend-aasland |
| erlend-aasland | https://github.com/erlend-aasland |
|
Apr 15, 2024
| https://github.com/python/cpython/pull/117893#ref-pullrequest-2239464988 |
|
gh-117752: Autoconf: fix PGO builds for 'make -C build' incantations
#117803
| https://github.com/python/cpython/pull/117803 |
| https://github.com/erlend-aasland |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F117893 |
| https://github.com/bedevere-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F117893 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
| 64cd6fc | https://github.com/python/cpython/commit/64cd6fc9a6a3c3c19091a1c81cbbe8994583017d |
| Apr 15, 2024 | https://github.com/python/cpython/pull/117893#event-12470828793 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
| April 15, 2024 13:59 | https://github.com/python/cpython/pull/117893#event-12470829042 |
| https://github.com/apps/miss-islington-app |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F117893 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Apr 15, 2024 | https://github.com/python/cpython/pull/117893#event-12470829767 |
| miss-islington | https://github.com/miss-islington |
|
Apr 15, 2024
| https://github.com/python/cpython/pull/117893#ref-commit-a6a1573 |
|
| https://github.com/vstinner |
|
| https://github.com/miss-islington |
| pythongh-117889 | https://github.com/python/cpython/issues/117889 |
| : Fix PGO test in test_peg_generator ( | https://github.com/miss-islington/cpython/commit/a6a15738cc1c9e72946ffba001f734614a5949d0 |
| pythonGH-117893 | https://github.com/python/cpython/pull/117893 |
| ) | https://github.com/miss-islington/cpython/commit/a6a15738cc1c9e72946ffba001f734614a5949d0 |
| a6a1573 | https://github.com/miss-islington/cpython/commit/a6a15738cc1c9e72946ffba001f734614a5949d0 |
| 64cd6fc | https://github.com/miss-islington/cpython/commit/64cd6fc9a6a3c3c19091a1c81cbbe8994583017d |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
| Apr 15, 2024 | https://github.com/python/cpython/pull/117893#issuecomment-2056933614 |
| GH-117895 | https://github.com/python/cpython/pull/117895 |
| 3.12 branch | https://github.com/python/cpython/tree/3.12 |
| Please reload this page | https://github.com/python/cpython/pull/117893 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
needs backport to 3.12
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22 |
| Apr 15, 2024 | https://github.com/python/cpython/pull/117893#event-12470833038 |
| erlend-aasland | https://github.com/erlend-aasland |
|
Apr 15, 2024
| https://github.com/python/cpython/pull/117893#ref-commit-6a4c06b |
|
| https://github.com/miss-islington |
|
| https://github.com/vstinner |
| [3.12] | https://github.com/python/cpython/commit/6a4c06bcb341628d720ea5b2d0cb5500db8b7694 |
| gh-117889 | https://github.com/python/cpython/issues/117889 |
| : Fix PGO test in test_peg_generator ( | https://github.com/python/cpython/commit/6a4c06bcb341628d720ea5b2d0cb5500db8b7694 |
| GH-117893 | https://github.com/python/cpython/pull/117893 |
| ) ( | https://github.com/python/cpython/commit/6a4c06bcb341628d720ea5b2d0cb5500db8b7694 |
| #11… | https://github.com/python/cpython/pull/117895 |
| 6a4c06b | https://github.com/python/cpython/commit/6a4c06bcb341628d720ea5b2d0cb5500db8b7694 |
| …7895 | https://github.com/python/cpython/pull/117895 |
| 64cd6fc | https://github.com/python/cpython/commit/64cd6fc9a6a3c3c19091a1c81cbbe8994583017d |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
| Apr 15, 2024 | https://github.com/python/cpython/pull/117893#issuecomment-2057688205 |
| @erlend-aasland | https://github.com/erlend-aasland |
| Please reload this page | https://github.com/python/cpython/pull/117893 |
| diegorusso | https://github.com/diegorusso |
|
Apr 17, 2024
| https://github.com/python/cpython/pull/117893#ref-commit-e015fc7 |
|
| https://github.com/vstinner |
|
| https://github.com/diegorusso |
| pythongh-117889 | https://github.com/python/cpython/issues/117889 |
| : Fix PGO test in test_peg_generator ( | https://github.com/diegorusso/cpython/commit/e015fc7aa8d2b5011d4bfe22443f176e30532c1f |
| python#117893 | https://github.com/python/cpython/pull/117893 |
| ) | https://github.com/diegorusso/cpython/commit/e015fc7aa8d2b5011d4bfe22443f176e30532c1f |
| e015fc7 | https://github.com/diegorusso/cpython/commit/e015fc7aa8d2b5011d4bfe22443f176e30532c1f |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F117893 |
|
| https://github.com/erlend-aasland |
|
erlend-aasland
| https://github.com/erlend-aasland |
|
| https://github.com/python/cpython/pull/117893/files/b95aa4788e38554989b98f29a02401cd8c244187 |
|
| https://github.com/pablogsal |
|
pablogsal
| https://github.com/pablogsal |
|
| https://github.com/lysnikolaou |
|
lysnikolaou
| https://github.com/lysnikolaou |
| Please reload this page | https://github.com/python/cpython/pull/117893 |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
|
tests
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests |
| Please reload this page | https://github.com/python/cpython/pull/117893 |
|
| https://github.com/vstinner |
|
| https://github.com/erlend-aasland |
|
| https://github.com/bedevere-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |