René's URL Explorer Experiment


Title: gh-116738: Make `_codecs` module thread-safe by swtaarrs · Pull Request #117530 · python/cpython · GitHub

Open Graph Title: gh-116738: Make `_codecs` module thread-safe by swtaarrs · Pull Request #117530 · python/cpython

X Title: gh-116738: Make `_codecs` module thread-safe by swtaarrs · Pull Request #117530 · python/cpython

Description: The module itself is a thin wrapper around calls to functions in Python/codecs.c, so that's where the meaningful changes happened: Move codecs-related state that lives on PyInterpreterState to a ...

Open Graph Description: The module itself is a thin wrapper around calls to functions in Python/codecs.c, so that's where the meaningful changes happened: Move codecs-related state that lives on PyInterpreterState t...

X Description: The module itself is a thin wrapper around calls to functions in Python/codecs.c, so that's where the meaningful changes happened: Move codecs-related state that lives on PyInterpreterSta...

Opengraph URL: https://github.com/python/cpython/pull/117530

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:93650981-012d-3d50-82c5-071e69da18eb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB862:1272F1:1738057:203ED27:696A9F28
html-safe-noncee0d50e98d756777e7bee9253685c804eba866b5f583ce0aaa631ef5b3404ec2c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCODYyOjEyNzJGMToxNzM4MDU3OjIwM0VEMjc6Njk2QTlGMjgiLCJ2aXNpdG9yX2lkIjoiMTY2NzA1NTUzMTUyNTMxNjM5MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac307241d22403cd40119769ac171e839d516faf7f3c5cfb9c9748f4701fe80a8f
hovercard-subject-tagpull_request:1805814297
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/117530/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/bfb70cec8644bb23546d2175daccf0d40aa03d560d3f03f6030c68f77164f73d/python/cpython/pull/117530
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bfb70cec8644bb23546d2175daccf0d40aa03d560d3f03f6030c68f77164f73d/python/cpython/pull/117530
og:image:altThe module itself is a thin wrapper around calls to functions in Python/codecs.c, so that's where the meaningful changes happened: Move codecs-related state that lives on PyInterpreterState t...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameswtaarrs
hostnamegithub.com
expected-hostnamegithub.com
Nonea51f97dbb9326f71c08ecb61577457d543c602124d1a2672871258ef37ac5261
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4bd0eac606c70914085176ef312ebdcd97a8cdf1
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/117530#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F117530
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F117530
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/117530
Reloadhttps://github.com/python/cpython/pull/117530
Reloadhttps://github.com/python/cpython/pull/117530
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/117530
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/117530
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/117530#issue-comment-box
colesburyhttps://github.com/colesbury
python:mainhttps://github.com/python/cpython/tree/main
swtaarrs:cpython-_codecs-modulehttps://github.com/swtaarrs/cpython/tree/cpython-_codecs-module
gh-116738: Make _codecs module thread-safe https://github.com/python/cpython/pull/117530#top
colesburyhttps://github.com/colesbury
python:mainhttps://github.com/python/cpython/tree/main
swtaarrs:cpython-_codecs-modulehttps://github.com/swtaarrs/cpython/tree/cpython-_codecs-module
Conversation 17 https://github.com/python/cpython/pull/117530
Commits 7 https://github.com/python/cpython/pull/117530/commits
Checks 0 https://github.com/python/cpython/pull/117530/checks
Files changed https://github.com/python/cpython/pull/117530/files
Please reload this pagehttps://github.com/python/cpython/pull/117530
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/swtaarrs
swtaarrshttps://github.com/swtaarrs
Apr 4, 2024https://github.com/python/cpython/pull/117530#issue-2224165370
Audit all built-in modules for thread safety #116738https://github.com/python/cpython/issues/116738
Please reload this pagehttps://github.com/python/cpython/pull/117530
https://github.com/swtaarrs
Make _codecs module thread-safehttps://github.com/python/cpython/pull/117530/commits/574e48c060ff85c335bcca5035d8c23c8158c9e5
574e48chttps://github.com/python/cpython/pull/117530/commits/574e48c060ff85c335bcca5035d8c23c8158c9e5
https://github.com/swtaarrs
swtaarrshttps://github.com/swtaarrs
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
interpreter-core https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Ainterpreter-core
topic-free-threading https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-free-threading
Apr 4, 2024https://github.com/python/cpython/pull/117530#event-12349842557
https://github.com/swtaarrs
swtaarrshttps://github.com/swtaarrs
colesburyhttps://github.com/colesbury
April 4, 2024 00:27https://github.com/python/cpython/pull/117530#event-12349842582
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Apr 4, 2024 https://github.com/python/cpython/pull/117530#ref-issue-2184479275
Audit all built-in modules for thread safety #116738 https://github.com/python/cpython/issues/116738
https://github.com/swtaarrs
Try to fix check-c-globalshttps://github.com/python/cpython/pull/117530/commits/d8bcdd8f9bc2cac51b8477143a5b861d302aa00b
d8bcdd8https://github.com/python/cpython/pull/117530/commits/d8bcdd8f9bc2cac51b8477143a5b861d302aa00b
https://github.com/swtaarrs
swtaarrshttps://github.com/swtaarrs
April 4, 2024 17:49https://github.com/python/cpython/pull/117530#event-12362450323
https://github.com/swtaarrs
swtaarrshttps://github.com/swtaarrs
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
code ownerhttps://github.com/python/cpython/blob/04697bcfaf5dd34c9312f4f405083b6d33b3511f/.github/CODEOWNERS#L45
April 4, 2024 17:49https://github.com/python/cpython/pull/117530#event-12362450401
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Apr 4, 2024https://github.com/python/cpython/pull/117530#event-12362450909
https://github.com/colesbury
colesburyhttps://github.com/colesbury
Apr 10, 2024 https://github.com/python/cpython/pull/117530#pullrequestreview-1992117747
View reviewed changes https://github.com/python/cpython/pull/117530/files/d8bcdd8f9bc2cac51b8477143a5b861d302aa00b
colesburyhttps://github.com/colesbury
https://github.com/python/cpython/pull/117530#pullrequestreview-1992117747
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/117530
Python/codecs.chttps://github.com/python/cpython/pull/117530/files/d8bcdd8f9bc2cac51b8477143a5b861d302aa00b#diff-a22bcb6c26007e5597e92a6abb0a27ce987072fcfa7220623c869044c3097784
Please reload this pagehttps://github.com/python/cpython/pull/117530
Python/codecs.chttps://github.com/python/cpython/pull/117530/files/d8bcdd8f9bc2cac51b8477143a5b861d302aa00b#diff-a22bcb6c26007e5597e92a6abb0a27ce987072fcfa7220623c869044c3097784
Please reload this pagehttps://github.com/python/cpython/pull/117530
swtaarrshttps://github.com/swtaarrs
April 14, 2024 18:03https://github.com/python/cpython/pull/117530#commits-pushed-8076032
https://github.com/swtaarrs
Initialize codec registry eagerly, greatly simplifying thingshttps://github.com/python/cpython/pull/117530/commits/8076032203cd345ff60839b964898cb61df4f55b
8076032https://github.com/python/cpython/pull/117530/commits/8076032203cd345ff60839b964898cb61df4f55b
https://github.com/swtaarrs
Merge remote-tracking branch 'upstream/main' into cpython-_codecs-modulehttps://github.com/python/cpython/pull/117530/commits/137cf271cc087698848c52e0e8abc36da9f73b60
137cf27https://github.com/python/cpython/pull/117530/commits/137cf271cc087698848c52e0e8abc36da9f73b60
https://github.com/colesbury
colesburyhttps://github.com/colesbury
Apr 15, 2024 https://github.com/python/cpython/pull/117530#pullrequestreview-2001555840
View reviewed changes https://github.com/python/cpython/pull/117530/files/137cf271cc087698848c52e0e8abc36da9f73b60
colesburyhttps://github.com/colesbury
https://github.com/python/cpython/pull/117530#pullrequestreview-2001555840
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/117530
Python/codecs.chttps://github.com/python/cpython/pull/117530/files/137cf271cc087698848c52e0e8abc36da9f73b60#diff-a22bcb6c26007e5597e92a6abb0a27ce987072fcfa7220623c869044c3097784
Please reload this pagehttps://github.com/python/cpython/pull/117530
Python/pystate.chttps://github.com/python/cpython/pull/117530/files/137cf271cc087698848c52e0e8abc36da9f73b60#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
Please reload this pagehttps://github.com/python/cpython/pull/117530
Objects/object.chttps://github.com/python/cpython/pull/117530/files/137cf271cc087698848c52e0e8abc36da9f73b60#diff-ba56d44ce0dd731d979970b966fde9d8dd15d12a82f727a052a8ad48d4a49363
Please reload this pagehttps://github.com/python/cpython/pull/117530
https://github.com/swtaarrs
Final review comments, and add missing newline after _PyCodec_InitReg…https://github.com/python/cpython/pull/117530/commits/4d5bffc741c6c501fd11cd418b68b5c35ce8ef56
4d5bffchttps://github.com/python/cpython/pull/117530/commits/4d5bffc741c6c501fd11cd418b68b5c35ce8ef56
https://github.com/swtaarrs
swtaarrshttps://github.com/swtaarrs
Apr 26, 2024https://github.com/python/cpython/pull/117530#issuecomment-2080020232
Please reload this pagehttps://github.com/python/cpython/pull/117530
swtaarrshttps://github.com/swtaarrs
April 26, 2024 12:44https://github.com/python/cpython/pull/117530#commits-pushed-dea7cf5
https://github.com/swtaarrs
Merge remote-tracking branch 'upstream/main' into cpython-_codecs-modulehttps://github.com/python/cpython/pull/117530/commits/dea7cf5727c23e973875ff58069fbe647cb54044
dea7cf5https://github.com/python/cpython/pull/117530/commits/dea7cf5727c23e973875ff58069fbe647cb54044
https://github.com/swtaarrs
Merge remote-tracking branch 'upstream/main' into cpython-_codecs-modulehttps://github.com/python/cpython/pull/117530/commits/6ffff020b84f898e3ba16f346d8e1189a978c4f6
6ffff02https://github.com/python/cpython/pull/117530/commits/6ffff020b84f898e3ba16f346d8e1189a978c4f6
https://github.com/colesbury
colesburyhttps://github.com/colesbury
May 2, 2024 https://github.com/python/cpython/pull/117530#pullrequestreview-2036552119
View reviewed changes https://github.com/python/cpython/pull/117530/files/6ffff020b84f898e3ba16f346d8e1189a978c4f6
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
May 2, 2024https://github.com/python/cpython/pull/117530#event-12687408521
https://github.com/colesbury
colesburyhttps://github.com/colesbury
f8290dfhttps://github.com/python/cpython/commit/f8290df63f1fd970dfd6bbfdc9a86341a9f97d05
May 2, 2024https://github.com/python/cpython/pull/117530#event-12690033833
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
May 2, 2024https://github.com/python/cpython/pull/117530#event-12690034194
SonicFieldhttps://github.com/SonicField
May 8, 2024 https://github.com/python/cpython/pull/117530#ref-commit-7dba86e
https://github.com/swtaarrs
https://github.com/SonicField
pythongh-116738https://github.com/python/cpython/issues/116738
: Makehttps://github.com/SonicField/cpython/commit/7dba86e8d457af9e8628808099c9ad9cf3df2296
_codecshttps://github.com/SonicField/cpython/commit/7dba86e8d457af9e8628808099c9ad9cf3df2296
module thread-safe (https://github.com/SonicField/cpython/commit/7dba86e8d457af9e8628808099c9ad9cf3df2296
python#117530https://github.com/python/cpython/pull/117530
)https://github.com/SonicField/cpython/commit/7dba86e8d457af9e8628808099c9ad9cf3df2296
7dba86ehttps://github.com/SonicField/cpython/commit/7dba86e8d457af9e8628808099c9ad9cf3df2296
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F117530
https://github.com/mpage
mpage https://github.com/mpage
https://github.com/python/cpython/pull/117530/files/d8bcdd8f9bc2cac51b8477143a5b861d302aa00b
https://github.com/colesbury
colesbury https://github.com/colesbury
https://github.com/python/cpython/pull/117530/files/6ffff020b84f898e3ba16f346d8e1189a978c4f6
https://github.com/ericsnowcurrently
ericsnowcurrently https://github.com/ericsnowcurrently
interpreter-core https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Ainterpreter-core
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
topic-free-threading https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-free-threading
Please reload this pagehttps://github.com/python/cpython/pull/117530
https://github.com/swtaarrs
https://github.com/mpage
https://github.com/colesbury
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.