René's URL Explorer Experiment


Title: bpo-35890 : Fix some API calling consistency by gongminmin · Pull Request #11742 · python/cpython · GitHub

Open Graph Title: bpo-35890 : Fix some API calling consistency by gongminmin · Pull Request #11742 · python/cpython

X Title: bpo-35890 : Fix some API calling consistency by gongminmin · Pull Request #11742 · python/cpython

Description: Unicode version of Windows APIs are used in places, but not for GetVersionEx in Python/sysmodule.c The wcstok_s is called on Windows in Modules/main.c and PC/launcher.c, but not in Python/pathconfig.c This change fixes these 2 callings by calling unicode version GetVersionExW, and add a WCSTOK macro to wrap wcstok_s. https://bugs.python.org/issue35890

Open Graph Description: Unicode version of Windows APIs are used in places, but not for GetVersionEx in Python/sysmodule.c The wcstok_s is called on Windows in Modules/main.c and PC/launcher.c, but not in Python/pathconfi...

X Description: Unicode version of Windows APIs are used in places, but not for GetVersionEx in Python/sysmodule.c The wcstok_s is called on Windows in Modules/main.c and PC/launcher.c, but not in Python/pathconfi...

Opengraph URL: https://github.com/python/cpython/pull/11742

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:da304a5f-21d8-ec83-53ef-d923231a22e1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id92D6:16BCD3:9F6279C:DFEA3EA:6A50CBE0
html-safe-nonceb101330300eb02525232363f4fe3db9a03291b3265e8a66337d8efff76bfcb46
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MkQ2OjE2QkNEMzo5RjYyNzlDOkRGRUEzRUE6NkE1MENCRTAiLCJ2aXNpdG9yX2lkIjoiNDE5ODQzNzU4OTk3ODUwMDA2NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4b67fd9e2ce28223431cb6ce1dc102077ca48ebe0520f711820a3d2e80426c6e
hovercard-subject-tagpull_request:249840477
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/11742/files
twitter:imagehttps://avatars.githubusercontent.com/u/1177147?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1177147?s=400&v=4
og:image:altUnicode version of Windows APIs are used in places, but not for GetVersionEx in Python/sysmodule.c The wcstok_s is called on Windows in Modules/main.c and PC/launcher.c, but not in Python/pathconfi...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None72b13e0e8d0319acdd27a145cfe73f4f06c791713d0ac4690e41fb68ad28cac0
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release08e79d53fc070870d5b168356afebb1e286a2ffe
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/11742/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F11742%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F11742%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/11742/files
Reloadhttps://github.com/python/cpython/pull/11742/files
Reloadhttps://github.com/python/cpython/pull/11742/files
Please reload this pagehttps://github.com/python/cpython/pull/11742/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/11742/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
zoobahttps://github.com/zooba
python:masterhttps://github.com/python/cpython/tree/master
gongminmin:ApiConsistencyhttps://github.com/gongminmin/cpython/tree/ApiConsistency
Conversation 4 https://github.com/python/cpython/pull/11742
Commits 3 https://github.com/python/cpython/pull/11742/commits
Checks 0 https://github.com/python/cpython/pull/11742/checks
Files changed https://github.com/python/cpython/pull/11742/files
Please reload this pagehttps://github.com/python/cpython/pull/11742/files
bpo-35890 : Fix some API calling consistency https://github.com/python/cpython/pull/11742/files#top
Show all changes 3 commits https://github.com/python/cpython/pull/11742/files
b699a11 Fix some API calling consistency gongminmin Feb 2, 2019 https://github.com/python/cpython/pull/11742/commits/b699a119bf0fa8adba84d635565829e743405dd7
78de4ac 📜🤖 Added by blurb_it. blurb-it[bot] Feb 2, 2019 https://github.com/python/cpython/pull/11742/commits/78de4ace2c8de3ff2c2e8d59fe86587ae30b030c
17fa3cc Addressing issues in code review gongminmin Feb 3, 2019 https://github.com/python/cpython/pull/11742/commits/17fa3cccbdee8d5cb5901b64e422adf2e6cbb088
Clear filters https://github.com/python/cpython/pull/11742/files
Please reload this pagehttps://github.com/python/cpython/pull/11742/files
Please reload this pagehttps://github.com/python/cpython/pull/11742/files
2019-02-02-22-12-23.bpo-35890.ccIjHH.rst https://github.com/python/cpython/pull/11742/files#diff-e95eebe06ab6058e63353a8e479083cc16fd7face649577a4aba919ae00816e8
pathconfig.c https://github.com/python/cpython/pull/11742/files#diff-09327e0a986b458413322c8ef2c9f7ff06f191cc79520787f95db7598e633415
sysmodule.c https://github.com/python/cpython/pull/11742/files#diff-a3a5c73931235f7f344c072dc755d6508e13923db3f5d581c5e88652075871cb
Misc/NEWS.d/next/Windows/2019-02-02-22-12-23.bpo-35890.ccIjHH.rsthttps://github.com/python/cpython/pull/11742/files#diff-e95eebe06ab6058e63353a8e479083cc16fd7face649577a4aba919ae00816e8
View file https://github.com/gongminmin/cpython/blob/17fa3cccbdee8d5cb5901b64e422adf2e6cbb088/Misc/NEWS.d/next/Windows/2019-02-02-22-12-23.bpo-35890.ccIjHH.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/11742/{{ revealButtonHref }}
Python/pathconfig.chttps://github.com/python/cpython/pull/11742/files#diff-09327e0a986b458413322c8ef2c9f7ff06f191cc79520787f95db7598e633415
View file https://github.com/gongminmin/cpython/blob/17fa3cccbdee8d5cb5901b64e422adf2e6cbb088/Python/pathconfig.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/11742/{{ revealButtonHref }}
https://github.com/python/cpython/pull/11742/files#diff-09327e0a986b458413322c8ef2c9f7ff06f191cc79520787f95db7598e633415
https://github.com/python/cpython/pull/11742/files#diff-09327e0a986b458413322c8ef2c9f7ff06f191cc79520787f95db7598e633415
https://github.com/python/cpython/pull/11742/files#diff-09327e0a986b458413322c8ef2c9f7ff06f191cc79520787f95db7598e633415
https://github.com/python/cpython/pull/11742/files#diff-09327e0a986b458413322c8ef2c9f7ff06f191cc79520787f95db7598e633415
Python/sysmodule.chttps://github.com/python/cpython/pull/11742/files#diff-a3a5c73931235f7f344c072dc755d6508e13923db3f5d581c5e88652075871cb
View file https://github.com/gongminmin/cpython/blob/17fa3cccbdee8d5cb5901b64e422adf2e6cbb088/Python/sysmodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/11742/{{ revealButtonHref }}
https://github.com/python/cpython/pull/11742/files#diff-a3a5c73931235f7f344c072dc755d6508e13923db3f5d581c5e88652075871cb
https://github.com/python/cpython/pull/11742/files#diff-a3a5c73931235f7f344c072dc755d6508e13923db3f5d581c5e88652075871cb
https://github.com/python/cpython/pull/11742/files#diff-a3a5c73931235f7f344c072dc755d6508e13923db3f5d581c5e88652075871cb
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.