René's URL Explorer Experiment


Title: gh-107674: Remove some unnecessary code in instrumentation code by gaogaotiantian · Pull Request #117393 · python/cpython · GitHub

Open Graph Title: gh-107674: Remove some unnecessary code in instrumentation code by gaogaotiantian · Pull Request #117393 · python/cpython

X Title: gh-107674: Remove some unnecessary code in instrumentation code by gaogaotiantian · Pull Request #117393 · python/cpython

Description: This might not be super helpful but it's free and easy to justify. Also it makes the code cleaner, not messier. line >= 0 was already asserted above so the check is unnecessary Py_None is immortal...

Open Graph Description: This might not be super helpful but it's free and easy to justify. Also it makes the code cleaner, not messier. line >= 0 was already asserted above so the check is unnecessary Py_None is i...

X Description: This might not be super helpful but it's free and easy to justify. Also it makes the code cleaner, not messier. line >= 0 was already asserted above so the check is unnecessary Py_N...

Opengraph URL: https://github.com/python/cpython/pull/117393

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ba27379c-3766-a781-6878-c1d1e7a10648
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCD2C:189C33:1D08377:25D78B0:696B3B4C
html-safe-noncefa2c3f43ed816e068735ba6aa7499eafee5bdf6ad45c451c1e557b3911a2b32b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRDJDOjE4OUMzMzoxRDA4Mzc3OjI1RDc4QjA6Njk2QjNCNEMiLCJ2aXNpdG9yX2lkIjoiNDg5NDE4NTcwNzM4NDAyNzk4MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac66877a429dcd85da7ce2ea82e52417943b154a366d9608bcfadbb83294899eff
hovercard-subject-tagpull_request:1799069879
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/117393/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d5e592d74a5df948291d0ece6e40ffce1b73cebb92cb4288baeecbd2459f9bc5/python/cpython/pull/117393
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d5e592d74a5df948291d0ece6e40ffce1b73cebb92cb4288baeecbd2459f9bc5/python/cpython/pull/117393
og:image:altThis might not be super helpful but it's free and easy to justify. Also it makes the code cleaner, not messier. line >= 0 was already asserted above so the check is unnecessary Py_None is i...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegaogaotiantian
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/117393#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F117393
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F117393
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/117393
Reloadhttps://github.com/python/cpython/pull/117393
Reloadhttps://github.com/python/cpython/pull/117393
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/117393
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/117393
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/117393#issue-comment-box
markshannonhttps://github.com/markshannon
python:mainhttps://github.com/python/cpython/tree/main
gaogaotiantian:remove-instrumentation-redundancyhttps://github.com/gaogaotiantian/cpython/tree/remove-instrumentation-redundancy
gh-107674: Remove some unnecessary code in instrumentation code https://github.com/python/cpython/pull/117393#top
markshannonhttps://github.com/markshannon
python:mainhttps://github.com/python/cpython/tree/main
gaogaotiantian:remove-instrumentation-redundancyhttps://github.com/gaogaotiantian/cpython/tree/remove-instrumentation-redundancy
Conversation 8 https://github.com/python/cpython/pull/117393
Commits 2 https://github.com/python/cpython/pull/117393/commits
Checks 0 https://github.com/python/cpython/pull/117393/checks
Files changed https://github.com/python/cpython/pull/117393/files
Please reload this pagehttps://github.com/python/cpython/pull/117393
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/gaogaotiantian
gaogaotiantianhttps://github.com/gaogaotiantian
Mar 30, 2024https://github.com/python/cpython/pull/117393#issue-2216628166
Please reload this pagehttps://github.com/python/cpython/pull/117393
sys.settrace dramatic slowdown in 3.12 #107674https://github.com/python/cpython/issues/107674
Please reload this pagehttps://github.com/python/cpython/pull/117393
https://github.com/gaogaotiantian
Remove some unnecessary code in instrumentation codehttps://github.com/python/cpython/pull/117393/commits/f3fab465c5dccf6e262391a287820ebf7230edc0
f3fab46https://github.com/python/cpython/pull/117393/commits/f3fab465c5dccf6e262391a287820ebf7230edc0
https://github.com/gaogaotiantian
gaogaotiantianhttps://github.com/gaogaotiantian
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Mar 30, 2024https://github.com/python/cpython/pull/117393#event-12301473971
https://github.com/gaogaotiantian
gaogaotiantianhttps://github.com/gaogaotiantian
markshannonhttps://github.com/markshannon
March 30, 2024 19:03https://github.com/python/cpython/pull/117393#event-12301473976
https://github.com/gaogaotiantian
gaogaotiantianhttps://github.com/gaogaotiantian
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
code ownerhttps://github.com/python/cpython/blob/bfc57d43d8766120ba0c8f3f6d7b2ac681a81d8a/.github/CODEOWNERS#L56
March 30, 2024 19:03https://github.com/python/cpython/pull/117393#event-12301474014
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Mar 30, 2024https://github.com/python/cpython/pull/117393#event-12301474205
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Mar 30, 2024 https://github.com/python/cpython/pull/117393#ref-issue-1837956644
sys.settrace dramatic slowdown in 3.12 #107674 https://github.com/python/cpython/issues/107674
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Apr 1, 2024 https://github.com/python/cpython/pull/117393#ref-issue-2218701924
Remove Incref/Decref of Specific Immortal Objects #117425 https://github.com/python/cpython/issues/117425
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Apr 1, 2024 https://github.com/python/cpython/pull/117393#pullrequestreview-1971710220
View reviewed changes https://github.com/python/cpython/pull/117393/files/f3fab465c5dccf6e262391a287820ebf7230edc0
Python/sysmodule.chttps://github.com/python/cpython/pull/117393/files/f3fab465c5dccf6e262391a287820ebf7230edc0#diff-a3a5c73931235f7f344c072dc755d6508e13923db3f5d581c5e88652075871cb
Please reload this pagehttps://github.com/python/cpython/pull/117393
Python/instrumentation.chttps://github.com/python/cpython/pull/117393/files/f3fab465c5dccf6e262391a287820ebf7230edc0#diff-adaefb7da847260ef7aff6e66007bc83f5b226c5389a23e1c9ea622c3b02c419
Please reload this pagehttps://github.com/python/cpython/pull/117393
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting changes https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Apr 1, 2024https://github.com/python/cpython/pull/117393#event-12313492965
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Apr 1, 2024https://github.com/python/cpython/pull/117393#issuecomment-2030202016
Please reload this pagehttps://github.com/python/cpython/pull/117393
https://github.com/gaogaotiantian
Revert removing Py_DECREF for Nonehttps://github.com/python/cpython/pull/117393/commits/8d5db73ceefa4040b11c2d04884c55c044227979
8d5db73https://github.com/python/cpython/pull/117393/commits/8d5db73ceefa4040b11c2d04884c55c044227979
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Apr 2, 2024 https://github.com/python/cpython/pull/117393#pullrequestreview-1974116195
View reviewed changes https://github.com/python/cpython/pull/117393/files/8d5db73ceefa4040b11c2d04884c55c044227979
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
https://github.com/python/cpython/pull/117393#pullrequestreview-1974116195
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
gh-107674https://github.com/python/cpython/issues/107674
Please reload this pagehttps://github.com/python/cpython/pull/117393
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting changes https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22
Apr 2, 2024https://github.com/python/cpython/pull/117393#event-12327542143
https://github.com/gaogaotiantian
gaogaotiantianhttps://github.com/gaogaotiantian
Apr 2, 2024https://github.com/python/cpython/pull/117393#issuecomment-2032685421
Please reload this pagehttps://github.com/python/cpython/pull/117393
https://github.com/gaogaotiantian
gaogaotiantianhttps://github.com/gaogaotiantian
Apr 8, 2024https://github.com/python/cpython/pull/117393#issuecomment-2043796925
@markshannonhttps://github.com/markshannon
Please reload this pagehttps://github.com/python/cpython/pull/117393
https://github.com/markshannon
markshannonhttps://github.com/markshannon
5718324https://github.com/python/cpython/commit/57183241af76bf33e44d886a733f799d20fc680c
Apr 9, 2024https://github.com/python/cpython/pull/117393#event-12403394336
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Apr 9, 2024https://github.com/python/cpython/pull/117393#event-12403395017
diegorussohttps://github.com/diegorusso
Apr 17, 2024 https://github.com/python/cpython/pull/117393#ref-commit-49fec3a
https://github.com/gaogaotiantian
https://github.com/diegorusso
pythongh-107674https://github.com/python/cpython/issues/107674
: Remove some unnecessary code in instrumentation code (https://github.com/diegorusso/cpython/commit/49fec3ada82d2c17b1ee80548d7183b4ec711ca1
…https://github.com/python/cpython/pull/117393
49fec3ahttps://github.com/diegorusso/cpython/commit/49fec3ada82d2c17b1ee80548d7183b4ec711ca1
…pythonGH-117393https://github.com/python/cpython/pull/117393
https://github.com/gaogaotiantian
gaogaotiantianhttps://github.com/gaogaotiantian
May 3, 2024 18:59https://github.com/python/cpython/pull/117393#event-12700019505
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F117393
https://github.com/ericsnowcurrently
ericsnowcurrently https://github.com/ericsnowcurrently
https://github.com/python/cpython/pull/117393/files/8d5db73ceefa4040b11c2d04884c55c044227979
https://github.com/markshannon
markshannon https://github.com/markshannon
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/117393
https://github.com/gaogaotiantian
https://github.com/ericsnowcurrently
https://github.com/markshannon
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.