| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:49dfde59-9e9b-db29-1929-ce0f40ef537f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BE4A:E0ADF:14CF9AA:1A444D2:6B02119B |
| html-safe-nonce | 26ac959c41925b9c7f329e956f9b90b2e9867ef1ca8f9c79f7ed3b0a7525ef89 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRTRBOkUwQURGOjE0Q0Y5QUE6MUE0NDREMjo2QjAyMTE5QiIsInZpc2l0b3JfaWQiOiI2MDkzNDM0NDAwMDE0NDcxNTc5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | b6f02bd380bdfef698161469b4dba9cd833be1d95fb03a865c6e3a4dfe0fb423 |
| hovercard-subject-tag | pull_request:1798220960 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/117372/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/88759aebb751c9ed85becec01ae47700a3bdb36d7102a49ca55ad96c97cf2a45/python/cpython/pull/117372 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/88759aebb751c9ed85becec01ae47700a3bdb36d7102a49ca55ad96c97cf2a45/python/cpython/pull/117372 |
| og:image:alt | Extract method for _read_inner, reducing complexity and indentation by 1.
Extract method for _raise_all and yield ParseErrors from _read_inner.
Prefer iterators to splat expansion and literal index... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jaraco |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/cpython/pull/117372#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F117372 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F117372 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/117372 |
| Reload | https://github.com/python/cpython/pull/117372 |
| Reload | https://github.com/python/cpython/pull/117372 |
| python | https://github.com/python |
| cpython | https://github.com/python/cpython |
| Code | https://github.com/python/cpython |
| Issues5k+ (5k+) | https://github.com/python/cpython/issues |
| Pull requests2.4k (2.4k) | https://github.com/python/cpython/pulls |
| Actions | https://github.com/python/cpython/actions |
| Projects | https://github.com/python/cpython/projects |
| Security and quality | https://github.com/python/cpython/security |
| Insights | https://github.com/python/cpython/insights |
| https://github.com/python/cpython |
| jaraco | https://github.com/jaraco |
| python:main | https://github.com/python/cpython/tree/main |
| jaraco:feature/refactor-configparser-read-complexity | https://github.com/jaraco/cpython/tree/feature/refactor-configparser-read-complexity |
| Conversation | https://github.com/python/cpython/pull/117372 |
| Commits23 (23) | https://github.com/python/cpython/pull/117372/commits |
| Checks | https://github.com/python/cpython/pull/117372/checks |
| Files changed | https://github.com/python/cpython/pull/117372/files |
| gh-117348: Refactored RawConfigParser._read for simplicity and comprehensibility | https://github.com/python/cpython/pull/117372#top |
| jaraco | https://github.com/jaraco |
| python:main | https://github.com/python/cpython/tree/main |
| jaraco:feature/refactor-configparser-read-complexity | https://github.com/jaraco/cpython/tree/feature/refactor-configparser-read-complexity |
|
| https://github.com/jaraco |
| jaraco | https://github.com/jaraco |
| Mar 29, 2024 | https://github.com/python/cpython/pull/117372#issue-2215631156 |
| Please reload this page | https://github.com/python/cpython/pull/117372 |
| configparser.RawConfigParser._read is unmanageably complex #117348 | https://github.com/python/cpython/issues/117348 |
| Please reload this page | https://github.com/python/cpython/pull/117372 |
| jaraco | https://github.com/jaraco |
| March 29, 2024 12:05 | https://github.com/python/cpython/pull/117372#commits-pushed-a25ac00 |
|
| https://github.com/jaraco |
| Extract method for _read_inner, reducing complexity and indentation b… | https://github.com/python/cpython/pull/117372/commits/a25ac002617c9756cd0f4ff8f0d0692134006592 |
| a25ac00 | https://github.com/python/cpython/pull/117372/commits/a25ac002617c9756cd0f4ff8f0d0692134006592 |
|
| https://github.com/jaraco |
| Extract method for _raise_all and yield ParseErrors from _read_inner. | https://github.com/python/cpython/pull/117372/commits/1e69aaecf0ae53540b798b698ee2ca7a7a243aab |
| 1e69aae | https://github.com/python/cpython/pull/117372/commits/1e69aaecf0ae53540b798b698ee2ca7a7a243aab |
|
| https://github.com/jaraco |
| Prefer iterators to splat expansion and literal indexing. | https://github.com/python/cpython/pull/117372/commits/8c4778136e1f119b864838772986b2ea3252ec43 |
| 8c47781 | https://github.com/python/cpython/pull/117372/commits/8c4778136e1f119b864838772986b2ea3252ec43 |
|
| https://github.com/jaraco |
| Extract method for _strip_comments. Reduces complexity by 7. | https://github.com/python/cpython/pull/117372/commits/74798147d91270f8b084b4eadce18462e3ec871c |
| 7479814 | https://github.com/python/cpython/pull/117372/commits/74798147d91270f8b084b4eadce18462e3ec871c |
|
| https://github.com/jaraco |
| Model the file lines in a class to encapsulate the comment status and… | https://github.com/python/cpython/pull/117372/commits/a2fffee5d8d4b5122f0671acd7101743ba99c048 |
| a2fffee | https://github.com/python/cpython/pull/117372/commits/a2fffee5d8d4b5122f0671acd7101743ba99c048 |
|
| https://github.com/jaraco |
| Encapsulate the read state as a dataclass | https://github.com/python/cpython/pull/117372/commits/23468cbaac87924417af3bce3f608289696a0bef |
| 23468cb | https://github.com/python/cpython/pull/117372/commits/23468cbaac87924417af3bce3f608289696a0bef |
|
| https://github.com/jaraco |
| Extract _handle_continuation_line and _handle_rest methods. Reduces c… | https://github.com/python/cpython/pull/117372/commits/3d1ef0a7b05c9c05c75942e01f99a9feaf27e70f |
| 3d1ef0a | https://github.com/python/cpython/pull/117372/commits/3d1ef0a7b05c9c05c75942e01f99a9feaf27e70f |
|
| https://github.com/jaraco |
| Reindent | https://github.com/python/cpython/pull/117372/commits/071baeb766e90a4d3e43ceed8ed1580e34e5eb0a |
| 071baeb | https://github.com/python/cpython/pull/117372/commits/071baeb766e90a4d3e43ceed8ed1580e34e5eb0a |
|
| https://github.com/jaraco |
| At least for now, collect errors in the ReadState | https://github.com/python/cpython/pull/117372/commits/81f4ce2a52026656bbca67e86415dd19f81be8d9 |
| 81f4ce2 | https://github.com/python/cpython/pull/117372/commits/81f4ce2a52026656bbca67e86415dd19f81be8d9 |
|
| https://github.com/jaraco |
| Check for missing section header separately. | https://github.com/python/cpython/pull/117372/commits/8942cc1522b5835e36df5a1cd04f7243b3b40de7 |
| 8942cc1 | https://github.com/python/cpython/pull/117372/commits/8942cc1522b5835e36df5a1cd04f7243b3b40de7 |
|
| https://github.com/jaraco |
| Extract methods for _handle_header and _handle_option. Reduces comple… | https://github.com/python/cpython/pull/117372/commits/1e72168d04d9d35c0b1e5a64496fab64de329e07 |
| 1e72168 | https://github.com/python/cpython/pull/117372/commits/1e72168d04d9d35c0b1e5a64496fab64de329e07 |
|
| https://github.com/jaraco |
| Remove unreachable code. Reduces complexity by 4. | https://github.com/python/cpython/pull/117372/commits/0dfd797486420506be9ec92db15f8f001b237414 |
| 0dfd797 | https://github.com/python/cpython/pull/117372/commits/0dfd797486420506be9ec92db15f8f001b237414 |
|
| https://github.com/jaraco |
| Remove unreachable branch | https://github.com/python/cpython/pull/117372/commits/77ed897299011cc7a288ba91caa6f7e97f80b2fb |
| 77ed897 | https://github.com/python/cpython/pull/117372/commits/77ed897299011cc7a288ba91caa6f7e97f80b2fb |
|
| https://github.com/jaraco |
| Handle error condition early. Reduces complexity by 1. | https://github.com/python/cpython/pull/117372/commits/76f42d3d856db5d5c0230b9d3ca47885608692af |
| 76f42d3 | https://github.com/python/cpython/pull/117372/commits/76f42d3d856db5d5c0230b9d3ca47885608692af |
|
| https://github.com/jaraco |
| Add blurb | https://github.com/python/cpython/pull/117372/commits/c18a2bb75844e132b35ab9560d5c6a38bdd8033f |
| c18a2bb | https://github.com/python/cpython/pull/117372/commits/c18a2bb75844e132b35ab9560d5c6a38bdd8033f |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Mar 29, 2024 | https://github.com/python/cpython/pull/117372#event-12296367643 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
Mar 29, 2024
| https://github.com/python/cpython/pull/117372#ref-issue-2214114012 |
|
configparser.RawConfigParser._read is unmanageably complex
#117348
| https://github.com/python/cpython/issues/117348 |
| https://github.com/jaraco |
| jaraco | https://github.com/jaraco |
| Mar 29, 2024 | https://github.com/python/cpython/pull/117372#issuecomment-2027445367 |
| Please reload this page | https://github.com/python/cpython/pull/117372 |
| jaraco | https://github.com/jaraco |
| March 29, 2024 12:27 | https://github.com/python/cpython/pull/117372#commits-pushed-97aa785 |
|
| https://github.com/jaraco |
| Move _raise_all to ParsingError, as its behavior is most closely rela… | https://github.com/python/cpython/pull/117372/commits/97aa785854da308047bd3026b59ee2fea73cbbac |
| 97aa785 | https://github.com/python/cpython/pull/117372/commits/97aa785854da308047bd3026b59ee2fea73cbbac |
|
| https://github.com/jaraco |
| Split _strip* into separate methods. | https://github.com/python/cpython/pull/117372/commits/d310cb404a0e9f3b5b0270f1008ca510ab8065db |
| d310cb4 | https://github.com/python/cpython/pull/117372/commits/d310cb404a0e9f3b5b0270f1008ca510ab8065db |
|
| https://github.com/jaraco |
| Refactor _strip_full to compute the strip just once and use 'not any'… | https://github.com/python/cpython/pull/117372/commits/f2a355cd7cf45099133ab8b292b04a757466ba1b |
| f2a355c | https://github.com/python/cpython/pull/117372/commits/f2a355cd7cf45099133ab8b292b04a757466ba1b |
|
| https://github.com/jaraco |
| Replace use of 'sys.maxsize' with direct computation of the stripped … | https://github.com/python/cpython/pull/117372/commits/249261416824eec48d70ae45103263f223d46eae |
| 2492614 | https://github.com/python/cpython/pull/117372/commits/249261416824eec48d70ae45103263f223d46eae |
|
| https://github.com/jaraco |
| Extract has_comments as a dynamic property. | https://github.com/python/cpython/pull/117372/commits/496859151f009d6c3cbf38ece82524291048fc12 |
| 4968591 | https://github.com/python/cpython/pull/117372/commits/496859151f009d6c3cbf38ece82524291048fc12 |
|
| https://github.com/jaraco |
| Implement clean as a cached property. | https://github.com/python/cpython/pull/117372/commits/7d807bba8cc70a926af16261abdf50e98be6a94f |
| 7d807bb | https://github.com/python/cpython/pull/117372/commits/7d807bba8cc70a926af16261abdf50e98be6a94f |
|
| https://github.com/jaraco |
| Model comment prefixes in the RawConfigParser within a prefixes names… | https://github.com/python/cpython/pull/117372/commits/29cb20f225216bc221e7b396eea1526157d83139 |
| 29cb20f | https://github.com/python/cpython/pull/117372/commits/29cb20f225216bc221e7b396eea1526157d83139 |
|
| https://github.com/jaraco |
| Use a regular expression to search for the first match. | https://github.com/python/cpython/pull/117372/commits/c834c356f72d07e03ad8ece49f72ebb4ee8759b4 |
| c834c35 | https://github.com/python/cpython/pull/117372/commits/c834c356f72d07e03ad8ece49f72ebb4ee8759b4 |
| https://github.com/jaraco |
| jaraco | https://github.com/jaraco |
| 019143f | https://github.com/python/cpython/commit/019143fecbfc26e69800d28d2a9e3392a051780b |
| Mar 29, 2024 | https://github.com/python/cpython/pull/117372#event-12298080895 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Mar 29, 2024 | https://github.com/python/cpython/pull/117372#event-12298081167 |
| https://github.com/jaraco |
| jaraco | https://github.com/jaraco |
| March 29, 2024 20:06 | https://github.com/python/cpython/pull/117372#event-12298081602 |
| https://github.com/erlend-aasland |
| erlend-aasland | https://github.com/erlend-aasland |
| Mar 29, 2024 | https://github.com/python/cpython/pull/117372#issuecomment-2027732469 |
| Please reload this page | https://github.com/python/cpython/pull/117372 |
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
| Apr 1, 2024 | https://github.com/python/cpython/pull/117372#issuecomment-2029565336 |
| Please reload this page | https://github.com/python/cpython/pull/117372 |
| NGRsoftlab | https://github.com/NGRsoftlab |
|
Apr 2, 2024
| https://github.com/python/cpython/pull/117372#ref-commit-1b5fe4c |
|
| https://github.com/ngr-ilmarh |
| Squashed commit of the following: | https://github.com/NGRsoftlab/cpython/commit/1b5fe4cad096e32efee3a0477ef6f277ec2a2b96 |
| 1b5fe4c | https://github.com/NGRsoftlab/cpython/commit/1b5fe4cad096e32efee3a0477ef6f277ec2a2b96 |
| NGRsoftlab | https://github.com/NGRsoftlab |
|
Apr 2, 2024
| https://github.com/python/cpython/pull/117372#ref-commit-a016a54 |
|
| https://github.com/ngr-ilmarh |
| Squashed commit of the following: | https://github.com/NGRsoftlab/cpython/commit/a016a5413a6d8bd02939a6fb9afef90dbbb2fb54 |
| a016a54 | https://github.com/NGRsoftlab/cpython/commit/a016a5413a6d8bd02939a6fb9afef90dbbb2fb54 |
| https://github.com/jaraco |
| jaraco | https://github.com/jaraco |
| Apr 9, 2024 | https://github.com/python/cpython/pull/117372#issuecomment-2046185253 |
| Please reload this page | https://github.com/python/cpython/pull/117372 |
| Please reload this page | https://github.com/python/cpython/pull/117372 |
| https://github.com/jaraco |
| jaraco | https://github.com/jaraco |
|
Apr 10, 2024
| https://github.com/python/cpython/pull/117372#ref-pullrequest-2234513891 |
|
gh-117348: restore import time performance of configparser
#117703
| https://github.com/python/cpython/pull/117703 |
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
| Apr 10, 2024 | https://github.com/python/cpython/pull/117372#event-12418833501 |
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
| Apr 10, 2024 | https://github.com/python/cpython/pull/117372#issuecomment-2047024740 |
| Please reload this page | https://github.com/python/cpython/pull/117372 |
| https://github.com/jaraco |
| jaraco | https://github.com/jaraco |
|
Apr 14, 2024
| https://github.com/python/cpython/pull/117372#ref-issue-2242086904 |
|
Inspect module is prohibitively expensive to import
#117865
| https://github.com/python/cpython/issues/117865 |
| diegorusso | https://github.com/diegorusso |
|
Apr 17, 2024
| https://github.com/python/cpython/pull/117372#ref-commit-90d0eeb |
|
| https://github.com/jaraco |
|
| https://github.com/diegorusso |
| pythongh-117348 | https://github.com/python/cpython/issues/117348 |
| : Refactored RawConfigParser._read for similicity and … | https://github.com/diegorusso/cpython/commit/90d0eebce09a4fd219ee9db72d0c665e5ea70922 |
| 90d0eeb | https://github.com/diegorusso/cpython/commit/90d0eebce09a4fd219ee9db72d0c665e5ea70922 |
| python#117372 | https://github.com/python/cpython/pull/117372 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F117372 |
| Please reload this page | https://github.com/python/cpython/pull/117372 |
| Please reload this page | https://github.com/python/cpython/pull/117372 |
|
| https://github.com/jaraco |
|
| https://github.com/erlend-aasland |
|
| https://github.com/AlexWaygood |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |