René's URL Explorer Experiment


Title: gh-117335: Handle non-iterables for `ntpath.commonpath` by nineteendo · Pull Request #117336 · python/cpython · GitHub

Open Graph Title: gh-117335: Handle non-iterables for `ntpath.commonpath` by nineteendo · Pull Request #117336 · python/cpython

X Title: gh-117335: Handle non-iterables for `ntpath.commonpath` by nineteendo · Pull Request #117336 · python/cpython

Description: Issue: Handle non-iterables for ntpath.commonpath #117335

Open Graph Description: Issue: Handle non-iterables for ntpath.commonpath #117335

X Description: Issue: Handle non-iterables for ntpath.commonpath #117335

Opengraph URL: https://github.com/python/cpython/pull/117336

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d09023ec-fdb7-a717-5404-7c94f800cb95
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA804:6222A:13B031:19C170:696B2FC3
html-safe-nonce1fb2fa53cf15ed45c6687e2f2d12fcaf0f93336d3402b532451ff93fa753d69c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBODA0OjYyMjJBOjEzQjAzMToxOUMxNzA6Njk2QjJGQzMiLCJ2aXNpdG9yX2lkIjoiMjczNjczODY4MDE1MDExMDE0NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca2125fc24a14f304b2fef19bf5dbef72830b84add9f578f455c9c6ed0db21405
hovercard-subject-tagpull_request:1796713849
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/117336/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d1a97952ce7732e608b854fe47f6c8158c30b6c9de3dd9fd5b3c1d83a34af184/python/cpython/pull/117336
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d1a97952ce7732e608b854fe47f6c8158c30b6c9de3dd9fd5b3c1d83a34af184/python/cpython/pull/117336
og:image:altIssue: Handle non-iterables for ntpath.commonpath #117335
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamenineteendo
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/117336#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F117336
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F117336
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/117336
Reloadhttps://github.com/python/cpython/pull/117336
Reloadhttps://github.com/python/cpython/pull/117336
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/117336
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/117336
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/117336#issue-comment-box
serhiy-storchakahttps://github.com/serhiy-storchaka
python:mainhttps://github.com/python/cpython/tree/main
nineteendo:fix-ntpath.commonpathhttps://github.com/nineteendo/cpython/tree/fix-ntpath.commonpath
gh-117335: Handle non-iterables for ntpath.commonpath https://github.com/python/cpython/pull/117336#top
serhiy-storchakahttps://github.com/serhiy-storchaka
python:mainhttps://github.com/python/cpython/tree/main
nineteendo:fix-ntpath.commonpathhttps://github.com/nineteendo/cpython/tree/fix-ntpath.commonpath
Conversation 10 https://github.com/python/cpython/pull/117336
Commits 4 https://github.com/python/cpython/pull/117336/commits
Checks 0 https://github.com/python/cpython/pull/117336/checks
Files changed 3 https://github.com/python/cpython/pull/117336/files
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/nineteendo
nineteendohttps://github.com/nineteendo
Mar 28, 2024https://github.com/python/cpython/pull/117336#issue-2213942651
Please reload this pagehttps://github.com/python/cpython/pull/117336
Handle non-iterables for ntpath.commonpath #117335https://github.com/python/cpython/issues/117335
Please reload this pagehttps://github.com/python/cpython/pull/117336
https://github.com/nineteendo
Handle non-iterables for ntpath.commonpathhttps://github.com/python/cpython/pull/117336/commits/a451699ce6605b422b4c0af65c1b2f78f968622c
a451699https://github.com/python/cpython/pull/117336/commits/a451699ce6605b422b4c0af65c1b2f78f968622c
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Mar 28, 2024 https://github.com/python/cpython/pull/117336#ref-issue-2213931468
Handle non-iterables for ntpath.commonpath #117335 https://github.com/python/cpython/issues/117335
https://github.com/apps/blurb-it
📜🤖 Added by blurb_it.https://github.com/python/cpython/pull/117336/commits/921816a1c30b0c1ac6388e1a9dff39a6b883f134
921816ahttps://github.com/python/cpython/pull/117336/commits/921816a1c30b0c1ac6388e1a9dff39a6b883f134
https://github.com/nineteendo
nineteendohttps://github.com/nineteendo
March 28, 2024 19:14https://github.com/python/cpython/pull/117336#event-12286359414
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Mar 28, 2024https://github.com/python/cpython/pull/117336#event-12286360000
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Mar 28, 2024 https://github.com/python/cpython/pull/117336#pullrequestreview-1967112702
View reviewed changes https://github.com/python/cpython/pull/117336/files/921816a1c30b0c1ac6388e1a9dff39a6b883f134
serhiy-storchakahttps://github.com/serhiy-storchaka
https://github.com/python/cpython/pull/117336#pullrequestreview-1967112702
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/117336
https://github.com/nineteendo
nineteendohttps://github.com/nineteendo
Mar 28, 2024https://github.com/python/cpython/pull/117336#issuecomment-2025976485
Please reload this pagehttps://github.com/python/cpython/pull/117336
https://github.com/nineteendo
nineteendohttps://github.com/nineteendo
Mar 28, 2024 https://github.com/python/cpython/pull/117336#ref-pullrequest-2204553481
gh-117201: Handle leading // for posixpath.commonpath #117202 https://github.com/python/cpython/pull/117202
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Mar 28, 2024https://github.com/python/cpython/pull/117336#issuecomment-2026023290
Please reload this pagehttps://github.com/python/cpython/pull/117336
https://github.com/nineteendo
nineteendohttps://github.com/nineteendo
Mar 28, 2024https://github.com/python/cpython/pull/117336#issuecomment-2026034627
Please reload this pagehttps://github.com/python/cpython/pull/117336
Please reload this pagehttps://github.com/python/cpython/pull/117336
https://github.com/nineteendo
Revert unnecessary changeshttps://github.com/python/cpython/pull/117336/commits/7f6902948acb09e25f144ff5ebf2d49d7cd75cc7
7f69029https://github.com/python/cpython/pull/117336/commits/7f6902948acb09e25f144ff5ebf2d49d7cd75cc7
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Mar 28, 2024https://github.com/python/cpython/pull/117336#issuecomment-2026061945
Please reload this pagehttps://github.com/python/cpython/pull/117336
https://github.com/nineteendo
nineteendohttps://github.com/nineteendo
Mar 28, 2024https://github.com/python/cpython/pull/117336#issuecomment-2026062639
Please reload this pagehttps://github.com/python/cpython/pull/117336
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Mar 28, 2024https://github.com/python/cpython/pull/117336#issuecomment-2026072122
Please reload this pagehttps://github.com/python/cpython/pull/117336
https://github.com/nineteendo
Revert all refactoringhttps://github.com/python/cpython/pull/117336/commits/331ceb479d89ed3057cb6caaccb9c52b04e3a6c8
331ceb4https://github.com/python/cpython/pull/117336/commits/331ceb479d89ed3057cb6caaccb9c52b04e3a6c8
https://github.com/nineteendo
nineteendohttps://github.com/nineteendo
Mar 28, 2024https://github.com/python/cpython/pull/117336#issuecomment-2026082415
Please reload this pagehttps://github.com/python/cpython/pull/117336
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Mar 28, 2024 https://github.com/python/cpython/pull/117336#pullrequestreview-1967298902
View reviewed changes https://github.com/python/cpython/pull/117336/files/331ceb479d89ed3057cb6caaccb9c52b04e3a6c8
serhiy-storchakahttps://github.com/serhiy-storchaka
https://github.com/python/cpython/pull/117336#pullrequestreview-1967298902
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/117336
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Mar 28, 2024https://github.com/python/cpython/pull/117336#event-12287541943
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
March 28, 2024 21:01https://github.com/python/cpython/pull/117336#event-12287547209
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
14f1ca7https://github.com/python/cpython/commit/14f1ca7d5363386163839b31ce987423daecc3de
Mar 28, 2024https://github.com/python/cpython/pull/117336#event-12287754129
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Mar 28, 2024https://github.com/python/cpython/pull/117336#event-12287754849
https://github.com/nineteendo
nineteendohttps://github.com/nineteendo
March 28, 2024 21:20https://github.com/python/cpython/pull/117336#event-12287758217
https://github.com/nineteendo
nineteendohttps://github.com/nineteendo
Mar 29, 2024 https://github.com/python/cpython/pull/117336#ref-issue-2214806134
Improve os #117361 https://github.com/python/cpython/issues/117361
NGRsoftlabhttps://github.com/NGRsoftlab
Apr 2, 2024 https://github.com/python/cpython/pull/117336#ref-commit-1b5fe4c
https://github.com/ngr-ilmarh
Squashed commit of the following:https://github.com/NGRsoftlab/cpython/commit/1b5fe4cad096e32efee3a0477ef6f277ec2a2b96
1b5fe4chttps://github.com/NGRsoftlab/cpython/commit/1b5fe4cad096e32efee3a0477ef6f277ec2a2b96
NGRsoftlabhttps://github.com/NGRsoftlab
Apr 2, 2024 https://github.com/python/cpython/pull/117336#ref-commit-a016a54
https://github.com/ngr-ilmarh
Squashed commit of the following:https://github.com/NGRsoftlab/cpython/commit/a016a5413a6d8bd02939a6fb9afef90dbbb2fb54
a016a54https://github.com/NGRsoftlab/cpython/commit/a016a5413a6d8bd02939a6fb9afef90dbbb2fb54
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Apr 3, 2024https://github.com/python/cpython/pull/117336#issuecomment-2035440721
@nineteendohttps://github.com/nineteendo
https://devguide.python.org/getting-started/pull-request-lifecycle/https://devguide.python.org/getting-started/pull-request-lifecycle/
Please reload this pagehttps://github.com/python/cpython/pull/117336
diegorussohttps://github.com/diegorusso
Apr 17, 2024 https://github.com/python/cpython/pull/117336#ref-commit-83da831
https://github.com/nineteendo
https://github.com/diegorusso
pythongh-117335https://github.com/python/cpython/issues/117335
: Handle non-iterables forhttps://github.com/diegorusso/cpython/commit/83da8312aa0e4d5a33738f4c805d1b55606327a6
ntpath.commonpathhttps://github.com/diegorusso/cpython/commit/83da8312aa0e4d5a33738f4c805d1b55606327a6
(https://github.com/diegorusso/cpython/commit/83da8312aa0e4d5a33738f4c805d1b55606327a6
python…https://github.com/python/cpython/pull/117336
83da831https://github.com/diegorusso/cpython/commit/83da8312aa0e4d5a33738f4c805d1b55606327a6
…GH-117336https://github.com/python/cpython/pull/117336
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F117336
https://github.com/serhiy-storchaka
serhiy-storchaka https://github.com/serhiy-storchaka
https://github.com/python/cpython/pull/117336/files/331ceb479d89ed3057cb6caaccb9c52b04e3a6c8
Please reload this pagehttps://github.com/python/cpython/pull/117336
https://github.com/nineteendo
https://github.com/serhiy-storchaka
https://github.com/erlend-aasland
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.