Title: gh-99108: Refresh HACL*; update modules accordingly; fix namespacing by msprotz · Pull Request #117237 · python/cpython · GitHub
Open Graph Title: gh-99108: Refresh HACL*; update modules accordingly; fix namespacing by msprotz · Pull Request #117237 · python/cpython
X Title: gh-99108: Refresh HACL*; update modules accordingly; fix namespacing by msprotz · Pull Request #117237 · python/cpython
Description: This refreshes the bundled copy of HACL* with the latest upstream. This is pulling from the latest main. Upstream HACL* improvements contained in this PR: C code quality improvement: remove a majority of the integer casts API improvement: consistent naming of all hash APIs and parameter names, removing jargon ("finish", "create_in") in favor of useful names ("digest", "malloc"), and align all APIs to be of the form Hacl_Hash_XXX In addition, this PR contains: a small fix to the "refresh" script: it turns out the python namespacing strategy (to avoid static linking conflicts) was only being applied to one of the HACL modules; it now applies uniformly to all modules, and I added a comment to that effect to make sure the namespacing mechanism is effective corresponding changes in Modules/ to use the new function names from the improved API I would like to start the Blake2 discussion with a corresponding PR soon, so this is a prerequisite before opening the topic of Blake2 -- we finally found time to implement all the APIs needed by Python, so we should be able to hook CPython to HACL*'s Blake2. CC @gpshead for review. Thanks! Issue: gh-99108
Open Graph Description: This refreshes the bundled copy of HACL* with the latest upstream. This is pulling from the latest main. Upstream HACL* improvements contained in this PR: C code quality improvement: remove a majo...
X Description: This refreshes the bundled copy of HACL* with the latest upstream. This is pulling from the latest main. Upstream HACL* improvements contained in this PR: C code quality improvement: remove a majo...
Opengraph URL: https://github.com/python/cpython/pull/117237
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:0a353868-cc99-8110-24fd-1d82c5774422 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9A18:9F9DA:1B1D42A:254FC57:696AAA31 |
| html-safe-nonce | 0ad1175a322734ab489704b5f5f54ebc10aca76c1f5c151bd29f583b4250ef07 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QTE4OjlGOURBOjFCMUQ0MkE6MjU0RkM1Nzo2OTZBQUEzMSIsInZpc2l0b3JfaWQiOiI0NjExMTU2ODExNTA1NjQyMDMzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | a2bc128659aa34a6c3c821aa085ab55102be08e7606cd438617677fa369f8bb2 |
| hovercard-subject-tag | pull_request:1790379781 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/117237/files |
| twitter:image | https://avatars.githubusercontent.com/u/10673049?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/10673049?s=400&v=4 |
| og:image:alt | This refreshes the bundled copy of HACL* with the latest upstream. This is pulling from the latest main. Upstream HACL* improvements contained in this PR: C code quality improvement: remove a majo... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3eaf9b8cf1badcd7041a8ad480b9d9b28bea0ef1cc821ca9ff20f2cc7f4fe4b9 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | dd9a979046e6382bd084e2bd873bf65f797125ff |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width