René's URL Explorer Experiment


Title: gh-117182: Allow lazily loaded modules to modify their own __class__ by effigies · Pull Request #117185 · python/cpython · GitHub

Open Graph Title: gh-117182: Allow lazily loaded modules to modify their own __class__ by effigies · Pull Request #117185 · python/cpython

X Title: gh-117182: Allow lazily loaded modules to modify their own __class__ by effigies · Pull Request #117185 · python/cpython

Description: This PR resolves #117182. The meat of the PR is to check whether the module modified its own __class__ during load, and only set the default class if not. I also realized that the LazyLoader saves ...

Open Graph Description: This PR resolves #117182. The meat of the PR is to check whether the module modified its own __class__ during load, and only set the default class if not. I also realized that the LazyLoader saves ...

X Description: This PR resolves #117182. The meat of the PR is to check whether the module modified its own __class__ during load, and only set the default class if not. I also realized that the LazyLoader saves ...

Opengraph URL: https://github.com/python/cpython/pull/117185

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:24ce119e-ffe6-4ccf-e55a-05d4bb921f95
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9B7E:37314B:1EBFC7E:28DA899:696EE993
html-safe-nonce312a6e254fc1bf9733452b882c8478783eb6cb03f576c52b32b02b4319657d97
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QjdFOjM3MzE0QjoxRUJGQzdFOjI4REE4OTk6Njk2RUU5OTMiLCJ2aXNpdG9yX2lkIjoiNTEzODE2NjI1MDk2MTAzNzcxNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac47c3c5f77c0364cf2671914e63bc18a9213c1e87a36486e9b6689349e454da93
hovercard-subject-tagpull_request:1787863199
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/117185/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e2be190c22cdae0ab5c380e2064559f13c1b1a05e2e38d94b2c2d4ca9f9c7e6a/python/cpython/pull/117185
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e2be190c22cdae0ab5c380e2064559f13c1b1a05e2e38d94b2c2d4ca9f9c7e6a/python/cpython/pull/117185
og:image:altThis PR resolves #117182. The meat of the PR is to check whether the module modified its own __class__ during load, and only set the default class if not. I also realized that the LazyLoader saves ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameeffigies
hostnamegithub.com
expected-hostnamegithub.com
Noneb278ad162d35332b6de714dfb005de04386c4d92df6475522bef910f491a35ee
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release39aed5006635ab6f45e6b77d23e73b08a00272a3
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/117185#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F117185
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F117185
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/117185
Reloadhttps://github.com/python/cpython/pull/117185
Reloadhttps://github.com/python/cpython/pull/117185
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/117185
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/117185
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/117185#issue-comment-box
FFY00https://github.com/FFY00
python:mainhttps://github.com/python/cpython/tree/main
effigies:fix-issue-117182https://github.com/effigies/cpython/tree/fix-issue-117182
gh-117182: Allow lazily loaded modules to modify their own __class__ https://github.com/python/cpython/pull/117185#top
FFY00https://github.com/FFY00
python:mainhttps://github.com/python/cpython/tree/main
effigies:fix-issue-117182https://github.com/effigies/cpython/tree/fix-issue-117182
Conversation 6 https://github.com/python/cpython/pull/117185
Commits 3 https://github.com/python/cpython/pull/117185/commits
Checks 0 https://github.com/python/cpython/pull/117185/checks
Files changed https://github.com/python/cpython/pull/117185/files
Please reload this pagehttps://github.com/python/cpython/pull/117185
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/effigies
effigieshttps://github.com/effigies
Mar 23, 2024https://github.com/python/cpython/pull/117185#issue-2203950782
Please reload this pagehttps://github.com/python/cpython/pull/117185
#117182https://github.com/python/cpython/issues/117182
Lazy loading conflicts with modules overriding ModuleType #117182https://github.com/python/cpython/issues/117182
Please reload this pagehttps://github.com/python/cpython/pull/117185
https://github.com/effigies
effigieshttps://github.com/effigies
brettcannonhttps://github.com/brettcannon
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
ncoghlanhttps://github.com/ncoghlan
warsawhttps://github.com/warsaw
code ownershttps://github.com/python/cpython/blob/f11d0d8be8af28e1368c3c7c116218cf65ddf93e/.github/CODEOWNERS#L106
March 23, 2024 16:30https://github.com/python/cpython/pull/117185#event-12224750759
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Mar 23, 2024https://github.com/python/cpython/pull/117185#event-12224750860
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Mar 23, 2024 https://github.com/python/cpython/pull/117185#ref-issue-2203919417
Lazy loading conflicts with modules overriding ModuleType #117182 https://github.com/python/cpython/issues/117182
effigieshttps://github.com/effigies
March 28, 2024 21:36https://github.com/python/cpython/pull/117185#commits-pushed-933c646
https://github.com/effigies
pythongh-117182https://github.com/python/cpython/issues/117182
: Test interaction between lazy modules and self-modif…https://github.com/python/cpython/pull/117185/commits/933c6467148dbd73d3a6d93760c82dfa71cfa4dc
933c646https://github.com/python/cpython/pull/117185/commits/933c6467148dbd73d3a6d93760c82dfa71cfa4dc
https://github.com/effigies
pythongh-117182https://github.com/python/cpython/issues/117182
: Allow modules to modify their own __class__ when laz…https://github.com/python/cpython/pull/117185/commits/a5e96703d96d78e93df67c748edcf05904bc23bc
a5e9670https://github.com/python/cpython/pull/117185/commits/a5e96703d96d78e93df67c748edcf05904bc23bc
https://github.com/effigies
Add news entryhttps://github.com/python/cpython/pull/117185/commits/393bb7cac9dcd9b2dc6ada84edbef641c36aad7f
393bb7chttps://github.com/python/cpython/pull/117185/commits/393bb7cac9dcd9b2dc6ada84edbef641c36aad7f
https://github.com/effigies
effigieshttps://github.com/effigies
force-pushedhttps://github.com/python/cpython/compare/b272bf5ac92f95e052ad6cce14dad06b8b2903b5..393bb7cac9dcd9b2dc6ada84edbef641c36aad7f
b272bf5https://github.com/python/cpython/commit/b272bf5ac92f95e052ad6cce14dad06b8b2903b5
393bb7chttps://github.com/python/cpython/commit/393bb7cac9dcd9b2dc6ada84edbef641c36aad7f
Compare https://github.com/python/cpython/compare/b272bf5ac92f95e052ad6cce14dad06b8b2903b5..393bb7cac9dcd9b2dc6ada84edbef641c36aad7f
March 29, 2024 01:37https://github.com/python/cpython/pull/117185#event-12289787647
https://github.com/FFY00
FFY00https://github.com/FFY00
Apr 9, 2024 https://github.com/python/cpython/pull/117185#pullrequestreview-1988028561
View reviewed changes https://github.com/python/cpython/pull/117185/files/393bb7cac9dcd9b2dc6ada84edbef641c36aad7f
FFY00https://github.com/FFY00
https://github.com/python/cpython/pull/117185#pullrequestreview-1988028561
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@effigieshttps://github.com/effigies
Please reload this pagehttps://github.com/python/cpython/pull/117185
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Apr 9, 2024https://github.com/python/cpython/pull/117185#event-12400660800
https://github.com/FFY00
FFY00https://github.com/FFY00
Apr 9, 2024https://github.com/python/cpython/pull/117185#event-12400666084
https://github.com/FFY00
FFY00https://github.com/FFY00
19a2202https://github.com/python/cpython/commit/19a22020676a599e1c92a24f841196645ddd9895
Apr 9, 2024https://github.com/python/cpython/pull/117185#event-12400667379
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Apr 9, 2024https://github.com/python/cpython/pull/117185#event-12400667647
https://github.com/FFY00
FFY00https://github.com/FFY00
Apr 9, 2024https://github.com/python/cpython/pull/117185#issuecomment-2044075168
Please reload this pagehttps://github.com/python/cpython/pull/117185
https://github.com/effigies
effigieshttps://github.com/effigies
April 9, 2024 10:14https://github.com/python/cpython/pull/117185#event-12404376211
https://github.com/lunaris
lunarishttps://github.com/lunaris
Apr 17, 2024https://github.com/python/cpython/pull/117185#issuecomment-2060851286
Please reload this pagehttps://github.com/python/cpython/pull/117185
https://github.com/pulumi/pulumihttps://github.com/pulumi/pulumi
https://github.com/lunaris/python-lazy-loading-reprohttps://github.com/lunaris/python-lazy-loading-repro
Please reload this pagehttps://github.com/python/cpython/pull/117185
https://github.com/lunaris
lunarishttps://github.com/lunaris
Apr 17, 2024 https://github.com/python/cpython/pull/117185#ref-issue-2233806446
Pulumi providers fail on Python 3.11.9 pulumi/pulumi#15882 https://github.com/pulumi/pulumi/issues/15882
https://github.com/effigies
effigieshttps://github.com/effigies
Apr 17, 2024https://github.com/python/cpython/pull/117185#issuecomment-2061900342
Please reload this pagehttps://github.com/python/cpython/pull/117185
#114781https://github.com/python/cpython/pull/114781
@FFY00https://github.com/FFY00
Please reload this pagehttps://github.com/python/cpython/pull/117185
https://github.com/effigies
effigieshttps://github.com/effigies
Apr 17, 2024https://github.com/python/cpython/pull/117185#issuecomment-2061908647
@lunarishttps://github.com/lunaris
Please reload this pagehttps://github.com/python/cpython/pull/117185
https://github.com/lunaris
lunarishttps://github.com/lunaris
Apr 26, 2024https://github.com/python/cpython/pull/117185#issuecomment-2079197440
@effigieshttps://github.com/effigies
Please reload this pagehttps://github.com/python/cpython/pull/117185
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F117185
https://github.com/FFY00
FFY00 https://github.com/FFY00
https://github.com/python/cpython/pull/117185/files/393bb7cac9dcd9b2dc6ada84edbef641c36aad7f
https://github.com/brettcannon
brettcannon https://github.com/brettcannon
https://github.com/ericsnowcurrently
ericsnowcurrently https://github.com/ericsnowcurrently
https://github.com/ncoghlan
ncoghlan https://github.com/ncoghlan
https://github.com/warsaw
warsaw https://github.com/warsaw
Lazy loading conflicts with modules overriding ModuleType https://github.com/python/cpython/issues/117182
Please reload this pagehttps://github.com/python/cpython/pull/117185
https://github.com/effigies
https://github.com/FFY00
https://github.com/lunaris
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.