René's URL Explorer Experiment


Title: subprocess: close pipes/fds by using ExitStack by giampaolo · Pull Request #11686 · python/cpython · GitHub

Open Graph Title: subprocess: close pipes/fds by using ExitStack by giampaolo · Pull Request #11686 · python/cpython

X Title: subprocess: close pipes/fds by using ExitStack by giampaolo · Pull Request #11686 · python/cpython

Description: "In case of premature failure on X.Close() or os.close(X) the remaining pipes/fds will remain "open". Perhaps it makes sense to use contextlib.ExitStack." This is a follow up of bpo-35537. Rational...

Open Graph Description: "In case of premature failure on X.Close() or os.close(X) the remaining pipes/fds will remain "open". Perhaps it makes sense to use contextlib.ExitStack." This is a follow up of...

X Description: "In case of premature failure on X.Close() or os.close(X) the remaining pipes/fds will remain "open". Perhaps it makes sense to use contextlib.ExitStack." This i...

Opengraph URL: https://github.com/python/cpython/pull/11686

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ac44a2a3-e55e-6fab-49f2-3286dcd9e17c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC034:1D81B0:9D717B:D8AD31:696A854C
html-safe-nonce40804c7579e7f98fbb21fd52b70dda150fc8b8f81d9e152fb1cc475a5a98b424
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMDM0OjFEODFCMDo5RDcxN0I6RDhBRDMxOjY5NkE4NTRDIiwidmlzaXRvcl9pZCI6IjYxMDYxMzg4NjA3MDYzMzcyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacb0808ec88a65e64904c62a4c7c66e201871e8f2d8f0102562936ddce1d9f81eb
hovercard-subject-tagpull_request:247958695
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/11686/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b33a06233cb8606e847e35787a70b8b70fc6d80780e43c7d2fdf8e1ea3f59ccc/python/cpython/pull/11686
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b33a06233cb8606e847e35787a70b8b70fc6d80780e43c7d2fdf8e1ea3f59ccc/python/cpython/pull/11686
og:image:alt"In case of premature failure on X.Close() or os.close(X) the remaining pipes/fds will remain "open". Perhaps it makes sense to use contextlib.ExitStack." This is a follow up of...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegiampaolo
hostnamegithub.com
expected-hostnamegithub.com
None913560fa317c3c5a71e34f9b19253c9f09d02b4b958a86c2a56f4c8541116377
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5998c30593994bf2589055aef7b22d368a499367
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/11686#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F11686
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F11686
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/11686
Reloadhttps://github.com/python/cpython/pull/11686
Reloadhttps://github.com/python/cpython/pull/11686
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/11686
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/11686
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/11686#issue-comment-box
gpsheadhttps://github.com/gpshead
python:masterhttps://github.com/python/cpython/tree/master
subprocess: close pipes/fds by using ExitStack https://github.com/python/cpython/pull/11686#top
gpsheadhttps://github.com/gpshead
python:masterhttps://github.com/python/cpython/tree/master
Conversation 4 https://github.com/python/cpython/pull/11686
Commits 4 https://github.com/python/cpython/pull/11686/commits
Checks 0 https://github.com/python/cpython/pull/11686/checks
Files changed https://github.com/python/cpython/pull/11686/files
Please reload this pagehttps://github.com/python/cpython/pull/11686
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/giampaolo
giampaolohttps://github.com/giampaolo
Jan 27, 2019https://github.com/python/cpython/pull/11686#issue-403559129
Please reload this pagehttps://github.com/python/cpython/pull/11686
bpo-35537https://bugs.python.org/issue35537
#11575 (comment)https://github.com/python/cpython/pull/11575#discussion_r250288394
Please reload this pagehttps://github.com/python/cpython/pull/11686
https://github.com/giampaolo
subprocess: close pipes/fds by using ExitStackhttps://github.com/python/cpython/pull/11686/commits/a2948423c3b0614ad6286810187b39f04ac9f7e6
a294842https://github.com/python/cpython/pull/11686/commits/a2948423c3b0614ad6286810187b39f04ac9f7e6
#11575 (comment)https://github.com/python/cpython/pull/11575#discussion_r250288394
https://github.com/giampaolo
giampaolohttps://github.com/giampaolo
ncoghlanhttps://github.com/ncoghlan
vstinnerhttps://github.com/vstinner
January 27, 2019 14:53https://github.com/python/cpython/pull/11686#event-2099351145
https://github.com/giampaolo
giampaolohttps://github.com/giampaolo
gpsheadhttps://github.com/gpshead
code ownerhttps://github.com/python/cpython/blob/81d04bcf2124341aa73e5c13c1f1c4bdd3f5dbef/.github/CODEOWNERS#L46
January 27, 2019 14:53https://github.com/python/cpython/pull/11686#event-2099351152
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Jan 27, 2019https://github.com/python/cpython/pull/11686#event-2099351162
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Jan 27, 2019https://github.com/python/cpython/pull/11686#event-2099351170
https://github.com/giampaolo
giampaolohttps://github.com/giampaolo
Jan 27, 2019 https://github.com/python/cpython/pull/11686#ref-pullrequest-399593756
bpo-35537: subprocess can use posix_spawn with pipes #11575 https://github.com/python/cpython/pull/11575
https://github.com/izbyshev
izbyshevhttps://github.com/izbyshev
Jan 27, 2019 https://github.com/python/cpython/pull/11686#pullrequestreview-196832657
View reviewed changes https://github.com/python/cpython/pull/11686/files/a2948423c3b0614ad6286810187b39f04ac9f7e6
Lib/subprocess.pyhttps://github.com/python/cpython/pull/11686/files/a2948423c3b0614ad6286810187b39f04ac9f7e6#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
Please reload this pagehttps://github.com/python/cpython/pull/11686
giampaolohttps://github.com/giampaolo
January 27, 2019 16:37https://github.com/python/cpython/pull/11686#commits-pushed-93ac155
https://github.com/giampaolo
avoid try/finally block around CloseHandle()https://github.com/python/cpython/pull/11686/commits/93ac155b9b2405a79be232599b1abeb83891c734
93ac155https://github.com/python/cpython/pull/11686/commits/93ac155b9b2405a79be232599b1abeb83891c734
https://github.com/giampaolo
fix accidental removal of CloseHandle() callshttps://github.com/python/cpython/pull/11686/commits/685cef2970dfdaa157bab3149c63257041f71c0c
685cef2https://github.com/python/cpython/pull/11686/commits/685cef2970dfdaa157bab3149c63257041f71c0c
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
skip issue https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20issue%22
skip issue https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20issue%22
Jan 27, 2019https://github.com/python/cpython/pull/11686#event-2099469904
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Jan 27, 2019https://github.com/python/cpython/pull/11686#issuecomment-457946065
Please reload this pagehttps://github.com/python/cpython/pull/11686
bpo-35537https://bugs.python.org/issue35537
Please reload this pagehttps://github.com/python/cpython/pull/11686
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Jan 27, 2019 https://github.com/python/cpython/pull/11686#pullrequestreview-196841409
View reviewed changes https://github.com/python/cpython/pull/11686/files/685cef2970dfdaa157bab3149c63257041f71c0c
https://github.com/giampaolo
add NEWS entryhttps://github.com/python/cpython/pull/11686/commits/65374c61215661de902343484b43a91f2afe67ff
65374c6https://github.com/python/cpython/pull/11686/commits/65374c61215661de902343484b43a91f2afe67ff
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Jan 29, 2019 https://github.com/python/cpython/pull/11686#pullrequestreview-197786556
View reviewed changes https://github.com/python/cpython/pull/11686/files/65374c61215661de902343484b43a91f2afe67ff
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
skip issue https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20issue%22
Jan 29, 2019https://github.com/python/cpython/pull/11686#event-2104861156
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
bafa848https://github.com/python/cpython/commit/bafa8487f77fa076de3a06755399daf81cb75598
Jan 29, 2019https://github.com/python/cpython/pull/11686#event-2104863127
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Jan 29, 2019https://github.com/python/cpython/pull/11686#event-2104863206
https://github.com/giampaolo
giampaolohttps://github.com/giampaolo
February 3, 2019 22:27https://github.com/python/cpython/pull/11686#event-2114538290
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F11686
https://github.com/gpshead
gpshead https://github.com/gpshead
https://github.com/python/cpython/pull/11686/files/65374c61215661de902343484b43a91f2afe67ff
https://github.com/vstinner
vstinner https://github.com/vstinner
https://github.com/ncoghlan
ncoghlan https://github.com/ncoghlan
https://github.com/izbyshev
izbyshev https://github.com/izbyshev
https://github.com/python/cpython/pull/11686/files/a2948423c3b0614ad6286810187b39f04ac9f7e6
skip issue https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20issue%22
Please reload this pagehttps://github.com/python/cpython/pull/11686
https://github.com/giampaolo
https://github.com/gpshead
https://github.com/ncoghlan
https://github.com/izbyshev
https://github.com/the-knights-who-say-ni
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.