René's URL Explorer Experiment


Title: gh-113538: Allow client connections to be closed by CendioOssman · Pull Request #116784 · python/cpython · GitHub

Open Graph Title: gh-113538: Allow client connections to be closed by CendioOssman · Pull Request #116784 · python/cpython

X Title: gh-113538: Allow client connections to be closed by CendioOssman · Pull Request #116784 · python/cpython

Description: This is a new attempt at #114432, with one additional commit to fix unreliably tests. Issue: Cannot cleanly shut down an asyncio based server #113538 📚 Documentation preview 📚: https://cpyth...

Open Graph Description: This is a new attempt at #114432, with one additional commit to fix unreliably tests. Issue: Cannot cleanly shut down an asyncio based server #113538 📚 Documentation preview 📚: https://cpyth...

X Description: This is a new attempt at #114432, with one additional commit to fix unreliably tests. Issue: Cannot cleanly shut down an asyncio based server #113538 📚 Documentation preview 📚: https://cpyth...

Opengraph URL: https://github.com/python/cpython/pull/116784

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0d6eb9a0-535b-8390-bce5-a86ab903de95
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9B6C:134C26:1446584:1B24A0A:696ADB19
html-safe-nonce9f11db3b68290df3762c6256afcabc2465a5e59729ff76d9bb8f453678deb255
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QjZDOjEzNEMyNjoxNDQ2NTg0OjFCMjRBMEE6Njk2QURCMTkiLCJ2aXNpdG9yX2lkIjoiNjU4MzIxMTI4MzM0OTk1MzMwNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac192aca234be5ab1bdce8c267cef098701051ead7857ac1e9dfa5d1e3ee1525a9
hovercard-subject-tagpull_request:1771667085
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/116784/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1c8791fb6cb2868167934fbc952b1afcf54a3e1e61c675c3755368e4aa1b0bd4/python/cpython/pull/116784
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1c8791fb6cb2868167934fbc952b1afcf54a3e1e61c675c3755368e4aa1b0bd4/python/cpython/pull/116784
og:image:altThis is a new attempt at #114432, with one additional commit to fix unreliably tests. Issue: Cannot cleanly shut down an asyncio based server #113538 📚 Documentation preview 📚: https://cpyth...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameCendioOssman
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release524a93f2c1f36522a3b4be4c110467ee4172245d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/116784#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F116784
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F116784
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/116784
Reloadhttps://github.com/python/cpython/pull/116784
Reloadhttps://github.com/python/cpython/pull/116784
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/116784
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/116784
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/116784#issue-comment-box
gvanrossumhttps://github.com/gvanrossum
python:mainhttps://github.com/python/cpython/tree/main
CendioOssman:server_closehttps://github.com/CendioOssman/cpython/tree/server_close
gh-113538: Allow client connections to be closed https://github.com/python/cpython/pull/116784#top
gvanrossumhttps://github.com/gvanrossum
python:mainhttps://github.com/python/cpython/tree/main
CendioOssman:server_closehttps://github.com/CendioOssman/cpython/tree/server_close
Conversation 2 https://github.com/python/cpython/pull/116784
Commits 15 https://github.com/python/cpython/pull/116784/commits
Checks 0 https://github.com/python/cpython/pull/116784/checks
Files changed https://github.com/python/cpython/pull/116784/files
Please reload this pagehttps://github.com/python/cpython/pull/116784
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/CendioOssman
CendioOssmanhttps://github.com/CendioOssman
Mar 14, 2024https://github.com/python/cpython/pull/116784#issue-2185763995
Please reload this pagehttps://github.com/python/cpython/pull/116784
#114432https://github.com/python/cpython/pull/114432
Cannot cleanly shut down an asyncio based server #113538https://github.com/python/cpython/issues/113538
https://cpython-previews--116784.org.readthedocs.build/https://cpython-previews--116784.org.readthedocs.build/
Please reload this pagehttps://github.com/python/cpython/pull/116784
CendioOssmanhttps://github.com/CendioOssman
January 22, 2024 11:30https://github.com/python/cpython/pull/116784#commits-pushed-9f0111e
https://github.com/CendioOssman
Don't use internals for wait_closed() testshttps://github.com/python/cpython/pull/116784/commits/9f0111ed872091df81ce7239f95581ee96296f51
9f0111ehttps://github.com/python/cpython/pull/116784/commits/9f0111ed872091df81ce7239f95581ee96296f51
https://github.com/CendioOssman
pythongh-113538https://github.com/python/cpython/issues/113538
: Allow client connections to be closedhttps://github.com/python/cpython/pull/116784/commits/c25eabbca6b3bac6ac9b30c25e20040b199d1733
c25eabbhttps://github.com/python/cpython/pull/116784/commits/c25eabbca6b3bac6ac9b30c25e20040b199d1733
https://github.com/CendioOssman
Fix method references in new documentationhttps://github.com/python/cpython/pull/116784/commits/b7fa1989d2466d56a1190b2412a9d8eb162bc6f8
b7fa198https://github.com/python/cpython/pull/116784/commits/b7fa1989d2466d56a1190b2412a9d8eb162bc6f8
https://github.com/CendioOssman
Add attributionhttps://github.com/python/cpython/pull/116784/commits/b3cd9c16363588aa381fa4b553c28cb0bbe9eb1c
b3cd9c1https://github.com/python/cpython/pull/116784/commits/b3cd9c16363588aa381fa4b553c28cb0bbe9eb1c
https://github.com/CendioOssman
Only keep a weak client referenceshttps://github.com/python/cpython/pull/116784/commits/c78a927c5c1de02f2bfd26cce7ec3301046bb097
c78a927https://github.com/python/cpython/pull/116784/commits/c78a927c5c1de02f2bfd26cce7ec3301046bb097
https://github.com/CendioOssman
Inform server of fallback transport cleanuphttps://github.com/python/cpython/pull/116784/commits/1ec06da9d744053b90c07f08d78a2158b48b450a
1ec06dahttps://github.com/python/cpython/pull/116784/commits/1ec06da9d744053b90c07f08d78a2158b48b450a
https://github.com/CendioOssman
Clarify recomended order of methodshttps://github.com/python/cpython/pull/116784/commits/2790ddf3348fa66361843219f8e47e92bf659e05
2790ddfhttps://github.com/python/cpython/pull/116784/commits/2790ddf3348fa66361843219f8e47e92bf659e05
https://github.com/CendioOssman
Fix typoshttps://github.com/python/cpython/pull/116784/commits/6a56a80bce06e824dc08a9e33e2348a09dbdc535
6a56a80https://github.com/python/cpython/pull/116784/commits/6a56a80bce06e824dc08a9e33e2348a09dbdc535
https://github.com/CendioOssman
Use discard() instead of conditional remove()https://github.com/python/cpython/pull/116784/commits/69298883c83b4505a19aef8bef683f3ef6ec932f
6929888https://github.com/python/cpython/pull/116784/commits/69298883c83b4505a19aef8bef683f3ef6ec932f
https://github.com/CendioOssman
Improve some commentshttps://github.com/python/cpython/pull/116784/commits/831619942e9619c270ddb65d7e55ed158e5b064e
8316199https://github.com/python/cpython/pull/116784/commits/831619942e9619c270ddb65d7e55ed158e5b064e
https://github.com/CendioOssman
Do multiple sleeps to flush out callbackshttps://github.com/python/cpython/pull/116784/commits/3e1705b27c9b6202a1980403b42e63995e4cfda5
3e1705bhttps://github.com/python/cpython/pull/116784/commits/3e1705b27c9b6202a1980403b42e63995e4cfda5
https://github.com/CendioOssman
More deterministic abort_clients() testhttps://github.com/python/cpython/pull/116784/commits/6c078d67811889ae6416656ef74144a2e626a183
6c078d6https://github.com/python/cpython/pull/116784/commits/6c078d67811889ae6416656ef74144a2e626a183
https://github.com/CendioOssman
Even more deterministichttps://github.com/python/cpython/pull/116784/commits/1158151d212afb03c0ab58f267b67178a2158454
1158151https://github.com/python/cpython/pull/116784/commits/1158151d212afb03c0ab58f267b67178a2158454
https://github.com/CendioOssman
Merge branch 'main' ofhttps://github.com/python/cpython/pull/116784/commits/1065ddaab23e2638ab65fae4c796aef0baf9e410
https://github.com/python/cpythonhttps://github.com/python/cpython
into server_…https://github.com/python/cpython/pull/116784/commits/1065ddaab23e2638ab65fae4c796aef0baf9e410
1065ddahttps://github.com/python/cpython/pull/116784/commits/1065ddaab23e2638ab65fae4c796aef0baf9e410
https://github.com/CendioOssman
Wait for test client to fully connecthttps://github.com/python/cpython/pull/116784/commits/6a524cb4549add97a93a4b5adf4c4b05ad0c79e3
6a524cbhttps://github.com/python/cpython/pull/116784/commits/6a524cb4549add97a93a4b5adf4c4b05ad0c79e3
https://github.com/CendioOssman
CendioOssmanhttps://github.com/CendioOssman
1st1https://github.com/1st1
asvetlovhttps://github.com/asvetlov
gvanrossumhttps://github.com/gvanrossum
kumaraditya303https://github.com/kumaraditya303
willingchttps://github.com/willingc
code ownershttps://github.com/python/cpython/blob/a18c9854e8c255981f07c0a1c1503253f85b7540/.github/CODEOWNERS#L18
March 14, 2024 08:43https://github.com/python/cpython/pull/116784#event-12114481777
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Mar 14, 2024https://github.com/python/cpython/pull/116784#event-12114482512
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Mar 14, 2024 https://github.com/python/cpython/pull/116784#ref-issue-2058252897
Cannot cleanly shut down an asyncio based server #113538 https://github.com/python/cpython/issues/113538
https://github.com/CendioOssman
CendioOssmanhttps://github.com/CendioOssman
Mar 14, 2024https://github.com/python/cpython/pull/116784#issuecomment-1996881735
@gvanrossumhttps://github.com/gvanrossum
Please reload this pagehttps://github.com/python/cpython/pull/116784
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Mar 18, 2024 https://github.com/python/cpython/pull/116784#pullrequestreview-1944095992
View reviewed changes https://github.com/python/cpython/pull/116784/files/6a524cb4549add97a93a4b5adf4c4b05ad0c79e3
gvanrossumhttps://github.com/gvanrossum
https://github.com/python/cpython/pull/116784#pullrequestreview-1944095992
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/116784
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Mar 18, 2024https://github.com/python/cpython/pull/116784#event-12158673815
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
4159644https://github.com/python/cpython/commit/415964417771946dcb7a163951913adf84644b6d
Mar 18, 2024https://github.com/python/cpython/pull/116784#event-12158707005
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Mar 18, 2024https://github.com/python/cpython/pull/116784#event-12158707761
vstinnerhttps://github.com/vstinner
Mar 20, 2024 https://github.com/python/cpython/pull/116784#ref-commit-cc24c18
https://github.com/CendioOssman
https://github.com/vstinner
pythongh-113538https://github.com/python/cpython/issues/113538
: Add asycio.Server.{close,abort}_clients (redo) (https://github.com/vstinner/cpython/commit/cc24c18af12199e471cf3163a0fc67e13d52a7b2
pyth…https://github.com/python/cpython/pull/116784
cc24c18https://github.com/vstinner/cpython/commit/cc24c18af12199e471cf3163a0fc67e13d52a7b2
…on#116784https://github.com/python/cpython/pull/116784
pythongh-114432https://github.com/python/cpython/pull/114432
adorilsonhttps://github.com/adorilson
Mar 25, 2024 https://github.com/python/cpython/pull/116784#ref-commit-ac9d421
https://github.com/CendioOssman
https://github.com/adorilson
pythongh-113538https://github.com/python/cpython/issues/113538
: Add asycio.Server.{close,abort}_clients (redo) (https://github.com/adorilson/cpython/commit/ac9d421a4c1cc4dc97430b192df82c54e6df07f7
pyth…https://github.com/python/cpython/pull/116784
ac9d421https://github.com/adorilson/cpython/commit/ac9d421a4c1cc4dc97430b192df82c54e6df07f7
…on#116784https://github.com/python/cpython/pull/116784
pythongh-114432https://github.com/python/cpython/pull/114432
diegorussohttps://github.com/diegorusso
Apr 17, 2024 https://github.com/python/cpython/pull/116784#ref-commit-01d051f
https://github.com/CendioOssman
https://github.com/diegorusso
pythongh-113538https://github.com/python/cpython/issues/113538
: Add asycio.Server.{close,abort}_clients (redo) (https://github.com/diegorusso/cpython/commit/01d051f575cac4aa689aec0b25e273c15198709d
pyth…https://github.com/python/cpython/pull/116784
01d051fhttps://github.com/diegorusso/cpython/commit/01d051f575cac4aa689aec0b25e273c15198709d
…on#116784https://github.com/python/cpython/pull/116784
pythongh-114432https://github.com/python/cpython/pull/114432
https://github.com/encukou
encukouhttps://github.com/encukou
Aug 28, 2024 https://github.com/python/cpython/pull/116784#ref-pullrequest-2491983576
gh-122136: test_asyncio: Don't fail if the kernel buffers more data than advertised #123423 https://github.com/python/cpython/pull/123423
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F116784
https://github.com/gvanrossum
gvanrossum https://github.com/gvanrossum
https://github.com/python/cpython/pull/116784/files/6a524cb4549add97a93a4b5adf4c4b05ad0c79e3
https://github.com/1st1
1st1 https://github.com/1st1
https://github.com/asvetlov
asvetlov https://github.com/asvetlov
https://github.com/kumaraditya303
kumaraditya303 https://github.com/kumaraditya303
https://github.com/willingc
willingc https://github.com/willingc
Please reload this pagehttps://github.com/python/cpython/pull/116784
https://github.com/CendioOssman
https://github.com/gvanrossum
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.