René's URL Explorer Experiment


Title: gh-100746: Improve `test_named_expressions.py` by sobolevn · Pull Request #116713 · python/cpython · GitHub

Open Graph Title: gh-100746: Improve `test_named_expressions.py` by sobolevn · Pull Request #116713 · python/cpython

X Title: gh-100746: Improve `test_named_expressions.py` by sobolevn · Pull Request #116713 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Two major changes: I removed pass where possible and instead used an assert for what we expect to happen I added dict-comprehensions testing by copy-pasting and modifing set-comprehension tests. W...

X Description: Two major changes: I removed pass where possible and instead used an assert for what we expect to happen I added dict-comprehensions testing by copy-pasting and modifing set-comprehension tests. W...

Opengraph URL: https://github.com/python/cpython/pull/116713

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:70042a25-bd30-9b58-dd13-c82ccddb3cb9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAD6E:2D8191:6211A4:8264BD:6B003483
html-safe-nonce756da5f6640634dd104c0f335abad265d90f059672d7e675dea91a5324c2f8c4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRDZFOjJEODE5MTo2MjExQTQ6ODI2NEJEOjZCMDAzNDgzIiwidmlzaXRvcl9pZCI6IjU5MDc3Nzc0Mzc4NDgwNTY5NjMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac63cadab82791b8ac46b12e2eb11f46ba5d9c3f2d3ab745f2cca5a488d8c39f39
hovercard-subject-tagpull_request:1769506948
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/116713/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/955214f9234c05f9109e794b67076bd22285a3b9baa508b36c54fda97df8e37f/python/cpython/pull/116713
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/955214f9234c05f9109e794b67076bd22285a3b9baa508b36c54fda97df8e37f/python/cpython/pull/116713
og:image:altTwo major changes: I removed pass where possible and instead used an assert for what we expect to happen I added dict-comprehensions testing by copy-pasting and modifing set-comprehension tests. W...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesobolevn
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/116713#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F116713
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F116713
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/116713
Reloadhttps://github.com/python/cpython/pull/116713
Reloadhttps://github.com/python/cpython/pull/116713
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
sobolevnhttps://github.com/sobolevn
python:mainhttps://github.com/python/cpython/tree/main
sobolevn:issue-100746https://github.com/sobolevn/cpython/tree/issue-100746
Conversationhttps://github.com/python/cpython/pull/116713
Commits1 (1)https://github.com/python/cpython/pull/116713/commits
Checkshttps://github.com/python/cpython/pull/116713/checks
Files changedhttps://github.com/python/cpython/pull/116713/files
gh-100746: Improve test_named_expressions.pyhttps://github.com/python/cpython/pull/116713#top
sobolevnhttps://github.com/sobolevn
python:mainhttps://github.com/python/cpython/tree/main
sobolevn:issue-100746https://github.com/sobolevn/cpython/tree/issue-100746
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
Mar 13, 2024https://github.com/python/cpython/pull/116713#issue-2183352071
Please reload this pagehttps://github.com/python/cpython/pull/116713
Dict comprehensions are not tested at all in test_named_expressions.py #100746https://github.com/python/cpython/issues/100746
Please reload this pagehttps://github.com/python/cpython/pull/116713
https://github.com/sobolevn
pythongh-100746https://github.com/python/cpython/issues/100746
: Improvehttps://github.com/python/cpython/pull/116713/commits/b1562be3cee5b133c9b28ada0d89220f8013bc7e
test_named_expressions.pyhttps://github.com/python/cpython/pull/116713/commits/b1562be3cee5b133c9b28ada0d89220f8013bc7e
b1562behttps://github.com/python/cpython/pull/116713/commits/b1562be3cee5b133c9b28ada0d89220f8013bc7e
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
emilyemorehousehttps://github.com/emilyemorehouse
pablogsalhttps://github.com/pablogsal
March 13, 2024 08:03https://github.com/python/cpython/pull/116713#event-12099364686
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Mar 13, 2024https://github.com/python/cpython/pull/116713#event-12099365235
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Mar 13, 2024 https://github.com/python/cpython/pull/116713#ref-issue-1518668707
Dict comprehensions are not tested at all in test_named_expressions.py #100746 https://github.com/python/cpython/issues/100746
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
tests https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests
Mar 13, 2024https://github.com/python/cpython/pull/116713#event-12099365926
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Mar 13, 2024https://github.com/python/cpython/pull/116713#event-12099369078
https://github.com/emilyemorehouse
emilyemorehousehttps://github.com/emilyemorehouse
Mar 13, 2024 https://github.com/python/cpython/pull/116713#pullrequestreview-1934508424
View reviewed changes https://github.com/python/cpython/pull/116713/files/b1562be3cee5b133c9b28ada0d89220f8013bc7e
emilyemorehousehttps://github.com/emilyemorehouse
https://github.com/python/cpython/pull/116713#pullrequestreview-1934508424
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/116713
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Mar 13, 2024https://github.com/python/cpython/pull/116713#event-12105332395
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
needs backport to 3.11 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.11%22
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
Mar 13, 2024https://github.com/python/cpython/pull/116713#event-12105485131
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
Mar 13, 2024https://github.com/python/cpython/pull/116713#issuecomment-1994690905
Please reload this pagehttps://github.com/python/cpython/pull/116713
https://github.com/Eclips4
Eclips4https://github.com/Eclips4
Mar 13, 2024 https://github.com/python/cpython/pull/116713#pullrequestreview-1934775755
View reviewed changes https://github.com/python/cpython/pull/116713/files/b1562be3cee5b133c9b28ada0d89220f8013bc7e
Eclips4https://github.com/Eclips4
https://github.com/python/cpython/pull/116713#pullrequestreview-1934775755
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/116713
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
25684e7https://github.com/python/cpython/commit/25684e71310642ffd20b45eea9b5226a1fa809a5
Mar 13, 2024https://github.com/python/cpython/pull/116713#event-12107430833
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Mar 13, 2024https://github.com/python/cpython/pull/116713#issuecomment-1995241496
@sobolevnhttps://github.com/sobolevn
Please reload this pagehttps://github.com/python/cpython/pull/116713
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Mar 13, 2024https://github.com/python/cpython/pull/116713#event-12107431327
miss-islingtonhttps://github.com/miss-islington
Mar 13, 2024 https://github.com/python/cpython/pull/116713#ref-commit-0b2e876
https://github.com/sobolevn
https://github.com/miss-islington
pythongh-100746https://github.com/python/cpython/issues/100746
: Improvehttps://github.com/miss-islington/cpython/commit/0b2e876cc64139b945faacf2aa68997c6c35fbb4
test_named_expressions.pyhttps://github.com/miss-islington/cpython/commit/0b2e876cc64139b945faacf2aa68997c6c35fbb4
(https://github.com/miss-islington/cpython/commit/0b2e876cc64139b945faacf2aa68997c6c35fbb4
pythonGH-116713https://github.com/python/cpython/pull/116713
)https://github.com/miss-islington/cpython/commit/0b2e876cc64139b945faacf2aa68997c6c35fbb4
0b2e876https://github.com/miss-islington/cpython/commit/0b2e876cc64139b945faacf2aa68997c6c35fbb4
25684e7https://github.com/miss-islington/cpython/commit/25684e71310642ffd20b45eea9b5226a1fa809a5
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Mar 13, 2024https://github.com/python/cpython/pull/116713#issuecomment-1995242045
GH-116747https://github.com/python/cpython/pull/116747
3.12 branchhttps://github.com/python/cpython/tree/3.12
Please reload this pagehttps://github.com/python/cpython/pull/116713
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
Mar 13, 2024https://github.com/python/cpython/pull/116713#event-12107432879
miss-islingtonhttps://github.com/miss-islington
Mar 13, 2024 https://github.com/python/cpython/pull/116713#ref-commit-4e72e66
https://github.com/sobolevn
https://github.com/miss-islington
pythongh-100746https://github.com/python/cpython/issues/100746
: Improvehttps://github.com/miss-islington/cpython/commit/4e72e6608c87ab7e82cda82c99b9b2d60ace60b8
test_named_expressions.pyhttps://github.com/miss-islington/cpython/commit/4e72e6608c87ab7e82cda82c99b9b2d60ace60b8
(https://github.com/miss-islington/cpython/commit/4e72e6608c87ab7e82cda82c99b9b2d60ace60b8
pythonGH-116713https://github.com/python/cpython/pull/116713
)https://github.com/miss-islington/cpython/commit/4e72e6608c87ab7e82cda82c99b9b2d60ace60b8
4e72e66https://github.com/miss-islington/cpython/commit/4e72e6608c87ab7e82cda82c99b9b2d60ace60b8
25684e7https://github.com/miss-islington/cpython/commit/25684e71310642ffd20b45eea9b5226a1fa809a5
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Mar 13, 2024https://github.com/python/cpython/pull/116713#issuecomment-1995242337
GH-116748https://github.com/python/cpython/pull/116748
3.11 branchhttps://github.com/python/cpython/tree/3.11
Please reload this pagehttps://github.com/python/cpython/pull/116713
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.11 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.11%22
Mar 13, 2024https://github.com/python/cpython/pull/116713#event-12107433735
sobolevnhttps://github.com/sobolevn
Mar 13, 2024 https://github.com/python/cpython/pull/116713#ref-commit-734c5c4
https://github.com/miss-islington
https://github.com/sobolevn
[3.12]https://github.com/python/cpython/commit/734c5c4a09573198a32c52ca43b05782f2b512f9
gh-100746https://github.com/python/cpython/issues/100746
: Improvehttps://github.com/python/cpython/commit/734c5c4a09573198a32c52ca43b05782f2b512f9
test_named_expressions.pyhttps://github.com/python/cpython/commit/734c5c4a09573198a32c52ca43b05782f2b512f9
(https://github.com/python/cpython/commit/734c5c4a09573198a32c52ca43b05782f2b512f9
GH-116713https://github.com/python/cpython/pull/116713
) (https://github.com/python/cpython/commit/734c5c4a09573198a32c52ca43b05782f2b512f9
#1…https://github.com/python/cpython/pull/116747
734c5c4https://github.com/python/cpython/commit/734c5c4a09573198a32c52ca43b05782f2b512f9
…16747https://github.com/python/cpython/pull/116747
gh-100746https://github.com/python/cpython/issues/100746
GH-116713https://github.com/python/cpython/pull/116713
25684e7https://github.com/python/cpython/commit/25684e71310642ffd20b45eea9b5226a1fa809a5
vstinnerhttps://github.com/vstinner
Mar 20, 2024 https://github.com/python/cpython/pull/116713#ref-commit-41f5bc2
https://github.com/sobolevn
https://github.com/vstinner
pythongh-100746https://github.com/python/cpython/issues/100746
: Improvehttps://github.com/vstinner/cpython/commit/41f5bc2eeaa230dc670ccd93fe5493f4044bfdb6
test_named_expressions.pyhttps://github.com/vstinner/cpython/commit/41f5bc2eeaa230dc670ccd93fe5493f4044bfdb6
(https://github.com/vstinner/cpython/commit/41f5bc2eeaa230dc670ccd93fe5493f4044bfdb6
python#116713https://github.com/python/cpython/pull/116713
)https://github.com/vstinner/cpython/commit/41f5bc2eeaa230dc670ccd93fe5493f4044bfdb6
41f5bc2https://github.com/vstinner/cpython/commit/41f5bc2eeaa230dc670ccd93fe5493f4044bfdb6
adorilsonhttps://github.com/adorilson
Mar 25, 2024 https://github.com/python/cpython/pull/116713#ref-commit-69861cd
https://github.com/sobolevn
https://github.com/adorilson
pythongh-100746https://github.com/python/cpython/issues/100746
: Improvehttps://github.com/adorilson/cpython/commit/69861cd9d32e7bc1fbc287d2cb5c945ffda00856
test_named_expressions.pyhttps://github.com/adorilson/cpython/commit/69861cd9d32e7bc1fbc287d2cb5c945ffda00856
(https://github.com/adorilson/cpython/commit/69861cd9d32e7bc1fbc287d2cb5c945ffda00856
python#116713https://github.com/python/cpython/pull/116713
)https://github.com/adorilson/cpython/commit/69861cd9d32e7bc1fbc287d2cb5c945ffda00856
69861cdhttps://github.com/adorilson/cpython/commit/69861cd9d32e7bc1fbc287d2cb5c945ffda00856
diegorussohttps://github.com/diegorusso
Apr 17, 2024 https://github.com/python/cpython/pull/116713#ref-commit-1e73fce
https://github.com/sobolevn
https://github.com/diegorusso
pythongh-100746https://github.com/python/cpython/issues/100746
: Improvehttps://github.com/diegorusso/cpython/commit/1e73fceea055bd2ae3d54b979ee74e0a2cec0346
test_named_expressions.pyhttps://github.com/diegorusso/cpython/commit/1e73fceea055bd2ae3d54b979ee74e0a2cec0346
(https://github.com/diegorusso/cpython/commit/1e73fceea055bd2ae3d54b979ee74e0a2cec0346
python#116713https://github.com/python/cpython/pull/116713
)https://github.com/diegorusso/cpython/commit/1e73fceea055bd2ae3d54b979ee74e0a2cec0346
1e73fcehttps://github.com/diegorusso/cpython/commit/1e73fceea055bd2ae3d54b979ee74e0a2cec0346
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F116713
https://github.com/emilyemorehouse
emilyemorehouse https://github.com/emilyemorehouse
https://github.com/python/cpython/pull/116713/files/b1562be3cee5b133c9b28ada0d89220f8013bc7e
https://github.com/Eclips4
Eclips4 https://github.com/Eclips4
https://github.com/python/cpython/pull/116713/files/b1562be3cee5b133c9b28ada0d89220f8013bc7e
https://github.com/pablogsal
pablogsal https://github.com/pablogsal
Please reload this pagehttps://github.com/python/cpython/pull/116713
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
tests https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests
Please reload this pagehttps://github.com/python/cpython/pull/116713
https://github.com/sobolevn
https://github.com/emilyemorehouse
https://github.com/Eclips4
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.