René's URL Explorer Experiment


Title: bpo-35766: Merge typed_ast back into CPython by gvanrossum · Pull Request #11645 · python/cpython · GitHub

Open Graph Title: bpo-35766: Merge typed_ast back into CPython by gvanrossum · Pull Request #11645 · python/cpython

X Title: bpo-35766: Merge typed_ast back into CPython by gvanrossum · Pull Request #11645 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: [UPDATE: I've rewritten this comment to match the latest state of the PR.] See the bpo issue for motivation. This is the minimal code I hope to merge into CPython. The PR here is complete excep...

X Description: [UPDATE: I've rewritten this comment to match the latest state of the PR.] See the bpo issue for motivation. This is the minimal code I hope to merge into CPython. The PR here is complete e...

Opengraph URL: https://github.com/python/cpython/pull/11645

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d3061389-76d2-2d9d-7e61-54c1e6cc5441
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB3B0:15F1A6:1C1EE4C:25C3921:6A5364F4
html-safe-noncec3bab89c133cc7f1d3708736c841ebc11b815891596865bd2a9e729193f4b1e0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCM0IwOjE1RjFBNjoxQzFFRTRDOjI1QzM5MjE6NkE1MzY0RjQiLCJ2aXNpdG9yX2lkIjoiNTYwNzY5NDg1MDMyMzYwNDcyNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacede9776699e6d3a32ca8b61377de0df115d902fb06a2c8230fbac3ec7b58137a
hovercard-subject-tagpull_request:246458420
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/11645/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/82dd1b9474a6a7611198cf9931dc7c32c2464fa5164b4d5e72500b16342efd2f/python/cpython/pull/11645
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/82dd1b9474a6a7611198cf9931dc7c32c2464fa5164b4d5e72500b16342efd2f/python/cpython/pull/11645
og:image:alt[UPDATE: I've rewritten this comment to match the latest state of the PR.] See the bpo issue for motivation. This is the minimal code I hope to merge into CPython. The PR here is complete excep...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegvanrossum
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/11645#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F11645
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F11645
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/11645
Reloadhttps://github.com/python/cpython/pull/11645
Reloadhttps://github.com/python/cpython/pull/11645
Please reload this pagehttps://github.com/python/cpython/pull/11645
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/11645
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
ambvhttps://github.com/ambv
python:masterhttps://github.com/python/cpython/tree/master
gvanrossum:ast-type-commentshttps://github.com/gvanrossum/cpython/tree/ast-type-comments
Conversationhttps://github.com/python/cpython/pull/11645
Commits49 (49)https://github.com/python/cpython/pull/11645/commits
Checkshttps://github.com/python/cpython/pull/11645/checks
Files changedhttps://github.com/python/cpython/pull/11645/files
bpo-35766: Merge typed_ast back into CPythonhttps://github.com/python/cpython/pull/11645#top
ambvhttps://github.com/ambv
python:masterhttps://github.com/python/cpython/tree/master
gvanrossum:ast-type-commentshttps://github.com/gvanrossum/cpython/tree/ast-type-comments
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Jan 22, 2019https://github.com/python/cpython/pull/11645#issue-401572991
Please reload this pagehttps://github.com/python/cpython/pull/11645
https://bugs.python.org/issue35766https://bugs.python.org/issue35766
Please reload this pagehttps://github.com/python/cpython/pull/11645
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
ambvhttps://github.com/ambv
ilevkivskyihttps://github.com/ilevkivskyi
January 22, 2019 02:26https://github.com/python/cpython/pull/11645#event-2087659333
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Jan 22, 2019https://github.com/python/cpython/pull/11645#event-2087659395
gvanrossumhttps://github.com/gvanrossum
January 22, 2019 08:58https://github.com/python/cpython/pull/11645#commits-pushed-77de614
https://github.com/gvanrossum
Add TYPE_IGNORE and TYPE_COMMENT without regenerating anythinghttps://github.com/python/cpython/pull/11645/commits/77de6144a453bba1834af33c99824497682ee9f1
77de614https://github.com/python/cpython/pull/11645/commits/77de6144a453bba1834af33c99824497682ee9f1
https://github.com/gvanrossum
Regenerated files (make regen-token)https://github.com/python/cpython/pull/11645/commits/8e0fd8a5681b717de68052b8822813721748b65e
8e0fd8ahttps://github.com/python/cpython/pull/11645/commits/8e0fd8a5681b717de68052b8822813721748b65e
https://github.com/gvanrossum
Tentative parsetok.c changes to handle TYPE_IGNOREhttps://github.com/python/cpython/pull/11645/commits/cb93ba56bf2ba336c84c8804b3c2c26b8f403428
cb93ba5https://github.com/python/cpython/pull/11645/commits/cb93ba56bf2ba336c84c8804b3c2c26b8f403428
https://github.com/gvanrossum
Unconditionally recognize type comments in tokenizer.chttps://github.com/python/cpython/pull/11645/commits/232f2b676a11c725af90deef4f01440bd934f832
232f2b6https://github.com/python/cpython/pull/11645/commits/232f2b676a11c725af90deef4f01440bd934f832
https://github.com/gvanrossum
Changes to Grammar without regenerating anythinghttps://github.com/python/cpython/pull/11645/commits/c80197ec528e84efba7f616385f2a42ca853af24
c80197ehttps://github.com/python/cpython/pull/11645/commits/c80197ec528e84efba7f616385f2a42ca853af24
https://github.com/gvanrossum
Regenerated files (make regen-grammar)https://github.com/python/cpython/pull/11645/commits/b440842d0849b7185262997d0cd8fec360bbd9ac
b440842https://github.com/python/cpython/pull/11645/commits/b440842d0849b7185262997d0cd8fec360bbd9ac
https://github.com/gvanrossum
Add type_comment fields to various asdl classes without regenerating …https://github.com/python/cpython/pull/11645/commits/9db5e34be2ef1f71e3848395ffaa5ef2240ca38e
9db5e34https://github.com/python/cpython/pull/11645/commits/9db5e34be2ef1f71e3848395ffaa5ef2240ca38e
https://github.com/gvanrossum
Regenerated files (make regen-ast)https://github.com/python/cpython/pull/11645/commits/6cc5a55306545238f4f989c9d2451c2fb1a576bb
6cc5a55https://github.com/python/cpython/pull/11645/commits/6cc5a55306545238f4f989c9d2451c2fb1a576bb
https://github.com/gvanrossum
Make ast.c compile by adding NULL for all type_comment argumentshttps://github.com/python/cpython/pull/11645/commits/e7f207d4d25de0248df4f71799bac12f23d3a15a
e7f207dhttps://github.com/python/cpython/pull/11645/commits/e7f207d4d25de0248df4f71799bac12f23d3a15a
https://github.com/gvanrossum
Make recognition of type comments conditional on a flag (off by default)https://github.com/python/cpython/pull/11645/commits/8b426b9dcad51ee64bb47c0cbde7236080662ce3
8b426b9https://github.com/python/cpython/pull/11645/commits/8b426b9dcad51ee64bb47c0cbde7236080662ce3
https://github.com/gvanrossum
Define flags to turn on parsing type commentshttps://github.com/python/cpython/pull/11645/commits/72e4f4d7bc516b6d7692a07b1a6c812871c4fd4a
72e4f4dhttps://github.com/python/cpython/pull/11645/commits/72e4f4d7bc516b6d7692a07b1a6c812871c4fd4a
https://github.com/gvanrossum
Support passing type ignores to Module objecthttps://github.com/python/cpython/pull/11645/commits/3d19dbb39e10d84780f2fb6ec171dfc7b3f82a7a
3d19dbbhttps://github.com/python/cpython/pull/11645/commits/3d19dbb39e10d84780f2fb6ec171dfc7b3f82a7a
https://github.com/gvanrossum
Support TYPE_COMMENT in ast.c for all nodes that need ithttps://github.com/python/cpython/pull/11645/commits/d273d6746aec19a666008afd5c1b4c2cd35807a4
d273d67https://github.com/python/cpython/pull/11645/commits/d273d6746aec19a666008afd5c1b4c2cd35807a4
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
force-pushedhttps://github.com/python/cpython/compare/e1bf9192c42c9e5c73165d7cef0c0aea4a201dea..d273d6746aec19a666008afd5c1b4c2cd35807a4
e1bf919https://github.com/python/cpython/commit/e1bf9192c42c9e5c73165d7cef0c0aea4a201dea
d273d67https://github.com/python/cpython/commit/d273d6746aec19a666008afd5c1b4c2cd35807a4
Compare https://github.com/python/cpython/compare/e1bf9192c42c9e5c73165d7cef0c0aea4a201dea..d273d6746aec19a666008afd5c1b4c2cd35807a4
January 22, 2019 17:21https://github.com/python/cpython/pull/11645#event-2089438949
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Jan 22, 2019https://github.com/python/cpython/pull/11645#issuecomment-456485948
#11605https://github.com/python/cpython/pull/11605
#11605https://github.com/python/cpython/pull/11605
Please reload this pagehttps://github.com/python/cpython/pull/11645
gvanrossumhttps://github.com/gvanrossum
January 22, 2019 09:32https://github.com/python/cpython/pull/11645#commits-pushed-830d63a
https://github.com/gvanrossum
Regenerate Lib/symbol.pyhttps://github.com/python/cpython/pull/11645/commits/830d63a57c6e713ddbef802694a355d8df4f687d
830d63ahttps://github.com/python/cpython/pull/11645/commits/830d63a57c6e713ddbef802694a355d8df4f687d
https://github.com/gvanrossum
Make growable_int_array functions statichttps://github.com/python/cpython/pull/11645/commits/71aecd553d4a03903ff0a304b56b29accc61c73d
71aecd5https://github.com/python/cpython/pull/11645/commits/71aecd553d4a03903ff0a304b56b29accc61c73d
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Jan 22, 2019https://github.com/python/cpython/pull/11645#issuecomment-456521322
Please reload this pagehttps://github.com/python/cpython/pull/11645
Please reload this pagehttps://github.com/python/cpython/pull/11645
blurb-ithttps://github.com/apps/blurb-it
January 22, 2019 11:21https://github.com/python/cpython/pull/11645#commits-pushed-53ceee6
https://github.com/apps/blurb-it
https://github.com/gvanrossum
News blurb (thank you blurb-it)https://github.com/python/cpython/pull/11645/commits/53ceee624db0e3a056bd773699f0906e601dcbbd
53ceee6https://github.com/python/cpython/pull/11645/commits/53ceee624db0e3a056bd773699f0906e601dcbbd
https://github.com/gvanrossum
Fix test_ast.pyhttps://github.com/python/cpython/pull/11645/commits/6ddca66f5ac52565a5d2591f5e35cc50854e9e7d
6ddca66https://github.com/python/cpython/pull/11645/commits/6ddca66f5ac52565a5d2591f5e35cc50854e9e7d
https://github.com/gvanrossum
Fix test_asdl_parser.pyhttps://github.com/python/cpython/pull/11645/commits/36c212bd153f044700c4fe0ff2e2312c4f364d58
36c212bhttps://github.com/python/cpython/pull/11645/commits/36c212bd153f044700c4fe0ff2e2312c4f364d58
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
force-pushedhttps://github.com/python/cpython/compare/a40849b781991b70c797b0c94c9e67f5bab22797..36c212bd153f044700c4fe0ff2e2312c4f364d58
a40849bhttps://github.com/python/cpython/commit/a40849b781991b70c797b0c94c9e67f5bab22797
36c212bhttps://github.com/python/cpython/commit/36c212bd153f044700c4fe0ff2e2312c4f364d58
Compare https://github.com/python/cpython/compare/a40849b781991b70c797b0c94c9e67f5bab22797..36c212bd153f044700c4fe0ff2e2312c4f364d58
January 22, 2019 20:56https://github.com/python/cpython/pull/11645#event-2089946336
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Jan 23, 2019 https://github.com/python/cpython/pull/11645#ref-pullrequest-318680722
[DO NOT MERGE] Fix def line numbers for decorated nodes python/typed_ast#61 https://github.com/python/typed_ast/pull/61
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Jan 23, 2019https://github.com/python/cpython/pull/11645#issuecomment-456627216
Please reload this pagehttps://github.com/python/cpython/pull/11645
this definitionhttps://github.com/gvanrossum/cpython/blob/ast-type-comments/Grammar/Grammar#L87-L88
Previouslyhttps://github.com/python/cpython/blob/master/Grammar/Grammar#L84
Python/pythonrun.c::err_inputhttps://github.com/python/cpython/blob/master/Python/pythonrun.c#L1339-L1355
Please reload this pagehttps://github.com/python/cpython/pull/11645
gvanrossumhttps://github.com/gvanrossum
January 22, 2019 20:30https://github.com/python/cpython/pull/11645#commits-pushed-d2091ed
https://github.com/gvanrossum
Hacky way to get tests to passhttps://github.com/python/cpython/pull/11645/commits/d2091edcf3ece52e10d38ec2cf2284ea435ad1a3
d2091edhttps://github.com/python/cpython/pull/11645/commits/d2091edcf3ece52e10d38ec2cf2284ea435ad1a3
https://github.com/gvanrossum
Regen Lib/symbol.py (again)https://github.com/python/cpython/pull/11645/commits/6d1f1de6e6c14a9a505c1cb6ff69c102d047b16a
6d1f1dehttps://github.com/python/cpython/pull/11645/commits/6d1f1de6e6c14a9a505c1cb6ff69c102d047b16a
https://github.com/gvanrossum
Fix assert in ast_for_suite() -- n can be a func_body_suite too nowhttps://github.com/python/cpython/pull/11645/commits/567f34132194ef45e90aa8b440a5c89bebc84f2c
567f341https://github.com/python/cpython/pull/11645/commits/567f34132194ef45e90aa8b440a5c89bebc84f2c
gvanrossumhttps://github.com/gvanrossum
January 28, 2019 11:31https://github.com/python/cpython/pull/11645#commits-pushed-98ee20a
https://github.com/gvanrossum
Add comment clarifying the func_body_suite switcheroohttps://github.com/python/cpython/pull/11645/commits/98ee20a1775fb80dda11c6a69c033415a054b367
98ee20ahttps://github.com/python/cpython/pull/11645/commits/98ee20a1775fb80dda11c6a69c033415a054b367
https://github.com/gvanrossum
Check for errors from _Py_asdl_seq_new()https://github.com/python/cpython/pull/11645/commits/4abedd3f9f46309ca9ff51189548daefc2e37e66
4abedd3https://github.com/python/cpython/pull/11645/commits/4abedd3f9f46309ca9ff51189548daefc2e37e66
https://github.com/gvanrossum
Check for NULL from NEW_TYPE_COMMENT()https://github.com/python/cpython/pull/11645/commits/551f2a645d9f954558cb389964effc6e7984932f
551f2a6https://github.com/python/cpython/pull/11645/commits/551f2a645d9f954558cb389964effc6e7984932f
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Jan 28, 2019https://github.com/python/cpython/pull/11645#issuecomment-458276207
Please reload this pagehttps://github.com/python/cpython/pull/11645
https://github.com/gvanrossum
Fix markup bughttps://github.com/python/cpython/pull/11645/commits/b68270ce090f6ccb44308e4f77f02c7819c5177d
b68270chttps://github.com/python/cpython/pull/11645/commits/b68270ce090f6ccb44308e4f77f02c7819c5177d
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Jan 30, 2019 https://github.com/python/cpython/pull/11645#pullrequestreview-197856847
View reviewed changes https://github.com/python/cpython/pull/11645/files/b68270ce090f6ccb44308e4f77f02c7819c5177d
ilevkivskyihttps://github.com/ilevkivskyi
https://github.com/python/cpython/pull/11645#pullrequestreview-197856847
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/11645
Parser/tokenizer.chttps://github.com/python/cpython/pull/11645/files/b68270ce090f6ccb44308e4f77f02c7819c5177d#diff-51e9668dbe1e270b3575209bcfcce9d3701ee0a145bdf7cef866209d9819f2ed
ilevkivskyihttps://github.com/ilevkivskyi
Jan 30, 2019https://github.com/python/cpython/pull/11645#discussion_r252077224
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/11645
gvanrossumhttps://github.com/gvanrossum
Jan 30, 2019https://github.com/python/cpython/pull/11645#discussion_r252360970
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/11645
Parser/parsetok.chttps://github.com/python/cpython/pull/11645/files/b68270ce090f6ccb44308e4f77f02c7819c5177d#diff-4f288ddeb5a08a904223ec054b3f2fa2380ecdb76951e11fe7192ea6536bae44
ilevkivskyihttps://github.com/ilevkivskyi
Jan 30, 2019https://github.com/python/cpython/pull/11645#discussion_r252077305
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/11645
Parser/tokenizer.chttps://github.com/python/cpython/pull/11645/files/b68270ce090f6ccb44308e4f77f02c7819c5177d#diff-51e9668dbe1e270b3575209bcfcce9d3701ee0a145bdf7cef866209d9819f2ed
ilevkivskyihttps://github.com/ilevkivskyi
Jan 30, 2019https://github.com/python/cpython/pull/11645#discussion_r252077417
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/11645
Python/ast.chttps://github.com/python/cpython/pull/11645/files/b68270ce090f6ccb44308e4f77f02c7819c5177d#diff-63309d32b22eaebd869b7ac0d2d4d02f95bd7ff5de2ba042d07c8e6962af8bbc
ilevkivskyihttps://github.com/ilevkivskyi
Jan 30, 2019https://github.com/python/cpython/pull/11645#discussion_r252077732
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/11645
Python/ast.chttps://github.com/python/cpython/pull/11645/files/b68270ce090f6ccb44308e4f77f02c7819c5177d#diff-63309d32b22eaebd869b7ac0d2d4d02f95bd7ff5de2ba042d07c8e6962af8bbc
ilevkivskyihttps://github.com/ilevkivskyi
Jan 30, 2019https://github.com/python/cpython/pull/11645#discussion_r252077775
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/11645
Python/ast.chttps://github.com/python/cpython/pull/11645/files/b68270ce090f6ccb44308e4f77f02c7819c5177d#diff-63309d32b22eaebd869b7ac0d2d4d02f95bd7ff5de2ba042d07c8e6962af8bbc
ilevkivskyihttps://github.com/ilevkivskyi
Jan 30, 2019https://github.com/python/cpython/pull/11645#discussion_r252077941
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/11645
gvanrossumhttps://github.com/gvanrossum
Jan 30, 2019https://github.com/python/cpython/pull/11645#discussion_r252361327
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/11645
Python/ast.chttps://github.com/python/cpython/pull/11645/files/b68270ce090f6ccb44308e4f77f02c7819c5177d#diff-63309d32b22eaebd869b7ac0d2d4d02f95bd7ff5de2ba042d07c8e6962af8bbc
ilevkivskyihttps://github.com/ilevkivskyi
Jan 30, 2019https://github.com/python/cpython/pull/11645#discussion_r252078366
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/11645
gvanrossumhttps://github.com/gvanrossum
Jan 30, 2019https://github.com/python/cpython/pull/11645#discussion_r252361556
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/11645
Python/ast.chttps://github.com/python/cpython/pull/11645/files/b68270ce090f6ccb44308e4f77f02c7819c5177d#diff-63309d32b22eaebd869b7ac0d2d4d02f95bd7ff5de2ba042d07c8e6962af8bbc
ilevkivskyihttps://github.com/ilevkivskyi
Jan 30, 2019https://github.com/python/cpython/pull/11645#discussion_r252079329
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/11645
gvanrossumhttps://github.com/gvanrossum
Jan 30, 2019https://github.com/python/cpython/pull/11645#discussion_r252361622
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/11645
Python/ast.chttps://github.com/python/cpython/pull/11645/files/b68270ce090f6ccb44308e4f77f02c7819c5177d#diff-63309d32b22eaebd869b7ac0d2d4d02f95bd7ff5de2ba042d07c8e6962af8bbc
ilevkivskyihttps://github.com/ilevkivskyi
Jan 30, 2019https://github.com/python/cpython/pull/11645#discussion_r252079502
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/11645
gvanrossumhttps://github.com/gvanrossum
Jan 30, 2019https://github.com/python/cpython/pull/11645#discussion_r252361672
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/11645
gvanrossumhttps://github.com/gvanrossum
January 30, 2019 09:18https://github.com/python/cpython/pull/11645#commits-pushed-dcf86e8
https://github.com/gvanrossum
Brace block in parsetok.chttps://github.com/python/cpython/pull/11645/commits/dcf86e88a7ca4a8b40a0223da0f6b6e41d68a2f2
dcf86e8https://github.com/python/cpython/pull/11645/commits/dcf86e88a7ca4a8b40a0223da0f6b6e41d68a2f2
https://github.com/gvanrossum
Brace a block and fix indentation of another blockhttps://github.com/python/cpython/pull/11645/commits/87812ad3cea4708b7949f0d0edb5e2d8d9626531
87812adhttps://github.com/python/cpython/pull/11645/commits/87812ad3cea4708b7949f0d0edb5e2d8d9626531
https://github.com/gvanrossum
Brace block, update grammar comment, fix indents of many ast_error callshttps://github.com/python/cpython/pull/11645/commits/5633403cab51ec2b417b83b2c5ac094ec68de7fa
5633403https://github.com/python/cpython/pull/11645/commits/5633403cab51ec2b417b83b2c5ac094ec68de7fa
https://github.com/gvanrossum
Merge branch 'master' into new-ast-type-commentshttps://github.com/python/cpython/pull/11645/commits/2062e279d59ad7a482b08059b63e2a3054768b1c
2062e27https://github.com/python/cpython/pull/11645/commits/2062e279d59ad7a482b08059b63e2a3054768b1c
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Jan 30, 2019https://github.com/python/cpython/pull/11645#issuecomment-459080557
@ambvhttps://github.com/ambv
Please reload this pagehttps://github.com/python/cpython/pull/11645
https://github.com/gvanrossum
Merge remote-tracking branch 'origin/master' into ast-type-commentshttps://github.com/python/cpython/pull/11645/commits/03310fcbf3063f8b4a4fe9124d56aa6ca7e12e34
03310fchttps://github.com/python/cpython/pull/11645/commits/03310fcbf3063f8b4a4fe9124d56aa6ca7e12e34
https://github.com/ambv
ambvhttps://github.com/ambv
Jan 30, 2019https://github.com/python/cpython/pull/11645#issuecomment-459084765
Please reload this pagehttps://github.com/python/cpython/pull/11645
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Jan 30, 2019https://github.com/python/cpython/pull/11645#issuecomment-459084960
Please reload this pagehttps://github.com/python/cpython/pull/11645
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Jan 30, 2019https://github.com/python/cpython/pull/11645#issuecomment-459086853
Please reload this pagehttps://github.com/python/cpython/pull/11645
https://github.com/zooba
zoobahttps://github.com/zooba
Jan 30, 2019https://github.com/python/cpython/pull/11645#issuecomment-459155189
https://user-images.githubusercontent.com/1693688/52020119-faa71080-24a4-11e9-9d6d-ee12c3025151.png
Please reload this pagehttps://github.com/python/cpython/pull/11645
https://github.com/gvanrossum
Break up long comment to trigger Appveyor buildhttps://github.com/python/cpython/pull/11645/commits/229874c612df868e7ae3e997e159915f49d16542
229874chttps://github.com/python/cpython/pull/11645/commits/229874c612df868e7ae3e997e159915f49d16542
https://github.com/ambv
ambvhttps://github.com/ambv
Jan 31, 2019 https://github.com/python/cpython/pull/11645#pullrequestreview-198542613
View reviewed changes https://github.com/python/cpython/pull/11645/files/229874c612df868e7ae3e997e159915f49d16542
ambvhttps://github.com/ambv
https://github.com/python/cpython/pull/11645#pullrequestreview-198542613
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@gvanrossumhttps://github.com/gvanrossum
Please reload this pagehttps://github.com/python/cpython/pull/11645
Parser/asdl_c.pyhttps://github.com/python/cpython/pull/11645/files/229874c612df868e7ae3e997e159915f49d16542#diff-c4dd13901c011c278fe5b6d175fdd23ed94e51568fe6b2ee4215d5ab376be9a8
ambvhttps://github.com/ambv
Jan 31, 2019https://github.com/python/cpython/pull/11645#discussion_r252631862
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/11645
gvanrossumhttps://github.com/gvanrossum
Jan 31, 2019https://github.com/python/cpython/pull/11645#discussion_r252750652
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/11645
https://github.com/ambv
ambvhttps://github.com/ambv
dcfcd14https://github.com/python/cpython/commit/dcfcd146f8e6fc5c2fc16a4c192a0c5f5ca8c53c
Jan 31, 2019https://github.com/python/cpython/pull/11645#event-2109174273
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Jan 31, 2019https://github.com/python/cpython/pull/11645#event-2109174389
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
Feb 1, 2019https://github.com/python/cpython/pull/11645#issuecomment-459732715
@ambvhttps://github.com/ambv
@gvanrossumhttps://github.com/gvanrossum
https://bugs.python.org/issue35881https://bugs.python.org/issue35881
Please reload this pagehttps://github.com/python/cpython/pull/11645
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Feb 1, 2019 https://github.com/python/cpython/pull/11645#ref-pullrequest-405907658
bpo-35879: Fix type comment leaks #11728 https://github.com/python/cpython/pull/11728
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
February 1, 2019 23:29https://github.com/python/cpython/pull/11645#event-2113484170
tyomitchhttps://github.com/tyomitch
Feb 5, 2019 https://github.com/python/cpython/pull/11645#ref-commit-31327c8
https://github.com/tyomitch
Update comment for builtin_compile_implhttps://github.com/tyomitch/cpython/commit/31327c84ba2cdfa9be86416f8499b4f9e8bfc4b4
31327c8https://github.com/tyomitch/cpython/commit/31327c84ba2cdfa9be86416f8499b4f9e8bfc4b4
pythonGH-11645https://github.com/python/cpython/pull/11645
https://github.com/tyomitch
tyomitchhttps://github.com/tyomitch
Feb 5, 2019 https://github.com/python/cpython/pull/11645#ref-pullrequest-406856046
Update comment for builtin_compile_impl #11762 https://github.com/python/cpython/pull/11762
https://github.com/tyomitch
tyomitchhttps://github.com/tyomitch
Feb 5, 2019https://github.com/python/cpython/pull/11645#issuecomment-460786906
GH-11762https://github.com/python/cpython/pull/11762
Please reload this pagehttps://github.com/python/cpython/pull/11645
msullivanhttps://github.com/msullivan
Feb 6, 2019 https://github.com/python/cpython/pull/11645#ref-commit-76511c0
https://github.com/msullivan
Check NEW_TYPE_COMMENT calls for failurehttps://github.com/python/typed_ast/commit/76511c026d9d0c4df1cf43f4ab391e42668a9964
76511c0https://github.com/python/typed_ast/commit/76511c026d9d0c4df1cf43f4ab391e42668a9964
python/cpython#11645https://github.com/python/cpython/pull/11645
https://github.com/msullivan
msullivanhttps://github.com/msullivan
Feb 6, 2019 https://github.com/python/cpython/pull/11645#ref-pullrequest-407033715
Check NEW_TYPE_COMMENT calls for failure python/typed_ast#93 https://github.com/python/typed_ast/pull/93
gvanrossumhttps://github.com/gvanrossum
Feb 6, 2019 https://github.com/python/cpython/pull/11645#ref-commit-f2acb2b
https://github.com/msullivan
https://github.com/gvanrossum
Check NEW_TYPE_COMMENT calls for failure (https://github.com/python/typed_ast/commit/f2acb2b3de00322e3df2310edeabee01a0f1319d
#93https://github.com/python/typed_ast/pull/93
)https://github.com/python/typed_ast/commit/f2acb2b3de00322e3df2310edeabee01a0f1319d
f2acb2bhttps://github.com/python/typed_ast/commit/f2acb2b3de00322e3df2310edeabee01a0f1319d
python/cpython#11645https://github.com/python/cpython/pull/11645
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F11645
https://github.com/gpshead
gpshead https://github.com/gpshead
https://github.com/python/cpython/pull/11645/files/8c527b71e6e7bd3a7b046b4ae56bbe1e880170db
https://github.com/zooba
zooba https://github.com/zooba
https://github.com/python/cpython/pull/11645/files/8c527b71e6e7bd3a7b046b4ae56bbe1e880170db
https://github.com/ambv
ambv https://github.com/ambv
https://github.com/python/cpython/pull/11645/files/229874c612df868e7ae3e997e159915f49d16542
https://github.com/ilevkivskyi
ilevkivskyi https://github.com/ilevkivskyi
https://github.com/python/cpython/pull/11645/files/b68270ce090f6ccb44308e4f77f02c7819c5177d
Please reload this pagehttps://github.com/python/cpython/pull/11645
https://github.com/gvanrossum
https://github.com/zooba
https://github.com/ambv
https://github.com/pablogsal
https://github.com/tyomitch
https://github.com/gpshead
https://github.com/ilevkivskyi
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.