Title: gh-116333: Relax error string text expectations in SSL-related tests by WillChilds-Klein · Pull Request #116334 · python/cpython · GitHub
Open Graph Title: gh-116333: Relax error string text expectations in SSL-related tests by WillChilds-Klein · Pull Request #116334 · python/cpython
X Title: gh-116333: Relax error string text expectations in SSL-related tests by WillChilds-Klein · Pull Request #116334 · python/cpython
Description: Description As suggested here, this change relaxes the OpenSSL error string text expectations in a number of tests. This was specifically done in support of more easily building CPython AWS-LC, but because AWS-LC is a fork of BoringSSL, it should increase compatibility with that library as well. In addition to the error string relaxations, we also add some guards around the tls-unique channel binding being used with TLSv1.3, as that feature (described in RFC 6929) is not defined for TLSv1.3. Call-outs I've omitted a NEWS entry as this PR does not change anything for end users, and does not fully provide out-of-the box support for AWS-LC on its own. Testing CPython CI local testing with AWS-LC (additional patch required) some tests still fail in local testing, but this is expected due to AWS-LC's present lack of support for TLSv1.3 post-handshake authentication local testing with system ssl system info $ openssl version && uname -r && cat /etc/*release OpenSSL 3.0.2 15 Mar 2022 (Library: OpenSSL 3.0.2 15 Mar 2022) 6.2.0-1014-aws DISTRIB_ID=Ubuntu DISTRIB_RELEASE=22.04 DISTRIB_CODENAME=jammy DISTRIB_DESCRIPTION="Ubuntu 22.04.2 LTS" PRETTY_NAME="Ubuntu 22.04.2 LTS" NAME="Ubuntu" VERSION_ID="22.04" VERSION="22.04.2 LTS (Jammy Jellyfish)" VERSION_CODENAME=jammy ID=ubuntu ID_LIKE=debian HOME_URL="https://www.ubuntu.com/" SUPPORT_URL="https://help.ubuntu.com/" BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/" PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy" UBUNTU_CODENAME=jammy Issue: gh-116333
Open Graph Description: Description As suggested here, this change relaxes the OpenSSL error string text expectations in a number of tests. This was specifically done in support of more easily building CPython AWS-LC, but...
X Description: Description As suggested here, this change relaxes the OpenSSL error string text expectations in a number of tests. This was specifically done in support of more easily building CPython AWS-LC, but...
Opengraph URL: https://github.com/python/cpython/pull/116334
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:427d2daf-4d20-15aa-ba4b-46151423433f |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | ACF0:323DD4:1BDA08A:2642864:696AB97E |
| html-safe-nonce | 5b5d5516487b1980f1889aaf33bbdfc7ff0d9671eab406ff227c1ce63ea8d5ae |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQ0YwOjMyM0RENDoxQkRBMDhBOjI2NDI4NjQ6Njk2QUI5N0UiLCJ2aXNpdG9yX2lkIjoiMjIzMjA2MjE3Mjk4NTk5NzY5NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 5583d69bfb06ba00f000c74103b934e6cef457ebb33b32644757176330b7633a |
| hovercard-subject-tag | pull_request:1755648206 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/116334/checks |
| twitter:image | https://avatars.githubusercontent.com/u/3589880?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/3589880?s=400&v=4 |
| og:image:alt | Description As suggested here, this change relaxes the OpenSSL error string text expectations in a number of tests. This was specifically done in support of more easily building CPython AWS-LC, but... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 46ce962e0e18113ea447391b6ace8b02d4d2861e57b4fbab3658698f73d8855b |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 30300f30bb3949de255e84a146706a3bdb5c19c9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width