René's URL Explorer Experiment


Title: DRAFT: limited call inlining by gvanrossum · Pull Request #116257 · python/cpython · GitHub

Open Graph Title: DRAFT: limited call inlining by gvanrossum · Pull Request #116257 · python/cpython

X Title: DRAFT: limited call inlining by gvanrossum · Pull Request #116257 · python/cpython

Description: Hey @Fidget-Spinner, I had a rainy day, so here's a very crude implementation of my idea for call inlining without frame reconstruction (only for some very limited cases). I learned a bunch of stuff -- our call sequence is rather verbose, and there are rare cases where self_of_null may unexpectedly be non-NULL. I hit an example of the latter, which crashed before I added _GUARD_NOT_METHOD as a hack, but something there feels shady. (I think this is the case where the abstract interpreter the check if (sym_is_null(self_or_null) || sym_is_not_null(self_or_null)) in the code block for _INIT_CALL_PY_EXACT_ARGS doesn't succeed. Maybe I should move the inlining code into the abstract interpreter, so it can use this same check?) Anyway, what do you think?

Open Graph Description: Hey @Fidget-Spinner, I had a rainy day, so here's a very crude implementation of my idea for call inlining without frame reconstruction (only for some very limited cases). I learned a bunch of ...

X Description: Hey @Fidget-Spinner, I had a rainy day, so here's a very crude implementation of my idea for call inlining without frame reconstruction (only for some very limited cases). I learned a bunch...

Opengraph URL: https://github.com/python/cpython/pull/116257

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:634e0e80-ab9e-37ab-d3de-647b5fa0d9b8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD2B8:8B1FC:1BCC3:256B7:6A57161B
html-safe-nonceff4e5601799fdce362a36f0a785777e992e3f197a924f9fd73f51cb0037597af
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMkI4OjhCMUZDOjFCQ0MzOjI1NkI3OjZBNTcxNjFCIiwidmlzaXRvcl9pZCI6IjQyNTQzOTEwODM4ODE0MDM5MzEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac324818aaa4e7942c97590b389e60a3858698e9e6bef78f805f4a1b7bf75b8835
hovercard-subject-tagpull_request:1753151059
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/116257/files
twitter:imagehttps://avatars.githubusercontent.com/u/2894642?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/2894642?s=400&v=4
og:image:altHey @Fidget-Spinner, I had a rainy day, so here's a very crude implementation of my idea for call inlining without frame reconstruction (only for some very limited cases). I learned a bunch of ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4e7a7296a3830877cf21a6ad2a972c9e618a48915e03966cf0c53eb08e5aad98
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2576d1f0198cf1588faf2edf27f1ed120903be10
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/116257/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F116257%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F116257%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/116257/files
Reloadhttps://github.com/python/cpython/pull/116257/files
Reloadhttps://github.com/python/cpython/pull/116257/files
Please reload this pagehttps://github.com/python/cpython/pull/116257/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/116257/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
gvanrossumhttps://github.com/gvanrossum
python:mainhttps://github.com/python/cpython/tree/main
gvanrossum:inline-callshttps://github.com/gvanrossum/cpython/tree/inline-calls
Conversation 5 https://github.com/python/cpython/pull/116257
Commits 12 https://github.com/python/cpython/pull/116257/commits
Checks 0 https://github.com/python/cpython/pull/116257/checks
Files changed https://github.com/python/cpython/pull/116257/files
Please reload this pagehttps://github.com/python/cpython/pull/116257/files
DRAFT: limited call inlining https://github.com/python/cpython/pull/116257/files#top
Show all changes 12 commits https://github.com/python/cpython/pull/116257/files
472af08 Print the final optimized uop gvanrossum Mar 2, 2024 https://github.com/python/cpython/pull/116257/commits/472af089670d05e9b46c966f3daf621e20ed48a1
aeafc38 First prototype, works for cast(int, x) gvanrossum Mar 2, 2024 https://github.com/python/cpython/pull/116257/commits/aeafc38e8447e0d0b693337cf38c7f743b3a422e
9bf95e4 More cleanup of debug output, and length adjustment gvanrossum Mar 2, 2024 https://github.com/python/cpython/pull/116257/commits/9bf95e4230cf219f0d69d6bf245b8d2698e47cac
8939a9a Tweak debug output gvanrossum Mar 2, 2024 https://github.com/python/cpython/pull/116257/commits/8939a9ae6c0bcc538cef42f26493133bead2de23
b0097a0 Fix decrefs in _ADJUST_STUFF gvanrossum Mar 2, 2024 https://github.com/python/cpython/pull/116257/commits/b0097a0279c2329a01c940a81ca2ad2e1db37c9c
7579cf3 X{INC,DEC}REF don't escape gvanrossum Mar 2, 2024 https://github.com/python/cpython/pull/116257/commits/7579cf3d5122e0197b456611027a17376024663f
a370161 Refactor call inline logic and support method calls gvanrossum Mar 2, 2024 https://github.com/python/cpython/pull/116257/commits/a370161a3684ad54287bdddfd2b4f4990fff1fee
087f8d4 Add tests gvanrossum Mar 2, 2024 https://github.com/python/cpython/pull/116257/commits/087f8d42b11c4f96a9f3d5999c94e247e289c714
215b7c2 Add _GUARD_NOT_METHOD uop gvanrossum Mar 3, 2024 https://github.com/python/cpython/pull/116257/commits/215b7c2096a15bb204eb6dcfcf800da42f70c287
0136b3a Deopt if inlined function call finds self != NULL gvanrossum Mar 3, 2024 https://github.com/python/cpython/pull/116257/commits/0136b3a9f56cd240304f78ed7ed0187a67040308
b2ef295 Comment out debug print() calls in test gvanrossum Mar 3, 2024 https://github.com/python/cpython/pull/116257/commits/b2ef2958ac9e625f5f14474ffccb73dee0a9f5a1
6c9ed1f Remove failing assert gvanrossum Mar 3, 2024 https://github.com/python/cpython/pull/116257/commits/6c9ed1ff5996882895af9444a4a0b44663cd3dec
Clear filters https://github.com/python/cpython/pull/116257/files
Please reload this pagehttps://github.com/python/cpython/pull/116257/files
Please reload this pagehttps://github.com/python/cpython/pull/116257/files
pycore_opcode_metadata.h https://github.com/python/cpython/pull/116257/files#diff-72bc4c0445516cc3eabd536220b2459617491ffaabbdb8a7c5381f36c991e378
pycore_uop_ids.h https://github.com/python/cpython/pull/116257/files#diff-2a420e4d0d58009249c0f73f7c822167b053bd51cb213b20179bd2aebfc66ff9
pycore_uop_metadata.h https://github.com/python/cpython/pull/116257/files#diff-55e65a72fa31e9b746e03076d2c74b716c0c1171663f36960b2339fcbfae9bab
test_opt.py https://github.com/python/cpython/pull/116257/files#diff-67b5bd915e37f77df79907865982648172c27d3b96fbb072b30a73c6a2735439
bytecodes.c https://github.com/python/cpython/pull/116257/files#diff-729a985b0cb8b431cb291f1edb561bbbfea22e3f8c262451cd83328a0936a342
executor_cases.c.h https://github.com/python/cpython/pull/116257/files#diff-a1c3430c42a66c16e6d2e154491a6da993b187b27c628545a12a02c7b2a06b81
optimizer.c https://github.com/python/cpython/pull/116257/files#diff-de09f74c4306be5ef0284d665091976873569094d645a35b48467ea2a11d67f7
optimizer_analysis.c https://github.com/python/cpython/pull/116257/files#diff-eac5ab7e741b8b825a24d31a5bf844e86086431fb698cfcabe1277b68c375ca2
optimizer_cases.c.h https://github.com/python/cpython/pull/116257/files#diff-ed4567b3e67709ec57bf4df91ef058cfcbe00d7da11cd2a75e38241fa1ca99d2
analyzer.py https://github.com/python/cpython/pull/116257/files#diff-bf1d5618934b787df486d8077f48217f17bf4321b9a151528f67b6e6f383976b
Include/internal/pycore_opcode_metadata.hhttps://github.com/python/cpython/pull/116257/files#diff-72bc4c0445516cc3eabd536220b2459617491ffaabbdb8a7c5381f36c991e378
View file https://github.com/gvanrossum/cpython/blob/6c9ed1ff5996882895af9444a4a0b44663cd3dec/Include/internal/pycore_opcode_metadata.h
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/116257/files
Include/internal/pycore_uop_ids.hhttps://github.com/python/cpython/pull/116257/files#diff-2a420e4d0d58009249c0f73f7c822167b053bd51cb213b20179bd2aebfc66ff9
View file https://github.com/gvanrossum/cpython/blob/6c9ed1ff5996882895af9444a4a0b44663cd3dec/Include/internal/pycore_uop_ids.h
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/116257/files
Include/internal/pycore_uop_metadata.hhttps://github.com/python/cpython/pull/116257/files#diff-55e65a72fa31e9b746e03076d2c74b716c0c1171663f36960b2339fcbfae9bab
View file https://github.com/gvanrossum/cpython/blob/6c9ed1ff5996882895af9444a4a0b44663cd3dec/Include/internal/pycore_uop_metadata.h
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/116257/files
Please reload this pagehttps://github.com/python/cpython/pull/116257/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.