| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:7b24c34a-aa2a-9d93-4815-ac07f367732c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9E2A:141056:A19AA:CFDCA:6AFF8E19 |
| html-safe-nonce | 382a8749adbf5efecb3cd24fd6672ba6f31e79b13029eb20a87e6613bec0abbc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RTJBOjE0MTA1NjpBMTlBQTpDRkRDQTo2QUZGOEUxOSIsInZpc2l0b3JfaWQiOiIzMDgxNzE4NDExOTY1NzMwMzI5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 6ca66f36dd4bba5bad717574a86223f4938002b9ca4c232f2aa33c8c91c53465 |
| hovercard-subject-tag | pull_request:1748922928 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/116096/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/2c03018008ab0bd68880f36abbace2c5dd2229dd37ea25ee064685660e85fd3d/python/cpython/pull/116096 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/2c03018008ab0bd68880f36abbace2c5dd2229dd37ea25ee064685660e85fd3d/python/cpython/pull/116096 |
| og:image:alt | Resolves this issue. The main goal was to permit ClassVar[Final[int]] and Final[ClassVar[int]]. This drops validation check that Final/ClassVar argument is not a special form.
This does allow some ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | hmc-cs-mdrissi |
| hostname | github.com |
| expected-hostname | github.com |
| None | 587ad99a3e443b2e1cb0d3df059ec49ab54389861f13310766dfdeb615fed90d |
| turbo-cache-control | no-cache |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5bb0fb68d64881d1344f5863d809515d496801e5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/cpython/pull/116096#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F116096 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F116096 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/116096 |
| Reload | https://github.com/python/cpython/pull/116096 |
| Reload | https://github.com/python/cpython/pull/116096 |
| python | https://github.com/python |
| cpython | https://github.com/python/cpython |
| Code | https://github.com/python/cpython |
| Issues5k+ (5k+) | https://github.com/python/cpython/issues |
| Pull requests2.4k (2.4k) | https://github.com/python/cpython/pulls |
| Actions | https://github.com/python/cpython/actions |
| Projects | https://github.com/python/cpython/projects |
| Security and quality | https://github.com/python/cpython/security |
| Insights | https://github.com/python/cpython/insights |
| https://github.com/python/cpython |
| JelleZijlstra | https://github.com/JelleZijlstra |
| python:main | https://github.com/python/cpython/tree/main |
| hmc-cs-mdrissi:support_nesting_special_forms | https://github.com/hmc-cs-mdrissi/cpython/tree/support_nesting_special_forms |
| Conversation | https://github.com/python/cpython/pull/116096 |
| Commits2 (2) | https://github.com/python/cpython/pull/116096/commits |
| Checks | https://github.com/python/cpython/pull/116096/checks |
| Files changed | https://github.com/python/cpython/pull/116096/files |
| gh-89547: Support for nesting special forms like Final | https://github.com/python/cpython/pull/116096#top |
| JelleZijlstra | https://github.com/JelleZijlstra |
| python:main | https://github.com/python/cpython/tree/main |
| hmc-cs-mdrissi:support_nesting_special_forms | https://github.com/hmc-cs-mdrissi/cpython/tree/support_nesting_special_forms |
|
| https://github.com/hmc-cs-mdrissi |
| hmc-cs-mdrissi | https://github.com/hmc-cs-mdrissi |
| Feb 29, 2024 | https://github.com/python/cpython/pull/116096#issue-2160315792 |
| Please reload this page | https://github.com/python/cpython/pull/116096 |
| issue | https://github.com/python/cpython/issues/89547 |
| Clarify meaning of Final in dataclasses #89547 | https://github.com/python/cpython/issues/89547 |
| Please reload this page | https://github.com/python/cpython/pull/116096 |
|
| https://github.com/hmc-cs-mdrissi |
| Add support for nesting special forms like Final | https://github.com/python/cpython/pull/116096/commits/a7ca1f7f91d6039c8c123d507b303c8889bfe655 |
| a7ca1f7 | https://github.com/python/cpython/pull/116096/commits/a7ca1f7f91d6039c8c123d507b303c8889bfe655 |
| https://github.com/hmc-cs-mdrissi |
| hmc-cs-mdrissi | https://github.com/hmc-cs-mdrissi |
| AlexWaygood | https://github.com/AlexWaygood |
| JelleZijlstra | https://github.com/JelleZijlstra |
| code owners | https://github.com/python/cpython/blob/86e5e063aba76a7f4fc58f7d06b17b0a4730fd8e/.github/CODEOWNERS#L209 |
| February 29, 2024 04:11 | https://github.com/python/cpython/pull/116096#event-11960355132 |
| https://github.com/ghost |
| ghost | https://github.com/ghost |
| Feb 29, 2024 | https://github.com/python/cpython/pull/116096#issuecomment-1970362167 |
| Please reload this page | https://github.com/python/cpython/pull/116096 |
| https://cpython-clabot.herokuapp.com/signed-contributor-license-agreement?version=96a49432-b8b1-11ec-9bf5-bfe9ad6c72c4 |
| Please reload this page | https://github.com/python/cpython/pull/116096 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Feb 29, 2024 | https://github.com/python/cpython/pull/116096#event-11960355395 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
Feb 29, 2024
| https://github.com/python/cpython/pull/116096#ref-issue-1199066444 |
|
Clarify meaning of Final in dataclasses
#89547
| https://github.com/python/cpython/issues/89547 |
| https://github.com/Eclips4 |
| Eclips4 | https://github.com/Eclips4 |
|
topic-typing
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-typing |
| Feb 29, 2024 | https://github.com/python/cpython/pull/116096#event-11961687008 |
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
|
Feb 29, 2024
| https://github.com/python/cpython/pull/116096#pullrequestreview-1908182024 |
|
View reviewed changes
| https://github.com/python/cpython/pull/116096/files/a7ca1f7f91d6039c8c123d507b303c8889bfe655 |
| AlexWaygood | https://github.com/AlexWaygood |
| https://github.com/python/cpython/pull/116096#pullrequestreview-1908182024 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @JelleZijlstra | https://github.com/JelleZijlstra |
| Please reload this page | https://github.com/python/cpython/pull/116096 |
| Lib/test/test_typing.py | https://github.com/python/cpython/pull/116096/files/a7ca1f7f91d6039c8c123d507b303c8889bfe655#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d |
| Please reload this page | https://github.com/python/cpython/pull/116096 |
|
| https://github.com/hmc-cs-mdrissi |
| Add comment for special forms test | https://github.com/python/cpython/pull/116096/commits/378aaea0c6c64b49aea8c478e2a9bf5d8fa6015d |
| 378aaea | https://github.com/python/cpython/pull/116096/commits/378aaea0c6c64b49aea8c478e2a9bf5d8fa6015d |
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
|
Mar 1, 2024
| https://github.com/python/cpython/pull/116096#pullrequestreview-1911332212 |
|
View reviewed changes
| https://github.com/python/cpython/pull/116096/files/378aaea0c6c64b49aea8c478e2a9bf5d8fa6015d |
| JelleZijlstra | https://github.com/JelleZijlstra |
| https://github.com/python/cpython/pull/116096#pullrequestreview-1911332212 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/116096 |
| https://github.com/carljm |
| carljm | https://github.com/carljm |
| Mar 1, 2024 | https://github.com/python/cpython/pull/116096#issuecomment-1973888704 |
| @JelleZijlstra | https://github.com/JelleZijlstra |
| Please reload this page | https://github.com/python/cpython/pull/116096 |
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
| Mar 1, 2024 | https://github.com/python/cpython/pull/116096#issuecomment-1973899462 |
| Please reload this page | https://github.com/python/cpython/pull/116096 |
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
|
Mar 12, 2024
| https://github.com/python/cpython/pull/116096#pullrequestreview-1930162922 |
|
View reviewed changes
| https://github.com/python/cpython/pull/116096/files/378aaea0c6c64b49aea8c478e2a9bf5d8fa6015d |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Mar 12, 2024 | https://github.com/python/cpython/pull/116096#event-12083510747 |
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
| d308d33 | https://github.com/python/cpython/commit/d308d33e098d8e176f1e5169225d3cf800ed6aa1 |
| Mar 12, 2024 | https://github.com/python/cpython/pull/116096#event-12083624569 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Mar 12, 2024 | https://github.com/python/cpython/pull/116096#event-12083624925 |
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
| Mar 12, 2024 | https://github.com/python/cpython/pull/116096#issuecomment-1990919831 |
| Please reload this page | https://github.com/python/cpython/pull/116096 |
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
|
Mar 12, 2024
| https://github.com/python/cpython/pull/116096#ref-pullrequest-2182773344 |
|
gh-89547: typing.rst: Add note about change in behavior with ClassVar/Final
#116686
| https://github.com/python/cpython/pull/116686 |
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
| Mar 12, 2024 | https://github.com/python/cpython/pull/116096#issuecomment-1992665066 |
| #116686 | https://github.com/python/cpython/pull/116686 |
| Please reload this page | https://github.com/python/cpython/pull/116096 |
| adorilson | https://github.com/adorilson |
|
Mar 25, 2024
| https://github.com/python/cpython/pull/116096#ref-commit-a9334b8 |
|
| https://github.com/hmc-cs-mdrissi |
|
| https://github.com/adorilson |
| pythongh-89547 | https://github.com/python/cpython/issues/89547 |
| : Support for nesting special forms like Final ( | https://github.com/adorilson/cpython/commit/a9334b824ede841137c39a8399aae38a02d11a2f |
| python#… | https://github.com/python/cpython/pull/116096 |
| a9334b8 | https://github.com/adorilson/cpython/commit/a9334b824ede841137c39a8399aae38a02d11a2f |
| …116096 | https://github.com/python/cpython/pull/116096 |
| https://github.com/JWCS |
| JWCS | https://github.com/JWCS |
|
Mar 27, 2024
| https://github.com/python/cpython/pull/116096#ref-issue-1113513751 |
|
Allow Annotated to wrap Final and ClassVar
python/mypy#12061
| https://github.com/python/mypy/issues/12061 |
| diegorusso | https://github.com/diegorusso |
|
Apr 17, 2024
| https://github.com/python/cpython/pull/116096#ref-commit-3381773 |
|
| https://github.com/hmc-cs-mdrissi |
|
| https://github.com/diegorusso |
| pythongh-89547 | https://github.com/python/cpython/issues/89547 |
| : Support for nesting special forms like Final ( | https://github.com/diegorusso/cpython/commit/338177392db09ff80bbe5b2f6a4beac62fe5a279 |
| python#… | https://github.com/python/cpython/pull/116096 |
| 3381773 | https://github.com/diegorusso/cpython/commit/338177392db09ff80bbe5b2f6a4beac62fe5a279 |
| …116096 | https://github.com/python/cpython/pull/116096 |
| https://github.com/Viicos |
| Viicos | https://github.com/Viicos |
|
May 26, 2025
| https://github.com/python/cpython/pull/116096#ref-issue-3088352478 |
|
ClassVar[Final[T]] should be allowed
microsoft/pyright#10500
| https://github.com/microsoft/pyright/issues/10500 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F116096 |
|
| https://github.com/AlexWaygood |
|
AlexWaygood
| https://github.com/AlexWaygood |
|
| https://github.com/python/cpython/pull/116096/files/a7ca1f7f91d6039c8c123d507b303c8889bfe655 |
|
| https://github.com/JelleZijlstra |
|
JelleZijlstra
| https://github.com/JelleZijlstra |
|
| https://github.com/python/cpython/pull/116096/files/378aaea0c6c64b49aea8c478e2a9bf5d8fa6015d |
| Please reload this page | https://github.com/python/cpython/pull/116096 |
|
topic-typing
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-typing |
| Please reload this page | https://github.com/python/cpython/pull/116096 |
|
| https://github.com/hmc-cs-mdrissi |
|
| https://github.com/carljm |
|
| https://github.com/JelleZijlstra |
|
| https://github.com/AlexWaygood |
|
| https://github.com/Eclips4 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |