René's URL Explorer Experiment


Title: gh-89547: Add support for nesting special forms like Final by hmc-cs-mdrissi · Pull Request #116092 · python/cpython · GitHub

Open Graph Title: gh-89547: Add support for nesting special forms like Final by hmc-cs-mdrissi · Pull Request #116092 · python/cpython

X Title: gh-89547: Add support for nesting special forms like Final by hmc-cs-mdrissi · Pull Request #116092 · python/cpython

Description: Resolves this issue. The main goal was to permit ClassVar[Final[int]] and Final[ClassVar[int]]. This drops validation check that Final/ClassVar argument is not a special form. This does allow some silly cases like ClassVar[ClassVar[int]] but I think it's simpler to allow them then have more complex validation rules at runtime. I did not remove special form check for other forms so Union[ClassVar[int], int] remains forbidden and list[ClassVar[int]] is also forbidden. There already was a test case that list[ClassVar[int]] fails. I also added couple tests for Annotated to ensure it can nest freely with ClassVar/Final. Issue: gh-89547

Open Graph Description: Resolves this issue. The main goal was to permit ClassVar[Final[int]] and Final[ClassVar[int]]. This drops validation check that Final/ClassVar argument is not a special form. This does allow some ...

X Description: Resolves this issue. The main goal was to permit ClassVar[Final[int]] and Final[ClassVar[int]]. This drops validation check that Final/ClassVar argument is not a special form. This does allow some ...

Opengraph URL: https://github.com/python/cpython/pull/116092

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:22338dcd-e157-0b27-03e7-0a5bb064490b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDAA4:30CC09:7CD975:A777E3:6AFF9149
html-safe-nonce1042025746e1a28221609f5167984d5122ad722c223dcfece35b3b58c7e4a02a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQUE0OjMwQ0MwOTo3Q0Q5NzU6QTc3N0UzOjZBRkY5MTQ5IiwidmlzaXRvcl9pZCI6IjgwNjE0NjM1MDM5NTQ3NDM2MjUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac1a0760b7d18f697b215e80cc1cf2cca1105f40a27d6101ea1ae6394153007847
hovercard-subject-tagpull_request:1748842163
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/116092/files
twitter:imagehttps://avatars.githubusercontent.com/u/16809055?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/16809055?s=400&v=4
og:image:altResolves this issue. The main goal was to permit ClassVar[Final[int]] and Final[ClassVar[int]]. This drops validation check that Final/ClassVar argument is not a special form. This does allow some ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None2c75d045e8c84b51e2ac680086a6dd1eeaf2bc15b82137d22ee5106835d6256c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseaa486b0389431f870c0adf9d4758aaff807c2d97
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/116092/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F116092%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F116092%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/116092/files
Reloadhttps://github.com/python/cpython/pull/116092/files
Reloadhttps://github.com/python/cpython/pull/116092/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
hmc-cs-mdrissihttps://github.com/hmc-cs-mdrissi
python:mainhttps://github.com/python/cpython/tree/main
hmc-cs-mdrissi:support_nested_special_formshttps://github.com/hmc-cs-mdrissi/cpython/tree/support_nested_special_forms
Conversation 2 https://github.com/python/cpython/pull/116092
Commits 1 https://github.com/python/cpython/pull/116092/commits
Checks 0 https://github.com/python/cpython/pull/116092/checks
Files changed https://github.com/python/cpython/pull/116092/files
Please reload this pagehttps://github.com/python/cpython/pull/116092/files
gh-89547: Add support for nesting special forms like Final https://github.com/python/cpython/pull/116092/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/116092/files
880f8ed Add support for nesting special forms like Final Feb 29, 2024 https://github.com/python/cpython/pull/116092/commits/880f8edf9815e8a174b97e44e6dbc6e30bbafa41
Clear filters https://github.com/python/cpython/pull/116092/files
Please reload this pagehttps://github.com/python/cpython/pull/116092/files
Please reload this pagehttps://github.com/python/cpython/pull/116092/files
test_typing.py https://github.com/python/cpython/pull/116092/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
typing.py https://github.com/python/cpython/pull/116092/files#diff-ddb987fca5f5df0c9a2f5521ed687919d70bb3d64eaeb8021f98833a2a716887
2024-02-28-17-50-42.gh-issue-89547.GetF38.rst https://github.com/python/cpython/pull/116092/files#diff-22c2cc4aed3c911255f73d0b6eec97e57fbeb830d643734e3b9a5baea5c49193
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L627
Lib/test/test_typing.pyhttps://github.com/python/cpython/pull/116092/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
View file https://github.com/hmc-cs-mdrissi/cpython/blob/880f8edf9815e8a174b97e44e6dbc6e30bbafa41/Lib/test/test_typing.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/116092/{{ revealButtonHref }}
https://github.com/python/cpython/pull/116092/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
https://github.com/python/cpython/pull/116092/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
https://github.com/python/cpython/pull/116092/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
https://github.com/python/cpython/pull/116092/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
https://github.com/python/cpython/pull/116092/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
https://github.com/python/cpython/pull/116092/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L629
Lib/typing.pyhttps://github.com/python/cpython/pull/116092/files#diff-ddb987fca5f5df0c9a2f5521ed687919d70bb3d64eaeb8021f98833a2a716887
View file https://github.com/hmc-cs-mdrissi/cpython/blob/880f8edf9815e8a174b97e44e6dbc6e30bbafa41/Lib/typing.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/116092/{{ revealButtonHref }}
https://github.com/python/cpython/pull/116092/files#diff-ddb987fca5f5df0c9a2f5521ed687919d70bb3d64eaeb8021f98833a2a716887
https://github.com/python/cpython/pull/116092/files#diff-ddb987fca5f5df0c9a2f5521ed687919d70bb3d64eaeb8021f98833a2a716887
https://github.com/python/cpython/pull/116092/files#diff-ddb987fca5f5df0c9a2f5521ed687919d70bb3d64eaeb8021f98833a2a716887
Misc/NEWS.d/next/Library/2024-02-28-17-50-42.gh-issue-89547.GetF38.rsthttps://github.com/python/cpython/pull/116092/files#diff-22c2cc4aed3c911255f73d0b6eec97e57fbeb830d643734e3b9a5baea5c49193
View file https://github.com/hmc-cs-mdrissi/cpython/blob/880f8edf9815e8a174b97e44e6dbc6e30bbafa41/Misc/NEWS.d/next/Library/2024-02-28-17-50-42.gh-issue-89547.GetF38.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/116092/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.