René's URL Explorer Experiment


Title: gh-112075: Avoid locking shared keys on every assignment by DinoV · Pull Request #116087 · python/cpython · GitHub

Open Graph Title: gh-112075: Avoid locking shared keys on every assignment by DinoV · Pull Request #116087 · python/cpython

X Title: gh-112075: Avoid locking shared keys on every assignment by DinoV · Pull Request #116087 · python/cpython

Description: Currently we lock the shared keys on every assignment to an instance attribute. Now that we have thread-safe gets we can use that instead. Issue: Make dict objects thread-safe in --disable-gil b...

Open Graph Description: Currently we lock the shared keys on every assignment to an instance attribute. Now that we have thread-safe gets we can use that instead. Issue: Make dict objects thread-safe in --disable-gil b...

X Description: Currently we lock the shared keys on every assignment to an instance attribute. Now that we have thread-safe gets we can use that instead. Issue: Make dict objects thread-safe in --disable-gil b...

Opengraph URL: https://github.com/python/cpython/pull/116087

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:992dd682-8598-0274-9f5b-36855aca6943
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA35E:2DE4E0:1490F3C:1B0DF6B:696B7E2C
html-safe-nonce7c5658a0ecc3d3fe02e37b69e843ebd860d04f9419aaae75385ceacd55eda32d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMzVFOjJERTRFMDoxNDkwRjNDOjFCMERGNkI6Njk2QjdFMkMiLCJ2aXNpdG9yX2lkIjoiNjY4NjU0ODM4NTQ3MDMxNjA3NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd0fc9632a0e3d0b745aae2d035345e249597c44d69cffae7d3764aae4ef5f003
hovercard-subject-tagpull_request:1748732575
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/116087/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/208818b3c271f23386134049b337e6b6dfa57faf3f28c14f3efba41c4c9be584/python/cpython/pull/116087
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/208818b3c271f23386134049b337e6b6dfa57faf3f28c14f3efba41c4c9be584/python/cpython/pull/116087
og:image:altCurrently we lock the shared keys on every assignment to an instance attribute. Now that we have thread-safe gets we can use that instead. Issue: Make dict objects thread-safe in --disable-gil b...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameDinoV
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/116087#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F116087
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F116087
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/116087
Reloadhttps://github.com/python/cpython/pull/116087
Reloadhttps://github.com/python/cpython/pull/116087
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/116087
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/116087
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/116087#issue-comment-box
DinoVhttps://github.com/DinoV
python:mainhttps://github.com/python/cpython/tree/main
DinoV:nogil_avoid_keys_lock_on_sethttps://github.com/DinoV/cpython/tree/nogil_avoid_keys_lock_on_set
gh-112075: Avoid locking shared keys on every assignment https://github.com/python/cpython/pull/116087#top
DinoVhttps://github.com/DinoV
python:mainhttps://github.com/python/cpython/tree/main
DinoV:nogil_avoid_keys_lock_on_sethttps://github.com/DinoV/cpython/tree/nogil_avoid_keys_lock_on_set
Conversation 4 https://github.com/python/cpython/pull/116087
Commits 2 https://github.com/python/cpython/pull/116087/commits
Checks 0 https://github.com/python/cpython/pull/116087/checks
Files changed https://github.com/python/cpython/pull/116087/files
Please reload this pagehttps://github.com/python/cpython/pull/116087
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/DinoV
DinoVhttps://github.com/DinoV
Feb 29, 2024https://github.com/python/cpython/pull/116087#issue-2160092804
Please reload this pagehttps://github.com/python/cpython/pull/116087
Make dict objects thread-safe in --disable-gil builds #112075https://github.com/python/cpython/issues/112075
Please reload this pagehttps://github.com/python/cpython/pull/116087
https://github.com/DinoV
DinoVhttps://github.com/DinoV
colesburyhttps://github.com/colesbury
February 29, 2024 00:10https://github.com/python/cpython/pull/116087#event-11958981290
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Feb 29, 2024 https://github.com/python/cpython/pull/116087#ref-issue-1993401425
Make dict objects thread-safe in --disable-gil builds #112075 https://github.com/python/cpython/issues/112075
https://github.com/DinoV
DinoVhttps://github.com/DinoV
topic-free-threading https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-free-threading
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Feb 29, 2024https://github.com/python/cpython/pull/116087#event-11959222019
https://github.com/DinoV
Avoid locking shared keys on every assignmenthttps://github.com/python/cpython/pull/116087/commits/22d7bfbd62dedd5cfcbae34af0bb098417d6e913
22d7bfbhttps://github.com/python/cpython/pull/116087/commits/22d7bfbd62dedd5cfcbae34af0bb098417d6e913
https://github.com/DinoV
DinoVhttps://github.com/DinoV
force-pushedhttps://github.com/python/cpython/compare/af52498c13c53db1c0b96e223e2dc66af8feacef..22d7bfbd62dedd5cfcbae34af0bb098417d6e913
af52498https://github.com/python/cpython/commit/af52498c13c53db1c0b96e223e2dc66af8feacef
22d7bfbhttps://github.com/python/cpython/commit/22d7bfbd62dedd5cfcbae34af0bb098417d6e913
Compare https://github.com/python/cpython/compare/af52498c13c53db1c0b96e223e2dc66af8feacef..22d7bfbd62dedd5cfcbae34af0bb098417d6e913
February 29, 2024 02:25https://github.com/python/cpython/pull/116087#event-11959806451
https://github.com/DinoV
DinoVhttps://github.com/DinoV
February 29, 2024 02:43https://github.com/python/cpython/pull/116087#event-11959908976
https://github.com/DinoV
DinoVhttps://github.com/DinoV
markshannonhttps://github.com/markshannon
methanehttps://github.com/methane
code ownershttps://github.com/python/cpython/blob/86e5e063aba76a7f4fc58f7d06b17b0a4730fd8e/.github/CODEOWNERS#L26
February 29, 2024 02:43https://github.com/python/cpython/pull/116087#event-11959909027
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 29, 2024https://github.com/python/cpython/pull/116087#event-11959909213
https://github.com/colesbury
colesburyhttps://github.com/colesbury
Feb 29, 2024 https://github.com/python/cpython/pull/116087#pullrequestreview-1909426393
View reviewed changes https://github.com/python/cpython/pull/116087/files/22d7bfbd62dedd5cfcbae34af0bb098417d6e913
Objects/dictobject.chttps://github.com/python/cpython/pull/116087/files/22d7bfbd62dedd5cfcbae34af0bb098417d6e913#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
Please reload this pagehttps://github.com/python/cpython/pull/116087
Objects/dictobject.chttps://github.com/python/cpython/pull/116087/files/22d7bfbd62dedd5cfcbae34af0bb098417d6e913#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
Please reload this pagehttps://github.com/python/cpython/pull/116087
Objects/dictobject.chttps://github.com/python/cpython/pull/116087/files/22d7bfbd62dedd5cfcbae34af0bb098417d6e913#diff-b08a47ddc5bc20b2e99ac2e5aa199ca24a56b994e7bc64e918513356088c20ae
Please reload this pagehttps://github.com/python/cpython/pull/116087
https://github.com/DinoV
Assert we don't get -1 from hashing exact unicode, lock in _PyObject_…https://github.com/python/cpython/pull/116087/commits/8812f5b4e3629b7ff120562156f753855d77906b
8812f5bhttps://github.com/python/cpython/pull/116087/commits/8812f5b4e3629b7ff120562156f753855d77906b
https://github.com/DinoV
DinoVhttps://github.com/DinoV
force-pushedhttps://github.com/python/cpython/compare/d6e97e9ee1c2981e04339a07932b0aa4bc81495e..8812f5b4e3629b7ff120562156f753855d77906b
d6e97e9https://github.com/python/cpython/commit/d6e97e9ee1c2981e04339a07932b0aa4bc81495e
8812f5bhttps://github.com/python/cpython/commit/8812f5b4e3629b7ff120562156f753855d77906b
Compare https://github.com/python/cpython/compare/d6e97e9ee1c2981e04339a07932b0aa4bc81495e..8812f5b4e3629b7ff120562156f753855d77906b
February 29, 2024 19:14https://github.com/python/cpython/pull/116087#event-11970402264
https://github.com/colesbury
colesburyhttps://github.com/colesbury
Feb 29, 2024 https://github.com/python/cpython/pull/116087#pullrequestreview-1909696518
View reviewed changes https://github.com/python/cpython/pull/116087/files/8812f5b4e3629b7ff120562156f753855d77906b
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 29, 2024https://github.com/python/cpython/pull/116087#event-11970457974
https://github.com/DinoV
DinoVhttps://github.com/DinoV
556749chttps://github.com/python/cpython/commit/556749c3e33f7787da149f75ca1702b80383bead
Feb 29, 2024https://github.com/python/cpython/pull/116087#event-11971775814
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Feb 29, 2024https://github.com/python/cpython/pull/116087#event-11971776208
woodruffwhttps://github.com/woodruffw
Mar 4, 2024 https://github.com/python/cpython/pull/116087#ref-commit-fcf9f14
https://github.com/DinoV
https://github.com/woodruffw
pythongh-112075https://github.com/python/cpython/issues/112075
: Avoid locking shared keys on every assignment (https://github.com/woodruffw-forks/cpython/commit/fcf9f1407d1f182c4dad394ec3d417bcc58e58e7
pytho…https://github.com/python/cpython/pull/116087
fcf9f14https://github.com/woodruffw-forks/cpython/commit/fcf9f1407d1f182c4dad394ec3d417bcc58e58e7
…n#116087https://github.com/python/cpython/pull/116087
https://github.com/DinoV
DinoVhttps://github.com/DinoV
Mar 4, 2024 https://github.com/python/cpython/pull/116087#ref-pullrequest-2167899274
gh-112075: Enable freeing with qsbr and fallback to lock on key changed #116336 https://github.com/python/cpython/pull/116336
adorilsonhttps://github.com/adorilson
Mar 25, 2024 https://github.com/python/cpython/pull/116087#ref-commit-943a1ff
https://github.com/DinoV
https://github.com/adorilson
pythongh-112075https://github.com/python/cpython/issues/112075
: Avoid locking shared keys on every assignment (https://github.com/adorilson/cpython/commit/943a1ff8a64ffbebcf41b48c778f12e606a84666
pytho…https://github.com/python/cpython/pull/116087
943a1ffhttps://github.com/adorilson/cpython/commit/943a1ff8a64ffbebcf41b48c778f12e606a84666
…n#116087https://github.com/python/cpython/pull/116087
diegorussohttps://github.com/diegorusso
Apr 17, 2024 https://github.com/python/cpython/pull/116087#ref-commit-af06784
https://github.com/DinoV
https://github.com/diegorusso
pythongh-112075https://github.com/python/cpython/issues/112075
: Avoid locking shared keys on every assignment (https://github.com/diegorusso/cpython/commit/af067849dd9d06b3738b4b353e404d68df0ead3b
pytho…https://github.com/python/cpython/pull/116087
af06784https://github.com/diegorusso/cpython/commit/af067849dd9d06b3738b4b353e404d68df0ead3b
…n#116087https://github.com/python/cpython/pull/116087
https://github.com/DinoV
DinoVhttps://github.com/DinoV
May 31, 2024 18:22https://github.com/python/cpython/pull/116087#event-13004357404
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F116087
https://github.com/colesbury
colesbury https://github.com/colesbury
https://github.com/python/cpython/pull/116087/files/8812f5b4e3629b7ff120562156f753855d77906b
https://github.com/methane
methane https://github.com/methane
https://github.com/markshannon
markshannon https://github.com/markshannon
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
topic-free-threading https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-free-threading
Please reload this pagehttps://github.com/python/cpython/pull/116087
https://github.com/DinoV
https://github.com/colesbury
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.