René's URL Explorer Experiment


Title: gh-115832: Fix instrumentation version mismatch during interpreter shutdown by swtaarrs · Pull Request #115856 · python/cpython · GitHub

Open Graph Title: gh-115832: Fix instrumentation version mismatch during interpreter shutdown by swtaarrs · Pull Request #115856 · python/cpython

X Title: gh-115832: Fix instrumentation version mismatch during interpreter shutdown by swtaarrs · Pull Request #115856 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: In 0749244d13412d, I introduced a bug to interpreter_clear(): it sets interp->ceval.instrumentation_version to 0, without making the corresponding change to tstate->eval_breaker (which holds ...

X Description: In 0749244d13412d, I introduced a bug to interpreter_clear(): it sets interp->ceval.instrumentation_version to 0, without making the corresponding change to tstate->eval_breaker (whic...

Opengraph URL: https://github.com/python/cpython/pull/115856

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a4b15407-61a3-4bbb-cb51-dfe27d29590c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8A28:320B78:682C07:96E81D:6A5612D2
html-safe-nonce0417a49529bcf08b96d7c921755e12e5c45fb21d766f07094aefe9b5a1869095
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTI4OjMyMEI3ODo2ODJDMDc6OTZFODFEOjZBNTYxMkQyIiwidmlzaXRvcl9pZCI6IjczMTM1Njk3NTA0OTU2NjI4MDIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac1896ee932050530bf596a9b6c7f70cd9c3ea7210205e386712d02fcff20d095d
hovercard-subject-tagpull_request:1740972530
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/115856/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/088deb3e80b6e690664b73aa3946261a026159671ee1d12887ef0c61a7dd5d72/python/cpython/pull/115856
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/088deb3e80b6e690664b73aa3946261a026159671ee1d12887ef0c61a7dd5d72/python/cpython/pull/115856
og:image:altIn 0749244d13412d, I introduced a bug to interpreter_clear(): it sets interp->ceval.instrumentation_version to 0, without making the corresponding change to tstate->eval_breaker (which holds ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameswtaarrs
hostnamegithub.com
expected-hostnamegithub.com
Nonef4368738fc918fecd9b3958f6b49218bbe60d4185f38e72e3954e11f1ad0213a
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb76b9cc70d30da50674184c9c66c56423fd0b93c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/115856#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F115856
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F115856
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/115856
Reloadhttps://github.com/python/cpython/pull/115856
Reloadhttps://github.com/python/cpython/pull/115856
Please reload this pagehttps://github.com/python/cpython/pull/115856
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/115856
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
colesburyhttps://github.com/colesbury
python:mainhttps://github.com/python/cpython/tree/main
swtaarrs:cpython-coverage.pyhttps://github.com/swtaarrs/cpython/tree/cpython-coverage.py
Conversationhttps://github.com/python/cpython/pull/115856
Commits5 (5)https://github.com/python/cpython/pull/115856/commits
Checkshttps://github.com/python/cpython/pull/115856/checks
Files changedhttps://github.com/python/cpython/pull/115856/files
gh-115832: Fix instrumentation version mismatch during interpreter shutdownhttps://github.com/python/cpython/pull/115856#top
colesburyhttps://github.com/colesbury
python:mainhttps://github.com/python/cpython/tree/main
swtaarrs:cpython-coverage.pyhttps://github.com/swtaarrs/cpython/tree/cpython-coverage.py
https://github.com/swtaarrs
swtaarrshttps://github.com/swtaarrs
Feb 23, 2024https://github.com/python/cpython/pull/115856#issue-2151354658
0749244d13412dhttps://github.com/python/cpython/commit/0749244d13412d
this version check in bytecodes.chttps://github.com/python/cpython/blob/4ee6bdfbaa792a3aa93c65c2022a89bd2d1e0894/Python/bytecodes.c#L147-L152
this one in instrumentation.chttps://github.com/python/cpython/blob/4ee6bdfbaa792a3aa93c65c2022a89bd2d1e0894/Python/instrumentation.c#L894-L895
Coverage.py test suite failure since commit 0749244d134 #115832https://github.com/python/cpython/issues/115832
Please reload this pagehttps://github.com/python/cpython/pull/115856
https://github.com/swtaarrs
pythongh-115832https://github.com/python/cpython/issues/115832
: Fix instrumentation version mismatch during interpre…https://github.com/python/cpython/pull/115856/commits/8ec580c9724c34641dd74ad559e22b13e48888bb
8ec580chttps://github.com/python/cpython/pull/115856/commits/8ec580c9724c34641dd74ad559e22b13e48888bb
python/cpython@0749244d13412dhttps://github.com/python/cpython/commit/0749244d13412d
https://github.com/python/cpython/blob/4ee6bdfbaa792a3aa93c65c2022a89bd2d1e0894/Python/bytecodes.c#L147-L152https://github.com/python/cpython/blob/4ee6bdfbaa792a3aa93c65c2022a89bd2d1e0894/Python/bytecodes.c#L147-L152
https://github.com/python/cpython/blob/4ee6bdfbaa792a3aa93c65c2022a89bd2d1e0894/Python/instrumentation.c#L894-L895https://github.com/python/cpython/blob/4ee6bdfbaa792a3aa93c65c2022a89bd2d1e0894/Python/instrumentation.c#L894-L895
pythongh-115832https://github.com/python/cpython/issues/115832
https://github.com/swtaarrs
swtaarrshttps://github.com/swtaarrs
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
gvanrossumhttps://github.com/gvanrossum
markshannonhttps://github.com/markshannon
code ownershttps://github.com/python/cpython/blob/2ec50b4a66de6be418bfad058117249d4775df0f/.github/CODEOWNERS#L52
February 23, 2024 15:50https://github.com/python/cpython/pull/115856#event-11905366541
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Feb 23, 2024https://github.com/python/cpython/pull/115856#event-11905367213
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Feb 23, 2024 https://github.com/python/cpython/pull/115856#ref-issue-2149723503
Coverage.py test suite failure since commit 0749244d134 #115832 https://github.com/python/cpython/issues/115832
https://github.com/swtaarrs
swtaarrshttps://github.com/swtaarrs
Feb 23, 2024https://github.com/python/cpython/pull/115856#issuecomment-1961571850
Please reload this pagehttps://github.com/python/cpython/pull/115856
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Feb 23, 2024https://github.com/python/cpython/pull/115856#event-11905399483
https://github.com/swtaarrs
swtaarrshttps://github.com/swtaarrs
Feb 23, 2024https://github.com/python/cpython/pull/115856#issuecomment-1961778318
Please reload this pagehttps://github.com/python/cpython/pull/115856
https://github.com/swtaarrs
swtaarrshttps://github.com/swtaarrs
February 23, 2024 18:50https://github.com/python/cpython/pull/115856#event-11907104548
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Feb 23, 2024https://github.com/python/cpython/pull/115856#event-11907104853
https://github.com/swtaarrs
Fix failing tests: don't pass inactive tstate to _Py_Instrument(), si…https://github.com/python/cpython/pull/115856/commits/8552fe03e05c29c0511b4394df33e49fcd705603
8552fe0https://github.com/python/cpython/pull/115856/commits/8552fe03e05c29c0511b4394df33e49fcd705603
https://github.com/swtaarrs
swtaarrshttps://github.com/swtaarrs
February 23, 2024 19:37https://github.com/python/cpython/pull/115856#event-11907509793
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Feb 23, 2024https://github.com/python/cpython/pull/115856#event-11907510314
https://github.com/swtaarrs
swtaarrshttps://github.com/swtaarrs
Feb 27, 2024https://github.com/python/cpython/pull/115856#event-11942019309
Coverage.py test suite failure since commit 0749244d134 #115832 https://github.com/python/cpython/issues/115832
https://github.com/swtaarrs
swtaarrshttps://github.com/swtaarrs
colesburyhttps://github.com/colesbury
February 27, 2024 22:42https://github.com/python/cpython/pull/115856#event-11943973879
https://github.com/colesbury
colesburyhttps://github.com/colesbury
Feb 28, 2024 https://github.com/python/cpython/pull/115856#pullrequestreview-1906967136
View reviewed changes https://github.com/python/cpython/pull/115856/files/8552fe03e05c29c0511b4394df33e49fcd705603
colesburyhttps://github.com/colesbury
https://github.com/python/cpython/pull/115856#pullrequestreview-1906967136
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/115856
https://github.com/swtaarrs
swtaarrshttps://github.com/swtaarrs
Feb 28, 2024https://github.com/python/cpython/pull/115856#issuecomment-1969849000
Please reload this pagehttps://github.com/python/cpython/pull/115856
swtaarrshttps://github.com/swtaarrs
February 28, 2024 12:33https://github.com/python/cpython/pull/115856#commits-pushed-2d261f5
https://github.com/swtaarrs
Move everything back to operate on interp instead of tstate, assert t…https://github.com/python/cpython/pull/115856/commits/2d261f59c1e8e3e5bcb55bae5aa1ec793f3e6b0c
2d261f5https://github.com/python/cpython/pull/115856/commits/2d261f59c1e8e3e5bcb55bae5aa1ec793f3e6b0c
https://github.com/swtaarrs
Merge remote-tracking branch 'upstream/main' into cpython-coverage.pyhttps://github.com/python/cpython/pull/115856/commits/a1b2f61f2e4efe0ac9506480cbf8a9e140221b1a
a1b2f61https://github.com/python/cpython/pull/115856/commits/a1b2f61f2e4efe0ac9506480cbf8a9e140221b1a
https://github.com/swtaarrs
Merge remote-tracking branch 'upstream/main' into cpython-coverage.pyhttps://github.com/python/cpython/pull/115856/commits/7a9c81a53ca827b586fd6b85ac787fc1edcf7159
7a9c81ahttps://github.com/python/cpython/pull/115856/commits/7a9c81a53ca827b586fd6b85ac787fc1edcf7159
https://github.com/swtaarrs
swtaarrshttps://github.com/swtaarrs
Mar 1, 2024https://github.com/python/cpython/pull/115856#issuecomment-1973642414
#116013https://github.com/python/cpython/pull/116013
Please reload this pagehttps://github.com/python/cpython/pull/115856
https://github.com/colesbury
colesburyhttps://github.com/colesbury
🔨 test-with-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-buildbots%22
Mar 1, 2024https://github.com/python/cpython/pull/115856#event-11982623696
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Mar 1, 2024https://github.com/python/cpython/pull/115856#issuecomment-1973677185
@colesburyhttps://github.com/colesbury
7a9c81ahttps://github.com/python/cpython/commit/7a9c81a53ca827b586fd6b85ac787fc1edcf7159
Please reload this pagehttps://github.com/python/cpython/pull/115856
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
🔨 test-with-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-buildbots%22
Mar 1, 2024https://github.com/python/cpython/pull/115856#event-11982624121
https://github.com/colesbury
colesburyhttps://github.com/colesbury
Mar 1, 2024 https://github.com/python/cpython/pull/115856#pullrequestreview-1911778383
View reviewed changes https://github.com/python/cpython/pull/115856/files/7a9c81a53ca827b586fd6b85ac787fc1edcf7159
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Mar 1, 2024https://github.com/python/cpython/pull/115856#event-11982763420
https://github.com/colesbury
colesburyhttps://github.com/colesbury
0adfa84https://github.com/python/cpython/commit/0adfa8482d369899e9963206a3307f423309e10c
Mar 4, 2024https://github.com/python/cpython/pull/115856#event-12001717410
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Mar 4, 2024https://github.com/python/cpython/pull/115856#event-12001718254
woodruffwhttps://github.com/woodruffw
Mar 4, 2024 https://github.com/python/cpython/pull/115856#ref-commit-3d4cf5b
https://github.com/swtaarrs
https://github.com/woodruffw
pythongh-115832https://github.com/python/cpython/issues/115832
: Fix instrumentation version mismatch during interpre…https://github.com/woodruffw-forks/cpython/commit/3d4cf5b738fce4d2b6233ab140e5a00136aeb14a
3d4cf5bhttps://github.com/woodruffw-forks/cpython/commit/3d4cf5b738fce4d2b6233ab140e5a00136aeb14a
python#115856https://github.com/python/cpython/pull/115856
adorilsonhttps://github.com/adorilson
Mar 25, 2024 https://github.com/python/cpython/pull/115856#ref-commit-beb1957
https://github.com/swtaarrs
https://github.com/adorilson
pythongh-115832https://github.com/python/cpython/issues/115832
: Fix instrumentation version mismatch during interpre…https://github.com/adorilson/cpython/commit/beb1957dddd8e780923be72fa0ce9896261b6fca
beb1957https://github.com/adorilson/cpython/commit/beb1957dddd8e780923be72fa0ce9896261b6fca
python#115856https://github.com/python/cpython/pull/115856
diegorussohttps://github.com/diegorusso
Apr 17, 2024 https://github.com/python/cpython/pull/115856#ref-commit-c92bb2c
https://github.com/swtaarrs
https://github.com/diegorusso
pythongh-115832https://github.com/python/cpython/issues/115832
: Fix instrumentation version mismatch during interpre…https://github.com/diegorusso/cpython/commit/c92bb2ce42659cf2c3f35c11e155f81419480ea8
c92bb2chttps://github.com/diegorusso/cpython/commit/c92bb2ce42659cf2c3f35c11e155f81419480ea8
python#115856https://github.com/python/cpython/pull/115856
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F115856
https://github.com/colesbury
colesbury https://github.com/colesbury
https://github.com/python/cpython/pull/115856/files/7a9c81a53ca827b586fd6b85ac787fc1edcf7159
https://github.com/ericsnowcurrently
ericsnowcurrently https://github.com/ericsnowcurrently
https://github.com/markshannon
markshannon https://github.com/markshannon
https://github.com/gvanrossum
gvanrossum https://github.com/gvanrossum
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Coverage.py test suite failure since commit 0749244d134 https://github.com/python/cpython/issues/115832
Please reload this pagehttps://github.com/python/cpython/pull/115856
https://github.com/swtaarrs
https://github.com/bedevere-bot
https://github.com/colesbury
https://github.com/AlexWaygood
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.