René's URL Explorer Experiment


Title: gh-111358: Fix timeout behaviour in BaseEventLoop.shutdown_default_executor by ordinary-jamie · Pull Request #115622 · python/cpython · GitHub

Open Graph Title: gh-111358: Fix timeout behaviour in BaseEventLoop.shutdown_default_executor by ordinary-jamie · Pull Request #115622 · python/cpython

X Title: gh-111358: Fix timeout behaviour in BaseEventLoop.shutdown_default_executor by ordinary-jamie · Pull Request #115622 · python/cpython

Description: Fixes the timeout behaviour in asyncio.BaseEventLoop.shutdown_default_executor to ensure that the coroutine correctly times-out when awaiting the shutdown thread. If the timeout is reaching, the thread is left to run, and is not joined (since waiting for the thread to join in this case would exceed the timeout). The Executor is shutdown without waiting. Minor updates to _do_shutdown to ensure future isn't cancelled. This is necessary since the thread can still run and attempt to set the future result/exception Issue: gh-111358

Open Graph Description: Fixes the timeout behaviour in asyncio.BaseEventLoop.shutdown_default_executor to ensure that the coroutine correctly times-out when awaiting the shutdown thread. If the timeout is reaching, the th...

X Description: Fixes the timeout behaviour in asyncio.BaseEventLoop.shutdown_default_executor to ensure that the coroutine correctly times-out when awaiting the shutdown thread. If the timeout is reaching, the th...

Opengraph URL: https://github.com/python/cpython/pull/115622

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3153fc3f-15cf-1705-e292-3610499f9d7d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC7D4:2CD0FB:BF0C2F:10C975F:6A4F4D43
html-safe-nonce91f8c29b95f885b0168329f8bff5c1440bed52b113b214ddf4edfc308b115bc6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDN0Q0OjJDRDBGQjpCRjBDMkY6MTBDOTc1Rjo2QTRGNEQ0MyIsInZpc2l0b3JfaWQiOiIxMjg2Mzk3NzQyNjQ2NTEyOTYzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac2acc2b1cbfb1b16fed9de8f0e4ee1cdc363e4b94522dfbeef7d712758f37f208
hovercard-subject-tagpull_request:1731413264
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/115622/files
twitter:imagehttps://avatars.githubusercontent.com/u/101677823?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/101677823?s=400&v=4
og:image:altFixes the timeout behaviour in asyncio.BaseEventLoop.shutdown_default_executor to ensure that the coroutine correctly times-out when awaiting the shutdown thread. If the timeout is reaching, the th...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/115622/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F115622%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F115622%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/115622/files
Reloadhttps://github.com/python/cpython/pull/115622/files
Reloadhttps://github.com/python/cpython/pull/115622/files
Please reload this pagehttps://github.com/python/cpython/pull/115622/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/115622/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
gvanrossumhttps://github.com/gvanrossum
python:mainhttps://github.com/python/cpython/tree/main
ordinary-jamie:asyncio-executor-shut-timeouthttps://github.com/ordinary-jamie/cpython/tree/asyncio-executor-shut-timeout
Conversation 8 https://github.com/python/cpython/pull/115622
Commits 3 https://github.com/python/cpython/pull/115622/commits
Checks 0 https://github.com/python/cpython/pull/115622/checks
Files changed https://github.com/python/cpython/pull/115622/files
Please reload this pagehttps://github.com/python/cpython/pull/115622/files
gh-111358: Fix timeout behaviour in BaseEventLoop.shutdown_default_executor https://github.com/python/cpython/pull/115622/files#top
Show all changes 3 commits https://github.com/python/cpython/pull/115622/files
d0a7d40 Fix timeout behaviour in BaseEventLoop.shutdown_default_executor ordinary-jamie Feb 18, 2024 https://github.com/python/cpython/pull/115622/commits/d0a7d405ad738ba7e362e17a4d424f68ec3ac412
a120c87 Fix unit test raising warnings ordinary-jamie Feb 18, 2024 https://github.com/python/cpython/pull/115622/commits/a120c87f12588c2b09a47f21e6c3504300e79cb4
c34ef8a Use correct method for testing warnings ordinary-jamie Feb 18, 2024 https://github.com/python/cpython/pull/115622/commits/c34ef8a6064ed4b34db3011ee23682ba92ae29c8
Clear filters https://github.com/python/cpython/pull/115622/files
Please reload this pagehttps://github.com/python/cpython/pull/115622/files
Please reload this pagehttps://github.com/python/cpython/pull/115622/files
base_events.py https://github.com/python/cpython/pull/115622/files#diff-7962e1627bc1bfbce13bef0be78d5ef7fc962f99bbc524a199ef489852ca1344
test_base_events.py https://github.com/python/cpython/pull/115622/files#diff-e5cbeae2e72425359e2b5f2b5f9488b699b5f3bd90cc2d639936109ee60b4819
2024-02-18-12-18-12.gh-issue-111358.9yJUMD.rst https://github.com/python/cpython/pull/115622/files#diff-7179e51f61f7c232c8bbfb9a01315be332f79d933e280aaff5a2bd714c873690
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L379
Lib/asyncio/base_events.pyhttps://github.com/python/cpython/pull/115622/files#diff-7962e1627bc1bfbce13bef0be78d5ef7fc962f99bbc524a199ef489852ca1344
View file https://github.com/ordinary-jamie/cpython/blob/c34ef8a6064ed4b34db3011ee23682ba92ae29c8/Lib/asyncio/base_events.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/115622/{{ revealButtonHref }}
https://github.com/python/cpython/pull/115622/files#diff-7962e1627bc1bfbce13bef0be78d5ef7fc962f99bbc524a199ef489852ca1344
https://github.com/python/cpython/pull/115622/files#diff-7962e1627bc1bfbce13bef0be78d5ef7fc962f99bbc524a199ef489852ca1344
https://github.com/python/cpython/pull/115622/files#diff-7962e1627bc1bfbce13bef0be78d5ef7fc962f99bbc524a199ef489852ca1344
https://github.com/python/cpython/pull/115622/files#diff-7962e1627bc1bfbce13bef0be78d5ef7fc962f99bbc524a199ef489852ca1344
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L380
Lib/test/test_asyncio/test_base_events.pyhttps://github.com/python/cpython/pull/115622/files#diff-e5cbeae2e72425359e2b5f2b5f9488b699b5f3bd90cc2d639936109ee60b4819
View file https://github.com/ordinary-jamie/cpython/blob/c34ef8a6064ed4b34db3011ee23682ba92ae29c8/Lib/test/test_asyncio/test_base_events.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/115622/{{ revealButtonHref }}
https://github.com/python/cpython/pull/115622/files#diff-e5cbeae2e72425359e2b5f2b5f9488b699b5f3bd90cc2d639936109ee60b4819
https://github.com/python/cpython/pull/115622/files#diff-e5cbeae2e72425359e2b5f2b5f9488b699b5f3bd90cc2d639936109ee60b4819
Misc/NEWS.d/next/Library/2024-02-18-12-18-12.gh-issue-111358.9yJUMD.rsthttps://github.com/python/cpython/pull/115622/files#diff-7179e51f61f7c232c8bbfb9a01315be332f79d933e280aaff5a2bd714c873690
View file https://github.com/ordinary-jamie/cpython/blob/c34ef8a6064ed4b34db3011ee23682ba92ae29c8/Misc/NEWS.d/next/Library/2024-02-18-12-18-12.gh-issue-111358.9yJUMD.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/115622/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.