René's URL Explorer Experiment


Title: gh-111358: Fix timeout behaviour in BaseEventLoop.shutdown_default_executor by ordinary-jamie · Pull Request #115622 · python/cpython · GitHub

Open Graph Title: gh-111358: Fix timeout behaviour in BaseEventLoop.shutdown_default_executor by ordinary-jamie · Pull Request #115622 · python/cpython

X Title: gh-111358: Fix timeout behaviour in BaseEventLoop.shutdown_default_executor by ordinary-jamie · Pull Request #115622 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Fixes the timeout behaviour in asyncio.BaseEventLoop.shutdown_default_executor to ensure that the coroutine correctly times-out when awaiting the shutdown thread. If the timeout is reaching, the th...

X Description: Fixes the timeout behaviour in asyncio.BaseEventLoop.shutdown_default_executor to ensure that the coroutine correctly times-out when awaiting the shutdown thread. If the timeout is reaching, the th...

Opengraph URL: https://github.com/python/cpython/pull/115622

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f602e0ba-6054-f36d-6dc4-3058694a9e7b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA2C2:6EB9C:BF29C1:1075167:6A4DE505
html-safe-nonce2d5527e8bf3dc8e6f80aad3ba791db3e420476682be0ac3cc6323eb8274d7e4f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMkMyOjZFQjlDOkJGMjlDMToxMDc1MTY3OjZBNERFNTA1IiwidmlzaXRvcl9pZCI6IjQ0NTI2MzAwODgzMTYyMTY1ODIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac36ba845f01906f1a5498a55456434722a2123a70c4533113184d6d1e107ee19d
hovercard-subject-tagpull_request:1731413264
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/115622/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a3450a090808f3befdb7a9dfd6813f324fc2629060348eac2e811447345ed7fe/python/cpython/pull/115622
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a3450a090808f3befdb7a9dfd6813f324fc2629060348eac2e811447345ed7fe/python/cpython/pull/115622
og:image:altFixes the timeout behaviour in asyncio.BaseEventLoop.shutdown_default_executor to ensure that the coroutine correctly times-out when awaiting the shutdown thread. If the timeout is reaching, the th...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameordinary-jamie
hostnamegithub.com
expected-hostnamegithub.com
None06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release1d344bdb7547fe6bca17a59bb2b8aac3dc9532a0
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/115622#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F115622
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F115622
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/115622
Reloadhttps://github.com/python/cpython/pull/115622
Reloadhttps://github.com/python/cpython/pull/115622
Please reload this pagehttps://github.com/python/cpython/pull/115622
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/115622
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
gvanrossumhttps://github.com/gvanrossum
python:mainhttps://github.com/python/cpython/tree/main
ordinary-jamie:asyncio-executor-shut-timeouthttps://github.com/ordinary-jamie/cpython/tree/asyncio-executor-shut-timeout
Conversationhttps://github.com/python/cpython/pull/115622
Commits3 (3)https://github.com/python/cpython/pull/115622/commits
Checkshttps://github.com/python/cpython/pull/115622/checks
Files changedhttps://github.com/python/cpython/pull/115622/files
gh-111358: Fix timeout behaviour in BaseEventLoop.shutdown_default_executorhttps://github.com/python/cpython/pull/115622#top
gvanrossumhttps://github.com/gvanrossum
python:mainhttps://github.com/python/cpython/tree/main
ordinary-jamie:asyncio-executor-shut-timeouthttps://github.com/ordinary-jamie/cpython/tree/asyncio-executor-shut-timeout
https://github.com/ordinary-jamie
ordinary-jamiehttps://github.com/ordinary-jamie
Feb 18, 2024https://github.com/python/cpython/pull/115622#issue-2140687578
Please reload this pagehttps://github.com/python/cpython/pull/115622
shutdown_default_executor / wait_for_tstate_lock deadlock (?) after Ctrl+C #111358https://github.com/python/cpython/issues/111358
Please reload this pagehttps://github.com/python/cpython/pull/115622
https://github.com/ordinary-jamie
Fix timeout behaviour in BaseEventLoop.shutdown_default_executorhttps://github.com/python/cpython/pull/115622/commits/d0a7d405ad738ba7e362e17a4d424f68ec3ac412
d0a7d40https://github.com/python/cpython/pull/115622/commits/d0a7d405ad738ba7e362e17a4d424f68ec3ac412
https://github.com/ordinary-jamie
ordinary-jamiehttps://github.com/ordinary-jamie
1st1https://github.com/1st1
asvetlovhttps://github.com/asvetlov
gvanrossumhttps://github.com/gvanrossum
kumaraditya303https://github.com/kumaraditya303
willingchttps://github.com/willingc
code ownershttps://github.com/python/cpython/blob/090dd21ab9379d6a2a6923d6cbab697355fb7165/.github/CODEOWNERS#L18
February 18, 2024 01:28https://github.com/python/cpython/pull/115622#event-11837573997
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Feb 18, 2024https://github.com/python/cpython/pull/115622#event-11837574055
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Feb 18, 2024 https://github.com/python/cpython/pull/115622#ref-issue-1963471803
shutdown_default_executor / wait_for_tstate_lock deadlock (?) after Ctrl+C #111358 https://github.com/python/cpython/issues/111358
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Feb 18, 2024https://github.com/python/cpython/pull/115622#issuecomment-1950959661
@ordinary-jamiehttps://github.com/ordinary-jamie
Please reload this pagehttps://github.com/python/cpython/pull/115622
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
Feb 18, 2024https://github.com/python/cpython/pull/115622#event-11837914643
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Feb 18, 2024https://github.com/python/cpython/pull/115622#issuecomment-1950965988
gh-111358https://github.com/python/cpython/issues/111358
@kumaraditya303https://github.com/kumaraditya303
gh-97561https://github.com/python/cpython/pull/97561
Please reload this pagehttps://github.com/python/cpython/pull/115622
https://github.com/ordinary-jamie
Fix unit test raising warningshttps://github.com/python/cpython/pull/115622/commits/a120c87f12588c2b09a47f21e6c3504300e79cb4
a120c87https://github.com/python/cpython/pull/115622/commits/a120c87f12588c2b09a47f21e6c3504300e79cb4
https://github.com/ordinary-jamie
ordinary-jamiehttps://github.com/ordinary-jamie
Feb 18, 2024https://github.com/python/cpython/pull/115622#issuecomment-1951445145
@ordinary-jamiehttps://github.com/ordinary-jamie
cpython/Lib/test/ssltests.pyhttps://github.com/python/cpython/blob/ded5f1f287674ad404ddd042745433388dc073a5/Lib/test/ssltests.py#L15-L19
ded5f1fhttps://github.com/python/cpython/commit/ded5f1f287674ad404ddd042745433388dc073a5
Please reload this pagehttps://github.com/python/cpython/pull/115622
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Feb 18, 2024 https://github.com/python/cpython/pull/115622#pullrequestreview-1887357473
View reviewed changes https://github.com/python/cpython/pull/115622/files/a120c87f12588c2b09a47f21e6c3504300e79cb4
Lib/test/test_asyncio/test_base_events.pyhttps://github.com/python/cpython/pull/115622/files/a120c87f12588c2b09a47f21e6c3504300e79cb4#diff-e5cbeae2e72425359e2b5f2b5f9488b699b5f3bd90cc2d639936109ee60b4819
gvanrossumhttps://github.com/gvanrossum
Feb 18, 2024https://github.com/python/cpython/pull/115622#discussion_r1493872493
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/115622
ordinary-jamiehttps://github.com/ordinary-jamie
Feb 18, 2024https://github.com/python/cpython/pull/115622#discussion_r1493877444
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/115622
https://github.com/ordinary-jamie
Use correct method for testing warningshttps://github.com/python/cpython/pull/115622/commits/c34ef8a6064ed4b34db3011ee23682ba92ae29c8
c34ef8ahttps://github.com/python/cpython/pull/115622/commits/c34ef8a6064ed4b34db3011ee23682ba92ae29c8
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Feb 18, 2024 https://github.com/python/cpython/pull/115622#pullrequestreview-1887367004
View reviewed changes https://github.com/python/cpython/pull/115622/files/c34ef8a6064ed4b34db3011ee23682ba92ae29c8
gvanrossumhttps://github.com/gvanrossum
https://github.com/python/cpython/pull/115622#pullrequestreview-1887367004
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/115622
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Feb 18, 2024https://github.com/python/cpython/pull/115622#event-11842374208
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
February 19, 2024 00:00https://github.com/python/cpython/pull/115622#event-11842374925
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
53d5e67https://github.com/python/cpython/commit/53d5e67804227d541ed2f9e8efea8de5d70cb1ec
Feb 19, 2024https://github.com/python/cpython/pull/115622#event-11842378453
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Feb 19, 2024https://github.com/python/cpython/pull/115622#issuecomment-1951491503
@ordinary-jamiehttps://github.com/ordinary-jamie
@gvanrossumhttps://github.com/gvanrossum
Please reload this pagehttps://github.com/python/cpython/pull/115622
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Feb 19, 2024https://github.com/python/cpython/pull/115622#event-11842378655
miss-islingtonhttps://github.com/miss-islington
Feb 19, 2024 https://github.com/python/cpython/pull/115622#ref-commit-a87e60e
https://github.com/ordinary-jamie
https://github.com/miss-islington
pythongh-111358https://github.com/python/cpython/issues/111358
: Fix timeout behaviour in BaseEventLoop.shutdown_defa…https://github.com/miss-islington/cpython/commit/a87e60e5dba1b0c622adaa7bd25ce4e49f2cc160
a87e60ehttps://github.com/miss-islington/cpython/commit/a87e60e5dba1b0c622adaa7bd25ce4e49f2cc160
pythonGH-115622https://github.com/python/cpython/pull/115622
53d5e67https://github.com/miss-islington/cpython/commit/53d5e67804227d541ed2f9e8efea8de5d70cb1ec
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Feb 19, 2024https://github.com/python/cpython/pull/115622#issuecomment-1951491588
GH-115641https://github.com/python/cpython/pull/115641
3.12 branchhttps://github.com/python/cpython/tree/3.12
Please reload this pagehttps://github.com/python/cpython/pull/115622
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
Feb 19, 2024https://github.com/python/cpython/pull/115622#event-11842379478
gvanrossumhttps://github.com/gvanrossum
Feb 19, 2024 https://github.com/python/cpython/pull/115622#ref-commit-e25ac3b
https://github.com/miss-islington
https://github.com/ordinary-jamie
[3.12]https://github.com/python/cpython/commit/e25ac3ba1d7c59ec2596cdc3febe0360d170afa0
gh-111358https://github.com/python/cpython/issues/111358
: Fix timeout behaviour in BaseEventLoop.shutdown_def…https://github.com/python/cpython/commit/e25ac3ba1d7c59ec2596cdc3febe0360d170afa0
e25ac3bhttps://github.com/python/cpython/commit/e25ac3ba1d7c59ec2596cdc3febe0360d170afa0
GH-115622https://github.com/python/cpython/pull/115622
#115641https://github.com/python/cpython/pull/115641
53d5e67https://github.com/python/cpython/commit/53d5e67804227d541ed2f9e8efea8de5d70cb1ec
woodruffwhttps://github.com/woodruffw
Mar 4, 2024 https://github.com/python/cpython/pull/115622#ref-commit-5fd3b1f
https://github.com/ordinary-jamie
https://github.com/woodruffw
pythongh-111358https://github.com/python/cpython/issues/111358
: Fix timeout behaviour in BaseEventLoop.shutdown_defa…https://github.com/woodruffw-forks/cpython/commit/5fd3b1f32c5ea7098b6c0d530a15607a61aa5155
5fd3b1fhttps://github.com/woodruffw-forks/cpython/commit/5fd3b1f32c5ea7098b6c0d530a15607a61aa5155
python#115622https://github.com/python/cpython/pull/115622
diegorussohttps://github.com/diegorusso
Apr 17, 2024 https://github.com/python/cpython/pull/115622#ref-commit-d74ecf8
https://github.com/ordinary-jamie
https://github.com/diegorusso
pythongh-111358https://github.com/python/cpython/issues/111358
: Fix timeout behaviour in BaseEventLoop.shutdown_defa…https://github.com/diegorusso/cpython/commit/d74ecf8ab8723c971ed90060ac88e8f4c5cff953
d74ecf8https://github.com/diegorusso/cpython/commit/d74ecf8ab8723c971ed90060ac88e8f4c5cff953
python#115622https://github.com/python/cpython/pull/115622
LukasWoodtlihttps://github.com/LukasWoodtli
Jan 22, 2025 https://github.com/python/cpython/pull/115622#ref-commit-20e0401
https://github.com/ordinary-jamie
https://github.com/LukasWoodtli
pythongh-111358https://github.com/python/cpython/issues/111358
: Fix timeout behaviour in BaseEventLoop.shutdown_defa…https://github.com/LukasWoodtli/cpython/commit/20e040103fcfde5adc4d43f0af3a5617ea14ac8c
20e0401https://github.com/LukasWoodtli/cpython/commit/20e040103fcfde5adc4d43f0af3a5617ea14ac8c
python#115622https://github.com/python/cpython/pull/115622
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F115622
https://github.com/gvanrossum
gvanrossum https://github.com/gvanrossum
https://github.com/python/cpython/pull/115622/files/c34ef8a6064ed4b34db3011ee23682ba92ae29c8
https://github.com/1st1
1st1 https://github.com/1st1
https://github.com/asvetlov
asvetlov https://github.com/asvetlov
https://github.com/kumaraditya303
kumaraditya303 https://github.com/kumaraditya303
https://github.com/willingc
willingc https://github.com/willingc
Please reload this pagehttps://github.com/python/cpython/pull/115622
https://github.com/ordinary-jamie
https://github.com/gvanrossum
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.