René's URL Explorer Experiment


Title: gh-70039: smtplib: store the server name in ._host in .connect() by nmartensen · Pull Request #115259 · python/cpython · GitHub

Open Graph Title: gh-70039: smtplib: store the server name in ._host in .connect() by nmartensen · Pull Request #115259 · python/cpython

X Title: gh-70039: smtplib: store the server name in ._host in .connect() by nmartensen · Pull Request #115259 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Original patch by gigaplastik, extended with a few more tests. Addresses: Issue: smtplib's SMTP.connect() should store the server name in ._host for .starttls() #70039 Issue: When using ...

X Description: Original patch by gigaplastik, extended with a few more tests. Addresses: Issue: smtplib's SMTP.connect() should store the server name in ._host for .starttls() #70039 Issue: When us...

Opengraph URL: https://github.com/python/cpython/pull/115259

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:c67fdd83-b951-9800-c537-2135e88fa475
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA43E:146E92:1C760FB:2979DC5:6A5645D0
html-safe-nonce737953cb0a2d25cbe98576e595a8b58f167f308911e88c2cf41141ce5401a4f4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDNFOjE0NkU5MjoxQzc2MEZCOjI5NzlEQzU6NkE1NjQ1RDAiLCJ2aXNpdG9yX2lkIjoiMTg4OTQ3NjQzMzM4NDc0OTYwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac2179849cc7999f99cc42dbd04c3cc6d05732da46bb33b487c5d872e88c8fe4fe
hovercard-subject-tagpull_request:1720745710
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/115259/commits
twitter:imagehttps://opengraph.githubassets.com/a717577f79be1c7b2ad85f8b61e3fb6186b0a0fd6d8d45069dc71ae7506a3f5f/python/cpython/pull/115259
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a717577f79be1c7b2ad85f8b61e3fb6186b0a0fd6d8d45069dc71ae7506a3f5f/python/cpython/pull/115259
og:image:altOriginal patch by gigaplastik, extended with a few more tests. Addresses: Issue: smtplib's SMTP.connect() should store the server name in ._host for .starttls() #70039 Issue: When using ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamenmartensen
hostnamegithub.com
expected-hostnamegithub.com
None96d96c6ad1e3234907759a5e634942d2ca0aded8a6ec1693a59d0f2c59c0dac9
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef0d7fddec181d430daaf48494eb476abffad4d37
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/115259/commits#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F115259%2Fcommits
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F115259%2Fcommits
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/115259/commits
Reloadhttps://github.com/python/cpython/pull/115259/commits
Reloadhttps://github.com/python/cpython/pull/115259/commits
Please reload this pagehttps://github.com/python/cpython/pull/115259/commits
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/115259/commits
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
bitdancerhttps://github.com/bitdancer
python:mainhttps://github.com/python/cpython/tree/main
nmartensen:70039_smtplib_host_porthttps://github.com/nmartensen/cpython/tree/70039_smtplib_host_port
Conversationhttps://github.com/python/cpython/pull/115259
Commits8 (8)https://github.com/python/cpython/pull/115259/commits
Checkshttps://github.com/python/cpython/pull/115259/checks
Files changedhttps://github.com/python/cpython/pull/115259/files
gh-70039: smtplib: store the server name in ._host in .connect()https://github.com/python/cpython/pull/115259/commits#top
bitdancerhttps://github.com/bitdancer
python:mainhttps://github.com/python/cpython/tree/main
nmartensen:70039_smtplib_host_porthttps://github.com/nmartensen/cpython/tree/70039_smtplib_host_port
smtplib: store the server name in ._host in .connect()https://github.com/python/cpython/pull/115259/commits/7e35eadfe888431ae00f025f2ac6e189c4b0ea98
https://github.com/nmartensen
nmartensenhttps://github.com/python/cpython/commits?author=nmartensen
7e35eadhttps://github.com/python/cpython/pull/115259/commits/7e35eadfe888431ae00f025f2ac6e189c4b0ea98
https://github.com/python/cpython/tree/7e35eadfe888431ae00f025f2ac6e189c4b0ea98
📜🤖 Added by blurb_it.https://github.com/python/cpython/pull/115259/commits/699384fe4d029c057400bbce5f0775e4052e21c8
blurb-it[bot]https://github.com/python/cpython/commits?author=blurb-it%5Bbot%5D
nmartensenhttps://github.com/python/cpython/commits?author=nmartensen
699384fhttps://github.com/python/cpython/pull/115259/commits/699384fe4d029c057400bbce5f0775e4052e21c8
https://github.com/python/cpython/tree/699384fe4d029c057400bbce5f0775e4052e21c8
move and rename testshttps://github.com/python/cpython/pull/115259/commits/5ea81fce9ee1095b25311eef460848688afce5fc
https://github.com/nmartensen
nmartensenhttps://github.com/python/cpython/commits?author=nmartensen
5ea81fchttps://github.com/python/cpython/pull/115259/commits/5ea81fce9ee1095b25311eef460848688afce5fc
https://github.com/python/cpython/tree/5ea81fce9ee1095b25311eef460848688afce5fc
Drop test_smtplib tests againhttps://github.com/python/cpython/pull/115259/commits/75f4265c1e0c037fd7c66e60107ca3c9f45f713e
https://github.com/nmartensen
nmartensenhttps://github.com/python/cpython/commits?author=nmartensen
75f4265https://github.com/python/cpython/pull/115259/commits/75f4265c1e0c037fd7c66e60107ca3c9f45f713e
https://github.com/python/cpython/tree/75f4265c1e0c037fd7c66e60107ca3c9f45f713e
Revised NEWS entryhttps://github.com/python/cpython/pull/115259/commits/8810ffbd49cdbe9d609673be388dc4a5030ce4e8
https://github.com/nmartensen
nmartensenhttps://github.com/python/cpython/commits?author=nmartensen
8810ffbhttps://github.com/python/cpython/pull/115259/commits/8810ffbd49cdbe9d609673be388dc4a5030ce4e8
https://github.com/python/cpython/tree/8810ffbd49cdbe9d609673be388dc4a5030ce4e8
add missing backticks to NEWS messagehttps://github.com/python/cpython/pull/115259/commits/eb2b5204d3a3ff02943734371c4788081a94c618
https://github.com/nmartensen
nmartensenhttps://github.com/python/cpython/commits?author=nmartensen
eb2b520https://github.com/python/cpython/pull/115259/commits/eb2b5204d3a3ff02943734371c4788081a94c618
https://github.com/python/cpython/tree/eb2b5204d3a3ff02943734371c4788081a94c618
Merge branch 'main' into 70039_smtplib_host_porthttps://github.com/python/cpython/pull/115259/commits/ffa8e28e54c7156c32f49b13d42236999ba05a98
https://github.com/nmartensen
nmartensenhttps://github.com/python/cpython/commits?author=nmartensen
ffa8e28https://github.com/python/cpython/pull/115259/commits/ffa8e28e54c7156c32f49b13d42236999ba05a98
https://github.com/python/cpython/tree/ffa8e28e54c7156c32f49b13d42236999ba05a98
NEWS entry: add missing smtplib contexthttps://github.com/python/cpython/pull/115259/commits/00355850a65c90be786e2f56aca6e8134194f7b5
https://github.com/nmartensen
nmartensenhttps://github.com/python/cpython/commits?author=nmartensen
0035585https://github.com/python/cpython/pull/115259/commits/00355850a65c90be786e2f56aca6e8134194f7b5
https://github.com/python/cpython/tree/00355850a65c90be786e2f56aca6e8134194f7b5
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.