René's URL Explorer Experiment


Title: gh-70039: smtplib: store the server name in ._host in .connect() by nmartensen · Pull Request #115259 · python/cpython · GitHub

Open Graph Title: gh-70039: smtplib: store the server name in ._host in .connect() by nmartensen · Pull Request #115259 · python/cpython

X Title: gh-70039: smtplib: store the server name in ._host in .connect() by nmartensen · Pull Request #115259 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Original patch by gigaplastik, extended with a few more tests. Addresses: Issue: smtplib's SMTP.connect() should store the server name in ._host for .starttls() #70039 Issue: When using ...

X Description: Original patch by gigaplastik, extended with a few more tests. Addresses: Issue: smtplib's SMTP.connect() should store the server name in ._host for .starttls() #70039 Issue: When us...

Opengraph URL: https://github.com/python/cpython/pull/115259

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/checks(.:format)
route-controllerpull_requests
route-actionchecks
fetch-noncev2:1fdfe940-c9af-1177-6e4f-c19f0f5c1d29
current-catalog-service-hash87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a
request-idE24E:2E80A1:43ADA73:5F97FBC:6A56BB30
html-safe-noncead13a60c51f77609718e929e0507d4ded12e8b57fcc163198cccf89d3e1d1e25
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMjRFOjJFODBBMTo0M0FEQTczOjVGOTdGQkM6NkE1NkJCMzAiLCJ2aXNpdG9yX2lkIjoiNDI3NDQ2OTY2MDg1MzE4OTQyNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace06972dd6ecb270886a9d4c3a274f65589112a1ed8c80e9dc09d5354dfeb2df8
hovercard-subject-tagpull_request:1720745710
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/checks
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/115259/checks
twitter:imagehttps://opengraph.githubassets.com/a717577f79be1c7b2ad85f8b61e3fb6186b0a0fd6d8d45069dc71ae7506a3f5f/python/cpython/pull/115259
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a717577f79be1c7b2ad85f8b61e3fb6186b0a0fd6d8d45069dc71ae7506a3f5f/python/cpython/pull/115259
og:image:altOriginal patch by gigaplastik, extended with a few more tests. Addresses: Issue: smtplib's SMTP.connect() should store the server name in ._host for .starttls() #70039 Issue: When using ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamenmartensen
hostnamegithub.com
expected-hostnamegithub.com
Nonedf99b7164e1d961b639cf5d3cbd6b5ba673edc67bd7e47cdc4746b96099e11ae
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release829f7fb08f3c7a059361601ffe917f622508969c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/115259/checks#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F115259%2Fchecks
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F115259%2Fchecks
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fchecks&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/115259/checks
Reloadhttps://github.com/python/cpython/pull/115259/checks
Reloadhttps://github.com/python/cpython/pull/115259/checks
Please reload this pagehttps://github.com/python/cpython/pull/115259/checks
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/115259/checks
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
bitdancerhttps://github.com/bitdancer
python:mainhttps://github.com/python/cpython/tree/main
nmartensen:70039_smtplib_host_porthttps://github.com/nmartensen/cpython/tree/70039_smtplib_host_port
Conversationhttps://github.com/python/cpython/pull/115259
Commits8 (8)https://github.com/python/cpython/pull/115259/commits
Checkshttps://github.com/python/cpython/pull/115259/checks
Files changedhttps://github.com/python/cpython/pull/115259/files
gh-70039: smtplib: store the server name in ._host in .connect()https://github.com/python/cpython/pull/115259/checks#top
bitdancerhttps://github.com/bitdancer
python:mainhttps://github.com/python/cpython/tree/main
nmartensen:70039_smtplib_host_porthttps://github.com/nmartensen/cpython/tree/70039_smtplib_host_port
Please reload this pagehttps://github.com/python/cpython/pull/115259/checks
Sign in for the full log viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F115259%2Fchecks
Lint on: pull_request https://github.com/python/cpython/actions/runs/20472369343
lint https://github.com/python/cpython/actions/runs/20472369343/job/58830332392?pr=115259
Check labels on: pull_request https://github.com/python/cpython/actions/runs/20472369344
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/20472369344/job/58830332260?pr=115259
Unresolved review https://github.com/python/cpython/actions/runs/20472369344/job/58830332245?pr=115259
Tests on: pull_request https://github.com/python/cpython/actions/runs/20472369350
Change detection / Create context from changed files https://github.com/python/cpython/actions/runs/20472369350/job/58830349288?pr=115259
Docs / Docs https://github.com/python/cpython/actions/runs/20472369350/job/58830379153?pr=115259
Docs / Doctest https://github.com/python/cpython/actions/runs/20472369350/job/58830379139?pr=115259
Docs / Check EPUB https://github.com/python/cpython/actions/runs/20472369350/job/58830379164?pr=115259
Check if Autoconf files are up to date https://github.com/python/cpython/actions/runs/20472369350/job/58830378954?pr=115259
Check if generated files are up to date https://github.com/python/cpython/actions/runs/20472369350/job/58830378996?pr=115259
Windows / Build and test (x64) https://github.com/python/cpython/actions/runs/20472369350/job/58830379127?pr=115259
Windows (free-threading) / Build and test (x64) https://github.com/python/cpython/actions/runs/20472369350/job/58830379131?pr=115259
Windows / Build and test (Win32) https://github.com/python/cpython/actions/runs/20472369350/job/58830379130?pr=115259
Windows / Build and test (arm64) https://github.com/python/cpython/actions/runs/20472369350/job/58830379119?pr=115259
Windows (free-threading) / Build and test (arm64) https://github.com/python/cpython/actions/runs/20472369350/job/58830379120?pr=115259
Windows MSI${{ '' }} https://github.com/python/cpython/actions/runs/20472369350/job/58830379085?pr=115259
macOS / build and test (macos-14) https://github.com/python/cpython/actions/runs/20472369350/job/58830379093?pr=115259
macOS (free-threading) / build and test (macos-14) https://github.com/python/cpython/actions/runs/20472369350/job/58830379089?pr=115259
macOS / build and test (macos-15-intel) https://github.com/python/cpython/actions/runs/20472369350/job/58830379099?pr=115259
Ubuntu / build and test (ubuntu-24.04) https://github.com/python/cpython/actions/runs/20472369350/job/58830379103?pr=115259
Ubuntu / build and test (ubuntu-24.04-arm) https://github.com/python/cpython/actions/runs/20472369350/job/58830379105?pr=115259
Ubuntu (free-threading) / build and test (ubuntu-24.04) https://github.com/python/cpython/actions/runs/20472369350/job/58830379095?pr=115259
Ubuntu (free-threading) / build and test (ubuntu-24.04-arm) https://github.com/python/cpython/actions/runs/20472369350/job/58830379112?pr=115259
Ubuntu (bolt) / build and test (ubuntu-24.04) https://github.com/python/cpython/actions/runs/20472369350/job/58830379115?pr=115259
Ubuntu SSL tests with OpenSSL (ubuntu-24.04, 1.1.1w) https://github.com/python/cpython/actions/runs/20472369350/job/58830379013?pr=115259
Ubuntu SSL tests with OpenSSL (ubuntu-24.04, 3.0.18) https://github.com/python/cpython/actions/runs/20472369350/job/58830379011?pr=115259
Ubuntu SSL tests with OpenSSL (ubuntu-24.04, 3.2.6) https://github.com/python/cpython/actions/runs/20472369350/job/58830379006?pr=115259
Ubuntu SSL tests with OpenSSL (ubuntu-24.04, 3.3.5) https://github.com/python/cpython/actions/runs/20472369350/job/58830379001?pr=115259
Ubuntu SSL tests with OpenSSL (ubuntu-24.04, 3.4.3) https://github.com/python/cpython/actions/runs/20472369350/job/58830378999?pr=115259
Ubuntu SSL tests with OpenSSL (ubuntu-24.04, 3.5.4) https://github.com/python/cpython/actions/runs/20472369350/job/58830379008?pr=115259
Ubuntu SSL tests with AWS-LC (ubuntu-24.04, 1.55.0) https://github.com/python/cpython/actions/runs/20472369350/job/58830378966?pr=115259
Android (aarch64) https://github.com/python/cpython/actions/runs/20472369350/job/58830378960?pr=115259
Android (x86_64) https://github.com/python/cpython/actions/runs/20472369350/job/58830378955?pr=115259
iOS https://github.com/python/cpython/actions/runs/20472369350/job/58830378965?pr=115259
WASI / build and test https://github.com/python/cpython/actions/runs/20472369350/job/58830379075?pr=115259
Hypothesis tests on Ubuntu https://github.com/python/cpython/actions/runs/20472369350/job/58830379018?pr=115259
Address sanitizer (ubuntu-24.04) https://github.com/python/cpython/actions/runs/20472369350/job/58830379016?pr=115259
Sanitizers / TSan https://github.com/python/cpython/actions/runs/20472369350/job/58830379117?pr=115259
Sanitizers / TSan (free-threading) https://github.com/python/cpython/actions/runs/20472369350/job/58830379135?pr=115259
Sanitizers / UBSan https://github.com/python/cpython/actions/runs/20472369350/job/58830379128?pr=115259
Cross build Linux https://github.com/python/cpython/actions/runs/20472369350/job/58830379007?pr=115259
CIFuzz https://github.com/python/cpython/actions/runs/20472369350/job/58830379091?pr=115259
All required checks pass https://github.com/python/cpython/actions/runs/20472369350/job/58831645861?pr=115259
Check labels on: pull_request https://github.com/python/cpython/actions/runs/24160392416
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/24160392416/job/70509994378?pr=115259
Unresolved review https://github.com/python/cpython/actions/runs/24160392416/job/70509994333?pr=115259
Check labels on: pull_request https://github.com/python/cpython/actions/runs/24160405636
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/24160405636/job/70510038180?pr=115259
Unresolved review https://github.com/python/cpython/actions/runs/24160405636/job/70510038221?pr=115259
Check labels on: pull_request https://github.com/python/cpython/actions/runs/24160405885
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/24160405885/job/70510039146?pr=115259
Unresolved review https://github.com/python/cpython/actions/runs/24160405885/job/70510039099?pr=115259
Check labels on: pull_request https://github.com/python/cpython/actions/runs/24160414171
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/24160414171/job/70510065992?pr=115259
Unresolved review https://github.com/python/cpython/actions/runs/24160414171/job/70510066008?pr=115259
Check labels on: pull_request https://github.com/python/cpython/actions/runs/24160417683
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/24160417683/job/70510077174?pr=115259
Unresolved review https://github.com/python/cpython/actions/runs/24160417683/job/70510077222?pr=115259
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.