René's URL Explorer Experiment


Title: GH-115060: Speed up `pathlib.Path.glob()` by removing redundant regex matching by barneygale · Pull Request #115061 · python/cpython · GitHub

Open Graph Title: GH-115060: Speed up `pathlib.Path.glob()` by removing redundant regex matching by barneygale · Pull Request #115061 · python/cpython

X Title: GH-115060: Speed up `pathlib.Path.glob()` by removing redundant regex matching by barneygale · Pull Request #115061 · python/cpython

Description: When expanding and filtering paths for a ** wildcard segment, build an re.Pattern object from the subsequent pattern parts, rather than the entire pattern, and match against the os.DirEntry object ...

Open Graph Description: When expanding and filtering paths for a ** wildcard segment, build an re.Pattern object from the subsequent pattern parts, rather than the entire pattern, and match against the os.DirEntry object ...

X Description: When expanding and filtering paths for a ** wildcard segment, build an re.Pattern object from the subsequent pattern parts, rather than the entire pattern, and match against the os.DirEntry object ...

Opengraph URL: https://github.com/python/cpython/pull/115061

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2438ca57-9d68-7ffd-8e97-3deaa14517ab
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idADD0:1272F1:248D9F9:32249E6:696AC8B5
html-safe-nonced7a747f5cf8f927fc49ceacfe8b0c4060598d2b97af8076cbb22b675623362a4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBREQwOjEyNzJGMToyNDhEOUY5OjMyMjQ5RTY6Njk2QUM4QjUiLCJ2aXNpdG9yX2lkIjoiMzUyNTA2MjA2NDU2MTg5OTcwMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf1e6d87c8d854479c54b797ecacc5216562b2d57694933d8bd878bd59fe7e34a
hovercard-subject-tagpull_request:1712913452
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/115061/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/389314d0995c25673be710853370bb22b2e16a3d8e112922df3e461d560180aa/python/cpython/pull/115061
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/389314d0995c25673be710853370bb22b2e16a3d8e112922df3e461d560180aa/python/cpython/pull/115061
og:image:altWhen expanding and filtering paths for a ** wildcard segment, build an re.Pattern object from the subsequent pattern parts, rather than the entire pattern, and match against the os.DirEntry object ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebarneygale
hostnamegithub.com
expected-hostnamegithub.com
Nonec785f4ce187e9e7331257791b36ddee01625bb8e292a9b4fe2c16d4c006abf5d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasec718a376fcf780eb22089171adb84a543f660bf7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/115061#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F115061
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F115061
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/115061
Reloadhttps://github.com/python/cpython/pull/115061
Reloadhttps://github.com/python/cpython/pull/115061
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/115061
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/115061
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/115061#issue-comment-box
barneygalehttps://github.com/barneygale
python:mainhttps://github.com/python/cpython/tree/main
barneygale:gh-115060https://github.com/barneygale/cpython/tree/gh-115060
GH-115060: Speed up pathlib.Path.glob() by removing redundant regex matching https://github.com/python/cpython/pull/115061#top
barneygalehttps://github.com/barneygale
python:mainhttps://github.com/python/cpython/tree/main
barneygale:gh-115060https://github.com/barneygale/cpython/tree/gh-115060
Conversation 10 https://github.com/python/cpython/pull/115061
Commits 10 https://github.com/python/cpython/pull/115061/commits
Checks 0 https://github.com/python/cpython/pull/115061/checks
Files changed https://github.com/python/cpython/pull/115061/files
Please reload this pagehttps://github.com/python/cpython/pull/115061
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/barneygale
barneygalehttps://github.com/barneygale
Feb 6, 2024https://github.com/python/cpython/pull/115061#issue-2119923811
Please reload this pagehttps://github.com/python/cpython/pull/115061
Speed up pathlib.Path.glob() by removing redundant regex matching #115060https://github.com/python/cpython/issues/115060
Please reload this pagehttps://github.com/python/cpython/pull/115061
https://github.com/barneygale
pythonGH-115060https://github.com/python/cpython/issues/115060
: Speed uphttps://github.com/python/cpython/pull/115061/commits/54c5aa5a9320cbb082389bf658fcf31ff7afe645
pathlib.Path.glob()https://github.com/python/cpython/pull/115061/commits/54c5aa5a9320cbb082389bf658fcf31ff7afe645
by removing redundant…https://github.com/python/cpython/pull/115061/commits/54c5aa5a9320cbb082389bf658fcf31ff7afe645
54c5aa5https://github.com/python/cpython/pull/115061/commits/54c5aa5a9320cbb082389bf658fcf31ff7afe645
https://github.com/barneygale
barneygalehttps://github.com/barneygale
performance https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Aperformance
topic-pathlib https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-pathlib
Feb 6, 2024https://github.com/python/cpython/pull/115061#event-11712703394
https://github.com/barneygale
barneygalehttps://github.com/barneygale
zoobahttps://github.com/zooba
February 6, 2024 04:10https://github.com/python/cpython/pull/115061#event-11712703421
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 6, 2024https://github.com/python/cpython/pull/115061#event-11712703756
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Feb 6, 2024 https://github.com/python/cpython/pull/115061#ref-issue-2119906994
Speed up pathlib.Path.glob() by removing redundant regex matching #115060 https://github.com/python/cpython/issues/115060
https://github.com/barneygale
barneygalehttps://github.com/barneygale
Feb 6, 2024https://github.com/python/cpython/pull/115061#issuecomment-1928758938
Please reload this pagehttps://github.com/python/cpython/pull/115061
Please reload this pagehttps://github.com/python/cpython/pull/115061
barneygalehttps://github.com/barneygale
February 6, 2024 04:58https://github.com/python/cpython/pull/115061#commits-pushed-6abb80d
https://github.com/barneygale
Match against os.DirEntry.path in _select_recursive()https://github.com/python/cpython/pull/115061/commits/6abb80da677dcec2fba0336b6c2d952e4024b6b3
6abb80dhttps://github.com/python/cpython/pull/115061/commits/6abb80da677dcec2fba0336b6c2d952e4024b6b3
https://github.com/barneygale
Matching against dot-prefixed path is fine (and faster!)https://github.com/python/cpython/pull/115061/commits/b382e400635b4dfd78c805f4f2bcdd0eae83842e
b382e40https://github.com/python/cpython/pull/115061/commits/b382e400635b4dfd78c805f4f2bcdd0eae83842e
https://github.com/barneygale
Revert "Matching against dot-prefixed path is fine (and faster!)"https://github.com/python/cpython/pull/115061/commits/e1472fc23549799473466b7d97827988bbe72684
e1472fchttps://github.com/python/cpython/pull/115061/commits/e1472fc23549799473466b7d97827988bbe72684
b382e40https://github.com/barneygale/cpython/commit/b382e400635b4dfd78c805f4f2bcdd0eae83842e
https://github.com/barneygale
Skip computing prefix len when not matchinghttps://github.com/python/cpython/pull/115061/commits/284c42e09ef3e69baee4f59da3ff4d471e9ddc81
284c42ehttps://github.com/python/cpython/pull/115061/commits/284c42e09ef3e69baee4f59da3ff4d471e9ddc81
https://github.com/zooba
zoobahttps://github.com/zooba
Feb 8, 2024https://github.com/python/cpython/pull/115061#issuecomment-1933161495
Please reload this pagehttps://github.com/python/cpython/pull/115061
https://github.com/barneygale
barneygalehttps://github.com/barneygale
Feb 8, 2024https://github.com/python/cpython/pull/115061#issuecomment-1934574924
Please reload this pagehttps://github.com/python/cpython/pull/115061
Please reload this pagehttps://github.com/python/cpython/pull/115061
https://github.com/barneygale
Rename prefix_len --> parent_len for clarity.https://github.com/python/cpython/pull/115061/commits/169b1e7e2b9c7c8bfc37d811b655070bccaa7022
169b1e7https://github.com/python/cpython/pull/115061/commits/169b1e7e2b9c7c8bfc37d811b655070bccaa7022
https://github.com/zooba
zoobahttps://github.com/zooba
Feb 8, 2024https://github.com/python/cpython/pull/115061#issuecomment-1935009659
Please reload this pagehttps://github.com/python/cpython/pull/115061
https://github.com/zooba
zoobahttps://github.com/zooba
Feb 8, 2024 https://github.com/python/cpython/pull/115061#pullrequestreview-1871349618
View reviewed changes https://github.com/python/cpython/pull/115061/files/169b1e7e2b9c7c8bfc37d811b655070bccaa7022
zoobahttps://github.com/zooba
https://github.com/python/cpython/pull/115061#pullrequestreview-1871349618
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/115061
Lib/pathlib/_abc.pyhttps://github.com/python/cpython/pull/115061/files/169b1e7e2b9c7c8bfc37d811b655070bccaa7022#diff-80172c23421c1dd13d79623c67c24cee61b300f18a55ab5d2d33d69d490abe9a
Please reload this pagehttps://github.com/python/cpython/pull/115061
Lib/pathlib/_abc.pyhttps://github.com/python/cpython/pull/115061/files/169b1e7e2b9c7c8bfc37d811b655070bccaa7022#diff-80172c23421c1dd13d79623c67c24cee61b300f18a55ab5d2d33d69d490abe9a
Please reload this pagehttps://github.com/python/cpython/pull/115061
Lib/pathlib/_abc.pyhttps://github.com/python/cpython/pull/115061/files/169b1e7e2b9c7c8bfc37d811b655070bccaa7022#diff-80172c23421c1dd13d79623c67c24cee61b300f18a55ab5d2d33d69d490abe9a
Please reload this pagehttps://github.com/python/cpython/pull/115061
Lib/pathlib/__init__.pyhttps://github.com/python/cpython/pull/115061/files/169b1e7e2b9c7c8bfc37d811b655070bccaa7022#diff-2282b1d4074c3cc317f8490ac16730aef232a3a125b8acfc49232dcd6c4f6d88
Please reload this pagehttps://github.com/python/cpython/pull/115061
barneygalehttps://github.com/barneygale
February 8, 2024 22:56https://github.com/python/cpython/pull/115061#commits-pushed-1c4184f
https://github.com/barneygale
Comments, naming.https://github.com/python/cpython/pull/115061/commits/1c4184f70dc41fa1a9475a616c71b3a7816f9676
1c4184fhttps://github.com/python/cpython/pull/115061/commits/1c4184f70dc41fa1a9475a616c71b3a7816f9676
https://github.com/barneygale
segment --> componenthttps://github.com/python/cpython/pull/115061/commits/2873ed852615b601d8916c3aaadb5b4136159024
2873ed8https://github.com/python/cpython/pull/115061/commits/2873ed852615b601d8916c3aaadb5b4136159024
https://github.com/barneygale
Test post-** matching when globbing ..https://github.com/python/cpython/pull/115061/commits/90d5a128896923a18e5d9ba8441d61c58eba29b1
90d5a12https://github.com/python/cpython/pull/115061/commits/90d5a128896923a18e5d9ba8441d61c58eba29b1
https://github.com/barneygale
Couple more test caseshttps://github.com/python/cpython/pull/115061/commits/a40924b6945b74118355d16ed3fb34f75978c3da
a40924bhttps://github.com/python/cpython/pull/115061/commits/a40924b6945b74118355d16ed3fb34f75978c3da
https://github.com/barneygale
barneygalehttps://github.com/barneygale
6f93b4dhttps://github.com/python/cpython/commit/6f93b4df92b8fbf80529cb6435789f5a75664a20
Feb 10, 2024https://github.com/python/cpython/pull/115061#event-11765380161
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Feb 10, 2024https://github.com/python/cpython/pull/115061#event-11765380233
fsc-erikerhttps://github.com/fsc-eriker
Feb 14, 2024 https://github.com/python/cpython/pull/115061#ref-commit-ee8ded0
https://github.com/barneygale
https://github.com/fsc-eriker
pythonGH-115060https://github.com/python/cpython/issues/115060
: Speed uphttps://github.com/fsc-eriker/cpython/commit/ee8ded02b8cc54a831d8e42298373d85385ff852
pathlib.Path.glob()https://github.com/fsc-eriker/cpython/commit/ee8ded02b8cc54a831d8e42298373d85385ff852
by removing redundant…https://github.com/fsc-eriker/cpython/commit/ee8ded02b8cc54a831d8e42298373d85385ff852
ee8ded0https://github.com/fsc-eriker/cpython/commit/ee8ded02b8cc54a831d8e42298373d85385ff852
python#115061https://github.com/python/cpython/pull/115061
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F115061
https://github.com/zooba
zooba https://github.com/zooba
https://github.com/python/cpython/pull/115061/files/169b1e7e2b9c7c8bfc37d811b655070bccaa7022
performance https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Aperformance
topic-pathlib https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-pathlib
Please reload this pagehttps://github.com/python/cpython/pull/115061
https://github.com/barneygale
https://github.com/zooba
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.