René's URL Explorer Experiment


Title: gh-114563: C decimal falls back to pydecimal for unsupported format strings by belm0 · Pull Request #114879 · python/cpython · GitHub

Open Graph Title: gh-114563: C decimal falls back to pydecimal for unsupported format strings by belm0 · Pull Request #114879 · python/cpython

X Title: gh-114563: C decimal falls back to pydecimal for unsupported format strings by belm0 · Pull Request #114879 · python/cpython

Description: When the mpdecimal lib fails to parse a format string, we fall back to the pydecimal format implementation. Notably this allows complex workarounds for 'z' format support to be removed. (mpdecimal added 'z' support in version 4.0.0, so this becomes efficient in the long term.) remove 'z' format implementation from C decimal fix 'z' format memory leak fix 'z' format applied to type 'F' fix missing '#' format support Suggested and prototyped by Stefan Krah. Fixes gh-114563, gh-91060

Open Graph Description: When the mpdecimal lib fails to parse a format string, we fall back to the pydecimal format implementation. Notably this allows complex workarounds for 'z' format support to be removed. (m...

X Description: When the mpdecimal lib fails to parse a format string, we fall back to the pydecimal format implementation. Notably this allows complex workarounds for 'z' format support to be remo...

Opengraph URL: https://github.com/python/cpython/pull/114879

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c92a84b9-d882-6242-70a3-422a9b1050a2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id93E2:3F8AB1:3C9DF5A:4CFBAEE:6B01EF81
html-safe-nonce3dc5b028f4d84b574480375ad64a25a585047e123e153b4a555bcbae4b0c1a2f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5M0UyOjNGOEFCMTozQzlERjVBOjRDRkJBRUU6NkIwMUVGODEiLCJ2aXNpdG9yX2lkIjoiMjc5NzcxMTM0NTg3NTgwODEzMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacdde2ae2a2135f404b78634c9cbd054f41c63307aed7f3afda1191256ddf33ed6
hovercard-subject-tagpull_request:1707109665
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/114879/files
twitter:imagehttps://avatars.githubusercontent.com/u/1708631?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1708631?s=400&v=4
og:image:altWhen the mpdecimal lib fails to parse a format string, we fall back to the pydecimal format implementation. Notably this allows complex workarounds for 'z' format support to be removed. (m...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/114879/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F114879%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F114879%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/114879/files
Reloadhttps://github.com/python/cpython/pull/114879/files
Reloadhttps://github.com/python/cpython/pull/114879/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
serhiy-storchakahttps://github.com/serhiy-storchaka
python:mainhttps://github.com/python/cpython/tree/main
belm0:fix-issue-114563https://github.com/belm0/cpython/tree/fix-issue-114563
Conversation 31 https://github.com/python/cpython/pull/114879
Commits 12 https://github.com/python/cpython/pull/114879/commits
Checks 0 https://github.com/python/cpython/pull/114879/checks
Files changed https://github.com/python/cpython/pull/114879/files
Please reload this pagehttps://github.com/python/cpython/pull/114879/files
gh-114563: C decimal falls back to pydecimal for unsupported format strings https://github.com/python/cpython/pull/114879/files#top
Show all changes 12 commits https://github.com/python/cpython/pull/114879/files
d49d679 add decimal tests belm0 Feb 1, 2024 https://github.com/python/cpython/pull/114879/commits/d49d67970ac45326a524e3112991f3570f624104
b526004 revert 'z' format support in C decimal belm0 Feb 1, 2024 https://github.com/python/cpython/pull/114879/commits/b52600420b65a91681359b55e81820d7448de2f0
6ac60d7 gh-114563: C decimal falls back to pydecimal for unsupported format s… belm0 Feb 1, 2024 https://github.com/python/cpython/pull/114879/commits/6ac60d7a08b36d476ecb3fdfcd6284f2a7706477
d37b5b8 Apply suggestions from code review belm0 Feb 10, 2024 https://github.com/python/cpython/pull/114879/commits/d37b5b81c582a8964fe83683e88660e9c4d4017b
d2b6893 disable failing null fill test belm0 Feb 10, 2024 https://github.com/python/cpython/pull/114879/commits/d2b68934089686c378a8296031e77afeb3d7393a
feb7469 only override message string on ValueError belm0 Feb 10, 2024 https://github.com/python/cpython/pull/114879/commits/feb746947d56c23fdceed389a21d35629419212f
5803d9c corrected null fill char test belm0 Feb 10, 2024 https://github.com/python/cpython/pull/114879/commits/5803d9c962aa0971ba3823ec82b699d1e0fa4da3
dcee58f honor round and capitals context in fallback belm0 Feb 11, 2024 https://github.com/python/cpython/pull/114879/commits/dcee58f3f3d5ada666954499ddc455370ddc4705
7a2ba4b format fallback context tests belm0 Feb 11, 2024 https://github.com/python/cpython/pull/114879/commits/7a2ba4bf2acccdec766c4f7e2633c5df8921c018
ab4f2d7 pass context directly to __format__() belm0 Feb 11, 2024 https://github.com/python/cpython/pull/114879/commits/ab4f2d7fea366507294a143fefb45c656ff81780
3b1b8f4 📜🤖 Added by blurb_it. blurb-it[bot] Feb 11, 2024 https://github.com/python/cpython/pull/114879/commits/3b1b8f4ee3037319d58599b6a43b6ef50a261191
06e371c fix NEWS formatting belm0 Feb 11, 2024 https://github.com/python/cpython/pull/114879/commits/06e371cf9241b0b236e31f5d0937db8e7feb14fe
Clear filters https://github.com/python/cpython/pull/114879/files
Please reload this pagehttps://github.com/python/cpython/pull/114879/files
Please reload this pagehttps://github.com/python/cpython/pull/114879/files
test_decimal.py https://github.com/python/cpython/pull/114879/files#diff-0bf3efdde952043078e322013c2459632397c6a9b312d49e70ae4a9791e2a1d8
2024-02-11-20-23-36.gh-issue-114563.RzxNYT.rst https://github.com/python/cpython/pull/114879/files#diff-749046965d3f4b443a472ecfecdfde733e93b9595bc7eb9994a262a205d5dcc4
_decimal.c https://github.com/python/cpython/pull/114879/files#diff-071237c57ffb81dd4303eb5f02e5c5a661891a31c746c8f55a97a39659ad95d6
Lib/test/test_decimal.pyhttps://github.com/python/cpython/pull/114879/files#diff-0bf3efdde952043078e322013c2459632397c6a9b312d49e70ae4a9791e2a1d8
View file https://github.com/belm0/cpython/blob/06e371cf9241b0b236e31f5d0937db8e7feb14fe/Lib/test/test_decimal.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/114879/{{ revealButtonHref }}
https://github.com/python/cpython/pull/114879/files#diff-0bf3efdde952043078e322013c2459632397c6a9b312d49e70ae4a9791e2a1d8
Please reload this pagehttps://github.com/python/cpython/pull/114879/files
https://github.com/python/cpython/pull/114879/files#diff-0bf3efdde952043078e322013c2459632397c6a9b312d49e70ae4a9791e2a1d8
https://github.com/python/cpython/pull/114879/files#diff-0bf3efdde952043078e322013c2459632397c6a9b312d49e70ae4a9791e2a1d8
https://github.com/python/cpython/pull/114879/files#diff-0bf3efdde952043078e322013c2459632397c6a9b312d49e70ae4a9791e2a1d8
Misc/NEWS.d/next/Library/2024-02-11-20-23-36.gh-issue-114563.RzxNYT.rsthttps://github.com/python/cpython/pull/114879/files#diff-749046965d3f4b443a472ecfecdfde733e93b9595bc7eb9994a262a205d5dcc4
View file https://github.com/belm0/cpython/blob/06e371cf9241b0b236e31f5d0937db8e7feb14fe/Misc/NEWS.d/next/Library/2024-02-11-20-23-36.gh-issue-114563.RzxNYT.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/114879/{{ revealButtonHref }}
Modules/_decimal/_decimal.chttps://github.com/python/cpython/pull/114879/files#diff-071237c57ffb81dd4303eb5f02e5c5a661891a31c746c8f55a97a39659ad95d6
View file https://github.com/belm0/cpython/blob/06e371cf9241b0b236e31f5d0937db8e7feb14fe/Modules/_decimal/_decimal.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/114879/{{ revealButtonHref }}
https://github.com/python/cpython/pull/114879/files#diff-071237c57ffb81dd4303eb5f02e5c5a661891a31c746c8f55a97a39659ad95d6
https://github.com/python/cpython/pull/114879/files#diff-071237c57ffb81dd4303eb5f02e5c5a661891a31c746c8f55a97a39659ad95d6
https://github.com/python/cpython/pull/114879/files#diff-071237c57ffb81dd4303eb5f02e5c5a661891a31c746c8f55a97a39659ad95d6
https://github.com/python/cpython/pull/114879/files#diff-071237c57ffb81dd4303eb5f02e5c5a661891a31c746c8f55a97a39659ad95d6
Please reload this pagehttps://github.com/python/cpython/pull/114879/files
https://github.com/python/cpython/pull/114879/files#diff-071237c57ffb81dd4303eb5f02e5c5a661891a31c746c8f55a97a39659ad95d6
Please reload this pagehttps://github.com/python/cpython/pull/114879/files
https://github.com/python/cpython/pull/114879/files#diff-071237c57ffb81dd4303eb5f02e5c5a661891a31c746c8f55a97a39659ad95d6
https://github.com/python/cpython/pull/114879/files#diff-071237c57ffb81dd4303eb5f02e5c5a661891a31c746c8f55a97a39659ad95d6
https://github.com/python/cpython/pull/114879/files#diff-071237c57ffb81dd4303eb5f02e5c5a661891a31c746c8f55a97a39659ad95d6
https://github.com/python/cpython/pull/114879/files#diff-071237c57ffb81dd4303eb5f02e5c5a661891a31c746c8f55a97a39659ad95d6
https://github.com/python/cpython/pull/114879/files#diff-071237c57ffb81dd4303eb5f02e5c5a661891a31c746c8f55a97a39659ad95d6
https://github.com/python/cpython/pull/114879/files#diff-071237c57ffb81dd4303eb5f02e5c5a661891a31c746c8f55a97a39659ad95d6
https://github.com/python/cpython/pull/114879/files#diff-071237c57ffb81dd4303eb5f02e5c5a661891a31c746c8f55a97a39659ad95d6
https://github.com/python/cpython/pull/114879/files#diff-071237c57ffb81dd4303eb5f02e5c5a661891a31c746c8f55a97a39659ad95d6
https://github.com/python/cpython/pull/114879/files#diff-071237c57ffb81dd4303eb5f02e5c5a661891a31c746c8f55a97a39659ad95d6
https://github.com/python/cpython/pull/114879/files#diff-071237c57ffb81dd4303eb5f02e5c5a661891a31c746c8f55a97a39659ad95d6
https://github.com/python/cpython/pull/114879/files#diff-071237c57ffb81dd4303eb5f02e5c5a661891a31c746c8f55a97a39659ad95d6
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.