René's URL Explorer Experiment


Title: GH-79634: Speed up pathlib globbing by removing `joinpath()` call. by barneygale · Pull Request #114623 · python/cpython · GitHub

Open Graph Title: GH-79634: Speed up pathlib globbing by removing `joinpath()` call. by barneygale · Pull Request #114623 · python/cpython

X Title: GH-79634: Speed up pathlib globbing by removing `joinpath()` call. by barneygale · Pull Request #114623 · python/cpython

Description: Remove self.joinpath('') call that should have been removed in 6313cdd. This makes PathBase.glob('') yield itself without adding a trailing slash. It's hard to say whether this is more or less corr...

Open Graph Description: Remove self.joinpath('') call that should have been removed in 6313cdd. This makes PathBase.glob('') yield itself without adding a trailing slash. It's hard to say whether this ...

X Description: Remove self.joinpath('') call that should have been removed in 6313cdd. This makes PathBase.glob('') yield itself without adding a trailing slash. It's hard ...

Opengraph URL: https://github.com/python/cpython/pull/114623

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d886f570-246f-110a-0c22-8424809e3d11
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDDBA:CD10D:317964E:40C522C:696B87F4
html-safe-nonceb1e872667be88c194732d0cbee54c4a72a5c9157951e980c847eb796baf67708
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEREJBOkNEMTBEOjMxNzk2NEU6NDBDNTIyQzo2OTZCODdGNCIsInZpc2l0b3JfaWQiOiI4NTc3MDY3MDczNjEzMzAxNzQ5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac988d9845dd55e2f632efe9663541f283091f843ae13a131ed6f77666d510839c
hovercard-subject-tagpull_request:1697695016
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/114623/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/bec2a8c64f784b116c106bef2a6ebb5d71fadd391b4626c4d274dd527bf62591/python/cpython/pull/114623
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bec2a8c64f784b116c106bef2a6ebb5d71fadd391b4626c4d274dd527bf62591/python/cpython/pull/114623
og:image:altRemove self.joinpath('') call that should have been removed in 6313cdd. This makes PathBase.glob('') yield itself without adding a trailing slash. It's hard to say whether this ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebarneygale
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/114623#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F114623
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F114623
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/114623
Reloadhttps://github.com/python/cpython/pull/114623
Reloadhttps://github.com/python/cpython/pull/114623
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/114623
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/114623
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/114623#issue-comment-box
barneygalehttps://github.com/barneygale
python:mainhttps://github.com/python/cpython/tree/main
barneygale:pathlib-abc-glob-emptyhttps://github.com/barneygale/cpython/tree/pathlib-abc-glob-empty
GH-79634: Speed up pathlib globbing by removing joinpath() call. https://github.com/python/cpython/pull/114623#top
barneygalehttps://github.com/barneygale
python:mainhttps://github.com/python/cpython/tree/main
barneygale:pathlib-abc-glob-emptyhttps://github.com/barneygale/cpython/tree/pathlib-abc-glob-empty
Conversation 0 https://github.com/python/cpython/pull/114623
Commits 2 https://github.com/python/cpython/pull/114623/commits
Checks 0 https://github.com/python/cpython/pull/114623/checks
Files changed 3 https://github.com/python/cpython/pull/114623/files
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/barneygale
barneygalehttps://github.com/barneygale
Jan 26, 2024https://github.com/python/cpython/pull/114623#issue-2102802273
Please reload this pagehttps://github.com/python/cpython/pull/114623
6313cddhttps://github.com/python/cpython/commit/6313cdde58f34648a430d2830357c9d2a5b67b87
pathlib.Path: glob and rglob should accept PathLike patterns #79634https://github.com/python/cpython/issues/79634
Please reload this pagehttps://github.com/python/cpython/pull/114623
https://github.com/barneygale
pythonGH-79634https://github.com/python/cpython/issues/79634
: Speed up globbing by removinghttps://github.com/python/cpython/pull/114623/commits/81dcf588b5e077e0acd066d75c47b9edc761e753
joinpath()https://github.com/python/cpython/pull/114623/commits/81dcf588b5e077e0acd066d75c47b9edc761e753
call.https://github.com/python/cpython/pull/114623/commits/81dcf588b5e077e0acd066d75c47b9edc761e753
81dcf58https://github.com/python/cpython/pull/114623/commits/81dcf588b5e077e0acd066d75c47b9edc761e753
6313cddhttps://github.com/barneygale/cpython/commit/6313cdde58f34648a430d2830357c9d2a5b67b87
https://github.com/barneygale
barneygalehttps://github.com/barneygale
performance https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Aperformance
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
topic-pathlib https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-pathlib
Jan 26, 2024https://github.com/python/cpython/pull/114623#event-11612644862
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jan 26, 2024https://github.com/python/cpython/pull/114623#event-11612645512
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jan 26, 2024 https://github.com/python/cpython/pull/114623#ref-issue-1199002424
pathlib.Path: glob and rglob should accept PathLike patterns #79634 https://github.com/python/cpython/issues/79634
https://github.com/barneygale
Merge branch 'main' into pathlib-abc-glob-emptyhttps://github.com/python/cpython/pull/114623/commits/ab292c4fe3fe6d472ce23fb9e6b8580f6549b930
ab292c4https://github.com/python/cpython/pull/114623/commits/ab292c4fe3fe6d472ce23fb9e6b8580f6549b930
https://github.com/barneygale
barneygalehttps://github.com/barneygale
823a38ahttps://github.com/python/cpython/commit/823a38a960c245cbf309ef29120d3690ba1bcd2c
Jan 27, 2024https://github.com/python/cpython/pull/114623#event-11617737896
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jan 27, 2024https://github.com/python/cpython/pull/114623#event-11617738239
aiskhttps://github.com/aisk
Feb 11, 2024 https://github.com/python/cpython/pull/114623#ref-commit-b45ca16
https://github.com/barneygale
https://github.com/aisk
pythonGH-79634https://github.com/python/cpython/issues/79634
: Speed up pathlib globbing by removinghttps://github.com/aisk/cpython/commit/b45ca162959cd67fd5d18dc494a04dc71ec11317
joinpath()https://github.com/aisk/cpython/commit/b45ca162959cd67fd5d18dc494a04dc71ec11317
ca…https://github.com/aisk/cpython/commit/b45ca162959cd67fd5d18dc494a04dc71ec11317
b45ca16https://github.com/aisk/cpython/commit/b45ca162959cd67fd5d18dc494a04dc71ec11317
python#114623https://github.com/python/cpython/pull/114623
6313cddhttps://github.com/aisk/cpython/commit/6313cdde58f34648a430d2830357c9d2a5b67b87
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F114623
performance https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Aperformance
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
topic-pathlib https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-pathlib
Please reload this pagehttps://github.com/python/cpython/pull/114623
https://github.com/barneygale
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.