René's URL Explorer Experiment


Title: gh-114572: Fix locking in cert_store_stats and get_ca_certs by davidben · Pull Request #114573 · python/cpython · GitHub

Open Graph Title: gh-114572: Fix locking in cert_store_stats and get_ca_certs by davidben · Pull Request #114573 · python/cpython

X Title: gh-114572: Fix locking in cert_store_stats and get_ca_certs by davidben · Pull Request #114573 · python/cpython

Description: cert_store_stats and get_ca_certs query the SSLContext's X509_STORE with X509_STORE_get0_objects, but reading the result requires a lock. See openssl/openssl#23224 for details. Instead, use X509_STORE_get1_objects, newly added in that PR. X509_STORE_get1_objects does not exist in current OpenSSLs, but we can polyfill it with X509_STORE_lock and X509_STORE_unlock. Issue: gh-114572

Open Graph Description: cert_store_stats and get_ca_certs query the SSLContext's X509_STORE with X509_STORE_get0_objects, but reading the result requires a lock. See openssl/openssl#23224 for details. Instead, use X50...

X Description: cert_store_stats and get_ca_certs query the SSLContext's X509_STORE with X509_STORE_get0_objects, but reading the result requires a lock. See openssl/openssl#23224 for details. Instead, use...

Opengraph URL: https://github.com/python/cpython/pull/114573

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9e32e9b8-38cb-ee90-939b-f1c6dcaf634d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9EEA:17FD9C:59E4DF:7846C0:6969B3AD
html-safe-nonce74f7e368fb927b798690110602d91119882cc188fbd5ebe17b1a515008d748e2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RUVBOjE3RkQ5Qzo1OUU0REY6Nzg0NkMwOjY5NjlCM0FEIiwidmlzaXRvcl9pZCI6Ijk1MTE5MDAxMDYyODUxODgyOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5b4171001f14392e4276f5bf110ef7e1a6c85b5b38195202e2c2aee6ced95712
hovercard-subject-tagpull_request:1696405137
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/114573/files
twitter:imagehttps://avatars.githubusercontent.com/u/109690?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/109690?s=400&v=4
og:image:altcert_store_stats and get_ca_certs query the SSLContext's X509_STORE with X509_STORE_get0_objects, but reading the result requires a lock. See openssl/openssl#23224 for details. Instead, use X50...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb23b8fcc855cd29bb04d6c94aafa62d336bf44eefa8229444eecc968cad03aee
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release0672399d88424758731ec07fe24509e23bb17fb5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/114573/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F114573%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F114573%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/114573/files
Reloadhttps://github.com/python/cpython/pull/114573/files
Reloadhttps://github.com/python/cpython/pull/114573/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/114573/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/114573/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
alexhttps://github.com/alex
python:mainhttps://github.com/python/cpython/tree/main
davidben:get1-objshttps://github.com/davidben/cpython/tree/get1-objs
Conversation 21 https://github.com/python/cpython/pull/114573
Commits 4 https://github.com/python/cpython/pull/114573/commits
Checks 0 https://github.com/python/cpython/pull/114573/checks
Files changed 2 https://github.com/python/cpython/pull/114573/files
gh-114572: Fix locking in cert_store_stats and get_ca_certs https://github.com/python/cpython/pull/114573/files#top
Show all changes 4 commits https://github.com/python/cpython/pull/114573/files
529311e gh-114572: Fix locking in cert_store_stats and get_ca_certs davidben Jan 7, 2024 https://github.com/python/cpython/pull/114573/commits/529311e4390a72bf500662ee9567d9113c1d0aec
27d984a Work around const-correctness problem davidben Jan 27, 2024 https://github.com/python/cpython/pull/114573/commits/27d984a9f9357e1334a7110ed68358f673a9cbf5
a0b1501 Add missing X509_STORE_get1_objects failure check davidben Jan 27, 2024 https://github.com/python/cpython/pull/114573/commits/a0b15011f53f207c655fe18e0a0d74214b867d82
549ae87 Add blurb davidben Jan 27, 2024 https://github.com/python/cpython/pull/114573/commits/549ae877540243458fcd7951164e3d736fe92b42
Clear filters https://github.com/python/cpython/pull/114573/files
Please reload this pagehttps://github.com/python/cpython/pull/114573/files
Please reload this pagehttps://github.com/python/cpython/pull/114573/files
2024-01-26-22-14-09.gh-issue-114572.t1QMQD.rst https://github.com/python/cpython/pull/114573/files#diff-210a187a4ade28a9dfb2b094495fe0d5bf2b8e8ac2c3f767bc23742a43f1138c
_ssl.c https://github.com/python/cpython/pull/114573/files#diff-89879be484d86da4e77c90d5408b2e10190ee27cc86337cd0f8efc3520d60621
Misc/NEWS.d/next/Security/2024-01-26-22-14-09.gh-issue-114572.t1QMQD.rsthttps://github.com/python/cpython/pull/114573/files#diff-210a187a4ade28a9dfb2b094495fe0d5bf2b8e8ac2c3f767bc23742a43f1138c
View file https://github.com/davidben/cpython/blob/549ae877540243458fcd7951164e3d736fe92b42/Misc/NEWS.d/next/Security/2024-01-26-22-14-09.gh-issue-114572.t1QMQD.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/114573/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L387
Modules/_ssl.chttps://github.com/python/cpython/pull/114573/files#diff-89879be484d86da4e77c90d5408b2e10190ee27cc86337cd0f8efc3520d60621
View file https://github.com/davidben/cpython/blob/549ae877540243458fcd7951164e3d736fe92b42/Modules/_ssl.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/114573/{{ revealButtonHref }}
https://github.com/python/cpython/pull/114573/files#diff-89879be484d86da4e77c90d5408b2e10190ee27cc86337cd0f8efc3520d60621
sethmlarsonhttps://github.com/sethmlarson
Jan 26, 2024https://github.com/python/cpython/pull/114573/files#r1468155682
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/114573/files
sethmlarsonhttps://github.com/sethmlarson
Jan 26, 2024https://github.com/python/cpython/pull/114573/files#r1468148670
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
openssl/openssl@08cecb4https://github.com/openssl/openssl/commit/08cecb4448e990f7914ec1df97b1ee0ca9031643
Please reload this pagehttps://github.com/python/cpython/pull/114573/files
https://github.com/python/cpython/pull/114573/files#diff-89879be484d86da4e77c90d5408b2e10190ee27cc86337cd0f8efc3520d60621
https://github.com/python/cpython/pull/114573/files#diff-89879be484d86da4e77c90d5408b2e10190ee27cc86337cd0f8efc3520d60621
https://github.com/python/cpython/pull/114573/files#diff-89879be484d86da4e77c90d5408b2e10190ee27cc86337cd0f8efc3520d60621
https://github.com/python/cpython/pull/114573/files#diff-89879be484d86da4e77c90d5408b2e10190ee27cc86337cd0f8efc3520d60621
https://github.com/python/cpython/pull/114573/files#diff-89879be484d86da4e77c90d5408b2e10190ee27cc86337cd0f8efc3520d60621
Please reload this pagehttps://github.com/python/cpython/pull/114573/files
https://github.com/python/cpython/pull/114573/files#diff-89879be484d86da4e77c90d5408b2e10190ee27cc86337cd0f8efc3520d60621
https://github.com/python/cpython/pull/114573/files#diff-89879be484d86da4e77c90d5408b2e10190ee27cc86337cd0f8efc3520d60621
https://github.com/python/cpython/pull/114573/files#diff-89879be484d86da4e77c90d5408b2e10190ee27cc86337cd0f8efc3520d60621
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.