| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:93102a26-8b9a-62a8-97a9-a8055f1c2183 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D2BA:DE287:BCCCBA:10005CC:696AC093 |
| html-safe-nonce | 83f7350d01ec7d9a6241759add2be314b9cd7a649426b46b9d30cc65ff170b12 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMkJBOkRFMjg3OkJDQ0NCQToxMDAwNUNDOjY5NkFDMDkzIiwidmlzaXRvcl9pZCI6IjQ0MjgyMzg2MDI2OTI2OTEzOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | c3848bd0d945437a9b9c5bd7d940b858b2ecb847b6ce4959fad27a5dfc9adb10 |
| hovercard-subject-tag | pull_request:1691541053 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/114479/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/7ae2a6314f6d646a6e750465eafc1e184cbd1b98ac2be04296ee4d046f63772b/python/cpython/pull/114479 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/7ae2a6314f6d646a6e750465eafc1e184cbd1b98ac2be04296ee4d046f63772b/python/cpython/pull/114479 |
| og:image:alt | Issue: TypeError for threading.Lock | None #114315
📚 Documentation preview 📚: https://cpython-previews--114479.org.readthedocs.build/ |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sobolevn |
| hostname | github.com |
| expected-hostname | github.com |
| None | 986b6a1d774985095564e64d6963d11f094da3d0e2bfda2ab1a27d63662eb033 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 89ad2112b9c4e11df6a0c13c8c1f8eedd36b0977 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/114479#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F114479 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F114479 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/114479 |
| Reload | https://github.com/python/cpython/pull/114479 |
| Reload | https://github.com/python/cpython/pull/114479 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/114479 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/114479 |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python/cpython/pull/114479#issue-comment-box |
| gpshead | https://github.com/gpshead |
| python:main | https://github.com/python/cpython/tree/main |
| sobolevn:issue-114315 | https://github.com/sobolevn/cpython/tree/issue-114315 |
|
gh-114315: Make threading.Lock a real class, not a factory function
| https://github.com/python/cpython/pull/114479#top |
| gpshead | https://github.com/gpshead |
| python:main | https://github.com/python/cpython/tree/main |
| sobolevn:issue-114315 | https://github.com/sobolevn/cpython/tree/issue-114315 |
|
Conversation
1
| https://github.com/python/cpython/pull/114479 |
|
Commits
9
| https://github.com/python/cpython/pull/114479/commits |
|
Checks
0
| https://github.com/python/cpython/pull/114479/checks |
|
Files changed
| https://github.com/python/cpython/pull/114479/files |
| Please reload this page | https://github.com/python/cpython/pull/114479 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
|
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
| Jan 23, 2024 | https://github.com/python/cpython/pull/114479#issue-2095839303 |
| Please reload this page | https://github.com/python/cpython/pull/114479 |
| TypeError for threading.Lock | None #114315 | https://github.com/python/cpython/issues/114315 |
| https://cpython-previews--114479.org.readthedocs.build/ | https://cpython-previews--114479.org.readthedocs.build/ |
| Please reload this page | https://github.com/python/cpython/pull/114479 |
| sobolevn | https://github.com/sobolevn |
| January 22, 2024 13:44 | https://github.com/python/cpython/pull/114479#commits-pushed-3620fa4 |
|
| https://github.com/sobolevn |
| wip | https://github.com/python/cpython/pull/114479/commits/3620fa4593c3977e019aff08555c15d90c87364a |
| 3620fa4 | https://github.com/python/cpython/pull/114479/commits/3620fa4593c3977e019aff08555c15d90c87364a |
|
| https://github.com/sobolevn |
| pythongh-114315 | https://github.com/python/cpython/issues/114315 |
| : Make | https://github.com/python/cpython/pull/114479/commits/4b1c4f6bedb95aa16ecbf429709d415e286617b3 |
| threading.Lock | https://github.com/python/cpython/pull/114479/commits/4b1c4f6bedb95aa16ecbf429709d415e286617b3 |
| a real class | https://github.com/python/cpython/pull/114479/commits/4b1c4f6bedb95aa16ecbf429709d415e286617b3 |
| 4b1c4f6 | https://github.com/python/cpython/pull/114479/commits/4b1c4f6bedb95aa16ecbf429709d415e286617b3 |
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
| gpshead | https://github.com/gpshead |
| pitrou | https://github.com/pitrou |
| January 23, 2024 11:12 | https://github.com/python/cpython/pull/114479#event-11568659610 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Jan 23, 2024 | https://github.com/python/cpython/pull/114479#event-11568660332 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
Jan 23, 2024
| https://github.com/python/cpython/pull/114479#ref-issue-2090629276 |
|
TypeError for threading.Lock | None
#114315
| https://github.com/python/cpython/issues/114315 |
| sobolevn | https://github.com/sobolevn |
| January 23, 2024 14:13 | https://github.com/python/cpython/pull/114479#commits-pushed-427b450 |
|
| https://github.com/sobolevn |
| Assert module instead | https://github.com/python/cpython/pull/114479/commits/427b450afe384790f83bf667d9b7af3269300bee |
| 427b450 | https://github.com/python/cpython/pull/114479/commits/427b450afe384790f83bf667d9b7af3269300bee |
|
| https://github.com/sobolevn |
| Do not add to module | https://github.com/python/cpython/pull/114479/commits/1a1b4e8638352ebde38b7169fa401f987cf4c5dc |
| 1a1b4e8 | https://github.com/python/cpython/pull/114479/commits/1a1b4e8638352ebde38b7169fa401f987cf4c5dc |
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
|
Jan 23, 2024
| https://github.com/python/cpython/pull/114479#pullrequestreview-1838508933 |
|
View reviewed changes
| https://github.com/python/cpython/pull/114479/files/1a1b4e8638352ebde38b7169fa401f987cf4c5dc |
| Doc/library/threading.rst | https://github.com/python/cpython/pull/114479/files/1a1b4e8638352ebde38b7169fa401f987cf4c5dc#diff-6a424b7e58eb2394ee0335dd6e08ab8d67e7058852fae0f3aa1b40493fa14a64 |
| Please reload this page | https://github.com/python/cpython/pull/114479 |
| sobolevn | https://github.com/sobolevn |
| January 23, 2024 14:20 | https://github.com/python/cpython/pull/114479#commits-pushed-aa896b1 |
|
| https://github.com/sobolevn |
|
| https://github.com/AlexWaygood |
| Update Doc/library/threading.rst | https://github.com/python/cpython/pull/114479/commits/aa896b1d24efbc02db2e616c02dcb97faa1c3acc |
| aa896b1 | https://github.com/python/cpython/pull/114479/commits/aa896b1d24efbc02db2e616c02dcb97faa1c3acc |
|
| https://github.com/sobolevn |
| Add lock to module | https://github.com/python/cpython/pull/114479/commits/9d30863a961b12537ea96ba35194d7b5e5e4de99 |
| 9d30863 | https://github.com/python/cpython/pull/114479/commits/9d30863a961b12537ea96ba35194d7b5e5e4de99 |
|
| https://github.com/sobolevn |
| Merge branch 'issue-114315' of | https://github.com/python/cpython/pull/114479/commits/ce357a8b42cbc4a5932a708fce90d2bcd326d45c |
| https://github.com/sobolevn/cpython | https://github.com/sobolevn/cpython |
| in… | https://github.com/python/cpython/pull/114479/commits/ce357a8b42cbc4a5932a708fce90d2bcd326d45c |
| ce357a8 | https://github.com/python/cpython/pull/114479/commits/ce357a8b42cbc4a5932a708fce90d2bcd326d45c |
| https://github.com/gpshead |
| gpshead | https://github.com/gpshead |
| Jan 25, 2024 | https://github.com/python/cpython/pull/114479#event-11601315113 |
| gpshead | https://github.com/gpshead |
| January 25, 2024 11:09 | https://github.com/python/cpython/pull/114479#commits-pushed-3311e0a |
|
| https://github.com/gpshead |
| Simplify the versionchanged wording. | https://github.com/python/cpython/pull/114479/commits/3311e0abc73b85dc5f1460ef40b13ce3d843ea98 |
| 3311e0a | https://github.com/python/cpython/pull/114479/commits/3311e0abc73b85dc5f1460ef40b13ce3d843ea98 |
|
| https://github.com/gpshead |
| Test that threading.Lock cannot be subclassed. | https://github.com/python/cpython/pull/114479/commits/b33a71ae609385d5e368ab98088ca2f0e6cf6aa9 |
| b33a71a | https://github.com/python/cpython/pull/114479/commits/b33a71ae609385d5e368ab98088ca2f0e6cf6aa9 |
| https://github.com/gpshead |
| gpshead | https://github.com/gpshead |
|
Jan 25, 2024
| https://github.com/python/cpython/pull/114479#pullrequestreview-1844461459 |
|
View reviewed changes
| https://github.com/python/cpython/pull/114479/files/b33a71ae609385d5e368ab98088ca2f0e6cf6aa9 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Jan 25, 2024 | https://github.com/python/cpython/pull/114479#event-11601405029 |
| https://github.com/gpshead |
| gpshead | https://github.com/gpshead |
| January 25, 2024 19:20 | https://github.com/python/cpython/pull/114479#event-11601429645 |
| https://github.com/gpshead |
| gpshead | https://github.com/gpshead |
| d96358f | https://github.com/python/cpython/commit/d96358ff9de646dbf64dfdfed46d510da7ec4803 |
| Jan 25, 2024 | https://github.com/python/cpython/pull/114479#event-11601673972 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Jan 25, 2024 | https://github.com/python/cpython/pull/114479#event-11601674510 |
| https://github.com/encukou |
| encukou | https://github.com/encukou |
|
Jan 30, 2024
| https://github.com/python/cpython/pull/114479#ref-issue-2107181267 |
|
test_pendingcalls_threaded times out on Windows free-threading builds
#114746
| https://github.com/python/cpython/issues/114746 |
| aisk | https://github.com/aisk |
|
Feb 11, 2024
| https://github.com/python/cpython/pull/114479#ref-commit-73115a7 |
|
| https://github.com/sobolevn |
|
| https://github.com/AlexWaygood |
|
| https://github.com/gpshead |
|
| https://github.com/aisk |
| pythongh-114315 | https://github.com/python/cpython/issues/114315 |
| : Make | https://github.com/aisk/cpython/commit/73115a77771520278af97baf14ab404250841ad1 |
| threading.Lock | https://github.com/aisk/cpython/commit/73115a77771520278af97baf14ab404250841ad1 |
| a real class, not a factory fu… | https://github.com/aisk/cpython/commit/73115a77771520278af97baf14ab404250841ad1 |
| 73115a7 | https://github.com/aisk/cpython/commit/73115a77771520278af97baf14ab404250841ad1 |
| python#114479 | https://github.com/python/cpython/pull/114479 |
| Glyphack | https://github.com/Glyphack |
|
Sep 2, 2024
| https://github.com/python/cpython/pull/114479#ref-commit-6a8a1df |
|
| https://github.com/sobolevn |
|
| https://github.com/AlexWaygood |
|
| https://github.com/gpshead |
|
| https://github.com/Glyphack |
| pythongh-114315 | https://github.com/python/cpython/issues/114315 |
| : Make | https://github.com/Glyphack/cpython/commit/6a8a1df5e9d450940af3a9b995a51df970840a21 |
| threading.Lock | https://github.com/Glyphack/cpython/commit/6a8a1df5e9d450940af3a9b995a51df970840a21 |
| a real class, not a factory fu… | https://github.com/Glyphack/cpython/commit/6a8a1df5e9d450940af3a9b995a51df970840a21 |
| 6a8a1df | https://github.com/Glyphack/cpython/commit/6a8a1df5e9d450940af3a9b995a51df970840a21 |
| python#114479 | https://github.com/python/cpython/pull/114479 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F114479 |
|
| https://github.com/AlexWaygood |
|
AlexWaygood
| https://github.com/AlexWaygood |
|
| https://github.com/python/cpython/pull/114479/files/1a1b4e8638352ebde38b7169fa401f987cf4c5dc |
|
| https://github.com/gpshead |
|
gpshead
| https://github.com/gpshead |
|
| https://github.com/python/cpython/pull/114479/files/b33a71ae609385d5e368ab98088ca2f0e6cf6aa9 |
|
| https://github.com/pitrou |
|
pitrou
| https://github.com/pitrou |
|
| https://github.com/gpshead |
|
gpshead
| https://github.com/gpshead |
| Please reload this page | https://github.com/python/cpython/pull/114479 |
|
| https://github.com/sobolevn |
|
| https://github.com/gpshead |
|
| https://github.com/AlexWaygood |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |