René's URL Explorer Experiment


Title: gh-113317: Don't use global clinic instance in bad_argument() by erlend-aasland · Pull Request #114330 · python/cpython · GitHub

Open Graph Title: gh-113317: Don't use global clinic instance in bad_argument() by erlend-aasland · Pull Request #114330 · python/cpython

X Title: gh-113317: Don't use global clinic instance in bad_argument() by erlend-aasland · Pull Request #114330 · python/cpython

Description: Make it possible for a converter to have multiple includes. Also make the 'includes' an instance attribute. This implies some converter includes are added to the converters during template generati...

Open Graph Description: Make it possible for a converter to have multiple includes. Also make the 'includes' an instance attribute. This implies some converter includes are added to the converters during template ...

X Description: Make it possible for a converter to have multiple includes. Also make the 'includes' an instance attribute. This implies some converter includes are added to the converters during t...

Opengraph URL: https://github.com/python/cpython/pull/114330

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6238a6d2-9294-4ea3-574b-1064fe6bef74
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB55E:2E3F95:134D0FC:1AB28B8:696A937F
html-safe-nonce851a5f95371681f0e036a9dbaffbe5c0ce701c35929cd72de86fc7d80ecc8d0a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNTVFOjJFM0Y5NToxMzREMEZDOjFBQjI4Qjg6Njk2QTkzN0YiLCJ2aXNpdG9yX2lkIjoiODIxNzQ5MjQwMzAwMjE4NDU3NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac85e8220a6d50c23c5036196829705c263abe8da5618dad5eae529cf376b11191
hovercard-subject-tagpull_request:1687596168
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/114330/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6aaf20e9c10bb706d6e3f69cc2a7354b37cd5d0553b85b25165f3f061e35fcf6/python/cpython/pull/114330
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6aaf20e9c10bb706d6e3f69cc2a7354b37cd5d0553b85b25165f3f061e35fcf6/python/cpython/pull/114330
og:image:altMake it possible for a converter to have multiple includes. Also make the 'includes' an instance attribute. This implies some converter includes are added to the converters during template ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameerlend-aasland
hostnamegithub.com
expected-hostnamegithub.com
None4dd496afc954da9c207b2d9fbe86e3074619f565754aa1d9274aec30d9e5b8d7
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release31496a13b80a2f6ad77d6c617ee2255a3545b539
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/114330#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F114330
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F114330
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/114330
Reloadhttps://github.com/python/cpython/pull/114330
Reloadhttps://github.com/python/cpython/pull/114330
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/114330
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/114330
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/114330#issue-comment-box
erlend-aaslandhttps://github.com/erlend-aasland
python:mainhttps://github.com/python/cpython/tree/main
erlend-aasland:clinic/converter-includeshttps://github.com/erlend-aasland/cpython/tree/clinic/converter-includes
gh-113317: Don't use global clinic instance in bad_argument() https://github.com/python/cpython/pull/114330#top
erlend-aaslandhttps://github.com/erlend-aasland
python:mainhttps://github.com/python/cpython/tree/main
erlend-aasland:clinic/converter-includeshttps://github.com/erlend-aasland/cpython/tree/clinic/converter-includes
Conversation 13 https://github.com/python/cpython/pull/114330
Commits 2 https://github.com/python/cpython/pull/114330/commits
Checks 0 https://github.com/python/cpython/pull/114330/checks
Files changed https://github.com/python/cpython/pull/114330/files
Please reload this pagehttps://github.com/python/cpython/pull/114330
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jan 19, 2024https://github.com/python/cpython/pull/114330#issue-2091363637
Please reload this pagehttps://github.com/python/cpython/pull/114330
Argument Clinic: split out global stateless helpers and constants from clinic.py #113317https://github.com/python/cpython/issues/113317
Please reload this pagehttps://github.com/python/cpython/pull/114330
https://github.com/erlend-aasland
pythongh-113317https://github.com/python/cpython/issues/113317
: Don't use global clinic instance in bad_argument()https://github.com/python/cpython/pull/114330/commits/51d79ea284eaf46a44a12b56a161525804fbc141
51d79eahttps://github.com/python/cpython/pull/114330/commits/51d79ea284eaf46a44a12b56a161525804fbc141
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
AlexWaygoodhttps://github.com/AlexWaygood
code ownerhttps://github.com/python/cpython/blob/681e9e85a2c1f72576ddfbd766506e2d6db34862/.github/CODEOWNERS#L190
January 19, 2024 20:32https://github.com/python/cpython/pull/114330#event-11541904263
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Jan 19, 2024https://github.com/python/cpython/pull/114330#event-11541904380
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jan 19, 2024https://github.com/python/cpython/pull/114330#event-11541905111
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jan 19, 2024 https://github.com/python/cpython/pull/114330#ref-issue-2050482755
Argument Clinic: split out global stateless helpers and constants from clinic.py #113317 https://github.com/python/cpython/issues/113317
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jan 19, 2024https://github.com/python/cpython/pull/114330#issuecomment-1901072965
#114324https://github.com/python/cpython/pull/114324
Please reload this pagehttps://github.com/python/cpython/pull/114330
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jan 19, 2024https://github.com/python/cpython/pull/114330#issuecomment-1901075188
Argument-Clinic#35https://github.com/Argument-Clinic/cpython/pull/35
Please reload this pagehttps://github.com/python/cpython/pull/114330
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
vstinnerhttps://github.com/vstinner
January 20, 2024 07:31https://github.com/python/cpython/pull/114330#event-11545172360
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jan 21, 2024 https://github.com/python/cpython/pull/114330#pullrequestreview-1835338834
View reviewed changes https://github.com/python/cpython/pull/114330/files/51d79ea284eaf46a44a12b56a161525804fbc141
Tools/clinic/clinic.pyhttps://github.com/python/cpython/pull/114330/files/51d79ea284eaf46a44a12b56a161525804fbc141#diff-4c6b55ec7d80a3d60f100ce230eb879d9acbe2e558e01d318960e6197d7c47b3
Please reload this pagehttps://github.com/python/cpython/pull/114330
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jan 22, 2024 https://github.com/python/cpython/pull/114330#pullrequestreview-1836509897
View reviewed changes https://github.com/python/cpython/pull/114330/files/51d79ea284eaf46a44a12b56a161525804fbc141
vstinnerhttps://github.com/vstinner
https://github.com/python/cpython/pull/114330#pullrequestreview-1836509897
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/114330
Tools/clinic/clinic.pyhttps://github.com/python/cpython/pull/114330/files/51d79ea284eaf46a44a12b56a161525804fbc141#diff-4c6b55ec7d80a3d60f100ce230eb879d9acbe2e558e01d318960e6197d7c47b3
Please reload this pagehttps://github.com/python/cpython/pull/114330
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jan 22, 2024https://github.com/python/cpython/pull/114330#event-11557001467
https://github.com/erlend-aasland
Address reviewhttps://github.com/python/cpython/pull/114330/commits/11186378da9db522ce7fabe9da40cecc56b1fa8d
1118637https://github.com/python/cpython/pull/114330/commits/11186378da9db522ce7fabe9da40cecc56b1fa8d
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jan 22, 2024https://github.com/python/cpython/pull/114330#issuecomment-1904104046
Please reload this pagehttps://github.com/python/cpython/pull/114330
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jan 23, 2024https://github.com/python/cpython/pull/114330#issuecomment-1905697631
Please reload this pagehttps://github.com/python/cpython/pull/114330
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Jan 23, 2024 https://github.com/python/cpython/pull/114330#pullrequestreview-1838359706
View reviewed changes https://github.com/python/cpython/pull/114330/files/11186378da9db522ce7fabe9da40cecc56b1fa8d
AlexWaygoodhttps://github.com/AlexWaygood
https://github.com/python/cpython/pull/114330#pullrequestreview-1838359706
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/114330
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
e14930fhttps://github.com/python/cpython/commit/e14930ff6397439759eb34ca70a3493baa845014
Jan 23, 2024https://github.com/python/cpython/pull/114330#event-11567892635
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
January 23, 2024 10:07https://github.com/python/cpython/pull/114330#event-11567892850
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Jan 23, 2024https://github.com/python/cpython/pull/114330#event-11567893329
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jan 23, 2024https://github.com/python/cpython/pull/114330#issuecomment-1905711597
Please reload this pagehttps://github.com/python/cpython/pull/114330
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jan 23, 2024https://github.com/python/cpython/pull/114330#issuecomment-1906053863
Please reload this pagehttps://github.com/python/cpython/pull/114330
aiskhttps://github.com/aisk
Feb 11, 2024 https://github.com/python/cpython/pull/114330#ref-commit-c082ff6
https://github.com/erlend-aasland
https://github.com/aisk
pythongh-113317https://github.com/python/cpython/issues/113317
: Don't use global clinic instance in bad_argument() (https://github.com/aisk/cpython/commit/c082ff6ce977c53d4c156175f210dc04578660e8
p…https://github.com/python/cpython/pull/114330
c082ff6https://github.com/aisk/cpython/commit/c082ff6ce977c53d4c156175f210dc04578660e8
…ython#114330https://github.com/python/cpython/pull/114330
Glyphackhttps://github.com/Glyphack
Sep 2, 2024 https://github.com/python/cpython/pull/114330#ref-commit-603e4e5
https://github.com/erlend-aasland
https://github.com/Glyphack
pythongh-113317https://github.com/python/cpython/issues/113317
: Don't use global clinic instance in bad_argument() (https://github.com/Glyphack/cpython/commit/603e4e59a5df0aa02d7cc9f4c5efbce3666efc19
p…https://github.com/python/cpython/pull/114330
603e4e5https://github.com/Glyphack/cpython/commit/603e4e59a5df0aa02d7cc9f4c5efbce3666efc19
…ython#114330https://github.com/python/cpython/pull/114330
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F114330
https://github.com/vstinner
vstinner https://github.com/vstinner
https://github.com/python/cpython/pull/114330/files/51d79ea284eaf46a44a12b56a161525804fbc141
https://github.com/AlexWaygood
AlexWaygood https://github.com/AlexWaygood
https://github.com/python/cpython/pull/114330/files/11186378da9db522ce7fabe9da40cecc56b1fa8d
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/114330
https://github.com/erlend-aasland
https://github.com/vstinner
https://github.com/AlexWaygood
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.