René's URL Explorer Experiment


Title: gh-109534: switch from sock_call to sock_call_ex in sock_send by geraldog · Pull Request #114311 · python/cpython · GitHub

Open Graph Title: gh-109534: switch from sock_call to sock_call_ex in sock_send by geraldog · Pull Request #114311 · python/cpython

X Title: gh-109534: switch from sock_call to sock_call_ex in sock_send by geraldog · Pull Request #114311 · python/cpython

Description: While writing webcrawlers with https://github.com/sonic182/aiosonic I came across the issues best described in #109534 I had the great idea of explicitly deleting the event loop my crawler was running on, and hey - I got a traceback of the leaks, repeated ad nauseam: OSError: [Errno 9] Bad file descriptor During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/usr/lib/python3.10/asyncio/sslproto.py", line 692, in _process_write_backlog self._transport.write(chunk) File "/usr/lib/python3.10/asyncio/selector_events.py", line 935, in write self._fatal_error(exc, 'Fatal write error on socket transport') File "/usr/lib/python3.10/asyncio/selector_events.py", line 729, in _fatal_error self._force_close(exc) File "/usr/lib/python3.10/asyncio/selector_events.py", line 741, in _force_close self._loop.call_soon(self._call_connection_lost, exc) File "/usr/lib/python3.10/asyncio/base_events.py", line 753, in call_soon self._check_closed() File "/usr/lib/python3.10/asyncio/base_events.py", line 515, in _check_closed raise RuntimeError('Event loop is closed') RuntimeError: Event loop is closed Fatal error on SSL transport protocol: transport: <_SelectorSocketTransport closing fd=329> Traceback (most recent call last): File "/usr/lib/python3.10/asyncio/selector_events.py", line 929, in write n = self._sock.send(data) Notice this traceback happens with Python <= 3.10 only. Python >= 3.11 leaks forever regardless of whether the loop is deleted or not. That got me thinking, there must be something special about the socket.send() function that isn't raising the exception... so I went looking in socketmodules.c, and lo and behold, there are multiple instances in that file where we use the sock_call() thin wrapper around sock_call_ex(). The problem is that wrapper does not set an err pointer to pass to sock_call_ex(). As a result, the exception may never be raised. As I said, multiple instances here, this one-liner won't solve #109534 by itself but I believe it's a step forward. I have a crawler running much more stabler now with this fix, particularly when I have to abort() the underlying SSL transport. Issue: gh-109534

Open Graph Description: While writing webcrawlers with https://github.com/sonic182/aiosonic I came across the issues best described in #109534 I had the great idea of explicitly deleting the event loop my crawler was runn...

X Description: While writing webcrawlers with https://github.com/sonic182/aiosonic I came across the issues best described in #109534 I had the great idea of explicitly deleting the event loop my crawler was runn...

Opengraph URL: https://github.com/python/cpython/pull/114311

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:15c256ca-579b-d91b-99d1-2db132a31a94
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9A22:78799:FF4E27:1523C4A:6AFE9E53
html-safe-nonced2ee3185331f289d0b8b69e16f122fbeb4e3fda4b513ef3a6fda14d5ecb8d214
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QTIyOjc4Nzk5OkZGNEUyNzoxNTIzQzRBOjZBRkU5RTUzIiwidmlzaXRvcl9pZCI6Ijk5NjA0NjczNDk5MzgyNTM2MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac85f5720e3adc7a19f2ef430a2aa4fcb6fc82ef2693b0bc378c1d60aa9d2c73c3
hovercard-subject-tagpull_request:1686713574
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/114311/files
twitter:imagehttps://avatars.githubusercontent.com/u/14135816?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/14135816?s=400&v=4
og:image:altWhile writing webcrawlers with https://github.com/sonic182/aiosonic I came across the issues best described in #109534 I had the great idea of explicitly deleting the event loop my crawler was runn...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/114311/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F114311%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F114311%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/114311/files
Reloadhttps://github.com/python/cpython/pull/114311/files
Reloadhttps://github.com/python/cpython/pull/114311/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
geraldoghttps://github.com/geraldog
python:mainhttps://github.com/python/cpython/tree/main
geraldog:add_socket_errorhttps://github.com/geraldog/cpython/tree/add_socket_error
Conversation 3 https://github.com/python/cpython/pull/114311
Commits 1 https://github.com/python/cpython/pull/114311/commits
Checks 0 https://github.com/python/cpython/pull/114311/checks
Files changed https://github.com/python/cpython/pull/114311/files
Please reload this pagehttps://github.com/python/cpython/pull/114311/files
gh-109534: switch from sock_call to sock_call_ex in sock_send https://github.com/python/cpython/pull/114311/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/114311/files
c566d01 gh-109534: switch from sock_call to sock_call_ex in sock_send geraldog Jan 19, 2024 https://github.com/python/cpython/pull/114311/commits/c566d01b816d819c2fb5f53dd07965f7a6c10a77
Clear filters https://github.com/python/cpython/pull/114311/files
Please reload this pagehttps://github.com/python/cpython/pull/114311/files
Please reload this pagehttps://github.com/python/cpython/pull/114311/files
Modules/socketmodule.chttps://github.com/python/cpython/pull/114311/files#diff-412f0023cab7bc5669c6c1e710a6f37e7c3c387d299794b5fe82268a10223b29
View file https://github.com/geraldog/cpython/blob/c566d01b816d819c2fb5f53dd07965f7a6c10a77/Modules/socketmodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/114311/{{ revealButtonHref }}
https://github.com/python/cpython/pull/114311/files#diff-412f0023cab7bc5669c6c1e710a6f37e7c3c387d299794b5fe82268a10223b29
https://github.com/python/cpython/pull/114311/files#diff-412f0023cab7bc5669c6c1e710a6f37e7c3c387d299794b5fe82268a10223b29
https://github.com/python/cpython/pull/114311/files#diff-412f0023cab7bc5669c6c1e710a6f37e7c3c387d299794b5fe82268a10223b29
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.