René's URL Explorer Experiment


Title: gh-109534: fix reference leak when SSL handshake fails by ordinary-jamie · Pull Request #114074 · python/cpython · GitHub

Open Graph Title: gh-109534: fix reference leak when SSL handshake fails by ordinary-jamie · Pull Request #114074 · python/cpython

X Title: gh-109534: fix reference leak when SSL handshake fails by ordinary-jamie · Pull Request #114074 · python/cpython

Description: Fixes a reference cycle issue between the Future object used in selector_events.BaseSelectorEventLoop._accept_connection2 and SSLProtocol which prevented the SSLProtocol from deallocating and causing spikes in memory usage. The root cause of the issue is that, on SSL handshake failure, the SSLProtocol sets the Future (waiter) exception, and the traceback frames in that exception will hold references to the protocol object and its buffers. Refactored SSLProtocol._on_handshake_complete to not use try/except as this created a frame that kept the waiter object alive. Edit: see comments below Issue: gh-109534

Open Graph Description: Fixes a reference cycle issue between the Future object used in selector_events.BaseSelectorEventLoop._accept_connection2 and SSLProtocol which prevented the SSLProtocol from deallocating and causi...

X Description: Fixes a reference cycle issue between the Future object used in selector_events.BaseSelectorEventLoop._accept_connection2 and SSLProtocol which prevented the SSLProtocol from deallocating and causi...

Opengraph URL: https://github.com/python/cpython/pull/114074

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7ae0d9cf-b235-bf3b-12bd-bf0852f68a62
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8962:EFEB1:10A4C3B:15EB03C:6AFE9E4E
html-safe-nonce78f2833858b787ff8970cd1370eeb32ad24695731b3e5ba90ed4d213432c15c4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OTYyOkVGRUIxOjEwQTRDM0I6MTVFQjAzQzo2QUZFOUU0RSIsInZpc2l0b3JfaWQiOiI0NTU0OTg2NDk5MDkwNTg3MjE0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacf42a595a1645f990ffc722f5e66a543438ec040bd3edf54cac6b6ee56fc4b177
hovercard-subject-tagpull_request:1678733716
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/114074/files
twitter:imagehttps://avatars.githubusercontent.com/u/101677823?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/101677823?s=400&v=4
og:image:altFixes a reference cycle issue between the Future object used in selector_events.BaseSelectorEventLoop._accept_connection2 and SSLProtocol which prevented the SSLProtocol from deallocating and causi...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/114074/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F114074%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F114074%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/114074/files
Reloadhttps://github.com/python/cpython/pull/114074/files
Reloadhttps://github.com/python/cpython/pull/114074/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
hauntsaninjahttps://github.com/hauntsaninja
python:mainhttps://github.com/python/cpython/tree/main
ordinary-jamie:asyncio-tls-refcycle-fixhttps://github.com/ordinary-jamie/cpython/tree/asyncio-tls-refcycle-fix
Conversation 21 https://github.com/python/cpython/pull/114074
Commits 2 https://github.com/python/cpython/pull/114074/commits
Checks 0 https://github.com/python/cpython/pull/114074/checks
Files changed https://github.com/python/cpython/pull/114074/files
Please reload this pagehttps://github.com/python/cpython/pull/114074/files
gh-109534: fix reference leak when SSL handshake fails https://github.com/python/cpython/pull/114074/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/114074/files
17723a5 gh-109534: fix reference leak when SSL handshake fails ordinary-jamie Jan 15, 2024 https://github.com/python/cpython/pull/114074/commits/17723a58f59145d774afc66018129e437518cdaf
e77579d Revert _on_handshake_complete changes and clear exception ref ordinary-jamie Jan 15, 2024 https://github.com/python/cpython/pull/114074/commits/e77579de6705a7bb590c179dc37d4d752878c0d4
Clear filters https://github.com/python/cpython/pull/114074/files
Please reload this pagehttps://github.com/python/cpython/pull/114074/files
Please reload this pagehttps://github.com/python/cpython/pull/114074/files
selector_events.py https://github.com/python/cpython/pull/114074/files#diff-905d4384eaa0f1d54083b6d643e90b9404e32339f2c151e880491cb2e595f207
sslproto.py https://github.com/python/cpython/pull/114074/files#diff-0ae38bdc337cc724282d20111dc780b8a9c07385c80476cf304d5b3c9ec306ec
2024-01-15-18-42-44.gh-issue-109534.wYaLMZ.rst https://github.com/python/cpython/pull/114074/files#diff-10d1604a8f4711159b15c8d624ef6d2c70d82dac5023cc9c4e3663f4f56a72b0
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L376
Lib/asyncio/selector_events.pyhttps://github.com/python/cpython/pull/114074/files#diff-905d4384eaa0f1d54083b6d643e90b9404e32339f2c151e880491cb2e595f207
View file https://github.com/ordinary-jamie/cpython/blob/e77579de6705a7bb590c179dc37d4d752878c0d4/Lib/asyncio/selector_events.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/114074/{{ revealButtonHref }}
https://github.com/python/cpython/pull/114074/files#diff-905d4384eaa0f1d54083b6d643e90b9404e32339f2c151e880491cb2e595f207
https://github.com/python/cpython/pull/114074/files#diff-905d4384eaa0f1d54083b6d643e90b9404e32339f2c151e880491cb2e595f207
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L394
Lib/asyncio/sslproto.pyhttps://github.com/python/cpython/pull/114074/files#diff-0ae38bdc337cc724282d20111dc780b8a9c07385c80476cf304d5b3c9ec306ec
View file https://github.com/ordinary-jamie/cpython/blob/e77579de6705a7bb590c179dc37d4d752878c0d4/Lib/asyncio/sslproto.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/114074/{{ revealButtonHref }}
https://github.com/python/cpython/pull/114074/files#diff-0ae38bdc337cc724282d20111dc780b8a9c07385c80476cf304d5b3c9ec306ec
mjpietershttps://github.com/mjpieters
Jan 15, 2024https://github.com/python/cpython/pull/114074/files#r1452667240
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/114074/files
mjpietershttps://github.com/mjpieters
Jan 15, 2024https://github.com/python/cpython/pull/114074/files#r1452672264
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/114074/files
ordinary-jamiehttps://github.com/ordinary-jamie
Jan 15, 2024https://github.com/python/cpython/pull/114074/files#r1452703398
Please reload this pagehttps://github.com/python/cpython/pull/114074/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/114074/files
https://github.com/python/cpython/pull/114074/files#diff-0ae38bdc337cc724282d20111dc780b8a9c07385c80476cf304d5b3c9ec306ec
Misc/NEWS.d/next/Library/2024-01-15-18-42-44.gh-issue-109534.wYaLMZ.rsthttps://github.com/python/cpython/pull/114074/files#diff-10d1604a8f4711159b15c8d624ef6d2c70d82dac5023cc9c4e3663f4f56a72b0
View file https://github.com/ordinary-jamie/cpython/blob/e77579de6705a7bb590c179dc37d4d752878c0d4/Misc/NEWS.d/next/Library/2024-01-15-18-42-44.gh-issue-109534.wYaLMZ.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/114074/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.