René's URL Explorer Experiment


Title: [3.7] bpo-35550: Fix incorrect Solaris define guards (GH-11275) by miss-islington · Pull Request #11383 · python/cpython · GitHub

Open Graph Title: [3.7] bpo-35550: Fix incorrect Solaris define guards (GH-11275) by miss-islington · Pull Request #11383 · python/cpython

X Title: [3.7] bpo-35550: Fix incorrect Solaris define guards (GH-11275) by miss-islington · Pull Request #11383 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Python source code uses on several places ifdef sun or defined(sun) without the underscores, which is not standard compliant and shouldn't be used. Defines should check for __sun instead. Refer...

X Description: Python source code uses on several places ifdef sun or defined(sun) without the underscores, which is not standard compliant and shouldn't be used. Defines should check for __sun instead. R...

Mail addresses
Kulikjak@gmail.com

Opengraph URL: https://github.com/python/cpython/pull/11383

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:06e3399c-27de-4887-4fbe-62a36d3a172a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id85E8:378B6C:1B63450:25409BE:6A524CD5
html-safe-nonce477c931f1d92ea6f7204f69160423a31d0a4ad2c750901da5abc6ea9641a13fc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NUU4OjM3OEI2QzoxQjYzNDUwOjI1NDA5QkU6NkE1MjRDRDUiLCJ2aXNpdG9yX2lkIjoiMzgzNTEwNTU3ODg5Nzc4ODExNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac08bb0e4a24feb0ff881f284ffbf6b7cb127ad0844cffb5b86975122248b20564
hovercard-subject-tagpull_request:241520224
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/11383/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/877dbddbfd03fac7ab0df66809157851100965b3e474abd2f9c40e5dcb219b61/python/cpython/pull/11383
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/877dbddbfd03fac7ab0df66809157851100965b3e474abd2f9c40e5dcb219b61/python/cpython/pull/11383
og:image:altPython source code uses on several places ifdef sun or defined(sun) without the underscores, which is not standard compliant and shouldn't be used. Defines should check for __sun instead. Refer...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemiss-islington
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/11383#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F11383
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F11383
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/11383
Reloadhttps://github.com/python/cpython/pull/11383
Reloadhttps://github.com/python/cpython/pull/11383
Please reload this pagehttps://github.com/python/cpython/pull/11383
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/11383
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.7k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
miss-islingtonhttps://github.com/miss-islington
python:3.7https://github.com/python/cpython/tree/3.7
miss-islington:backport-6f9bc72-3.7https://github.com/miss-islington/cpython/tree/backport-6f9bc72-3.7
Conversationhttps://github.com/python/cpython/pull/11383
Commits1 (1)https://github.com/python/cpython/pull/11383/commits
Checkshttps://github.com/python/cpython/pull/11383/checks
Files changedhttps://github.com/python/cpython/pull/11383/files
[3.7] bpo-35550: Fix incorrect Solaris define guards (GH-11275)https://github.com/python/cpython/pull/11383#top
miss-islingtonhttps://github.com/miss-islington
python:3.7https://github.com/python/cpython/tree/3.7
miss-islington:backport-6f9bc72-3.7https://github.com/miss-islington/cpython/tree/backport-6f9bc72-3.7
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Dec 31, 2018https://github.com/python/cpython/pull/11383#issue-394919637
Please reload this pagehttps://github.com/python/cpython/pull/11383
http://nadeausoftware.com/articles/2012/01/c_c_tip_how_use_compiler_predefined_macros_detect_operating_systemGH-Solarishttp://nadeausoftware.com/articles/2012/01/c_c_tip_how_use_compiler_predefined_macros_detect_operating_systemGH-Solaris
https://bugs.python.org/issue35550https://bugs.python.org/issue35550
6f9bc72https://github.com/python/cpython/commit/6f9bc72c79c3262e5d0f2c0e96b016477399cfb1
https://bugs.python.org/issue35550https://bugs.python.org/issue35550
Please reload this pagehttps://github.com/python/cpython/pull/11383
https://github.com/kulikjak
https://github.com/miss-islington
bpo-35550: Fix incorrect Solaris define guards (https://github.com/python/cpython/pull/11383/commits/9f38e946125e449910c6df57992a349557b76859
pythonGH-11275https://github.com/python/cpython/pull/11275
)https://github.com/python/cpython/pull/11383/commits/9f38e946125e449910c6df57992a349557b76859
9f38e94https://github.com/python/cpython/pull/11383/commits/9f38e946125e449910c6df57992a349557b76859
http://nadeausoftware.com/articles/2012/01/c_c_tip_how_use_compiler_predefined_macros_detect_operating_systemGH-Solarishttp://nadeausoftware.com/articles/2012/01/c_c_tip_how_use_compiler_predefined_macros_detect_operating_systemGH-Solaris
https://bugs.python.org/issue35550https://bugs.python.org/issue35550
6f9bc72https://github.com/miss-islington/cpython/commit/6f9bc72c79c3262e5d0f2c0e96b016477399cfb1
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
gpsheadhttps://github.com/gpshead
code ownerhttps://github.com/python/cpython/blob/a144feeb7ec501aaf30072d50e70d54b200e5ef0/.github/CODEOWNERS#L41
December 31, 2018 02:16https://github.com/python/cpython/pull/11383#event-2048628401
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Dec 31, 2018https://github.com/python/cpython/pull/11383#event-2048628408
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Dec 31, 2018 https://github.com/python/cpython/pull/11383#ref-pullrequest-393399874
bpo-35550 fix incorrect Solaris define guards #11275 https://github.com/python/cpython/pull/11275
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Dec 31, 2018https://github.com/python/cpython/pull/11383#event-2048628419
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Dec 31, 2018 https://github.com/python/cpython/pull/11383#pullrequestreview-188456905
View reviewed changes https://github.com/python/cpython/pull/11383/files/9f38e946125e449910c6df57992a349557b76859
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Dec 31, 2018https://github.com/python/cpython/pull/11383#event-2048628578
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
🤖 automerge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Arobot%3A%20automerge%22
Dec 31, 2018https://github.com/python/cpython/pull/11383#event-2048628620
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Dec 31, 2018https://github.com/python/cpython/pull/11383#issuecomment-450602631
@kulikjakhttps://github.com/kulikjak
@gpsheadhttps://github.com/gpshead
Please reload this pagehttps://github.com/python/cpython/pull/11383
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Dec 31, 2018https://github.com/python/cpython/pull/11383#issuecomment-450602632
@kulikjakhttps://github.com/kulikjak
@gpsheadhttps://github.com/gpshead
Please reload this pagehttps://github.com/python/cpython/pull/11383
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
d823443https://github.com/python/cpython/commit/d82344378ad8e471b8ed12fb99807f68351c5412
Dec 31, 2018https://github.com/python/cpython/pull/11383#event-2048634574
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Dec 31, 2018https://github.com/python/cpython/pull/11383#issuecomment-450602633
Please reload this pagehttps://github.com/python/cpython/pull/11383
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Dec 31, 2018https://github.com/python/cpython/pull/11383#event-2048634590
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
December 31, 2018 02:39https://github.com/python/cpython/pull/11383#event-2048634592
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F11383
https://github.com/gpshead
gpshead https://github.com/gpshead
https://github.com/python/cpython/pull/11383/files/9f38e946125e449910c6df57992a349557b76859
Please reload this pagehttps://github.com/python/cpython/pull/11383
https://github.com/miss-islington
https://github.com/gpshead
https://github.com/the-knights-who-say-ni
https://github.com/bedevere-bot
https://github.com/kulikjak
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.