René's URL Explorer Experiment


Title: GH-44626, GH-105476: Fix `ntpath.isabs()` handling of part-absolute paths by barneygale · Pull Request #113829 · python/cpython · GitHub

Open Graph Title: GH-44626, GH-105476: Fix `ntpath.isabs()` handling of part-absolute paths by barneygale · Pull Request #113829 · python/cpython

X Title: GH-44626, GH-105476: Fix `ntpath.isabs()` handling of part-absolute paths by barneygale · Pull Request #113829 · python/cpython

Description: On Windows, os.path.isabs() now returns False when given a path that starts with exactly one (back)slash. This is more compatible with other functions in os.path, and with Microsoft's own documentation. Also adjust pathlib.PureWindowsPath.is_absolute() to call ntpath.isabs(), which corrects its handling of partial UNC/device paths like //foo. Issue: gh-44626 Issue: gh-105476 📚 Documentation preview 📚: https://cpython-previews--113829.org.readthedocs.build/

Open Graph Description: On Windows, os.path.isabs() now returns False when given a path that starts with exactly one (back)slash. This is more compatible with other functions in os.path, and with Microsoft's own docum...

X Description: On Windows, os.path.isabs() now returns False when given a path that starts with exactly one (back)slash. This is more compatible with other functions in os.path, and with Microsoft's own d...

Opengraph URL: https://github.com/python/cpython/pull/113829

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:6ef623c4-70ad-6c9e-add9-3a2a1fc1b09a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA0BE:38EE04:1AA8ED1:232AA2E:6B02192C
html-safe-nonce6eea2fdd2c569ca9907db6a6f5da974dbd7092e4334ea46723fdf2cd1a304dc9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMEJFOjM4RUUwNDoxQUE4RUQxOjIzMkFBMkU6NkIwMjE5MkMiLCJ2aXNpdG9yX2lkIjoiMjQ2NjEwMDE5MzcxNjczODM0OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac894299d5ca9165d418a83b07e54bd623eee5baae2cd7ca9c27f5529e657ec420
hovercard-subject-tagpull_request:1669653139
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/113829/files
twitter:imagehttps://avatars.githubusercontent.com/u/960340?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/960340?s=400&v=4
og:image:altOn Windows, os.path.isabs() now returns False when given a path that starts with exactly one (back)slash. This is more compatible with other functions in os.path, and with Microsoft's own docum...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/113829/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F113829%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F113829%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/113829/files
Reloadhttps://github.com/python/cpython/pull/113829/files
Reloadhttps://github.com/python/cpython/pull/113829/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
barneygalehttps://github.com/barneygale
python:mainhttps://github.com/python/cpython/tree/main
barneygale:gh-44626-fix-ntpath-isabshttps://github.com/barneygale/cpython/tree/gh-44626-fix-ntpath-isabs
Conversation 1 https://github.com/python/cpython/pull/113829
Commits 3 https://github.com/python/cpython/pull/113829/commits
Checks 0 https://github.com/python/cpython/pull/113829/checks
Files changed https://github.com/python/cpython/pull/113829/files
Please reload this pagehttps://github.com/python/cpython/pull/113829/files
GH-44626, GH-105476: Fix ntpath.isabs() handling of part-absolute paths https://github.com/python/cpython/pull/113829/files#top
Show all changes 3 commits https://github.com/python/cpython/pull/113829/files
2100e3e GH-44626, GH-105476: Fix `ntpath.isabs()` handling of part-absolute p… barneygale Jan 8, 2024 https://github.com/python/cpython/pull/113829/commits/2100e3e4d2149f770554a67c13678310bdd8e3b4
f6f0e35 Attempt to fix some test failures. barneygale Jan 8, 2024 https://github.com/python/cpython/pull/113829/commits/f6f0e35a33fd55b00fbef53ec9dacdb0a1ba818f
bb7abe5 Fix tests, attempt #2 barneygale Jan 8, 2024 https://github.com/python/cpython/pull/113829/commits/bb7abe5918acc0f34bdae2d2e303c72839059aa0
Clear filters https://github.com/python/cpython/pull/113829/files
Please reload this pagehttps://github.com/python/cpython/pull/113829/files
Please reload this pagehttps://github.com/python/cpython/pull/113829/files
os.path.rst https://github.com/python/cpython/pull/113829/files#diff-22dc079c4b2ebb7590f7963d2a7ea70133920c3f465d35b421ec9451c563d783
3.13.rst https://github.com/python/cpython/pull/113829/files#diff-0eef04c1aae0cf8389945464f271ff6789259ef8985f5fdbb21c9a99c4b5021f
ntpath.py https://github.com/python/cpython/pull/113829/files#diff-892add06b0598c5d7b07448e0ac87f5aa6b97fd0a79d77bcbc69092b70d1d065
_abc.py https://github.com/python/cpython/pull/113829/files#diff-80172c23421c1dd13d79623c67c24cee61b300f18a55ab5d2d33d69d490abe9a
test_ntpath.py https://github.com/python/cpython/pull/113829/files#diff-f32eb738dcaaaaeb2ac5bcd885fd517e11c9efc35c44912bef0c725e20c1fbea
test_pathlib.py https://github.com/python/cpython/pull/113829/files#diff-03d884d0a180340cc959b85206069287a4720ba88da9463cc94f79396d0f8f9c
test_program.py https://github.com/python/cpython/pull/113829/files#diff-51bb955808b4fd7cdfc300b124339375d50475c55013108e741902e2935687f3
test_zoneinfo.py https://github.com/python/cpython/pull/113829/files#diff-7908b1930bd1135d6f8077ef5ff578b02577f5f7042b54be88b9b86b6c7af45d
2024-01-08-21-15-48.gh-issue-44626.DRq-PR.rst https://github.com/python/cpython/pull/113829/files#diff-1a4e692d6b1ed0303b3c5da1caa06412519a8d0dd712fd2012da24de5a5e0f14
Doc/library/os.path.rsthttps://github.com/python/cpython/pull/113829/files#diff-22dc079c4b2ebb7590f7963d2a7ea70133920c3f465d35b421ec9451c563d783
View file https://github.com/barneygale/cpython/blob/bb7abe5918acc0f34bdae2d2e303c72839059aa0/Doc/library/os.path.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/113829/{{ revealButtonHref }}
https://github.com/python/cpython/pull/113829/files#diff-22dc079c4b2ebb7590f7963d2a7ea70133920c3f465d35b421ec9451c563d783
https://github.com/python/cpython/pull/113829/files#diff-22dc079c4b2ebb7590f7963d2a7ea70133920c3f465d35b421ec9451c563d783
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L116
Doc/whatsnew/3.13.rsthttps://github.com/python/cpython/pull/113829/files#diff-0eef04c1aae0cf8389945464f271ff6789259ef8985f5fdbb21c9a99c4b5021f
View file https://github.com/barneygale/cpython/blob/bb7abe5918acc0f34bdae2d2e303c72839059aa0/Doc/whatsnew/3.13.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/113829/{{ revealButtonHref }}
https://github.com/python/cpython/pull/113829/files#diff-0eef04c1aae0cf8389945464f271ff6789259ef8985f5fdbb21c9a99c4b5021f
https://github.com/python/cpython/pull/113829/files#diff-0eef04c1aae0cf8389945464f271ff6789259ef8985f5fdbb21c9a99c4b5021f
Lib/ntpath.pyhttps://github.com/python/cpython/pull/113829/files#diff-892add06b0598c5d7b07448e0ac87f5aa6b97fd0a79d77bcbc69092b70d1d065
View file https://github.com/barneygale/cpython/blob/bb7abe5918acc0f34bdae2d2e303c72839059aa0/Lib/ntpath.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/113829/{{ revealButtonHref }}
https://github.com/python/cpython/pull/113829/files#diff-892add06b0598c5d7b07448e0ac87f5aa6b97fd0a79d77bcbc69092b70d1d065
https://github.com/python/cpython/pull/113829/files#diff-892add06b0598c5d7b07448e0ac87f5aa6b97fd0a79d77bcbc69092b70d1d065
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L548
Lib/pathlib/_abc.pyhttps://github.com/python/cpython/pull/113829/files#diff-80172c23421c1dd13d79623c67c24cee61b300f18a55ab5d2d33d69d490abe9a
View file https://github.com/barneygale/cpython/blob/bb7abe5918acc0f34bdae2d2e303c72839059aa0/Lib/pathlib/_abc.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/113829/{{ revealButtonHref }}
https://github.com/python/cpython/pull/113829/files#diff-80172c23421c1dd13d79623c67c24cee61b300f18a55ab5d2d33d69d490abe9a
https://github.com/python/cpython/pull/113829/files#diff-80172c23421c1dd13d79623c67c24cee61b300f18a55ab5d2d33d69d490abe9a
https://github.com/python/cpython/pull/113829/files#diff-80172c23421c1dd13d79623c67c24cee61b300f18a55ab5d2d33d69d490abe9a
Lib/test/test_ntpath.pyhttps://github.com/python/cpython/pull/113829/files#diff-f32eb738dcaaaaeb2ac5bcd885fd517e11c9efc35c44912bef0c725e20c1fbea
View file https://github.com/barneygale/cpython/blob/bb7abe5918acc0f34bdae2d2e303c72839059aa0/Lib/test/test_ntpath.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/113829/{{ revealButtonHref }}
https://github.com/python/cpython/pull/113829/files#diff-f32eb738dcaaaaeb2ac5bcd885fd517e11c9efc35c44912bef0c725e20c1fbea
https://github.com/python/cpython/pull/113829/files#diff-f32eb738dcaaaaeb2ac5bcd885fd517e11c9efc35c44912bef0c725e20c1fbea
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L549
Lib/test/test_pathlib/test_pathlib.pyhttps://github.com/python/cpython/pull/113829/files#diff-03d884d0a180340cc959b85206069287a4720ba88da9463cc94f79396d0f8f9c
View file https://github.com/barneygale/cpython/blob/bb7abe5918acc0f34bdae2d2e303c72839059aa0/Lib/test/test_pathlib/test_pathlib.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/113829/{{ revealButtonHref }}
https://github.com/python/cpython/pull/113829/files#diff-03d884d0a180340cc959b85206069287a4720ba88da9463cc94f79396d0f8f9c
https://github.com/python/cpython/pull/113829/files#diff-03d884d0a180340cc959b85206069287a4720ba88da9463cc94f79396d0f8f9c
Lib/test/test_unittest/test_program.pyhttps://github.com/python/cpython/pull/113829/files#diff-51bb955808b4fd7cdfc300b124339375d50475c55013108e741902e2935687f3
View file https://github.com/barneygale/cpython/blob/bb7abe5918acc0f34bdae2d2e303c72839059aa0/Lib/test/test_unittest/test_program.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/113829/{{ revealButtonHref }}
https://github.com/python/cpython/pull/113829/files#diff-51bb955808b4fd7cdfc300b124339375d50475c55013108e741902e2935687f3
https://github.com/python/cpython/pull/113829/files#diff-51bb955808b4fd7cdfc300b124339375d50475c55013108e741902e2935687f3
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L431
Lib/test/test_zoneinfo/test_zoneinfo.pyhttps://github.com/python/cpython/pull/113829/files#diff-7908b1930bd1135d6f8077ef5ff578b02577f5f7042b54be88b9b86b6c7af45d
View file https://github.com/barneygale/cpython/blob/bb7abe5918acc0f34bdae2d2e303c72839059aa0/Lib/test/test_zoneinfo/test_zoneinfo.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/113829/{{ revealButtonHref }}
https://github.com/python/cpython/pull/113829/files#diff-7908b1930bd1135d6f8077ef5ff578b02577f5f7042b54be88b9b86b6c7af45d
https://github.com/python/cpython/pull/113829/files#diff-7908b1930bd1135d6f8077ef5ff578b02577f5f7042b54be88b9b86b6c7af45d
https://github.com/python/cpython/pull/113829/files#diff-7908b1930bd1135d6f8077ef5ff578b02577f5f7042b54be88b9b86b6c7af45d
https://github.com/python/cpython/pull/113829/files#diff-7908b1930bd1135d6f8077ef5ff578b02577f5f7042b54be88b9b86b6c7af45d
https://github.com/python/cpython/pull/113829/files#diff-7908b1930bd1135d6f8077ef5ff578b02577f5f7042b54be88b9b86b6c7af45d
https://github.com/python/cpython/pull/113829/files#diff-7908b1930bd1135d6f8077ef5ff578b02577f5f7042b54be88b9b86b6c7af45d
https://github.com/python/cpython/pull/113829/files#diff-7908b1930bd1135d6f8077ef5ff578b02577f5f7042b54be88b9b86b6c7af45d
https://github.com/python/cpython/pull/113829/files#diff-7908b1930bd1135d6f8077ef5ff578b02577f5f7042b54be88b9b86b6c7af45d
Misc/NEWS.d/next/Tests/2024-01-08-21-15-48.gh-issue-44626.DRq-PR.rsthttps://github.com/python/cpython/pull/113829/files#diff-1a4e692d6b1ed0303b3c5da1caa06412519a8d0dd712fd2012da24de5a5e0f14
View file https://github.com/barneygale/cpython/blob/bb7abe5918acc0f34bdae2d2e303c72839059aa0/Misc/NEWS.d/next/Tests/2024-01-08-21-15-48.gh-issue-44626.DRq-PR.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/113829/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.