René's URL Explorer Experiment


Title: bpo-28503: Use crypt_r() when available instead of crypt() by gpshead · Pull Request #11373 · python/cpython · GitHub

Open Graph Title: bpo-28503: Use crypt_r() when available instead of crypt() by gpshead · Pull Request #11373 · python/cpython

X Title: bpo-28503: Use crypt_r() when available instead of crypt() by gpshead · Pull Request #11373 · python/cpython

Description: Use the crypt_r library function instead of crypt when available (currently Linux and FreeBSD) to avoid using static shared libc data structures. Motivation: This fixes a memory sanitizer failure due to it not understanding libc crypt()'s preallocated space. We could release the GIL around the crypt_r call, but it is such a fast function anyways that seems rather silly. Do that in a followup PR if desired. https://bugs.python.org/issue28503

Open Graph Description: Use the crypt_r library function instead of crypt when available (currently Linux and FreeBSD) to avoid using static shared libc data structures. Motivation: This fixes a memory sanitizer failure d...

X Description: Use the crypt_r library function instead of crypt when available (currently Linux and FreeBSD) to avoid using static shared libc data structures. Motivation: This fixes a memory sanitizer failure d...

Opengraph URL: https://github.com/python/cpython/pull/11373

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d1e83c36-f6a4-5273-8c52-740a682195c3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE1B0:19C73D:E0ABD9:12ECF72:6A5326B9
html-safe-nonce72d7c046adde8666bbdbf6de3068ff6b0a8372f54e842d1f79675400b15cfaec
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMUIwOjE5QzczRDpFMEFCRDk6MTJFQ0Y3Mjo2QTUzMjZCOSIsInZpc2l0b3JfaWQiOiI4MzQwOTk5NDcwNDIzNjgwNjk4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacaffcc1dda797b5b03af29d86cd97cb96157f0bb32441d21e7f11af68da07a0db
hovercard-subject-tagpull_request:241513017
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/11373/files
twitter:imagehttps://avatars.githubusercontent.com/u/68491?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/68491?s=400&v=4
og:image:altUse the crypt_r library function instead of crypt when available (currently Linux and FreeBSD) to avoid using static shared libc data structures. Motivation: This fixes a memory sanitizer failure d...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/11373/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F11373%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F11373%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/11373/files
Reloadhttps://github.com/python/cpython/pull/11373/files
Reloadhttps://github.com/python/cpython/pull/11373/files
Please reload this pagehttps://github.com/python/cpython/pull/11373/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/11373/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
gpsheadhttps://github.com/gpshead
python:masterhttps://github.com/python/cpython/tree/master
gpshead:use_crypt_rhttps://github.com/gpshead/cpython/tree/use_crypt_r
Conversation 4 https://github.com/python/cpython/pull/11373
Commits 3 https://github.com/python/cpython/pull/11373/commits
Checks 0 https://github.com/python/cpython/pull/11373/checks
Files changed https://github.com/python/cpython/pull/11373/files
Please reload this pagehttps://github.com/python/cpython/pull/11373/files
bpo-28503: Use crypt_r() when available instead of crypt() https://github.com/python/cpython/pull/11373/files#top
Show all changes 3 commits https://github.com/python/cpython/pull/11373/files
bc580e1 Use crypt_r() when available instead of crypt(). gpshead Dec 30, 2018 https://github.com/python/cpython/pull/11373/commits/bc580e1d0339588fbfcd2e6fda1caed9ba8c017f
d659d5f Search for crypt_r independant of crypt. gpshead Dec 30, 2018 https://github.com/python/cpython/pull/11373/commits/d659d5f8955afcc1e1b1d567166f065c908f86b1
ae9df3e Make my comment pedantically correct. gpshead Dec 30, 2018 https://github.com/python/cpython/pull/11373/commits/ae9df3e3e337d4d9b704c81a4db416357b27f41d
Clear filters https://github.com/python/cpython/pull/11373/files
Please reload this pagehttps://github.com/python/cpython/pull/11373/files
Please reload this pagehttps://github.com/python/cpython/pull/11373/files
Python.h https://github.com/python/cpython/pull/11373/files#diff-f60ef9db994347493c9ad11a939d46272a5b9a3d03e9aa22f186a87dd9ce8769
2018-12-30-14-56-33.bpo-28503.V4kNN3.rst https://github.com/python/cpython/pull/11373/files#diff-7905556dada3eb338166cdeda93915b1abbb9c76152a84c37d674efc28d92d5a
_cryptmodule.c https://github.com/python/cpython/pull/11373/files#diff-ead1009bc9bbe5d9681626f08d79c02a40bb9551c5a4248d5b3100d5cad83e35
configure https://github.com/python/cpython/pull/11373/files#diff-90d08e583c4c9c6f391b2ae90f819f600a6326928ea9512c9e0c6d98e9f29ac2
configure.ac https://github.com/python/cpython/pull/11373/files#diff-49473dca262eeab3b4a43002adb08b4db31020d190caaad1594b47f1d5daa810
pyconfig.h.in https://github.com/python/cpython/pull/11373/files#diff-f67052280dd3a53f0e713339632a8c10bc2e420e24a70852d83aeb50d495835f
Include/Python.hhttps://github.com/python/cpython/pull/11373/files#diff-f60ef9db994347493c9ad11a939d46272a5b9a3d03e9aa22f186a87dd9ce8769
View file https://github.com/gpshead/cpython/blob/ae9df3e3e337d4d9b704c81a4db416357b27f41d/Include/Python.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/11373/{{ revealButtonHref }}
https://github.com/python/cpython/pull/11373/files#diff-f60ef9db994347493c9ad11a939d46272a5b9a3d03e9aa22f186a87dd9ce8769
https://github.com/python/cpython/pull/11373/files#diff-f60ef9db994347493c9ad11a939d46272a5b9a3d03e9aa22f186a87dd9ce8769
Misc/NEWS.d/next/Library/2018-12-30-14-56-33.bpo-28503.V4kNN3.rsthttps://github.com/python/cpython/pull/11373/files#diff-7905556dada3eb338166cdeda93915b1abbb9c76152a84c37d674efc28d92d5a
View file https://github.com/gpshead/cpython/blob/ae9df3e3e337d4d9b704c81a4db416357b27f41d/Misc/NEWS.d/next/Library/2018-12-30-14-56-33.bpo-28503.V4kNN3.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/11373/{{ revealButtonHref }}
Modules/_cryptmodule.chttps://github.com/python/cpython/pull/11373/files#diff-ead1009bc9bbe5d9681626f08d79c02a40bb9551c5a4248d5b3100d5cad83e35
View file https://github.com/gpshead/cpython/blob/ae9df3e3e337d4d9b704c81a4db416357b27f41d/Modules/_cryptmodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/11373/{{ revealButtonHref }}
https://github.com/python/cpython/pull/11373/files#diff-ead1009bc9bbe5d9681626f08d79c02a40bb9551c5a4248d5b3100d5cad83e35
https://github.com/python/cpython/pull/11373/files#diff-ead1009bc9bbe5d9681626f08d79c02a40bb9551c5a4248d5b3100d5cad83e35
configurehttps://github.com/python/cpython/pull/11373/files#diff-90d08e583c4c9c6f391b2ae90f819f600a6326928ea9512c9e0c6d98e9f29ac2
View file https://github.com/gpshead/cpython/blob/ae9df3e3e337d4d9b704c81a4db416357b27f41d/configure
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/11373/{{ revealButtonHref }}
https://github.com/python/cpython/pull/11373/files#diff-90d08e583c4c9c6f391b2ae90f819f600a6326928ea9512c9e0c6d98e9f29ac2
https://github.com/python/cpython/pull/11373/files#diff-90d08e583c4c9c6f391b2ae90f819f600a6326928ea9512c9e0c6d98e9f29ac2
configure.achttps://github.com/python/cpython/pull/11373/files#diff-49473dca262eeab3b4a43002adb08b4db31020d190caaad1594b47f1d5daa810
View file https://github.com/gpshead/cpython/blob/ae9df3e3e337d4d9b704c81a4db416357b27f41d/configure.ac
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/11373/{{ revealButtonHref }}
https://github.com/python/cpython/pull/11373/files#diff-49473dca262eeab3b4a43002adb08b4db31020d190caaad1594b47f1d5daa810
https://github.com/python/cpython/pull/11373/files#diff-49473dca262eeab3b4a43002adb08b4db31020d190caaad1594b47f1d5daa810
pyconfig.h.inhttps://github.com/python/cpython/pull/11373/files#diff-f67052280dd3a53f0e713339632a8c10bc2e420e24a70852d83aeb50d495835f
View file https://github.com/gpshead/cpython/blob/ae9df3e3e337d4d9b704c81a4db416357b27f41d/pyconfig.h.in
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/11373/{{ revealButtonHref }}
https://github.com/python/cpython/pull/11373/files#diff-f67052280dd3a53f0e713339632a8c10bc2e420e24a70852d83aeb50d495835f
https://github.com/python/cpython/pull/11373/files#diff-f67052280dd3a53f0e713339632a8c10bc2e420e24a70852d83aeb50d495835f
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.