René's URL Explorer Experiment


Title: gh-92936: allow double quote in cookie values by nburns · Pull Request #113663 · python/cpython · GitHub

Open Graph Title: gh-92936: allow double quote in cookie values by nburns · Pull Request #113663 · python/cpython

X Title: gh-92936: allow double quote in cookie values by nburns · Pull Request #113663 · python/cpython

Description: As detailed more extensively in: #92936 it's not uncommon to see cookies with json and therefore double quotes in them. While IMO a well behaved application would base64 or otherwise encode those values, there are numerous services putting double quotes in the cookies, and it would be nice to have support for this directly in python so various http server/client/util libraries don't need to implement their own cookie parsing. Additionally browsers are tolerant of and handle double quotes in cookie values so SimpleCookie should also. Before this change SimpleCookie will without error drop cookie values that appear after a value with a double quote in them, which can lead to some very confusing and hard to debug issues when implementing http clients and servers. After this change SimpleCookie allows a double quote character in the values section of the cookie while making no attempt to determine if the value is valid json or anything else (since that's a application/usecase specific concern) Downstream issues: aio-libs/aiohttp#7993 yt-dlp/yt-dlp#4780 Issue: gh-92936

Open Graph Description: As detailed more extensively in: #92936 it's not uncommon to see cookies with json and therefore double quotes in them. While IMO a well behaved application would base64 or otherwise encode tho...

X Description: As detailed more extensively in: #92936 it's not uncommon to see cookies with json and therefore double quotes in them. While IMO a well behaved application would base64 or otherwise encode...

Opengraph URL: https://github.com/python/cpython/pull/113663

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:97b30612-f98a-4d91-228d-bdbe6e1aa795
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB1A4:29068E:64D2:83EC:6B021E55
html-safe-noncebda0fcfba3d3f1c5f508dfa12c981b4818ed7e8d218c8c880d9b697cb08bdc50
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMUE0OjI5MDY4RTo2NEQyOjgzRUM6NkIwMjFFNTUiLCJ2aXNpdG9yX2lkIjoiNjU4NDU4MzEzODg4MDY1OTAyOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9b86b7571d697b74f8e2c73569a9174baf9fa59829b7d3c4fc204a09d7d2c474
hovercard-subject-tagpull_request:1662222810
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/113663/files
twitter:imagehttps://avatars.githubusercontent.com/u/1725338?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1725338?s=400&v=4
og:image:altAs detailed more extensively in: #92936 it's not uncommon to see cookies with json and therefore double quotes in them. While IMO a well behaved application would base64 or otherwise encode tho...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/113663/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F113663%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F113663%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/113663/files
Reloadhttps://github.com/python/cpython/pull/113663/files
Reloadhttps://github.com/python/cpython/pull/113663/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
orsenthilhttps://github.com/orsenthil
python:mainhttps://github.com/python/cpython/tree/main
nburns:allow-double-quote-in-cookie-valueshttps://github.com/nburns/cpython/tree/allow-double-quote-in-cookie-values
Conversation 17 https://github.com/python/cpython/pull/113663
Commits 2 https://github.com/python/cpython/pull/113663/commits
Checks 0 https://github.com/python/cpython/pull/113663/checks
Files changed https://github.com/python/cpython/pull/113663/files
Please reload this pagehttps://github.com/python/cpython/pull/113663/files
gh-92936: allow double quote in cookie values https://github.com/python/cpython/pull/113663/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/113663/files
423efc5 allow double quote in cookie values nburns Jan 2, 2024 https://github.com/python/cpython/pull/113663/commits/423efc50f9e44632ecea00123011c25b553f917a
081ace2 Update Lib/test/test_http_cookies.py nburns Aug 8, 2025 https://github.com/python/cpython/pull/113663/commits/081ace233f6bf22f80a8f6794fd731a8d61f8351
Clear filters https://github.com/python/cpython/pull/113663/files
Please reload this pagehttps://github.com/python/cpython/pull/113663/files
Please reload this pagehttps://github.com/python/cpython/pull/113663/files
cookies.py https://github.com/python/cpython/pull/113663/files#diff-e49aab1421911b035542d1a9221c31b8c74053f0e8b28f90f03af66177026176
test_http_cookies.py https://github.com/python/cpython/pull/113663/files#diff-c76b9066e16ee59493163f762aae4279fd1533f96181cddf0c3d63b1c8ec19aa
2025-08-08-21-20-14.gh-issue-92936.rOgG1S.rst https://github.com/python/cpython/pull/113663/files#diff-db13b8051449bfc93d125978a238d5c9534aa610852a48665d504000b3d64c27
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L503
Lib/http/cookies.pyhttps://github.com/python/cpython/pull/113663/files#diff-e49aab1421911b035542d1a9221c31b8c74053f0e8b28f90f03af66177026176
View file https://github.com/nburns/cpython/blob/081ace233f6bf22f80a8f6794fd731a8d61f8351/Lib/http/cookies.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/113663/{{ revealButtonHref }}
https://github.com/python/cpython/pull/113663/files#diff-e49aab1421911b035542d1a9221c31b8c74053f0e8b28f90f03af66177026176
https://github.com/python/cpython/pull/113663/files#diff-e49aab1421911b035542d1a9221c31b8c74053f0e8b28f90f03af66177026176
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L504
Lib/test/test_http_cookies.pyhttps://github.com/python/cpython/pull/113663/files#diff-c76b9066e16ee59493163f762aae4279fd1533f96181cddf0c3d63b1c8ec19aa
View file https://github.com/nburns/cpython/blob/081ace233f6bf22f80a8f6794fd731a8d61f8351/Lib/test/test_http_cookies.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/113663/{{ revealButtonHref }}
https://github.com/python/cpython/pull/113663/files#diff-c76b9066e16ee59493163f762aae4279fd1533f96181cddf0c3d63b1c8ec19aa
https://github.com/python/cpython/pull/113663/files#diff-c76b9066e16ee59493163f762aae4279fd1533f96181cddf0c3d63b1c8ec19aa
Misc/NEWS.d/next/Library/2025-08-08-21-20-14.gh-issue-92936.rOgG1S.rsthttps://github.com/python/cpython/pull/113663/files#diff-db13b8051449bfc93d125978a238d5c9534aa610852a48665d504000b3d64c27
View file https://github.com/nburns/cpython/blob/081ace233f6bf22f80a8f6794fd731a8d61f8351/Misc/NEWS.d/next/Library/2025-08-08-21-20-14.gh-issue-92936.rOgG1S.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/113663/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.