René's URL Explorer Experiment


Title: gh-112898: Fix double close dialog with warning about unsafed files by ronaldoussoren · Pull Request #113513 · python/cpython · GitHub

Open Graph Title: gh-112898: Fix double close dialog with warning about unsafed files by ronaldoussoren · Pull Request #113513 · python/cpython

X Title: gh-112898: Fix double close dialog with warning about unsafed files by ronaldoussoren · Pull Request #113513 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Without this changeset I get two consecutive dialogs asking if I want to save an unsafed file, when choosing "Cancel" in the first one. Issue: IDLE on macOS will close without warning w...

X Description: Without this changeset I get two consecutive dialogs asking if I want to save an unsafed file, when choosing "Cancel" in the first one. Issue: IDLE on macOS will close without w...

Opengraph URL: https://github.com/python/cpython/pull/113513

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:320a434a-f080-78aa-15c2-e3dd87532f6a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE7B2:16AB79:476F118:5A9A32C:6B02448D
html-safe-nonce5b71710dba153b88a42d84c418a506f76cbb52fe43530af852a0ec6ae1180ed8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFN0IyOjE2QUI3OTo0NzZGMTE4OjVBOUEzMkM6NkIwMjQ0OEQiLCJ2aXNpdG9yX2lkIjoiODA5MzE2NTExMjgzMzIyOTk2NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac3a8c2d5dae08e2453340a26ac1e06e8668037d341fdc1fd1d217f0e7b3aa4508
hovercard-subject-tagpull_request:1658094984
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/113513/commits
twitter:imagehttps://opengraph.githubassets.com/2e9383c86f93e8a6539d8163c248fe6a80591b0e01348b1f10262ea84f8a49fd/python/cpython/pull/113513
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2e9383c86f93e8a6539d8163c248fe6a80591b0e01348b1f10262ea84f8a49fd/python/cpython/pull/113513
og:image:altWithout this changeset I get two consecutive dialogs asking if I want to save an unsafed file, when choosing "Cancel" in the first one. Issue: IDLE on macOS will close without warning w...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameronaldoussoren
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/113513/commits#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F113513%2Fcommits
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F113513%2Fcommits
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/113513/commits
Reloadhttps://github.com/python/cpython/pull/113513/commits
Reloadhttps://github.com/python/cpython/pull/113513/commits
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
ronaldoussorenhttps://github.com/ronaldoussoren
python:mainhttps://github.com/python/cpython/tree/main
ronaldoussoren:gh-112898-double-dialoghttps://github.com/ronaldoussoren/cpython/tree/gh-112898-double-dialog
Conversationhttps://github.com/python/cpython/pull/113513
Commits18 (18)https://github.com/python/cpython/pull/113513/commits
Checkshttps://github.com/python/cpython/pull/113513/checks
Files changedhttps://github.com/python/cpython/pull/113513/files
gh-112898: Fix double close dialog with warning about unsafed fileshttps://github.com/python/cpython/pull/113513/commits#top
ronaldoussorenhttps://github.com/ronaldoussoren
python:mainhttps://github.com/python/cpython/tree/main
ronaldoussoren:gh-112898-double-dialoghttps://github.com/ronaldoussoren/cpython/tree/gh-112898-double-dialog
gh-112898: Fix double close dialog with warning about unsafed fileshttps://github.com/python/cpython/pull/113513/commits/a0bb7abe46aedbe480f4e8378f9a27111e0b39f5
https://github.com/ronaldoussoren
ronaldoussorenhttps://github.com/python/cpython/commits?author=ronaldoussoren
a0bb7abhttps://github.com/python/cpython/pull/113513/commits/a0bb7abe46aedbe480f4e8378f9a27111e0b39f5
https://github.com/python/cpython/tree/a0bb7abe46aedbe480f4e8378f9a27111e0b39f5
Actually work with various quit events (menu, shortcut, osascript)https://github.com/python/cpython/pull/113513/commits/eda57502a75dd763413226a7bcaaa6a8d495313f
https://github.com/ronaldoussoren
ronaldoussorenhttps://github.com/python/cpython/commits?author=ronaldoussoren
eda5750https://github.com/python/cpython/pull/113513/commits/eda57502a75dd763413226a7bcaaa6a8d495313f
https://github.com/python/cpython/tree/eda57502a75dd763413226a7bcaaa6a8d495313f
Remove comment that is no longer neededhttps://github.com/python/cpython/pull/113513/commits/3686a65339d191c10864bf1d72681aca12baa597
https://github.com/ronaldoussoren
ronaldoussorenhttps://github.com/python/cpython/commits?author=ronaldoussoren
3686a65https://github.com/python/cpython/pull/113513/commits/3686a65339d191c10864bf1d72681aca12baa597
https://github.com/python/cpython/tree/3686a65339d191c10864bf1d72681aca12baa597
Restore working code pathhttps://github.com/python/cpython/pull/113513/commits/b305b36d0def3770bc7e4fa98c77e0fdedf2eb83
https://github.com/ronaldoussoren
ronaldoussorenhttps://github.com/python/cpython/commits?author=ronaldoussoren
b305b36https://github.com/python/cpython/pull/113513/commits/b305b36d0def3770bc7e4fa98c77e0fdedf2eb83
https://github.com/python/cpython/tree/b305b36d0def3770bc7e4fa98c77e0fdedf2eb83
Crude hack to make sure the quit command is calledhttps://github.com/python/cpython/pull/113513/commits/a84a2d7d6f1530647744f6e4fa519e704431bb8b
https://github.com/ronaldoussoren
ronaldoussorenhttps://github.com/python/cpython/commits?author=ronaldoussoren
a84a2d7https://github.com/python/cpython/pull/113513/commits/a84a2d7d6f1530647744f6e4fa519e704431bb8b
https://github.com/python/cpython/tree/a84a2d7d6f1530647744f6e4fa519e704431bb8b
Remove unnecesary key setuphttps://github.com/python/cpython/pull/113513/commits/0ce7d86c31c4529d3c67af43aa86d1a9c1f10fd5
https://github.com/ronaldoussoren
ronaldoussorenhttps://github.com/python/cpython/commits?author=ronaldoussoren
0ce7d86https://github.com/python/cpython/pull/113513/commits/0ce7d86c31c4529d3c67af43aa86d1a9c1f10fd5
https://github.com/python/cpython/tree/0ce7d86c31c4529d3c67af43aa86d1a9c1f10fd5
Remove unnecessary importhttps://github.com/python/cpython/pull/113513/commits/ce08ba0f3283e1dd074e469cdaad34267c29d3b6
https://github.com/ronaldoussoren
ronaldoussorenhttps://github.com/python/cpython/commits?author=ronaldoussoren
ce08ba0https://github.com/python/cpython/pull/113513/commits/ce08ba0f3283e1dd074e469cdaad34267c29d3b6
https://github.com/python/cpython/tree/ce08ba0f3283e1dd074e469cdaad34267c29d3b6
typohttps://github.com/python/cpython/pull/113513/commits/92c1206c7ce3e92c0dc5dfefe97ed22c226768cb
https://github.com/ronaldoussoren
ronaldoussorenhttps://github.com/python/cpython/commits?author=ronaldoussoren
92c1206https://github.com/python/cpython/pull/113513/commits/92c1206c7ce3e92c0dc5dfefe97ed22c226768cb
https://github.com/python/cpython/tree/92c1206c7ce3e92c0dc5dfefe97ed22c226768cb
Getting lost ...https://github.com/python/cpython/pull/113513/commits/4cefbea797d7d6e415fc768e95df568d7b4403e6
https://github.com/ronaldoussoren
ronaldoussorenhttps://github.com/python/cpython/commits?author=ronaldoussoren
4cefbeahttps://github.com/python/cpython/pull/113513/commits/4cefbea797d7d6e415fc768e95df568d7b4403e6
https://github.com/python/cpython/tree/4cefbea797d7d6e415fc768e95df568d7b4403e6
Restructure code to avoid creating a temporary ``tkinter.Tk``https://github.com/python/cpython/pull/113513/commits/bbdee67a1b80d1264e2162a145a23103a9235591
https://github.com/ronaldoussoren
ronaldoussorenhttps://github.com/python/cpython/commits?author=ronaldoussoren
bbdee67https://github.com/python/cpython/pull/113513/commits/bbdee67a1b80d1264e2162a145a23103a9235591
https://github.com/python/cpython/tree/bbdee67a1b80d1264e2162a145a23103a9235591
Document why the close-all-windows keybinding is removed on macOShttps://github.com/python/cpython/pull/113513/commits/ab7800a71cb04d99d6381609c018796c5fee532b
https://github.com/ronaldoussoren
ronaldoussorenhttps://github.com/python/cpython/commits?author=ronaldoussoren
ab7800ahttps://github.com/python/cpython/pull/113513/commits/ab7800a71cb04d99d6381609c018796c5fee532b
https://github.com/python/cpython/tree/ab7800a71cb04d99d6381609c018796c5fee532b
Fix test failure and lint warninghttps://github.com/python/cpython/pull/113513/commits/63087e30b7eb94853070dddd3abbc297b30d1092
https://github.com/ronaldoussoren
ronaldoussorenhttps://github.com/python/cpython/commits?author=ronaldoussoren
63087e3https://github.com/python/cpython/pull/113513/commits/63087e30b7eb94853070dddd3abbc297b30d1092
https://github.com/python/cpython/tree/63087e30b7eb94853070dddd3abbc297b30d1092
Merge branch 'main' into gh-112898-double-dialoghttps://github.com/python/cpython/pull/113513/commits/4c7ad176557faf753c281a28806995aee5748a9a
https://github.com/ronaldoussoren
ronaldoussorenhttps://github.com/python/cpython/commits?author=ronaldoussoren
4c7ad17https://github.com/python/cpython/pull/113513/commits/4c7ad176557faf753c281a28806995aee5748a9a
https://github.com/python/cpython/tree/4c7ad176557faf753c281a28806995aee5748a9a
The changes to macosx.py broke some of the testshttps://github.com/python/cpython/pull/113513/commits/4794ee7ba640c05d93b455c97c7517e31766f71c
https://github.com/ronaldoussoren
ronaldoussorenhttps://github.com/python/cpython/commits?author=ronaldoussoren
4794ee7https://github.com/python/cpython/pull/113513/commits/4794ee7ba640c05d93b455c97c7517e31766f71c
https://github.com/python/cpython/tree/4794ee7ba640c05d93b455c97c7517e31766f71c
Fix copy&paste errorhttps://github.com/python/cpython/pull/113513/commits/8d9a7f0b5e85879785aa15cb935069e4f5b747f8
https://github.com/ronaldoussoren
ronaldoussorenhttps://github.com/python/cpython/commits?author=ronaldoussoren
8d9a7f0https://github.com/python/cpython/pull/113513/commits/8d9a7f0b5e85879785aa15cb935069e4f5b747f8
https://github.com/python/cpython/tree/8d9a7f0b5e85879785aa15cb935069e4f5b747f8
Merge branch 'main' into gh-112898-double-dialoghttps://github.com/python/cpython/pull/113513/commits/7ccc8fa03bd47b027300ce639c095c00c90315b7
https://github.com/terryjreedy
terryjreedyhttps://github.com/python/cpython/commits?author=terryjreedy
7ccc8fahttps://github.com/python/cpython/pull/113513/commits/7ccc8fa03bd47b027300ce639c095c00c90315b7
https://github.com/python/cpython/tree/7ccc8fa03bd47b027300ce639c095c00c90315b7
review commentshttps://github.com/python/cpython/pull/113513/commits/bf6f348c40228dda24edec349b324ab1d13b00cd
https://github.com/ronaldoussoren
ronaldoussorenhttps://github.com/python/cpython/commits?author=ronaldoussoren
bf6f348https://github.com/python/cpython/pull/113513/commits/bf6f348c40228dda24edec349b324ab1d13b00cd
https://github.com/python/cpython/tree/bf6f348c40228dda24edec349b324ab1d13b00cd
Merge branch 'gh-112898-double-dialog' of github.com:ronaldoussoren/cpython into gh-112898-double-dialoghttps://github.com/python/cpython/pull/113513/commits/60ccabb7cd966f704cf5f453d847be554e7e89f5
https://github.com/ronaldoussoren
ronaldoussorenhttps://github.com/python/cpython/commits?author=ronaldoussoren
60ccabbhttps://github.com/python/cpython/pull/113513/commits/60ccabb7cd966f704cf5f453d847be554e7e89f5
https://github.com/python/cpython/tree/60ccabb7cd966f704cf5f453d847be554e7e89f5
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.