René's URL Explorer Experiment


Title: gh-113317: Clean up Argument Clinic global namespace by erlend-aasland · Pull Request #113414 · python/cpython · GitHub

Open Graph Title: gh-113317: Clean up Argument Clinic global namespace by erlend-aasland · Pull Request #113414 · python/cpython

X Title: gh-113317: Clean up Argument Clinic global namespace by erlend-aasland · Pull Request #113414 · python/cpython

Description: Split up clinic.py by establishing libclinic as a support package for Argument Clinic. Get rid of clinic.py globals by either making them class members, or by putting them into libclinic. Move INC...

Open Graph Description: Split up clinic.py by establishing libclinic as a support package for Argument Clinic. Get rid of clinic.py globals by either making them class members, or by putting them into libclinic. Move INC...

X Description: Split up clinic.py by establishing libclinic as a support package for Argument Clinic. Get rid of clinic.py globals by either making them class members, or by putting them into libclinic. Move INC...

Opengraph URL: https://github.com/python/cpython/pull/113414

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a684034e-2e60-39b6-0068-60444440d429
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE4BA:DAF27:1F3AAC:2B2A77:696A415E
html-safe-nonce60532e28e5f6e0935ecd1185f1323d5db0c12804c77c56d03feaaa70a4da54e5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNEJBOkRBRjI3OjFGM0FBQzoyQjJBNzc6Njk2QTQxNUUiLCJ2aXNpdG9yX2lkIjoiNDQ2ODc3NDU4MjYwNDE1MzE4MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8e625d04eee936446d40dddc5f5bfd6e864019c1017446697f9b814cf19b1170
hovercard-subject-tagpull_request:1655680048
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/113414/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/34a1f659780bd8c96837499499257cee01f77311629adcd1cb85c7c61cc48e05/python/cpython/pull/113414
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/34a1f659780bd8c96837499499257cee01f77311629adcd1cb85c7c61cc48e05/python/cpython/pull/113414
og:image:altSplit up clinic.py by establishing libclinic as a support package for Argument Clinic. Get rid of clinic.py globals by either making them class members, or by putting them into libclinic. Move INC...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameerlend-aasland
hostnamegithub.com
expected-hostnamegithub.com
None321736bfdb3f591415ae895a0459bec204b26a76caf47ba5c980634cfacc4538
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release13581a31d51edf4a3aca179e10890a4d4f9b6d76
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/113414#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F113414
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F113414
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/113414
Reloadhttps://github.com/python/cpython/pull/113414
Reloadhttps://github.com/python/cpython/pull/113414
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/113414
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/113414
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/113414#issue-comment-box
erlend-aaslandhttps://github.com/erlend-aasland
python:mainhttps://github.com/python/cpython/tree/main
erlend-aasland:clinic/globalshttps://github.com/erlend-aasland/cpython/tree/clinic/globals
gh-113317: Clean up Argument Clinic global namespace https://github.com/python/cpython/pull/113414#top
erlend-aaslandhttps://github.com/erlend-aasland
python:mainhttps://github.com/python/cpython/tree/main
erlend-aasland:clinic/globalshttps://github.com/erlend-aasland/cpython/tree/clinic/globals
Conversation 8 https://github.com/python/cpython/pull/113414
Commits 10 https://github.com/python/cpython/pull/113414/commits
Checks 0 https://github.com/python/cpython/pull/113414/checks
Files changed https://github.com/python/cpython/pull/113414/files
Please reload this pagehttps://github.com/python/cpython/pull/113414
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Dec 22, 2023https://github.com/python/cpython/pull/113414#issue-2054559712
Please reload this pagehttps://github.com/python/cpython/pull/113414
Argument Clinic: split out global stateless helpers and constants from clinic.py #113317https://github.com/python/cpython/issues/113317
Please reload this pagehttps://github.com/python/cpython/pull/113414
https://github.com/erlend-aasland
pythongh-113317https://github.com/python/cpython/issues/113317
: Clean up Argument Clinic global namespacehttps://github.com/python/cpython/pull/113414/commits/6dc7246c61f8fb9cdebc03f91ae12bf50d8bf1e4
6dc7246https://github.com/python/cpython/pull/113414/commits/6dc7246c61f8fb9cdebc03f91ae12bf50d8bf1e4
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
AlexWaygoodhttps://github.com/AlexWaygood
code ownerhttps://github.com/python/cpython/blob/9c3ddf31a34295ebcef6dc49b9e0ddd75d0ea9f1/.github/CODEOWNERS#L188
December 22, 2023 22:47https://github.com/python/cpython/pull/113414#event-11329740220
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Dec 22, 2023https://github.com/python/cpython/pull/113414#event-11329740275
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Dec 22, 2023https://github.com/python/cpython/pull/113414#event-11329740416
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Dec 22, 2023 https://github.com/python/cpython/pull/113414#ref-issue-2050482755
Argument Clinic: split out global stateless helpers and constants from clinic.py #113317 https://github.com/python/cpython/issues/113317
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Dec 22, 2023 https://github.com/python/cpython/pull/113414#ref-pullrequest-2051427387
PoC: Get rid of some globals Argument-Clinic/cpython#30 https://github.com/Argument-Clinic/cpython/pull/30
erlend-aaslandhttps://github.com/erlend-aasland
December 22, 2023 23:50https://github.com/python/cpython/pull/113414#commits-pushed-9e5ee9f
https://github.com/erlend-aasland
Address Alex's initial review commentshttps://github.com/python/cpython/pull/113414/commits/9e5ee9fe02b2a02487d5ba8875d5aaeba528907d
9e5ee9fhttps://github.com/python/cpython/pull/113414/commits/9e5ee9fe02b2a02487d5ba8875d5aaeba528907d
https://github.com/erlend-aasland
Fix indenthttps://github.com/python/cpython/pull/113414/commits/c94618b17a1de5e6f01a1d8e3a5a3a0467aac185
c94618bhttps://github.com/python/cpython/pull/113414/commits/c94618b17a1de5e6f01a1d8e3a5a3a0467aac185
https://github.com/erlend-aasland
Fix more indentshttps://github.com/python/cpython/pull/113414/commits/e5168ff9a2d6e304841703b37d62a173b5e976e9
e5168ffhttps://github.com/python/cpython/pull/113414/commits/e5168ff9a2d6e304841703b37d62a173b5e976e9
https://github.com/erlend-aasland
Oh well, since we're introducing a new file, let's just run black on ithttps://github.com/python/cpython/pull/113414/commits/fe04157926e43c1e950e650d82805868c200dd57
fe04157https://github.com/python/cpython/pull/113414/commits/fe04157926e43c1e950e650d82805868c200dd57
https://github.com/erlend-aasland
Also blacken __init__.pyhttps://github.com/python/cpython/pull/113414/commits/a0c2ce5b0ad6b27c6f109377788181efa036e82a
a0c2ce5https://github.com/python/cpython/pull/113414/commits/a0c2ce5b0ad6b27c6f109377788181efa036e82a
https://github.com/erlend-aasland
Commentshttps://github.com/python/cpython/pull/113414/commits/87e55141860d17c4d87810fa2509f4747380518a
87e5514https://github.com/python/cpython/pull/113414/commits/87e55141860d17c4d87810fa2509f4747380518a
https://github.com/erlend-aasland
Nitshttps://github.com/python/cpython/pull/113414/commits/11cada6e980b282f599788e95a544aa2e3d53413
11cada6https://github.com/python/cpython/pull/113414/commits/11cada6e980b282f599788e95a544aa2e3d53413
https://github.com/erlend-aasland
Nitshttps://github.com/python/cpython/pull/113414/commits/2bd7ea4fed6e6ab8ea92619063a9397cc095165d
2bd7ea4https://github.com/python/cpython/pull/113414/commits/2bd7ea4fed6e6ab8ea92619063a9397cc095165d
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Dec 22, 2023 https://github.com/python/cpython/pull/113414#pullrequestreview-1795347409
View reviewed changes https://github.com/python/cpython/pull/113414/files/2bd7ea4fed6e6ab8ea92619063a9397cc095165d
Tools/clinic/libclinic/formatting.pyhttps://github.com/python/cpython/pull/113414/files/2bd7ea4fed6e6ab8ea92619063a9397cc095165d#diff-d5b4f1cc65d35f4e2404eb019dc74e393f90e143eeded71a71e50d5930b02cb5
Please reload this pagehttps://github.com/python/cpython/pull/113414
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Dec 23, 2023 https://github.com/python/cpython/pull/113414#pullrequestreview-1795356865
View reviewed changes https://github.com/python/cpython/pull/113414/files/2bd7ea4fed6e6ab8ea92619063a9397cc095165d
AlexWaygoodhttps://github.com/AlexWaygood
Please reload this pagehttps://github.com/python/cpython/pull/113414
https://github.com/python/cpython/pull/113414#pullrequestreview-1795356865
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/113414
Lib/test/test_clinic.pyhttps://github.com/python/cpython/pull/113414/files/2bd7ea4fed6e6ab8ea92619063a9397cc095165d#diff-0267fab8cf520e17e208f9f0d8fb6fbd2ec5fb6eb5c7dbab5bc08a01239938bf
Please reload this pagehttps://github.com/python/cpython/pull/113414
Tools/clinic/libclinic/__init__.pyhttps://github.com/python/cpython/pull/113414/files/2bd7ea4fed6e6ab8ea92619063a9397cc095165d#diff-72db93a6a0b16a522dbc4bea19231cdbf197c0428fe1339a4998817662cd9b78
Please reload this pagehttps://github.com/python/cpython/pull/113414
Tools/clinic/libclinic/formatting.pyhttps://github.com/python/cpython/pull/113414/files/2bd7ea4fed6e6ab8ea92619063a9397cc095165d#diff-d5b4f1cc65d35f4e2404eb019dc74e393f90e143eeded71a71e50d5930b02cb5
Please reload this pagehttps://github.com/python/cpython/pull/113414
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Dec 23, 2023https://github.com/python/cpython/pull/113414#event-11329904559
https://github.com/erlend-aasland
Address reviewhttps://github.com/python/cpython/pull/113414/commits/6a2b9e471de0f57669a84a01ee875b993099c34e
6a2b9e4https://github.com/python/cpython/pull/113414/commits/6a2b9e471de0f57669a84a01ee875b993099c34e
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
December 23, 2023 00:20https://github.com/python/cpython/pull/113414#event-11329926539
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Dec 23, 2023https://github.com/python/cpython/pull/113414#issuecomment-1868148029
Please reload this pagehttps://github.com/python/cpython/pull/113414
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
c3f92f6https://github.com/python/cpython/commit/c3f92f6a7513340dfe2d82bfcd38eb77453e935d
Dec 23, 2023https://github.com/python/cpython/pull/113414#event-11329958070
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
December 23, 2023 00:37https://github.com/python/cpython/pull/113414#event-11329958086
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Dec 23, 2023https://github.com/python/cpython/pull/113414#event-11329958137
ryan-duvehttps://github.com/ryan-duve
Dec 26, 2023 https://github.com/python/cpython/pull/113414#ref-commit-d05281a
https://github.com/erlend-aasland
https://github.com/ryan-duve
pythongh-113317https://github.com/python/cpython/issues/113317
: Clean up Argument Clinic global namespace (https://github.com/ryan-duve/cpython/commit/d05281a84644f5800b66dedda343d54288dd5998
python#11…https://github.com/python/cpython/pull/113414
d05281ahttps://github.com/ryan-duve/cpython/commit/d05281a84644f5800b66dedda343d54288dd5998
…3414https://github.com/python/cpython/pull/113414
kulikjakhttps://github.com/kulikjak
Jan 22, 2024 https://github.com/python/cpython/pull/113414#ref-commit-17c9d92
https://github.com/erlend-aasland
https://github.com/kulikjak
pythongh-113317https://github.com/python/cpython/issues/113317
: Clean up Argument Clinic global namespace (https://github.com/kulikjak/cpython/commit/17c9d92d562e8bec8f9c15842062bbf006826f8b
python#11…https://github.com/python/cpython/pull/113414
17c9d92https://github.com/kulikjak/cpython/commit/17c9d92d562e8bec8f9c15842062bbf006826f8b
…3414https://github.com/python/cpython/pull/113414
aiskhttps://github.com/aisk
Feb 11, 2024 https://github.com/python/cpython/pull/113414#ref-commit-527be4d
https://github.com/erlend-aasland
https://github.com/aisk
pythongh-113317https://github.com/python/cpython/issues/113317
: Clean up Argument Clinic global namespace (https://github.com/aisk/cpython/commit/527be4d0b39600f83971f0031ac104628c1d84da
python#11…https://github.com/python/cpython/pull/113414
527be4dhttps://github.com/aisk/cpython/commit/527be4d0b39600f83971f0031ac104628c1d84da
…3414https://github.com/python/cpython/pull/113414
Glyphackhttps://github.com/Glyphack
Sep 2, 2024 https://github.com/python/cpython/pull/113414#ref-commit-5b0a168
https://github.com/erlend-aasland
https://github.com/Glyphack
pythongh-113317https://github.com/python/cpython/issues/113317
: Clean up Argument Clinic global namespace (https://github.com/Glyphack/cpython/commit/5b0a168b888045402f5bf47bc137175fb6b0a300
python#11…https://github.com/python/cpython/pull/113414
5b0a168https://github.com/Glyphack/cpython/commit/5b0a168b888045402f5bf47bc137175fb6b0a300
…3414https://github.com/python/cpython/pull/113414
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F113414
https://github.com/AlexWaygood
AlexWaygood https://github.com/AlexWaygood
https://github.com/python/cpython/pull/113414/files/6a2b9e471de0f57669a84a01ee875b993099c34e
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/113414
https://github.com/erlend-aasland
https://github.com/AlexWaygood
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.