René's URL Explorer Experiment


Title: [3.11] GH-113214: Fix SSLProto exception handling in SSL-over-SSL scenarios (GH-113334) by miss-islington · Pull Request #113340 · python/cpython · GitHub

Open Graph Title: [3.11] GH-113214: Fix SSLProto exception handling in SSL-over-SSL scenarios (GH-113334) by miss-islington · Pull Request #113340 · python/cpython

X Title: [3.11] GH-113214: Fix SSLProto exception handling in SSL-over-SSL scenarios (GH-113334) by miss-islington · Pull Request #113340 · python/cpython

Description: When wrapped, _SSLProtocolTransport._force_close(exc) is called just like in the unwrapped scenario _SelectorTransport._force_close(exc) or _ProactorBasePipeTransport._force_close(exc) would be called, except here the exception needs to be passed through the SSLProtocol._abort() method, which didn't accept an exception object. This commit ensures that this path works, in the same way that the uvloop implementation of SSLProto passes on the exception (on which the current implementation of SSLProto is based). (cherry picked from commit 1ff0238) Co-authored-by: Martijn Pieters mj@zopatista.com Issue: gh-113214

Open Graph Description: When wrapped, _SSLProtocolTransport._force_close(exc) is called just like in the unwrapped scenario _SelectorTransport._force_close(exc) or _ProactorBasePipeTransport._force_close(exc) would be cal...

X Description: When wrapped, _SSLProtocolTransport._force_close(exc) is called just like in the unwrapped scenario _SelectorTransport._force_close(exc) or _ProactorBasePipeTransport._force_close(exc) would be cal...

Opengraph URL: https://github.com/python/cpython/pull/113340

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3ac05d83-eea8-e874-11f7-450733904c3f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id91BE:3C28FE:58353E:765AD8:6AFEA897
html-safe-nonce4ab2b869e7844f629b9e6e1c62e7f494c1e62008deab97f635abb8f1dfc39a45
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MUJFOjNDMjhGRTo1ODM1M0U6NzY1QUQ4OjZBRkVBODk3IiwidmlzaXRvcl9pZCI6IjU3NDUwODY2NzUxMzA2ODk2ODciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace67ad3d2258d7077897bee0a1692d001804c3c8e508885a161b056ee7293ccac
hovercard-subject-tagpull_request:1652874710
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/113340/files
twitter:imagehttps://avatars.githubusercontent.com/u/31488909?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/31488909?s=400&v=4
og:image:altWhen wrapped, _SSLProtocolTransport._force_close(exc) is called just like in the unwrapped scenario _SelectorTransport._force_close(exc) or _ProactorBasePipeTransport._force_close(exc) would be cal...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None95b2753c978240785d6cca00783c00a371b2d7d9879bb32e305170a1b19bd28e
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3f25273206cd841171bca0002261ae4c9757d934
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/113340/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F113340%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F113340%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/113340/files
Reloadhttps://github.com/python/cpython/pull/113340/files
Reloadhttps://github.com/python/cpython/pull/113340/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
gvanrossumhttps://github.com/gvanrossum
python:3.11https://github.com/python/cpython/tree/3.11
miss-islington:backport-1ff0238-3.11https://github.com/miss-islington/cpython/tree/backport-1ff0238-3.11
Conversation 0 https://github.com/python/cpython/pull/113340
Commits 1 https://github.com/python/cpython/pull/113340/commits
Checks 0 https://github.com/python/cpython/pull/113340/checks
Files changed https://github.com/python/cpython/pull/113340/files
Please reload this pagehttps://github.com/python/cpython/pull/113340/files
[3.11] GH-113214: Fix SSLProto exception handling in SSL-over-SSL scenarios (GH-113334) https://github.com/python/cpython/pull/113340/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/113340/files
46cd200 GH-113214: Fix SSLProto exception handling in SSL-over-SSL scenarios … mjpieters Dec 20, 2023 https://github.com/python/cpython/pull/113340/commits/46cd2001e32b8192fe552da69b8516faa663bc52
Clear filters https://github.com/python/cpython/pull/113340/files
Please reload this pagehttps://github.com/python/cpython/pull/113340/files
Please reload this pagehttps://github.com/python/cpython/pull/113340/files
sslproto.py https://github.com/python/cpython/pull/113340/files#diff-0ae38bdc337cc724282d20111dc780b8a9c07385c80476cf304d5b3c9ec306ec
test_sslproto.py https://github.com/python/cpython/pull/113340/files#diff-b0872a36b23aba6bcdc8de20fae7d2ba78e18885ff8f6b7a5b5e6b2953f0d2a7
2023-12-20-21-18-51.gh-issue-113214.JcV9Mn.rst https://github.com/python/cpython/pull/113340/files#diff-7cc834fba3af034dc715a6d941ef7e670cd94b6d918d1da7f368ae9392dbc826
https://github.com/python/cpython/blob/3.11/.github/CODEOWNERS#L15
Lib/asyncio/sslproto.pyhttps://github.com/python/cpython/pull/113340/files#diff-0ae38bdc337cc724282d20111dc780b8a9c07385c80476cf304d5b3c9ec306ec
View file https://github.com/miss-islington/cpython/blob/46cd2001e32b8192fe552da69b8516faa663bc52/Lib/asyncio/sslproto.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/113340/{{ revealButtonHref }}
https://github.com/python/cpython/pull/113340/files#diff-0ae38bdc337cc724282d20111dc780b8a9c07385c80476cf304d5b3c9ec306ec
https://github.com/python/cpython/pull/113340/files#diff-0ae38bdc337cc724282d20111dc780b8a9c07385c80476cf304d5b3c9ec306ec
https://github.com/python/cpython/pull/113340/files#diff-0ae38bdc337cc724282d20111dc780b8a9c07385c80476cf304d5b3c9ec306ec
https://github.com/python/cpython/pull/113340/files#diff-0ae38bdc337cc724282d20111dc780b8a9c07385c80476cf304d5b3c9ec306ec
https://github.com/python/cpython/pull/113340/files#diff-0ae38bdc337cc724282d20111dc780b8a9c07385c80476cf304d5b3c9ec306ec
https://github.com/python/cpython/pull/113340/files#diff-0ae38bdc337cc724282d20111dc780b8a9c07385c80476cf304d5b3c9ec306ec
https://github.com/python/cpython/blob/3.11/.github/CODEOWNERS#L15
Lib/test/test_asyncio/test_sslproto.pyhttps://github.com/python/cpython/pull/113340/files#diff-b0872a36b23aba6bcdc8de20fae7d2ba78e18885ff8f6b7a5b5e6b2953f0d2a7
View file https://github.com/miss-islington/cpython/blob/46cd2001e32b8192fe552da69b8516faa663bc52/Lib/test/test_asyncio/test_sslproto.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/113340/{{ revealButtonHref }}
https://github.com/python/cpython/pull/113340/files#diff-b0872a36b23aba6bcdc8de20fae7d2ba78e18885ff8f6b7a5b5e6b2953f0d2a7
https://github.com/python/cpython/pull/113340/files#diff-b0872a36b23aba6bcdc8de20fae7d2ba78e18885ff8f6b7a5b5e6b2953f0d2a7
https://github.com/python/cpython/pull/113340/files#diff-b0872a36b23aba6bcdc8de20fae7d2ba78e18885ff8f6b7a5b5e6b2953f0d2a7
https://github.com/python/cpython/pull/113340/files#diff-b0872a36b23aba6bcdc8de20fae7d2ba78e18885ff8f6b7a5b5e6b2953f0d2a7
Misc/NEWS.d/next/Library/2023-12-20-21-18-51.gh-issue-113214.JcV9Mn.rsthttps://github.com/python/cpython/pull/113340/files#diff-7cc834fba3af034dc715a6d941ef7e670cd94b6d918d1da7f368ae9392dbc826
View file https://github.com/miss-islington/cpython/blob/46cd2001e32b8192fe552da69b8516faa663bc52/Misc/NEWS.d/next/Library/2023-12-20-21-18-51.gh-issue-113214.JcV9Mn.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/113340/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.