René's URL Explorer Experiment


Title: gh-113157 gh-89519: Fix method descriptors by rhettinger · Pull Request #113233 · python/cpython · GitHub

Open Graph Title: gh-113157 gh-89519: Fix method descriptors by rhettinger · Pull Request #113233 · python/cpython

X Title: gh-113157 gh-89519: Fix method descriptors by rhettinger · Pull Request #113233 · python/cpython

Description: Fix yet another problem created by classmethod descriptor chaining. This completes the work in gh-89519, fixes the bug reported in gh-113157, and get us back to the stable and correct semantics in Python 3.9. There is still an open question about what if anything to do for Python 3.11 and Python 3.12. We can' t backport this without breaking something else. Issue: gh-113157

Open Graph Description: Fix yet another problem created by classmethod descriptor chaining. This completes the work in gh-89519, fixes the bug reported in gh-113157, and get us back to the stable and correct semantics i...

X Description: Fix yet another problem created by classmethod descriptor chaining. This completes the work in gh-89519, fixes the bug reported in gh-113157, and get us back to the stable and correct semantics i...

Opengraph URL: https://github.com/python/cpython/pull/113233

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:08ef6de4-8eb4-7a97-de2a-94c5e68e4127
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idADC6:366BF1:3C631EF:5372F31:6A60EFEB
html-safe-nonced42392476ddb4d179a45fa1bba6660ca99d31310c5306cd414970ded4bbed61f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBREM2OjM2NkJGMTozQzYzMUVGOjUzNzJGMzE6NkE2MEVGRUIiLCJ2aXNpdG9yX2lkIjoiMTYyMTUxNjk0Njc4NDcxMDYzNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacdeb2b350f7b914ab0e8962e7eba0c99da446c776d660ead09eae484d0039614a
hovercard-subject-tagpull_request:1647392794
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/113233/files
twitter:imagehttps://avatars.githubusercontent.com/u/1623689?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1623689?s=400&v=4
og:image:altFix yet another problem created by classmethod descriptor chaining. This completes the work in gh-89519, fixes the bug reported in gh-113157, and get us back to the stable and correct semantics i...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None3ba36a464b9464992131f4003292a219fc87f92404b0dbe3fd1ef07f11102d0f
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2cc5e4f897a27632dd600edfec4c737bea2f8338
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/113233/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F113233%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F113233%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/113233/files
Reloadhttps://github.com/python/cpython/pull/113233/files
Reloadhttps://github.com/python/cpython/pull/113233/files
Please reload this pagehttps://github.com/python/cpython/pull/113233/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/113233/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.4k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
rhettingerhttps://github.com/rhettinger
python:mainhttps://github.com/python/cpython/tree/main
rhettinger:desc_chain_cleanhttps://github.com/rhettinger/cpython/tree/desc_chain_clean
Conversation 1 https://github.com/python/cpython/pull/113233
Commits 1 https://github.com/python/cpython/pull/113233/commits
Checks 0 https://github.com/python/cpython/pull/113233/checks
Files changed https://github.com/python/cpython/pull/113233/files
Please reload this pagehttps://github.com/python/cpython/pull/113233/files
gh-113157 gh-89519: Fix method descriptors https://github.com/python/cpython/pull/113233/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/113233/files
172f34a gh-113157 gh-89519 Restore behaviors before classmethod descriptor ch… rhettinger Dec 17, 2023 https://github.com/python/cpython/pull/113233/commits/172f34ade1fd44e1394ac0fad1749a1f88478a9a
Clear filters https://github.com/python/cpython/pull/113233/files
Please reload this pagehttps://github.com/python/cpython/pull/113233/files
Please reload this pagehttps://github.com/python/cpython/pull/113233/files
test_descr.py https://github.com/python/cpython/pull/113233/files#diff-6b813570d02ae3544e7e0233ae21d647f8e2dc47486495557e8d16c80460e85b
classobject.c https://github.com/python/cpython/pull/113233/files#diff-d36823aa86f63074d7ae49b390602ea3840cabe4b54484c42aab8ea6b04a1479
Lib/test/test_descr.pyhttps://github.com/python/cpython/pull/113233/files#diff-6b813570d02ae3544e7e0233ae21d647f8e2dc47486495557e8d16c80460e85b
View file https://github.com/rhettinger/cpython/blob/172f34ade1fd44e1394ac0fad1749a1f88478a9a/Lib/test/test_descr.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/113233/{{ revealButtonHref }}
https://github.com/python/cpython/pull/113233/files#diff-6b813570d02ae3544e7e0233ae21d647f8e2dc47486495557e8d16c80460e85b
https://github.com/python/cpython/pull/113233/files#diff-6b813570d02ae3544e7e0233ae21d647f8e2dc47486495557e8d16c80460e85b
Objects/classobject.chttps://github.com/python/cpython/pull/113233/files#diff-d36823aa86f63074d7ae49b390602ea3840cabe4b54484c42aab8ea6b04a1479
View file https://github.com/rhettinger/cpython/blob/172f34ade1fd44e1394ac0fad1749a1f88478a9a/Objects/classobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/113233/{{ revealButtonHref }}
https://github.com/python/cpython/pull/113233/files#diff-d36823aa86f63074d7ae49b390602ea3840cabe4b54484c42aab8ea6b04a1479
https://github.com/python/cpython/pull/113233/files#diff-d36823aa86f63074d7ae49b390602ea3840cabe4b54484c42aab8ea6b04a1479
https://github.com/python/cpython/pull/113233/files#diff-d36823aa86f63074d7ae49b390602ea3840cabe4b54484c42aab8ea6b04a1479
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.