René's URL Explorer Experiment


Title: gh-111178: Avoid calling functions from incompatible pointer types in _tkinter.c by chrstphrchvz · Pull Request #112893 · python/cpython · GitHub

Open Graph Title: gh-111178: Avoid calling functions from incompatible pointer types in _tkinter.c by chrstphrchvz · Pull Request #112893 · python/cpython

X Title: gh-111178: Avoid calling functions from incompatible pointer types in _tkinter.c by chrstphrchvz · Pull Request #112893 · python/cpython

Description: Potential compiler warnings eliminated: ./Modules/_tkinter.c:819:18: warning: cast from 'PyObject *(*)(PyTclObject *, void *)' (aka 'struct _object *(*)(PyTclObject *, void *)') to 'getter' (aka 'struct _object *(*)(struct _object *, void *)') converts to incompatible function type [-Wcast-function-type-strict] 819 | {"typename", (getter)get_typename, NULL, get_typename__doc__}, | ^~~~~~~~~~~~~~~~~~~~ ./Modules/_tkinter.c:820:16: warning: cast from 'PyObject *(*)(PyTclObject *, void *)' (aka 'struct _object *(*)(PyTclObject *, void *)') to 'getter' (aka 'struct _object *(*)(struct _object *, void *)') converts to incompatible function type [-Wcast-function-type-strict] 820 | {"string", (getter)PyTclObject_string, NULL, | ^~~~~~~~~~~~~~~~~~~~~~~~~~ ./Modules/_tkinter.c:826:21: warning: cast from 'void (*)(PyTclObject *)' to 'destructor' (aka 'void (*)(struct _object *)') converts to incompatible function type [-Wcast-function-type-strict] 826 | {Py_tp_dealloc, (destructor)PyTclObject_dealloc}, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ./Modules/_tkinter.c:827:18: warning: cast from 'PyObject *(*)(PyTclObject *)' (aka 'struct _object *(*)(PyTclObject *)') to 'reprfunc' (aka 'struct _object *(*)(struct _object *)') converts to incompatible function type [-Wcast-function-type-strict] 827 | {Py_tp_repr, (reprfunc)PyTclObject_repr}, | ^~~~~~~~~~~~~~~~~~~~~~~~~~ ./Modules/_tkinter.c:828:17: warning: cast from 'PyObject *(*)(PyTclObject *)' (aka 'struct _object *(*)(PyTclObject *)') to 'reprfunc' (aka 'struct _object *(*)(struct _object *)') converts to incompatible function type [-Wcast-function-type-strict] 828 | {Py_tp_str, (reprfunc)PyTclObject_str}, | ^~~~~~~~~~~~~~~~~~~~~~~~~ ./Modules/_tkinter.c:1388:23: warning: cast from 'int (*)(Tkapp_CallEvent *, int)' (aka 'int (*)(struct Tkapp_CallEvent *, int)') to 'Tcl_EventProc *' (aka 'int (*)(struct Tcl_Event *, int)') converts to incompatible function type [-Wcast-function-type-strict] 1388 | ev->ev.proc = (Tcl_EventProc*)Tkapp_CallProc; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ./Modules/_tkinter.c:1666:23: warning: cast from 'int (*)(VarEvent *, int)' (aka 'int (*)(struct VarEvent *, int)') to 'Tcl_EventProc *' (aka 'int (*)(struct Tcl_Event *, int)') converts to incompatible function type [-Wcast-function-type-strict] 1666 | ev->ev.proc = (Tcl_EventProc*)var_proc; | ^~~~~~~~~~~~~~~~~~~~~~~~ ./Modules/_tkinter.c:2293:23: warning: cast from 'int (*)(CommandEvent *, int)' (aka 'int (*)(struct CommandEvent *, int)') to 'Tcl_EventProc *' (aka 'int (*)(struct Tcl_Event *, int)') converts to incompatible function type [-Wcast-function-type-strict] 2293 | ev->ev.proc = (Tcl_EventProc*)Tkapp_CommandProc; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ./Modules/_tkinter.c:2346:23: warning: cast from 'int (*)(CommandEvent *, int)' (aka 'int (*)(struct CommandEvent *, int)') to 'Tcl_EventProc *' (aka 'int (*)(struct Tcl_Event *, int)') converts to incompatible function type [-Wcast-function-type-strict] 2346 | ev->ev.proc = (Tcl_EventProc*)Tkapp_CommandProc; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Issue: gh-111178

Open Graph Description: Potential compiler warnings eliminated: ./Modules/_tkinter.c:819:18: warning: cast from 'PyObject *(*)(PyTclObject *, void *)' (aka 'struct _object *(*)(PyTclObject *, void *)') to ...

X Description: Potential compiler warnings eliminated: ./Modules/_tkinter.c:819:18: warning: cast from 'PyObject *(*)(PyTclObject *, void *)' (aka 'struct _object *(*)(PyTclObject *, void ...

Opengraph URL: https://github.com/python/cpython/pull/112893

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:85907882-e54d-9de9-d67e-36c5253fd538
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD08E:84862:C21CF7:1102E5D:696A2AE1
html-safe-nonceb7011f33ac543fb2a1ebe7dde5f6427c9db8cc33c109370e00488e653b6a8f60
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMDhFOjg0ODYyOkMyMUNGNzoxMTAyRTVEOjY5NkEyQUUxIiwidmlzaXRvcl9pZCI6IjY2NjQ0NDYzNTM2NTMyMTQ0MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf2202af89a3503c0497d7bd0e823215628dd2fcde8496c53b906b42b6a34b1c4
hovercard-subject-tagpull_request:1637104400
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/112893/files
twitter:imagehttps://avatars.githubusercontent.com/u/7941193?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/7941193?s=400&v=4
og:image:altPotential compiler warnings eliminated: ./Modules/_tkinter.c:819:18: warning: cast from 'PyObject *(*)(PyTclObject *, void *)' (aka 'struct _object *(*)(PyTclObject *, void *)') to ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonea1022f03e4f0d91ea173e4e5dac892c982e0588c62f1ce56121d755a320a3569
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef472b8e6c7b3fdd5d0354972a3f4c516289bf0be
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/112893/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F112893%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F112893%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/112893/files
Reloadhttps://github.com/python/cpython/pull/112893/files
Reloadhttps://github.com/python/cpython/pull/112893/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/112893/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/112893/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
chrstphrchvz:patch-111178-tkinterhttps://github.com/chrstphrchvz/cpython/tree/patch-111178-tkinter
Conversation 0 https://github.com/python/cpython/pull/112893
Commits 6 https://github.com/python/cpython/pull/112893/commits
Checks 0 https://github.com/python/cpython/pull/112893/checks
Files changed https://github.com/python/cpython/pull/112893/files
Please reload this pagehttps://github.com/python/cpython/pull/112893/files
gh-111178: Avoid calling functions from incompatible pointer types in _tkinter.c https://github.com/python/cpython/pull/112893/files#top
Show all changes 6 commits https://github.com/python/cpython/pull/112893/files
f5bd621 Make functions compatible with Tcl_EventProc where needed chrstphrchvz Dec 9, 2023 https://github.com/python/cpython/pull/112893/commits/f5bd621a6db920f46b15b7c4fb24801606a6c000
cb062e3 Make PyTclObject_string() compatible with getter chrstphrchvz Dec 9, 2023 https://github.com/python/cpython/pull/112893/commits/cb062e3b883294c6af29549c9e8f9b771d7ee8c9
c309917 Make get_typename() compatible with getter chrstphrchvz Dec 9, 2023 https://github.com/python/cpython/pull/112893/commits/c3099170527fcd09692c6ec92f99e331b0176ad3
98c082d Make PyTclObject_repr() compatible with reprfunc chrstphrchvz Dec 9, 2023 https://github.com/python/cpython/pull/112893/commits/98c082d809e83bdfc268c697d3b856471ab348dc
352876b Make PyTclObject_str() compatible with reprfunc chrstphrchvz Dec 9, 2023 https://github.com/python/cpython/pull/112893/commits/352876b5966bacfb572072666a6af056e0313dff
001b4cf Make PyTclObject_dealloc() compatible with destructor chrstphrchvz Dec 9, 2023 https://github.com/python/cpython/pull/112893/commits/001b4cf28ed3be88d2b6be59a42c5e440dba4e76
Clear filters https://github.com/python/cpython/pull/112893/files
Please reload this pagehttps://github.com/python/cpython/pull/112893/files
Please reload this pagehttps://github.com/python/cpython/pull/112893/files
Modules/_tkinter.chttps://github.com/python/cpython/pull/112893/files#diff-e22af16a12488bb5478ce31dcf26da13ba5a95e051b2440a740ab6bc4ab0c4fd
View file https://github.com/chrstphrchvz/cpython/blob/001b4cf28ed3be88d2b6be59a42c5e440dba4e76/Modules/_tkinter.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/112893/{{ revealButtonHref }}
https://github.com/python/cpython/pull/112893/files#diff-e22af16a12488bb5478ce31dcf26da13ba5a95e051b2440a740ab6bc4ab0c4fd
https://github.com/python/cpython/pull/112893/files#diff-e22af16a12488bb5478ce31dcf26da13ba5a95e051b2440a740ab6bc4ab0c4fd
https://github.com/python/cpython/pull/112893/files#diff-e22af16a12488bb5478ce31dcf26da13ba5a95e051b2440a740ab6bc4ab0c4fd
https://github.com/python/cpython/pull/112893/files#diff-e22af16a12488bb5478ce31dcf26da13ba5a95e051b2440a740ab6bc4ab0c4fd
https://github.com/python/cpython/pull/112893/files#diff-e22af16a12488bb5478ce31dcf26da13ba5a95e051b2440a740ab6bc4ab0c4fd
https://github.com/python/cpython/pull/112893/files#diff-e22af16a12488bb5478ce31dcf26da13ba5a95e051b2440a740ab6bc4ab0c4fd
https://github.com/python/cpython/pull/112893/files#diff-e22af16a12488bb5478ce31dcf26da13ba5a95e051b2440a740ab6bc4ab0c4fd
https://github.com/python/cpython/pull/112893/files#diff-e22af16a12488bb5478ce31dcf26da13ba5a95e051b2440a740ab6bc4ab0c4fd
https://github.com/python/cpython/pull/112893/files#diff-e22af16a12488bb5478ce31dcf26da13ba5a95e051b2440a740ab6bc4ab0c4fd
https://github.com/python/cpython/pull/112893/files#diff-e22af16a12488bb5478ce31dcf26da13ba5a95e051b2440a740ab6bc4ab0c4fd
https://github.com/python/cpython/pull/112893/files#diff-e22af16a12488bb5478ce31dcf26da13ba5a95e051b2440a740ab6bc4ab0c4fd
https://github.com/python/cpython/pull/112893/files#diff-e22af16a12488bb5478ce31dcf26da13ba5a95e051b2440a740ab6bc4ab0c4fd
https://github.com/python/cpython/pull/112893/files#diff-e22af16a12488bb5478ce31dcf26da13ba5a95e051b2440a740ab6bc4ab0c4fd
https://github.com/python/cpython/pull/112893/files#diff-e22af16a12488bb5478ce31dcf26da13ba5a95e051b2440a740ab6bc4ab0c4fd
https://github.com/python/cpython/pull/112893/files#diff-e22af16a12488bb5478ce31dcf26da13ba5a95e051b2440a740ab6bc4ab0c4fd
https://github.com/python/cpython/pull/112893/files#diff-e22af16a12488bb5478ce31dcf26da13ba5a95e051b2440a740ab6bc4ab0c4fd
https://github.com/python/cpython/pull/112893/files#diff-e22af16a12488bb5478ce31dcf26da13ba5a95e051b2440a740ab6bc4ab0c4fd
https://github.com/python/cpython/pull/112893/files#diff-e22af16a12488bb5478ce31dcf26da13ba5a95e051b2440a740ab6bc4ab0c4fd
https://github.com/python/cpython/pull/112893/files#diff-e22af16a12488bb5478ce31dcf26da13ba5a95e051b2440a740ab6bc4ab0c4fd
https://github.com/python/cpython/pull/112893/files#diff-e22af16a12488bb5478ce31dcf26da13ba5a95e051b2440a740ab6bc4ab0c4fd
https://github.com/python/cpython/pull/112893/files#diff-e22af16a12488bb5478ce31dcf26da13ba5a95e051b2440a740ab6bc4ab0c4fd
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.