Title: gh-111178: Make slot functions in typeobject.c have compatible types by chrstphrchvz · Pull Request #112752 · python/cpython · GitHub
Open Graph Title: gh-111178: Make slot functions in typeobject.c have compatible types by chrstphrchvz · Pull Request #112752 · python/cpython
X Title: gh-111178: Make slot functions in typeobject.c have compatible types by chrstphrchvz · Pull Request #112752 · python/cpython
Description: There are likely many more changes to be made for gh-111178; this is just one small batch proposed separately for review by the respective codeowner. Potential compiler warnings addressed: Objects/typeobject.c:5352:5: warning: cast from 'void (*)(PyTypeObject *)' (aka 'void (*)(struct _typeobject *)') to 'destructor' (aka 'void (*)(struct _object *)') converts to incompatible function type [-Wcast-function-type-strict] 5352 | (destructor)type_dealloc, /* tp_dealloc */ | ^~~~~~~~~~~~~~~~~~~~~~~~ Objects/typeobject.c:5357:5: warning: cast from 'PyObject *(*)(PyTypeObject *)' (aka 'struct _object *(*)(struct _typeobject *)') to 'reprfunc' (aka 'struct _object *(*)(struct _object *)') converts to incompatible function type [-Wcast-function-type-strict] 5357 | (reprfunc)type_repr, /* tp_repr */ | ^~~~~~~~~~~~~~~~~~~ Objects/typeobject.c:5362:5: warning: cast from 'PyObject *(*)(PyTypeObject *, PyObject *, PyObject *)' (aka 'struct _object *(*)(struct _typeobject *, struct _object *, struct _object *)') to 'ternaryfunc' (aka 'struct _object *(*)(struct _object *, struct _object *, struct _object *)') converts to incompatible function type [-Wcast-function-type-strict] 5362 | (ternaryfunc)type_call, /* tp_call */ | ^~~~~~~~~~~~~~~~~~~~~~ Objects/typeobject.c:5364:5: warning: cast from 'PyObject *(*)(PyTypeObject *, PyObject *)' (aka 'struct _object *(*)(struct _typeobject *, struct _object *)') to 'getattrofunc' (aka 'struct _object *(*)(struct _object *, struct _object *)') converts to incompatible function type [-Wcast-function-type-strict] 5364 | (getattrofunc)_Py_type_getattro, /* tp_getattro */ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Objects/typeobject.c:5365:5: warning: cast from 'int (*)(PyTypeObject *, PyObject *, PyObject *)' (aka 'int (*)(struct _typeobject *, struct _object *, struct _object *)') to 'setattrofunc' (aka 'int (*)(struct _object *, struct _object *, struct _object *)') converts to incompatible function type [-Wcast-function-type-strict] 5365 | (setattrofunc)type_setattro, /* tp_setattro */ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ Objects/typeobject.c:5372:5: warning: cast from 'int (*)(PyTypeObject *, visitproc, void *)' (aka 'int (*)(struct _typeobject *, int (*)(struct _object *, void *), void *)') to 'traverseproc' (aka 'int (*)(struct _object *, int (*)(struct _object *, void *), void *)') converts to incompatible function type [-Wcast-function-type-strict] 5372 | (traverseproc)type_traverse, /* tp_traverse */ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ Objects/typeobject.c:5373:5: warning: cast from 'int (*)(PyTypeObject *)' (aka 'int (*)(struct _typeobject *)') to 'inquiry' (aka 'int (*)(struct _object *)') converts to incompatible function type [-Wcast-function-type-strict] 5373 | (inquiry)type_clear, /* tp_clear */ | ^~~~~~~~~~~~~~~~~~~ Objects/typeobject.c:5390:5: warning: cast from 'int (*)(PyTypeObject *)' (aka 'int (*)(struct _typeobject *)') to 'inquiry' (aka 'int (*)(struct _object *)') converts to incompatible function type [-Wcast-function-type-strict] 5390 | (inquiry)type_is_gc, /* tp_is_gc */ | ^~~~~~~~~~~~~~~~~~~ Objects/typeobject.c:6572:5: warning: cast from 'Py_hash_t (*)(const void *)' (aka 'long (*)(const void *)') to 'hashfunc' (aka 'long (*)(struct _object *)') converts to incompatible function type [-Wcast-function-type-strict] 6572 | (hashfunc)_Py_HashPointer, /* tp_hash */ | ^~~~~~~~~~~~~~~~~~~~~~~~~ Example UBSan -fsanitize=function errors addressed: Objects/typeobject.c:7788:12: runtime error: call to function _Py_type_getattro through pointer to incorrect function type 'struct _object *(*)(struct _object *, struct _object *)' typeobject.c:4921: note: _Py_type_getattro defined here SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior Objects/typeobject.c:7788:12 in Objects/call.c:242:18: runtime error: call to function type_call through pointer to incorrect function type 'struct _object *(*)(struct _object *, struct _object *, struct _object *)' typeobject.c:1634: note: type_call defined here SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior Objects/call.c:242:18 in Objects/typeobject.c:1905:16: runtime error: call to function type_clear through pointer to incorrect function type 'int (*)(struct _object *)' typeobject.c:5290: note: type_clear defined here SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior Objects/typeobject.c:1905:16 in Include/internal/pycore_object.h:444:43: runtime error: call to function type_is_gc through pointer to incorrect function type 'int (*)(struct _object *)' typeobject.c:5338: note: type_is_gc defined here SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior Include/internal/pycore_object.h:444:43 in Objects/typeobject.c:5581:12: runtime error: call to function type_repr through pointer to incorrect function type 'struct _object *(*)(struct _object *)' typeobject.c:1601: note: type_repr defined here SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior Objects/typeobject.c:5581:12 in Objects/object.c:1308:15: runtime error: call to function type_setattro through pointer to incorrect function type 'int (*)(struct _object *, struct _object *, struct _object *)' typeobject.c:4927: note: type_setattro defined here SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior Objects/object.c:1308:15 in Modules/_ctypes/_ctypes.c:908:12: runtime error: call to function type_traverse through pointer to incorrect function type 'int (*)(struct _object *, int (*)(struct _object *, void *), void *)' typeobject.c:5261: note: type_traverse defined here SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior Modules/_ctypes/_ctypes.c:908:12 in
Open Graph Description: There are likely many more changes to be made for gh-111178; this is just one small batch proposed separately for review by the respective codeowner. Potential compiler warnings addressed: Objects/...
X Description: There are likely many more changes to be made for gh-111178; this is just one small batch proposed separately for review by the respective codeowner. Potential compiler warnings addressed: Objects/...
Opengraph URL: https://github.com/python/cpython/pull/112752
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:00c53a3d-0150-9b74-3f9a-5ec7348cec99 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | DBF0:C2480:16A56F:1F91E0:696A63BD |
| html-safe-nonce | 479a8425973caf7c03ebe8e223133881312722749bc8dd844854f1e723160a74 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQkYwOkMyNDgwOjE2QTU2RjoxRjkxRTA6Njk2QTYzQkQiLCJ2aXNpdG9yX2lkIjoiMTY1NTg1NjE2Mzc4MjgxMjYwNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | da7b13311e03c84ee82dc02483b6385ccc8c7069eb220a7fceaebee7b40c24e2 |
| hovercard-subject-tag | pull_request:1630245860 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/112752/checks |
| twitter:image | https://avatars.githubusercontent.com/u/7941193?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/7941193?s=400&v=4 |
| og:image:alt | There are likely many more changes to be made for gh-111178; this is just one small batch proposed separately for review by the respective codeowner. Potential compiler warnings addressed: Objects/... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9b7735a184970dd9333b2cbe036c8f3c0a9108c64aaa93827c5a64fc70993392 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 87cbd411c2982752221b5751d583a515b23bf5fa |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width