René's URL Explorer Experiment


Title: bpo-35550 fix incorrect Solaris define guards by kulikjak · Pull Request #11275 · python/cpython · GitHub

Open Graph Title: bpo-35550 fix incorrect Solaris define guards by kulikjak · Pull Request #11275 · python/cpython

X Title: bpo-35550 fix incorrect Solaris define guards by kulikjak · Pull Request #11275 · python/cpython

Description: Python source code uses on several places ifdef sun or defined(sun) without the underscores, which is not standard compliant and shouldn't be used. Defines should check for __sun instead. Reference: http://nadeausoftware.com/articles/2012/01/c_c_tip_how_use_compiler_predefined_macros_detect_operating_system#Solaris https://bugs.python.org/issue35550

Open Graph Description: Python source code uses on several places ifdef sun or defined(sun) without the underscores, which is not standard compliant and shouldn't be used. Defines should check for __sun instead. Refe...

X Description: Python source code uses on several places ifdef sun or defined(sun) without the underscores, which is not standard compliant and shouldn't be used. Defines should check for __sun instead. ...

Opengraph URL: https://github.com/python/cpython/pull/11275

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:30c60dd6-b119-b654-e207-7c128f3e6211
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id98E8:3AC7E6:2878313:35F55EA:6A5211C6
html-safe-nonce447994a299f5193b0bf33fda546503c7224767be4b364828d30bf7f840842adc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OEU4OjNBQzdFNjoyODc4MzEzOjM1RjU1RUE6NkE1MjExQzYiLCJ2aXNpdG9yX2lkIjoiNDY4NTIyMzg0NDY2Mjg3NDU2NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac944b6a79c0e157ed1e53572fafdb26da255d91ba236265d6238663fbd244087f
hovercard-subject-tagpull_request:240427503
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/11275/files
twitter:imagehttps://avatars.githubusercontent.com/u/18516837?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/18516837?s=400&v=4
og:image:altPython source code uses on several places ifdef sun or defined(sun) without the underscores, which is not standard compliant and shouldn't be used. Defines should check for __sun instead. Refe...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/11275/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F11275%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F11275%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/11275/files
Reloadhttps://github.com/python/cpython/pull/11275/files
Reloadhttps://github.com/python/cpython/pull/11275/files
Please reload this pagehttps://github.com/python/cpython/pull/11275/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/11275/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.7k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
gpsheadhttps://github.com/gpshead
python:masterhttps://github.com/python/cpython/tree/master
kulikjak:fix-sun-defineshttps://github.com/kulikjak/cpython/tree/fix-sun-defines
Conversation 4 https://github.com/python/cpython/pull/11275
Commits 3 https://github.com/python/cpython/pull/11275/commits
Checks 0 https://github.com/python/cpython/pull/11275/checks
Files changed https://github.com/python/cpython/pull/11275/files
Please reload this pagehttps://github.com/python/cpython/pull/11275/files
bpo-35550 fix incorrect Solaris define guards https://github.com/python/cpython/pull/11275/files#top
Show all changes 3 commits https://github.com/python/cpython/pull/11275/files
992002a bpo-35550 fix incorrect Solaris define guards kulikjak Dec 21, 2018 https://github.com/python/cpython/pull/11275/commits/992002afdfa003225305c38eac0b5b33dd32d7d8
b586a86 📜🤖 Added by blurb_it. blurb-it[bot] Dec 29, 2018 https://github.com/python/cpython/pull/11275/commits/b586a86839bcdd64e796e8ffacb040cb361ebd8c
59c7e38 Fix minor ifdef mistake kulikjak Dec 29, 2018 https://github.com/python/cpython/pull/11275/commits/59c7e38a6c99017cb20cb768cd1989c2a7596909
Clear filters https://github.com/python/cpython/pull/11275/files
Please reload this pagehttps://github.com/python/cpython/pull/11275/files
Please reload this pagehttps://github.com/python/cpython/pull/11275/files
2018-12-29-10-19-43.bpo-35550.BTuu8e.rst https://github.com/python/cpython/pull/11275/files#diff-9b032e935abe6eac4ca9e0b218bb890cdd4dc14a08359a93142d611ce35a9f81
_posixsubprocess.c https://github.com/python/cpython/pull/11275/files#diff-e182817ec4633ebe50bbfa9a6d0b7c00be01307f5457abfc85f9689055be908b
posixmodule.c https://github.com/python/cpython/pull/11275/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
socketmodule.c https://github.com/python/cpython/pull/11275/files#diff-412f0023cab7bc5669c6c1e710a6f37e7c3c387d299794b5fe82268a10223b29
timemodule.c https://github.com/python/cpython/pull/11275/files#diff-5b4563bfeddc3e20890eada5c8aa651b107a05a0ca8008ae839b86e67897e679
bootstrap_hash.c https://github.com/python/cpython/pull/11275/files#diff-711e9ece55e6c88a5f41a37929104331637766b4b922274a8a7892530fb356e4
Misc/NEWS.d/next/Build/2018-12-29-10-19-43.bpo-35550.BTuu8e.rsthttps://github.com/python/cpython/pull/11275/files#diff-9b032e935abe6eac4ca9e0b218bb890cdd4dc14a08359a93142d611ce35a9f81
View file https://github.com/kulikjak/cpython/blob/59c7e38a6c99017cb20cb768cd1989c2a7596909/Misc/NEWS.d/next/Build/2018-12-29-10-19-43.bpo-35550.BTuu8e.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/11275/{{ revealButtonHref }}
Modules/_posixsubprocess.chttps://github.com/python/cpython/pull/11275/files#diff-e182817ec4633ebe50bbfa9a6d0b7c00be01307f5457abfc85f9689055be908b
View file https://github.com/kulikjak/cpython/blob/59c7e38a6c99017cb20cb768cd1989c2a7596909/Modules/_posixsubprocess.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/11275/{{ revealButtonHref }}
https://github.com/python/cpython/pull/11275/files#diff-e182817ec4633ebe50bbfa9a6d0b7c00be01307f5457abfc85f9689055be908b
https://github.com/python/cpython/pull/11275/files#diff-e182817ec4633ebe50bbfa9a6d0b7c00be01307f5457abfc85f9689055be908b
Modules/posixmodule.chttps://github.com/python/cpython/pull/11275/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
View file https://github.com/kulikjak/cpython/blob/59c7e38a6c99017cb20cb768cd1989c2a7596909/Modules/posixmodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/11275/{{ revealButtonHref }}
https://github.com/python/cpython/pull/11275/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
https://github.com/python/cpython/pull/11275/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
Modules/socketmodule.chttps://github.com/python/cpython/pull/11275/files#diff-412f0023cab7bc5669c6c1e710a6f37e7c3c387d299794b5fe82268a10223b29
View file https://github.com/kulikjak/cpython/blob/59c7e38a6c99017cb20cb768cd1989c2a7596909/Modules/socketmodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/11275/{{ revealButtonHref }}
https://github.com/python/cpython/pull/11275/files#diff-412f0023cab7bc5669c6c1e710a6f37e7c3c387d299794b5fe82268a10223b29
https://github.com/python/cpython/pull/11275/files#diff-412f0023cab7bc5669c6c1e710a6f37e7c3c387d299794b5fe82268a10223b29
Modules/timemodule.chttps://github.com/python/cpython/pull/11275/files#diff-5b4563bfeddc3e20890eada5c8aa651b107a05a0ca8008ae839b86e67897e679
View file https://github.com/kulikjak/cpython/blob/59c7e38a6c99017cb20cb768cd1989c2a7596909/Modules/timemodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/11275/{{ revealButtonHref }}
https://github.com/python/cpython/pull/11275/files#diff-5b4563bfeddc3e20890eada5c8aa651b107a05a0ca8008ae839b86e67897e679
https://github.com/python/cpython/pull/11275/files#diff-5b4563bfeddc3e20890eada5c8aa651b107a05a0ca8008ae839b86e67897e679
https://github.com/python/cpython/pull/11275/files#diff-5b4563bfeddc3e20890eada5c8aa651b107a05a0ca8008ae839b86e67897e679
https://github.com/python/cpython/pull/11275/files#diff-5b4563bfeddc3e20890eada5c8aa651b107a05a0ca8008ae839b86e67897e679
Python/bootstrap_hash.chttps://github.com/python/cpython/pull/11275/files#diff-711e9ece55e6c88a5f41a37929104331637766b4b922274a8a7892530fb356e4
View file https://github.com/kulikjak/cpython/blob/59c7e38a6c99017cb20cb768cd1989c2a7596909/Python/bootstrap_hash.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/11275/{{ revealButtonHref }}
https://github.com/python/cpython/pull/11275/files#diff-711e9ece55e6c88a5f41a37929104331637766b4b922274a8a7892530fb356e4
https://github.com/python/cpython/pull/11275/files#diff-711e9ece55e6c88a5f41a37929104331637766b4b922274a8a7892530fb356e4
https://github.com/python/cpython/pull/11275/files#diff-711e9ece55e6c88a5f41a37929104331637766b4b922274a8a7892530fb356e4
https://github.com/python/cpython/pull/11275/files#diff-711e9ece55e6c88a5f41a37929104331637766b4b922274a8a7892530fb356e4
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.