René's URL Explorer Experiment


Title: bpo-35550 fix incorrect Solaris define guards by kulikjak · Pull Request #11275 · python/cpython · GitHub

Open Graph Title: bpo-35550 fix incorrect Solaris define guards by kulikjak · Pull Request #11275 · python/cpython

X Title: bpo-35550 fix incorrect Solaris define guards by kulikjak · Pull Request #11275 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Python source code uses on several places ifdef sun or defined(sun) without the underscores, which is not standard compliant and shouldn't be used. Defines should check for __sun instead. Refe...

X Description: Python source code uses on several places ifdef sun or defined(sun) without the underscores, which is not standard compliant and shouldn't be used. Defines should check for __sun instead. ...

Opengraph URL: https://github.com/python/cpython/pull/11275

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1d601d20-3d07-0bd7-7747-9ccd0a148c41
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD888:F7027:2142CF:2C9AC7:6A51D6A7
html-safe-noncec4aff3e77ea600ed347c9e85bf48661b346347593bccc7a7e511114aac7b76ad
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEODg4OkY3MDI3OjIxNDJDRjoyQzlBQzc6NkE1MUQ2QTciLCJ2aXNpdG9yX2lkIjoiNzAxNDE2MjY1Mzk2MzczNjc0MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac975d4ef0517c903a6ec602d9cc28eabe2a097e43b2eca5a4355c3ccab3809f2e
hovercard-subject-tagpull_request:240427503
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/11275/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/74d1c5e7d9ce971fe90c61d637587d2c7cbeab9b7f4b2c6cb5ed8b219c8c3996/python/cpython/pull/11275
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/74d1c5e7d9ce971fe90c61d637587d2c7cbeab9b7f4b2c6cb5ed8b219c8c3996/python/cpython/pull/11275
og:image:altPython source code uses on several places ifdef sun or defined(sun) without the underscores, which is not standard compliant and shouldn't be used. Defines should check for __sun instead. Refe...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamekulikjak
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/11275#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F11275
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F11275
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/11275
Reloadhttps://github.com/python/cpython/pull/11275
Reloadhttps://github.com/python/cpython/pull/11275
Please reload this pagehttps://github.com/python/cpython/pull/11275
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/11275
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.7k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
gpsheadhttps://github.com/gpshead
python:masterhttps://github.com/python/cpython/tree/master
kulikjak:fix-sun-defineshttps://github.com/kulikjak/cpython/tree/fix-sun-defines
Conversationhttps://github.com/python/cpython/pull/11275
Commits3 (3)https://github.com/python/cpython/pull/11275/commits
Checkshttps://github.com/python/cpython/pull/11275/checks
Files changedhttps://github.com/python/cpython/pull/11275/files
bpo-35550 fix incorrect Solaris define guardshttps://github.com/python/cpython/pull/11275#top
gpsheadhttps://github.com/gpshead
python:masterhttps://github.com/python/cpython/tree/master
kulikjak:fix-sun-defineshttps://github.com/kulikjak/cpython/tree/fix-sun-defines
https://github.com/kulikjak
kulikjakhttps://github.com/kulikjak
Dec 21, 2018https://github.com/python/cpython/pull/11275#issue-393399874
Please reload this pagehttps://github.com/python/cpython/pull/11275
http://nadeausoftware.com/articles/2012/01/c_c_tip_how_use_compiler_predefined_macros_detect_operating_system#Solarishttp://nadeausoftware.com/articles/2012/01/c_c_tip_how_use_compiler_predefined_macros_detect_operating_system#Solaris
https://bugs.python.org/issue35550https://bugs.python.org/issue35550
Please reload this pagehttps://github.com/python/cpython/pull/11275
https://github.com/kulikjak
bpo-35550 fix incorrect Solaris define guardshttps://github.com/python/cpython/pull/11275/commits/992002afdfa003225305c38eac0b5b33dd32d7d8
992002ahttps://github.com/python/cpython/pull/11275/commits/992002afdfa003225305c38eac0b5b33dd32d7d8
https://github.com/kulikjak
kulikjakhttps://github.com/kulikjak
gpsheadhttps://github.com/gpshead
code ownerhttps://github.com/python/cpython/blob/3e8f962e63c2f929604443531a9a3aced242f3e8/.github/CODEOWNERS#L46
December 21, 2018 10:10https://github.com/python/cpython/pull/11275#event-2040479308
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Dec 21, 2018https://github.com/python/cpython/pull/11275#event-2040479379
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Dec 21, 2018https://github.com/python/cpython/pull/11275#event-2040479394
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Dec 26, 2018 https://github.com/python/cpython/pull/11275#pullrequestreview-187967052
View reviewed changes https://github.com/python/cpython/pull/11275/files/992002afdfa003225305c38eac0b5b33dd32d7d8
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Dec 26, 2018https://github.com/python/cpython/pull/11275#event-2045073589
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Dec 26, 2018https://github.com/python/cpython/pull/11275#issuecomment-450032976
Please reload this pagehttps://github.com/python/cpython/pull/11275
blurb-ithttps://github.com/apps/blurb-it
December 29, 2018 10:19https://github.com/python/cpython/pull/11275#commits-pushed-b586a86
https://github.com/apps/blurb-it
📜🤖 Added by blurb_it.https://github.com/python/cpython/pull/11275/commits/b586a86839bcdd64e796e8ffacb040cb361ebd8c
b586a86https://github.com/python/cpython/pull/11275/commits/b586a86839bcdd64e796e8ffacb040cb361ebd8c
https://github.com/kulikjak
Fix minor ifdef mistakehttps://github.com/python/cpython/pull/11275/commits/59c7e38a6c99017cb20cb768cd1989c2a7596909
59c7e38https://github.com/python/cpython/pull/11275/commits/59c7e38a6c99017cb20cb768cd1989c2a7596909
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Dec 31, 2018 https://github.com/python/cpython/pull/11275#pullrequestreview-188456858
View reviewed changes https://github.com/python/cpython/pull/11275/files/59c7e38a6c99017cb20cb768cd1989c2a7596909
gpsheadhttps://github.com/gpshead
https://github.com/python/cpython/pull/11275#pullrequestreview-188456858
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/11275
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
needs backport to 3.7 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.7%22
Dec 31, 2018https://github.com/python/cpython/pull/11275#event-2048628321
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
6f9bc72https://github.com/python/cpython/commit/6f9bc72c79c3262e5d0f2c0e96b016477399cfb1
Dec 31, 2018https://github.com/python/cpython/pull/11275#event-2048628344
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Dec 31, 2018https://github.com/python/cpython/pull/11275#issuecomment-450601741
@kulikjakhttps://github.com/kulikjak
@gpsheadhttps://github.com/gpshead
Please reload this pagehttps://github.com/python/cpython/pull/11275
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Dec 31, 2018https://github.com/python/cpython/pull/11275#event-2048628352
miss-islingtonhttps://github.com/miss-islington
Dec 31, 2018 https://github.com/python/cpython/pull/11275#ref-commit-9f38e94
https://github.com/kulikjak
https://github.com/miss-islington
bpo-35550: Fix incorrect Solaris define guards (https://github.com/miss-islington/cpython/commit/9f38e946125e449910c6df57992a349557b76859
pythonGH-11275https://github.com/python/cpython/pull/11275
)https://github.com/miss-islington/cpython/commit/9f38e946125e449910c6df57992a349557b76859
9f38e94https://github.com/miss-islington/cpython/commit/9f38e946125e449910c6df57992a349557b76859
http://nadeausoftware.com/articles/2012/01/c_c_tip_how_use_compiler_predefined_macros_detect_operating_systemGH-Solarishttp://nadeausoftware.com/articles/2012/01/c_c_tip_how_use_compiler_predefined_macros_detect_operating_systemGH-Solaris
https://bugs.python.org/issue35550https://bugs.python.org/issue35550
6f9bc72https://github.com/miss-islington/cpython/commit/6f9bc72c79c3262e5d0f2c0e96b016477399cfb1
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Dec 31, 2018https://github.com/python/cpython/pull/11275#issuecomment-450601750
GH-11383https://github.com/python/cpython/pull/11383
3.7 branchhttps://github.com/python/cpython/tree/3.7
Please reload this pagehttps://github.com/python/cpython/pull/11275
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.7 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.7%22
Dec 31, 2018https://github.com/python/cpython/pull/11275#event-2048628406
miss-islingtonhttps://github.com/miss-islington
Dec 31, 2018 https://github.com/python/cpython/pull/11275#ref-commit-d823443
https://github.com/miss-islington
https://github.com/kulikjak
bpo-35550https://bugs.python.org/issue?@action=redirect&bpo=35550
: Fix incorrect Solaris define guards (https://github.com/python/cpython/commit/d82344378ad8e471b8ed12fb99807f68351c5412
GH-11275https://github.com/python/cpython/pull/11275
)https://github.com/python/cpython/commit/d82344378ad8e471b8ed12fb99807f68351c5412
d823443https://github.com/python/cpython/commit/d82344378ad8e471b8ed12fb99807f68351c5412
http://nadeausoftware.com/articles/2012/01/c_c_tip_how_use_compiler_predefined_macros_detect_operating_systemGH-Solarishttp://nadeausoftware.com/articles/2012/01/c_c_tip_how_use_compiler_predefined_macros_detect_operating_systemGH-Solaris
https://bugs.python.org/issue35550https://bugs.python.org/issue35550
6f9bc72https://github.com/python/cpython/commit/6f9bc72c79c3262e5d0f2c0e96b016477399cfb1
csabellahttps://github.com/csabella
Dec 31, 2018 https://github.com/python/cpython/pull/11275#ref-commit-701c79c
https://github.com/kulikjak
https://github.com/csabella
bpo-35550: Fix incorrect Solaris define guards (https://github.com/csabella/cpython/commit/701c79c55f4abc3fcf27b50fecc8fed864edf5cd
pythonGH-11275https://github.com/python/cpython/pull/11275
)https://github.com/csabella/cpython/commit/701c79c55f4abc3fcf27b50fecc8fed864edf5cd
701c79chttps://github.com/csabella/cpython/commit/701c79c55f4abc3fcf27b50fecc8fed864edf5cd
http://nadeausoftware.com/articles/2012/01/c_c_tip_how_use_compiler_predefined_macros_detect_operating_system#Solarishttp://nadeausoftware.com/articles/2012/01/c_c_tip_how_use_compiler_predefined_macros_detect_operating_system#Solaris
https://bugs.python.org/issue35550https://bugs.python.org/issue35550
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F11275
https://github.com/gpshead
gpshead https://github.com/gpshead
https://github.com/python/cpython/pull/11275/files/59c7e38a6c99017cb20cb768cd1989c2a7596909
Please reload this pagehttps://github.com/python/cpython/pull/11275
https://github.com/kulikjak
https://github.com/gpshead
https://github.com/miss-islington
https://github.com/bedevere-bot
https://github.com/the-knights-who-say-ni
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.