René's URL Explorer Experiment


Title: gh-112243: Don't include comments in f-string debug expressions by pablogsal · Pull Request #112284 · python/cpython · GitHub

Open Graph Title: gh-112243: Don't include comments in f-string debug expressions by pablogsal · Pull Request #112284 · python/cpython

X Title: gh-112243: Don't include comments in f-string debug expressions by pablogsal · Pull Request #112284 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Issue: Decide how to handle comments with debug expressions in f-strings #112243

X Description: Issue: Decide how to handle comments with debug expressions in f-strings #112243

Opengraph URL: https://github.com/python/cpython/pull/112284

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:834a71ee-440a-6b8a-bffd-100c0954e6fc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC89E:2A98A:22CFE2:2BD9B8:6B0204B5
html-safe-nonce1304e967f7fa2bc0f70be4774d8d3f0f6937e2a6734274dc62ecfc724f45e556
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDODlFOjJBOThBOjIyQ0ZFMjoyQkQ5Qjg6NkIwMjA0QjUiLCJ2aXNpdG9yX2lkIjoiNTE1MTY0NDAwNDM5MTE5MTczMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6e08c1e97a620c1bb31650162df10d2e818f13168ce9916c7b3c45bf8f5965a2
hovercard-subject-tagpull_request:1609193314
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/112284/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d100604e5a48a053fef351dd26305c518337466c99ae79f5d302634f97e5e07c/python/cpython/pull/112284
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d100604e5a48a053fef351dd26305c518337466c99ae79f5d302634f97e5e07c/python/cpython/pull/112284
og:image:altIssue: Decide how to handle comments with debug expressions in f-strings #112243
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepablogsal
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/112284#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F112284
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F112284
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/112284
Reloadhttps://github.com/python/cpython/pull/112284
Reloadhttps://github.com/python/cpython/pull/112284
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
pablogsalhttps://github.com/pablogsal
python:mainhttps://github.com/python/cpython/tree/main
pablogsal:fstrings_debughttps://github.com/pablogsal/cpython/tree/fstrings_debug
Conversationhttps://github.com/python/cpython/pull/112284
Commits2 (2)https://github.com/python/cpython/pull/112284/commits
Checkshttps://github.com/python/cpython/pull/112284/checks
Files changedhttps://github.com/python/cpython/pull/112284/files
gh-112243: Don't include comments in f-string debug expressionshttps://github.com/python/cpython/pull/112284#top
pablogsalhttps://github.com/pablogsal
python:mainhttps://github.com/python/cpython/tree/main
pablogsal:fstrings_debughttps://github.com/pablogsal/cpython/tree/fstrings_debug
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
Nov 20, 2023https://github.com/python/cpython/pull/112284#issue-2002298707
Please reload this pagehttps://github.com/python/cpython/pull/112284
Decide how to handle comments with debug expressions in f-strings #112243https://github.com/python/cpython/issues/112243
Please reload this pagehttps://github.com/python/cpython/pull/112284
https://github.com/pablogsal
pythongh-112243https://github.com/python/cpython/issues/112243
: Don't include comments in f-string debug expressionshttps://github.com/python/cpython/pull/112284/commits/f204fbd88a2ea153461f302fb7340fa84c7a2ea5
f204fbdhttps://github.com/python/cpython/pull/112284/commits/f204fbd88a2ea153461f302fb7340fa84c7a2ea5
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
lysnikolaouhttps://github.com/lysnikolaou
code ownerhttps://github.com/python/cpython/blob/3b3ec0d77f0f836cbe5ff1ab97efcc8b7ed5d787/.github/CODEOWNERS#L102
November 20, 2023 14:13https://github.com/python/cpython/pull/112284#event-11012440989
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Nov 20, 2023https://github.com/python/cpython/pull/112284#event-11012441880
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Nov 20, 2023 https://github.com/python/cpython/pull/112284#ref-issue-2000504624
Decide how to handle comments with debug expressions in f-strings #112243 https://github.com/python/cpython/issues/112243
https://github.com/lysnikolaou
lysnikolaouhttps://github.com/lysnikolaou
Nov 20, 2023 https://github.com/python/cpython/pull/112284#pullrequestreview-1739965690
View reviewed changes https://github.com/python/cpython/pull/112284/files/f204fbd88a2ea153461f302fb7340fa84c7a2ea5
lysnikolaouhttps://github.com/lysnikolaou
https://github.com/python/cpython/pull/112284#pullrequestreview-1739965690
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/112284
Parser/lexer/lexer.chttps://github.com/python/cpython/pull/112284/files/f204fbd88a2ea153461f302fb7340fa84c7a2ea5#diff-4903ddce642a378ef03f37f72332cf1f5acb5bb0c6247669145fc3d8ea7cd43e
Please reload this pagehttps://github.com/python/cpython/pull/112284
Parser/lexer/lexer.chttps://github.com/python/cpython/pull/112284/files/f204fbd88a2ea153461f302fb7340fa84c7a2ea5#diff-4903ddce642a378ef03f37f72332cf1f5acb5bb0c6247669145fc3d8ea7cd43e
Please reload this pagehttps://github.com/python/cpython/pull/112284
https://github.com/pablogsal
fixup!https://github.com/python/cpython/pull/112284/commits/2637415d006ebfceea8c46834eb3bf8d0ba2ce8e
pythongh-112243https://github.com/python/cpython/issues/112243
: Don't include comments in f-string debug expr…https://github.com/python/cpython/pull/112284/commits/2637415d006ebfceea8c46834eb3bf8d0ba2ce8e
2637415https://github.com/python/cpython/pull/112284/commits/2637415d006ebfceea8c46834eb3bf8d0ba2ce8e
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
Nov 20, 2023https://github.com/python/cpython/pull/112284#issuecomment-1819190269
@lysnikolaouhttps://github.com/lysnikolaou
Please reload this pagehttps://github.com/python/cpython/pull/112284
https://github.com/lysnikolaou
lysnikolaouhttps://github.com/lysnikolaou
Nov 20, 2023 https://github.com/python/cpython/pull/112284#pullrequestreview-1740036373
View reviewed changes https://github.com/python/cpython/pull/112284/files/2637415d006ebfceea8c46834eb3bf8d0ba2ce8e
lysnikolaouhttps://github.com/lysnikolaou
https://github.com/python/cpython/pull/112284#pullrequestreview-1740036373
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/112284
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Nov 20, 2023https://github.com/python/cpython/pull/112284#event-11013085517
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
d59feb5https://github.com/python/cpython/commit/d59feb5dbe5395615d06c30a95e6a6a9b7681d4d
Nov 20, 2023https://github.com/python/cpython/pull/112284#event-11013261978
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
November 20, 2023 15:18https://github.com/python/cpython/pull/112284#event-11013262284
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Nov 20, 2023https://github.com/python/cpython/pull/112284#event-11013262862
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Nov 20, 2023https://github.com/python/cpython/pull/112284#issuecomment-1819274487
GH-112285https://github.com/python/cpython/pull/112285
3.12 branchhttps://github.com/python/cpython/tree/3.12
Please reload this pagehttps://github.com/python/cpython/pull/112284
pablogsalhttps://github.com/pablogsal
Nov 20, 2023 https://github.com/python/cpython/pull/112284#ref-commit-de4f091
https://github.com/pablogsal
[3.12]https://github.com/pablogsal/cpython/commit/de4f091947f444a08e38efeddf6629caeb9cf1f3
pythongh-112243https://github.com/python/cpython/issues/112243
: Don't include comments in f-string debug expr…https://github.com/pablogsal/cpython/commit/de4f091947f444a08e38efeddf6629caeb9cf1f3
de4f091https://github.com/pablogsal/cpython/commit/de4f091947f444a08e38efeddf6629caeb9cf1f3
pythonGH-112284https://github.com/python/cpython/pull/112284
d59feb5https://github.com/pablogsal/cpython/commit/d59feb5dbe5395615d06c30a95e6a6a9b7681d4d
pablogsalhttps://github.com/pablogsal
Nov 20, 2023 https://github.com/python/cpython/pull/112284#ref-commit-7e70e2e
https://github.com/pablogsal
[3.12]https://github.com/python/cpython/commit/7e70e2ed29703e3d06d0908be5c7836a67bae785
gh-112243https://github.com/python/cpython/issues/112243
: Don't include comments in f-string debug expressions (https://github.com/python/cpython/commit/7e70e2ed29703e3d06d0908be5c7836a67bae785
7e70e2ehttps://github.com/python/cpython/commit/7e70e2ed29703e3d06d0908be5c7836a67bae785
GH-112284https://github.com/python/cpython/pull/112284
#112285https://github.com/python/cpython/pull/112285
d59feb5https://github.com/python/cpython/commit/d59feb5dbe5395615d06c30a95e6a6a9b7681d4d
aiskhttps://github.com/aisk
Feb 11, 2024 https://github.com/python/cpython/pull/112284#ref-commit-cd41ab6
https://github.com/pablogsal
https://github.com/aisk
pythongh-112243https://github.com/python/cpython/issues/112243
: Don't include comments in f-string debug expressions (https://github.com/aisk/cpython/commit/cd41ab63ff609f646abd3d44f315560d159d5977
…https://github.com/python/cpython/pull/112284
cd41ab6https://github.com/aisk/cpython/commit/cd41ab63ff609f646abd3d44f315560d159d5977
…python#112284https://github.com/python/cpython/pull/112284
Glyphackhttps://github.com/Glyphack
Sep 2, 2024 https://github.com/python/cpython/pull/112284#ref-commit-25649f7
https://github.com/pablogsal
https://github.com/Glyphack
pythongh-112243https://github.com/python/cpython/issues/112243
: Don't include comments in f-string debug expressions (https://github.com/Glyphack/cpython/commit/25649f71aa433a7c492c1f200a509c867059596e
…https://github.com/python/cpython/pull/112284
25649f7https://github.com/Glyphack/cpython/commit/25649f71aa433a7c492c1f200a509c867059596e
…python#112284https://github.com/python/cpython/pull/112284
https://github.com/lysnikolaou
lysnikolaouhttps://github.com/lysnikolaou
Jun 5, 2025 https://github.com/python/cpython/pull/112284#ref-issue-3118797188
Parts of strings that look like comments being stripped out of nested strings with debug specifier #135148 https://github.com/python/cpython/issues/135148
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F112284
https://github.com/lysnikolaou
lysnikolaou https://github.com/lysnikolaou
https://github.com/python/cpython/pull/112284/files/2637415d006ebfceea8c46834eb3bf8d0ba2ce8e
Please reload this pagehttps://github.com/python/cpython/pull/112284
Please reload this pagehttps://github.com/python/cpython/pull/112284
https://github.com/pablogsal
https://github.com/lysnikolaou
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.