René's URL Explorer Experiment


Title: gh-101178: refactor base64.b85encode to be memory friendly by romuald · Pull Request #112248 · python/cpython · GitHub

Open Graph Title: gh-101178: refactor base64.b85encode to be memory friendly by romuald · Pull Request #112248 · python/cpython

X Title: gh-101178: refactor base64.b85encode to be memory friendly by romuald · Pull Request #112248 · python/cpython

Description: Current description Rewrote the base64._85encode method logic in C, by plugging in the binascii module (already taking care of the bae64 methods) By using C and a single buffer, the memory use is r...

Open Graph Description: Current description Rewrote the base64._85encode method logic in C, by plugging in the binascii module (already taking care of the bae64 methods) By using C and a single buffer, the memory use is r...

X Description: Current description Rewrote the base64._85encode method logic in C, by plugging in the binascii module (already taking care of the bae64 methods) By using C and a single buffer, the memory use is r...

Opengraph URL: https://github.com/python/cpython/pull/112248

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3bda43dd-3ffd-1f45-b117-10153b1ed5b0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9D0E:9F1EC:142DB70:1C3B47D:696A3F66
html-safe-nonce1573231336fef01384182fffdc37a99767ee998a8917a6b1febee275f994e951
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RDBFOjlGMUVDOjE0MkRCNzA6MUMzQjQ3RDo2OTZBM0Y2NiIsInZpc2l0b3JfaWQiOiI1MTEwMjIwNTgyMzkyODQwMDM4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac3c2aa8c600451731adda127b047d3ba41284785970f0b400ebbe1ea469e2ee66
hovercard-subject-tagpull_request:1607720156
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/112248/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/505c667b485bd2cf64742f4e9744e86d687448cf291c436b65c29f4abca239bf/python/cpython/pull/112248
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/505c667b485bd2cf64742f4e9744e86d687448cf291c436b65c29f4abca239bf/python/cpython/pull/112248
og:image:altCurrent description Rewrote the base64._85encode method logic in C, by plugging in the binascii module (already taking care of the bae64 methods) By using C and a single buffer, the memory use is r...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameromuald
hostnamegithub.com
expected-hostnamegithub.com
None321736bfdb3f591415ae895a0459bec204b26a76caf47ba5c980634cfacc4538
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release13581a31d51edf4a3aca179e10890a4d4f9b6d76
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/112248#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F112248
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F112248
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/112248
Reloadhttps://github.com/python/cpython/pull/112248
Reloadhttps://github.com/python/cpython/pull/112248
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/112248
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/112248
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/112248#issue-comment-box
romualdhttps://github.com/romuald
python:mainhttps://github.com/python/cpython/tree/main
romuald:gh-101178-b58encode-memusehttps://github.com/romuald/cpython/tree/gh-101178-b58encode-memuse
gh-101178: refactor base64.b85encode to be memory friendly https://github.com/python/cpython/pull/112248#top
romualdhttps://github.com/romuald
python:mainhttps://github.com/python/cpython/tree/main
romuald:gh-101178-b58encode-memusehttps://github.com/romuald/cpython/tree/gh-101178-b58encode-memuse
Conversation 26 https://github.com/python/cpython/pull/112248
Commits 7 https://github.com/python/cpython/pull/112248/commits
Checks 37 https://github.com/python/cpython/pull/112248/checks
Files changed 4 https://github.com/python/cpython/pull/112248/files
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/romuald
romualdhttps://github.com/romuald
Nov 18, 2023https://github.com/python/cpython/pull/112248#issue-2000597384
Please reload this pagehttps://github.com/python/cpython/pull/112248
https://gist.github.com/romuald/7aeba5f40693bb351da4abe62ad7321dhttps://gist.github.com/romuald/7aeba5f40693bb351da4abe62ad7321d
base64.b85encode uses significant amount of RAM #101178https://github.com/python/cpython/issues/101178
Please reload this pagehttps://github.com/python/cpython/pull/112248
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Nov 18, 2023https://github.com/python/cpython/pull/112248#event-11002559696
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Nov 18, 2023 https://github.com/python/cpython/pull/112248#ref-issue-1550367829
base64.b85encode uses significant amount of RAM #101178 https://github.com/python/cpython/issues/101178
https://github.com/romuald
romualdhttps://github.com/romuald
force-pushedhttps://github.com/python/cpython/compare/eb341875bf8e8e60ec9f2c49c4c3691822ace990..54793e72b82f05ef15fa15d9eaa22774eefe1043
eb34187https://github.com/python/cpython/commit/eb341875bf8e8e60ec9f2c49c4c3691822ace990
54793e7https://github.com/python/cpython/commit/54793e72b82f05ef15fa15d9eaa22774eefe1043
Compare https://github.com/python/cpython/compare/eb341875bf8e8e60ec9f2c49c4c3691822ace990..54793e72b82f05ef15fa15d9eaa22774eefe1043
November 19, 2023 13:51https://github.com/python/cpython/pull/112248#event-11003819289
https://github.com/romuald
romualdhttps://github.com/romuald
Nov 19, 2023https://github.com/python/cpython/pull/112248#issuecomment-1817863191
Please reload this pagehttps://github.com/python/cpython/pull/112248
https://github.com/romuald
romualdhttps://github.com/romuald
force-pushedhttps://github.com/python/cpython/compare/54793e72b82f05ef15fa15d9eaa22774eefe1043..39b1d7e8b22ac0e941e4ac23eff990f6effc1d63
54793e7https://github.com/python/cpython/commit/54793e72b82f05ef15fa15d9eaa22774eefe1043
39b1d7ehttps://github.com/python/cpython/commit/39b1d7e8b22ac0e941e4ac23eff990f6effc1d63
Compare https://github.com/python/cpython/compare/54793e72b82f05ef15fa15d9eaa22774eefe1043..39b1d7e8b22ac0e941e4ac23eff990f6effc1d63
November 19, 2023 13:59https://github.com/python/cpython/pull/112248#event-11003834235
https://github.com/arhadthedev
arhadthedevhttps://github.com/arhadthedev
performance https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Aperformance
Nov 19, 2023https://github.com/python/cpython/pull/112248#event-11003840897
https://github.com/arhadthedev
arhadthedevhttps://github.com/arhadthedev
Nov 19, 2023https://github.com/python/cpython/pull/112248#issuecomment-1817867564
@sobolevnhttps://github.com/sobolevn
@pitrouhttps://github.com/pitrou
Please reload this pagehttps://github.com/python/cpython/pull/112248
https://github.com/romuald
romualdhttps://github.com/romuald
Nov 19, 2023https://github.com/python/cpython/pull/112248#issuecomment-1817870858
Please reload this pagehttps://github.com/python/cpython/pull/112248
https://github.com/romuald
romualdhttps://github.com/romuald
Mar 1, 2024https://github.com/python/cpython/pull/112248#issuecomment-1973286320
@pitrouhttps://github.com/pitrou
Please reload this pagehttps://github.com/python/cpython/pull/112248
https://github.com/pitrou
pitrouhttps://github.com/pitrou
Mar 1, 2024https://github.com/python/cpython/pull/112248#issuecomment-1973513587
Please reload this pagehttps://github.com/python/cpython/pull/112248
https://github.com/pitrou
pitrouhttps://github.com/pitrou
Mar 1, 2024 https://github.com/python/cpython/pull/112248#pullrequestreview-1911562178
View reviewed changes https://github.com/python/cpython/pull/112248/files
Lib/base64.pyhttps://github.com/python/cpython/pull/112248/files#diff-1d196d93fbeed5133b0bc9de7b58a2f5a0caee15e693ba605c7182d127e7f263
pitrouhttps://github.com/pitrou
Mar 1, 2024https://github.com/python/cpython/pull/112248#discussion_r1509246816
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/112248
romualdhttps://github.com/romuald
Mar 3, 2024https://github.com/python/cpython/pull/112248#discussion_r1510297310
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/112248
https://github.com/pitrou
pitrouhttps://github.com/pitrou
Mar 1, 2024 https://github.com/python/cpython/pull/112248#pullrequestreview-1911563933
View reviewed changes https://github.com/python/cpython/pull/112248/files
Lib/test/test_base64.pyhttps://github.com/python/cpython/pull/112248/files#diff-036e96402d4431a46f7f436f3beb8a6634ecc7f27fb195c4be573b5ad3c214fe
pitrouhttps://github.com/pitrou
Mar 1, 2024https://github.com/python/cpython/pull/112248#discussion_r1509247911
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@gpsheadhttps://github.com/gpshead
Please reload this pagehttps://github.com/python/cpython/pull/112248
romualdhttps://github.com/romuald
Mar 3, 2024https://github.com/python/cpython/pull/112248#discussion_r1510297175
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://docs.python.org/3/library/hashlib.html#hashlib.algorithms_guaranteedhttps://docs.python.org/3/library/hashlib.html#hashlib.algorithms_guaranteed
Please reload this pagehttps://github.com/python/cpython/pull/112248
https://github.com/romuald
romualdhttps://github.com/romuald
force-pushedhttps://github.com/python/cpython/compare/899c88d2a6da167c7bfa3b4f081e163641e930fa..d0e76916664a261c95563a178a49a5ef68dbf280
899c88dhttps://github.com/python/cpython/commit/899c88d2a6da167c7bfa3b4f081e163641e930fa
d0e7691https://github.com/python/cpython/commit/d0e76916664a261c95563a178a49a5ef68dbf280
Compare https://github.com/python/cpython/compare/899c88d2a6da167c7bfa3b4f081e163641e930fa..d0e76916664a261c95563a178a49a5ef68dbf280
March 3, 2024 15:30https://github.com/python/cpython/pull/112248#event-11990441693
https://github.com/romuald
romualdhttps://github.com/romuald
Mar 3, 2024https://github.com/python/cpython/pull/112248#issuecomment-1975209674
@pitrouhttps://github.com/pitrou
Please reload this pagehttps://github.com/python/cpython/pull/112248
https://github.com/pitrou
pitrouhttps://github.com/pitrou
Mar 3, 2024https://github.com/python/cpython/pull/112248#issuecomment-1975235955
Please reload this pagehttps://github.com/python/cpython/pull/112248
Please reload this pagehttps://github.com/python/cpython/pull/112248
https://github.com/romuald
romualdhttps://github.com/romuald
Mar 4, 2024https://github.com/python/cpython/pull/112248#issuecomment-1976200224
Please reload this pagehttps://github.com/python/cpython/pull/112248
https://github.com/romuald
romualdhttps://github.com/romuald
Feb 14, 2025https://github.com/python/cpython/pull/112248#issuecomment-2658872377
@pitrouhttps://github.com/pitrou
Please reload this pagehttps://github.com/python/cpython/pull/112248
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
Feb 14, 2025https://github.com/python/cpython/pull/112248#issuecomment-2658930016
Please reload this pagehttps://github.com/python/cpython/pull/112248
Please reload this pagehttps://github.com/python/cpython/pull/112248
romualdhttps://github.com/romuald
February 16, 2025 16:05https://github.com/python/cpython/pull/112248#commits-pushed-84e20ea
https://github.com/romuald
pythongh-101178https://github.com/python/cpython/issues/101178
: C implementation of base64._a85encodehttps://github.com/python/cpython/pull/112248/commits/84e20ea4953ea25ba8d228d405fb9e7ac0ccf20b
84e20eahttps://github.com/python/cpython/pull/112248/commits/84e20ea4953ea25ba8d228d405fb9e7ac0ccf20b
https://github.com/romuald
Add possible regression test in test_base64https://github.com/python/cpython/pull/112248/commits/74fc245760ddeff612f7866a4ced3afb77cafc13
74fc245https://github.com/python/cpython/pull/112248/commits/74fc245760ddeff612f7866a4ced3afb77cafc13
https://github.com/romuald
romualdhttps://github.com/romuald
force-pushedhttps://github.com/python/cpython/compare/d0e76916664a261c95563a178a49a5ef68dbf280..74fc245760ddeff612f7866a4ced3afb77cafc13
d0e7691https://github.com/python/cpython/commit/d0e76916664a261c95563a178a49a5ef68dbf280
74fc245https://github.com/python/cpython/commit/74fc245760ddeff612f7866a4ced3afb77cafc13
Compare https://github.com/python/cpython/compare/d0e76916664a261c95563a178a49a5ef68dbf280..74fc245760ddeff612f7866a4ced3afb77cafc13
February 16, 2025 15:05https://github.com/python/cpython/pull/112248#event-16324455667
https://github.com/romuald
romualdhttps://github.com/romuald
Feb 16, 2025https://github.com/python/cpython/pull/112248#issuecomment-2661480903
@pitrouhttps://github.com/pitrou
@sobolevnhttps://github.com/sobolevn
Please reload this pagehttps://github.com/python/cpython/pull/112248
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Feb 16, 2025 https://github.com/python/cpython/pull/112248#pullrequestreview-2619656111
View reviewed changes https://github.com/python/cpython/pull/112248/files/74fc245760ddeff612f7866a4ced3afb77cafc13
Modules/binascii.chttps://github.com/python/cpython/pull/112248/files/74fc245760ddeff612f7866a4ced3afb77cafc13#diff-ba5e0c9b1d3a07e484b80157530df909d6cbc13e479e464e9fe0e7744822653c
Please reload this pagehttps://github.com/python/cpython/pull/112248
Modules/binascii.chttps://github.com/python/cpython/pull/112248/files/74fc245760ddeff612f7866a4ced3afb77cafc13#diff-ba5e0c9b1d3a07e484b80157530df909d6cbc13e479e464e9fe0e7744822653c
Please reload this pagehttps://github.com/python/cpython/pull/112248
Modules/binascii.chttps://github.com/python/cpython/pull/112248/files/74fc245760ddeff612f7866a4ced3afb77cafc13#diff-ba5e0c9b1d3a07e484b80157530df909d6cbc13e479e464e9fe0e7744822653c
picnixzhttps://github.com/picnixz
Feb 16, 2025https://github.com/python/cpython/pull/112248#discussion_r1957354073
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/112248
romualdhttps://github.com/romuald
Feb 17, 2025https://github.com/python/cpython/pull/112248#discussion_r1958806061
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/112248
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Feb 16, 2025https://github.com/python/cpython/pull/112248#issuecomment-2661489112
https://github.com/git/git/blob/master/base85.c#L40https://github.com/git/git/blob/master/base85.c#L40
Please reload this pagehttps://github.com/python/cpython/pull/112248
https://github.com/romuald
https://github.com/picnixz
Review changes Modules/binascii.chttps://github.com/python/cpython/pull/112248/commits/60a3ae64c885a04907841522de8436633e58db6d
60a3ae6https://github.com/python/cpython/pull/112248/commits/60a3ae64c885a04907841522de8436633e58db6d
https://github.com/romuald
romualdhttps://github.com/romuald
Feb 16, 2025https://github.com/python/cpython/pull/112248#issuecomment-2661524661
Please reload this pagehttps://github.com/python/cpython/pull/112248
https://github.com/git/git/blob/master/base85.c#L40https://github.com/git/git/blob/master/base85.c#L40
Please reload this pagehttps://github.com/python/cpython/pull/112248
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Feb 16, 2025https://github.com/python/cpython/pull/112248#issuecomment-2661536656
Please reload this pagehttps://github.com/python/cpython/pull/112248
Please reload this pagehttps://github.com/python/cpython/pull/112248
romualdhttps://github.com/romuald
February 16, 2025 20:33https://github.com/python/cpython/pull/112248#commits-pushed-aaa09e1
https://github.com/romuald
Review fixes: update algorithmhttps://github.com/python/cpython/pull/112248/commits/aaa09e16e3fd2d2e38ab63d041b957485113fbca
aaa09e1https://github.com/python/cpython/pull/112248/commits/aaa09e16e3fd2d2e38ab63d041b957485113fbca
https://github.com/git/git/blob/03944513488db4a81fdb4c21c3b515e4cb260b05/base85.c#L79https://github.com/git/git/blob/03944513488db4a81fdb4c21c3b515e4cb260b05/base85.c#L79
https://github.com/romuald
Further plagiate git's implementationhttps://github.com/python/cpython/pull/112248/commits/cb46a5db57abd8b12d790f454e07dbf1d4a244c5
cb46a5dhttps://github.com/python/cpython/pull/112248/commits/cb46a5db57abd8b12d790f454e07dbf1d4a244c5
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Feb 17, 2025 https://github.com/python/cpython/pull/112248#pullrequestreview-2620780383
View reviewed changes https://github.com/python/cpython/pull/112248/files/cb46a5db57abd8b12d790f454e07dbf1d4a244c5
Modules/binascii.chttps://github.com/python/cpython/pull/112248/files/cb46a5db57abd8b12d790f454e07dbf1d4a244c5#diff-ba5e0c9b1d3a07e484b80157530df909d6cbc13e479e464e9fe0e7744822653c
picnixzhttps://github.com/picnixz
Feb 17, 2025https://github.com/python/cpython/pull/112248#discussion_r1958068993
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/112248
romualdhttps://github.com/romuald
Feb 17, 2025https://github.com/python/cpython/pull/112248#discussion_r1958806418
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/112248
romualdhttps://github.com/romuald
February 17, 2025 22:47https://github.com/python/cpython/pull/112248#commits-pushed-c88450b
https://github.com/romuald
Rename b2a_base85 as private for nowhttps://github.com/python/cpython/pull/112248/commits/c88450ba34e4ba9c4fbbe470a6c54a5a3bcf709d
c88450bhttps://github.com/python/cpython/pull/112248/commits/c88450ba34e4ba9c4fbbe470a6c54a5a3bcf709d
https://github.com/romuald
Credit to git's implementation and more commentshttps://github.com/python/cpython/pull/112248/commits/2fc892cd05efbbaff2e0c4a171cdda155e26720a
2fc892chttps://github.com/python/cpython/pull/112248/commits/2fc892cd05efbbaff2e0c4a171cdda155e26720a
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F112248
https://github.com/pitrou
pitrou https://github.com/pitrou
https://github.com/python/cpython/pull/112248/files/6c33ebb36f1f24d11603a31f106c03fc231c2fec
https://github.com/picnixz
picnixz https://github.com/picnixz
https://github.com/python/cpython/pull/112248/files/cb46a5db57abd8b12d790f454e07dbf1d4a244c5
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
performance https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Aperformance
Please reload this pagehttps://github.com/python/cpython/pull/112248
https://github.com/romuald
https://github.com/arhadthedev
https://github.com/pitrou
https://github.com/sobolevn
https://github.com/picnixz
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.