René's URL Explorer Experiment


Title: gh-111650: Generate pyconfig.h on Windows by colesbury · Pull Request #112179 · python/cpython · GitHub

Open Graph Title: gh-111650: Generate pyconfig.h on Windows by colesbury · Pull Request #112179 · python/cpython

X Title: gh-111650: Generate pyconfig.h on Windows by colesbury · Pull Request #112179 · python/cpython

Description: Prior to this change, the Py_NOGIL macro was not defined when building C API extensions with the --disable-gil build on Windows. Py_NOGIL was only defined as a pre-processor definition in pyproject.props, but that is not used by C-API extensions. This instead generates the pyconfig.h header on Windows as part of the build process. For now, Py_NOGIL is the only macro that may be conditionally defined in the generated file. Issue: gh-111650

Open Graph Description: Prior to this change, the Py_NOGIL macro was not defined when building C API extensions with the --disable-gil build on Windows. Py_NOGIL was only defined as a pre-processor definition in pyproject...

X Description: Prior to this change, the Py_NOGIL macro was not defined when building C API extensions with the --disable-gil build on Windows. Py_NOGIL was only defined as a pre-processor definition in pyproject...

Opengraph URL: https://github.com/python/cpython/pull/112179

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:2805d456-ec53-96b4-d1ab-abac3a01918d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDEF0:17FB7:3AE6EB8:4A9518E:6B0233E5
html-safe-noncea148e6e0305d3adb1eef6eaf5402828444d9c952fe5165907254851b73cd1e5d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERUYwOjE3RkI3OjNBRTZFQjg6NEE5NTE4RTo2QjAyMzNFNSIsInZpc2l0b3JfaWQiOiIzOTEwOTIyMzM0NDgzMTMzNDEzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac1b513e1e569cd3327221eb173a0578c6ed0acda7bd05dac264a9de9f447f6e7d
hovercard-subject-tagpull_request:1605185289
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/112179/files
twitter:imagehttps://avatars.githubusercontent.com/u/655866?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/655866?s=400&v=4
og:image:altPrior to this change, the Py_NOGIL macro was not defined when building C API extensions with the --disable-gil build on Windows. Py_NOGIL was only defined as a pre-processor definition in pyproject...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/112179/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F112179%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F112179%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/112179/files
Reloadhttps://github.com/python/cpython/pull/112179/files
Reloadhttps://github.com/python/cpython/pull/112179/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
colesburyhttps://github.com/colesbury
python:mainhttps://github.com/python/cpython/tree/main
colesbury:generate-pyconfig-winhttps://github.com/colesbury/cpython/tree/generate-pyconfig-win
Conversation 9 https://github.com/python/cpython/pull/112179
Commits 4 https://github.com/python/cpython/pull/112179/commits
Checks 0 https://github.com/python/cpython/pull/112179/checks
Files changed https://github.com/python/cpython/pull/112179/files
Please reload this pagehttps://github.com/python/cpython/pull/112179/files
gh-111650: Generate pyconfig.h on Windows https://github.com/python/cpython/pull/112179/files#top
Show all changes 4 commits https://github.com/python/cpython/pull/112179/files
6585ab1 gh-111650: Generate pyconfig.h on Windows colesbury Nov 16, 2023 https://github.com/python/cpython/pull/112179/commits/6585ab1f557e68202e3313c76b7a909464322a7b
dbe0ddd Fix test_sysconfig.py colesbury Nov 16, 2023 https://github.com/python/cpython/pull/112179/commits/dbe0dddccd55157b3305f72815eec24bc092b027
25c6028 Add blurb colesbury Nov 16, 2023 https://github.com/python/cpython/pull/112179/commits/25c6028e020c329a1cfc9602a06bbfb3d668729c
b654d10 Rename Py_NOGIL to Py_GIL_DISABLED colesbury Nov 20, 2023 https://github.com/python/cpython/pull/112179/commits/b654d10977d69f005d3de459d471abd16c1fef7e
Clear filters https://github.com/python/cpython/pull/112179/files
Please reload this pagehttps://github.com/python/cpython/pull/112179/files
Please reload this pagehttps://github.com/python/cpython/pull/112179/files
.gitignore https://github.com/python/cpython/pull/112179/files#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947
test_sysconfig.py https://github.com/python/cpython/pull/112179/files#diff-365f96442d242edc27cd09ce48da3cd6f81d1b47c9baf8f1b7bbbe5b1d2e7bda
2023-11-16-16-19-51.gh-issue-111650.zdWe-n.rst https://github.com/python/cpython/pull/112179/files#diff-68841dd1f847881c01752b87119c6f77a72a21920040f091f59adce141fdf705
pyconfig.h.in https://github.com/python/cpython/pull/112179/files#diff-a23fdddaacfd85ee1d61106232a4c7e8ff55fd4888a23e5d70c3b58c2c66ea34
generate_pyconfig.ps1 https://github.com/python/cpython/pull/112179/files#diff-0d79ed51ad3bea9a9931f2d2107ac1a3c7906c9b3ace67b1e0d60e47a5efee60
pcbuild.proj https://github.com/python/cpython/pull/112179/files#diff-36143ac3d62d4f210bf836dcc3104c7474562bca5b02a18aa5d285b4a8373c6e
.gitignorehttps://github.com/python/cpython/pull/112179/files#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947
View file https://github.com/colesbury/cpython/blob/b654d10977d69f005d3de459d471abd16c1fef7e/.gitignore
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/112179/{{ revealButtonHref }}
https://github.com/python/cpython/pull/112179/files#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947
https://github.com/python/cpython/pull/112179/files#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L596
Lib/test/test_sysconfig.pyhttps://github.com/python/cpython/pull/112179/files#diff-365f96442d242edc27cd09ce48da3cd6f81d1b47c9baf8f1b7bbbe5b1d2e7bda
View file https://github.com/colesbury/cpython/blob/b654d10977d69f005d3de459d471abd16c1fef7e/Lib/test/test_sysconfig.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/112179/{{ revealButtonHref }}
https://github.com/python/cpython/pull/112179/files#diff-365f96442d242edc27cd09ce48da3cd6f81d1b47c9baf8f1b7bbbe5b1d2e7bda
zoobahttps://github.com/zooba
Nov 29, 2023https://github.com/python/cpython/pull/112179/files#r1408850962
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/112179/files
https://github.com/python/cpython/pull/112179/files#diff-365f96442d242edc27cd09ce48da3cd6f81d1b47c9baf8f1b7bbbe5b1d2e7bda
Misc/NEWS.d/next/Windows/2023-11-16-16-19-51.gh-issue-111650.zdWe-n.rsthttps://github.com/python/cpython/pull/112179/files#diff-68841dd1f847881c01752b87119c6f77a72a21920040f091f59adce141fdf705
View file https://github.com/colesbury/cpython/blob/b654d10977d69f005d3de459d471abd16c1fef7e/Misc/NEWS.d/next/Windows/2023-11-16-16-19-51.gh-issue-111650.zdWe-n.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/112179/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L189
PC/pyconfig.h → PC/pyconfig.h.inhttps://github.com/python/cpython/pull/112179/files#diff-a23fdddaacfd85ee1d61106232a4c7e8ff55fd4888a23e5d70c3b58c2c66ea34
View file https://github.com/colesbury/cpython/blob/b654d10977d69f005d3de459d471abd16c1fef7e/PC/pyconfig.h.in
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/112179/{{ revealButtonHref }}
https://github.com/python/cpython/pull/112179/files#diff-a23fdddaacfd85ee1d61106232a4c7e8ff55fd4888a23e5d70c3b58c2c66ea34
https://github.com/python/cpython/pull/112179/files#diff-a23fdddaacfd85ee1d61106232a4c7e8ff55fd4888a23e5d70c3b58c2c66ea34
https://github.com/python/cpython/pull/112179/files#diff-a23fdddaacfd85ee1d61106232a4c7e8ff55fd4888a23e5d70c3b58c2c66ea34
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L190
PCbuild/generate_pyconfig.ps1https://github.com/python/cpython/pull/112179/files#diff-0d79ed51ad3bea9a9931f2d2107ac1a3c7906c9b3ace67b1e0d60e47a5efee60
View file https://github.com/colesbury/cpython/blob/b654d10977d69f005d3de459d471abd16c1fef7e/PCbuild/generate_pyconfig.ps1
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/112179/{{ revealButtonHref }}
zoobahttps://github.com/zooba
Nov 29, 2023https://github.com/python/cpython/pull/112179/files#r1408855860
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/112179/files
zoobahttps://github.com/zooba
Nov 29, 2023https://github.com/python/cpython/pull/112179/files#r1408863713
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/112179/files
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L190
PCbuild/pcbuild.projhttps://github.com/python/cpython/pull/112179/files#diff-36143ac3d62d4f210bf836dcc3104c7474562bca5b02a18aa5d285b4a8373c6e
View file https://github.com/colesbury/cpython/blob/b654d10977d69f005d3de459d471abd16c1fef7e/PCbuild/pcbuild.proj
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/112179/{{ revealButtonHref }}
https://github.com/python/cpython/pull/112179/files#diff-36143ac3d62d4f210bf836dcc3104c7474562bca5b02a18aa5d285b4a8373c6e
https://github.com/python/cpython/pull/112179/files#diff-36143ac3d62d4f210bf836dcc3104c7474562bca5b02a18aa5d285b4a8373c6e
zoobahttps://github.com/zooba
Nov 29, 2023https://github.com/python/cpython/pull/112179/files#r1408861687
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/112179/files
https://github.com/python/cpython/pull/112179/files#diff-36143ac3d62d4f210bf836dcc3104c7474562bca5b02a18aa5d285b4a8373c6e
https://github.com/python/cpython/pull/112179/files#diff-36143ac3d62d4f210bf836dcc3104c7474562bca5b02a18aa5d285b4a8373c6e
zoobahttps://github.com/zooba
Nov 29, 2023https://github.com/python/cpython/pull/112179/files#r1408848213
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/112179/files
https://github.com/python/cpython/pull/112179/files#diff-36143ac3d62d4f210bf836dcc3104c7474562bca5b02a18aa5d285b4a8373c6e
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.