René's URL Explorer Experiment


Title: [3.12] gh-111942: Fix SystemError in the TextIOWrapper constructor (#112061) by vstinner · Pull Request #112089 · python/cpython · GitHub

Open Graph Title: [3.12] gh-111942: Fix SystemError in the TextIOWrapper constructor (#112061) by vstinner · Pull Request #112089 · python/cpython

X Title: [3.12] gh-111942: Fix SystemError in the TextIOWrapper constructor (#112061) by vstinner · Pull Request #112089 · python/cpython

Description: In non-debug more the check for the "errors" argument is skipped, and then PyUnicode_AsUTF8() can fail, but its result was not checked. Co-authored-by: Victor Stinner vstinner@python.org (cherry pi...

Open Graph Description: In non-debug more the check for the "errors" argument is skipped, and then PyUnicode_AsUTF8() can fail, but its result was not checked. Co-authored-by: Victor Stinner vstinner@python.org ...

X Description: In non-debug more the check for the "errors" argument is skipped, and then PyUnicode_AsUTF8() can fail, but its result was not checked. Co-authored-by: Victor Stinner vstinner@pyt...

Mail addresses
vstinner@python.org

Opengraph URL: https://github.com/python/cpython/pull/112089

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:74fd71e1-d3b8-bb3e-32b7-2fbedfa229e1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9BE8:F5661:1E504A:29BD15:696A702F
html-safe-nonce827e029db4d5e2eef05b2a6eadcc39b0a25390923184d834c0de0c7151f961f4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QkU4OkY1NjYxOjFFNTA0QToyOUJEMTU6Njk2QTcwMkYiLCJ2aXNpdG9yX2lkIjoiMjA5NTIyMzY0NzM1MjAyNTEzNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaccee96fbcb24a4dd272dee4178e09cd7660425129d670762c6585986085cd604f
hovercard-subject-tagpull_request:1601461105
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/112089/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1791e8db604caa239d07ca0b509ff4462d127effae5ac6ca1dde5793f1639645/python/cpython/pull/112089
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1791e8db604caa239d07ca0b509ff4462d127effae5ac6ca1dde5793f1639645/python/cpython/pull/112089
og:image:altIn non-debug more the check for the "errors" argument is skipped, and then PyUnicode_AsUTF8() can fail, but its result was not checked. Co-authored-by: Victor Stinner vstinner@python.org ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamevstinner
hostnamegithub.com
expected-hostnamegithub.com
Nonecfa223d62d272274e0b68350b4bd7741f3ca7498b8c4b8b1bc1e6deabbdbc09d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release6a0b6893c221f98f607598e939299fdf5763435d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/112089#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F112089
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F112089
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/112089
Reloadhttps://github.com/python/cpython/pull/112089
Reloadhttps://github.com/python/cpython/pull/112089
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/112089
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/112089
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/112089#issue-comment-box
serhiy-storchakahttps://github.com/serhiy-storchaka
python:3.12https://github.com/python/cpython/tree/3.12
vstinner:test_io12https://github.com/vstinner/cpython/tree/test_io12
[3.12] gh-111942: Fix SystemError in the TextIOWrapper constructor (#112061) https://github.com/python/cpython/pull/112089#top
serhiy-storchakahttps://github.com/serhiy-storchaka
python:3.12https://github.com/python/cpython/tree/3.12
vstinner:test_io12https://github.com/vstinner/cpython/tree/test_io12
Conversation 1 https://github.com/python/cpython/pull/112089
Commits 1 https://github.com/python/cpython/pull/112089/commits
Checks 0 https://github.com/python/cpython/pull/112089/checks
Files changed https://github.com/python/cpython/pull/112089/files
Please reload this pagehttps://github.com/python/cpython/pull/112089
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Nov 14, 2023https://github.com/python/cpython/pull/112089#issue-1993561510
Please reload this pagehttps://github.com/python/cpython/pull/112089
9302f05https://github.com/python/cpython/commit/9302f05f9af07332c414b3c19003efd1b1763cf3
TextIOWrapper.reconfigure() crashes if encoding is not string or None #111942https://github.com/python/cpython/issues/111942
Please reload this pagehttps://github.com/python/cpython/pull/112089
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Nov 14, 2023https://github.com/python/cpython/pull/112089#event-10960037052
https://github.com/serhiy-storchaka
https://github.com/vstinner
pythongh-111942https://github.com/python/cpython/issues/111942
: Fix SystemError in the TextIOWrapper constructor (https://github.com/python/cpython/pull/112089/commits/45075b896913f72e1b170f0a50c4e497d48e470f
py…https://github.com/python/cpython/pull/112061
45075b8https://github.com/python/cpython/pull/112089/commits/45075b896913f72e1b170f0a50c4e497d48e470f
…thon#112061https://github.com/python/cpython/pull/112061
9302f05https://github.com/vstinner/cpython/commit/9302f05f9af07332c414b3c19003efd1b1763cf3
TextIOWrapper.reconfigure() crashes if encoding is not string or None #111942 https://github.com/python/cpython/issues/111942
gh-111942: Fix SystemError in the TextIOWrapper constructor #112061 https://github.com/python/cpython/pull/112061
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
Nov 14, 2023https://github.com/python/cpython/pull/112089#event-10960037905
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
force-pushedhttps://github.com/python/cpython/compare/7f58ab2e27c6b486fa4beb229865c502c7d5055a..45075b896913f72e1b170f0a50c4e497d48e470f
7f58ab2https://github.com/python/cpython/commit/7f58ab2e27c6b486fa4beb229865c502c7d5055a
45075b8https://github.com/python/cpython/commit/45075b896913f72e1b170f0a50c4e497d48e470f
Compare https://github.com/python/cpython/compare/7f58ab2e27c6b486fa4beb229865c502c7d5055a..45075b896913f72e1b170f0a50c4e497d48e470f
November 14, 2023 20:59https://github.com/python/cpython/pull/112089#event-10960038884
[3.12] gh-111942: Fix SystemError in the TextIOWrapper constructor (GH-112061) #112085 https://github.com/python/cpython/pull/112085
[3.11] gh-111942: Fix crashes in TextIOWrapper.reconfigure() (GH-111976) #112059 https://github.com/python/cpython/pull/112059
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Nov 14, 2023https://github.com/python/cpython/pull/112089#issuecomment-1811332519
#112088https://github.com/python/cpython/issues/112088
Please reload this pagehttps://github.com/python/cpython/pull/112089
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Nov 15, 2023 https://github.com/python/cpython/pull/112089#pullrequestreview-1732085734
View reviewed changes https://github.com/python/cpython/pull/112089/files/45075b896913f72e1b170f0a50c4e497d48e470f
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Nov 15, 2023https://github.com/python/cpython/pull/112089#event-10967732477
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
1445d77https://github.com/python/cpython/commit/1445d77282f9082f3fecde772ddf6bb2f5a383f1
Nov 15, 2023https://github.com/python/cpython/pull/112089#event-10967757686
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Nov 15, 2023https://github.com/python/cpython/pull/112089#event-10967758417
serhiy-storchakahttps://github.com/serhiy-storchaka
Nov 15, 2023 https://github.com/python/cpython/pull/112089#ref-commit-52cafc8
https://github.com/vstinner
https://github.com/serhiy-storchaka
[3.12]https://github.com/miss-islington/cpython/commit/52cafc893d5abda6baad20c67368a1ad14bff961
pythongh-111942https://github.com/python/cpython/issues/111942
: Fix SystemError in the TextIOWrapper construc…https://github.com/miss-islington/cpython/commit/52cafc893d5abda6baad20c67368a1ad14bff961
52cafc8https://github.com/miss-islington/cpython/commit/52cafc893d5abda6baad20c67368a1ad14bff961
pythonGH-112061https://github.com/python/cpython/pull/112061
pythonGH-112089https://github.com/python/cpython/pull/112089
9302f05https://github.com/miss-islington/cpython/commit/9302f05f9af07332c414b3c19003efd1b1763cf3
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
November 15, 2023 15:40https://github.com/python/cpython/pull/112089#event-10969020704
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F112089
https://github.com/serhiy-storchaka
serhiy-storchaka https://github.com/serhiy-storchaka
https://github.com/python/cpython/pull/112089/files/45075b896913f72e1b170f0a50c4e497d48e470f
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
Please reload this pagehttps://github.com/python/cpython/pull/112089
https://github.com/vstinner
https://github.com/serhiy-storchaka
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.